Issues in SoapClient.php (master) - Issues in master - MohannadNaj/smsa-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Issues (33)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/SoapClient.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace SmsaSDK;

/**
 * SoapClient
 * Insert description here.
 */
class SoapClient extends \SoapClient
{
    public static $testing = false;
    public static $lastException = null;
    public static $client = null;
    public static $lastCall = null;

    /**
     * __soapCall
     * Insert description here.
     *
     * @param $function_name
     * @param $arguments
     * @param $options
     * @param $input_headers
     * @param $output_headers
     *
     * @return
     */
    public function __soapCall($function_name, $arguments, $options = null, $input_headers = null, &$output_headers = null)
    {
        static::$lastCall = compact('function_name', 'arguments', 'options', 'input_headers', 'output_headers');

        // if the alternative client was set, for testing or customization for example
        if (static::$client) {
            return static::$client->$function_name($arguments);
        }

        return $this->soapCall($function_name, $arguments, $options, $input_headers, $output_headers);
    }

    /**
     * soapCall
     * Insert description here.
     *
     * @param $function_name
     * @param $arguments
     * @param $options
     * @param $input_headers
     * @param $output_headers
     *
     * @return
     */
    private function soapCall($function_name, $arguments, $options = null, $input_headers = null, &$output_headers = null)
    {
        try {
            return parent::__soapCall($function_name, $arguments, $options, $input_headers, $output_headers);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        } catch (\Exception $e) {
            static::$lastException = $e;
            if (!static::$testing) {
                throw $e;
            }
        }
    }

    /**
     * setTestingClient
     * Insert description here.
     *
     * @param $client
     *
     * @return
     */
    public static function setTestingClient($client = null)
    {
        static::$testing = true;
        static::$client = $client;
    }

    /**
     * getTestingClient
     * Insert description here.
     *
     * @return
     */
    public static function getTestingClient()
    {
        return static::$client;
    }

    /**
     * turnOffTestingClient
     * Insert description here.
     *
     * @return
     */
    public static function turnOffTestingClient()
    {
        static::$testing = false;
        static::$client = null;
    }
}


1		<?php
2
3		namespace SmsaSDK;
4
5		/**
6		* SoapClient
7		* Insert description here.
8		*/
9		class SoapClient extends \SoapClient
10		{
11		public static $testing = false;
12		public static $lastException = null;
13		public static $client = null;
14		public static $lastCall = null;
15
16		/**
17		* __soapCall
18		* Insert description here.
19		*
20		* @param $function_name
21		* @param $arguments
22		* @param $options
23		* @param $input_headers
24		* @param $output_headers
25		*
26		* @return
27		*/
28	3	public function __soapCall($function_name, $arguments, $options = null, $input_headers = null, &$output_headers = null)
29		{
30	3	static::$lastCall = compact('function_name', 'arguments', 'options', 'input_headers', 'output_headers');
31
32		// if the alternative client was set, for testing or customization for example
33	3	if (static::$client) {
34	3	return static::$client->$function_name($arguments);
35		}
36
37		return $this->soapCall($function_name, $arguments, $options, $input_headers, $output_headers);
38		}
39
40		/**
41		* soapCall
42		* Insert description here.
43		*
44		* @param $function_name
45		* @param $arguments
46		* @param $options
47		* @param $input_headers
48		* @param $output_headers
49		*
50		* @return
51		*/
52		private function soapCall($function_name, $arguments, $options = null, $input_headers = null, &$output_headers = null)
53		{
54		try {
55		return parent::__soapCall($function_name, $arguments, $options, $input_headers, $output_headers);
		0 ignored issues – show Comprehensibility Bug introduced 2018-01-10 02:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you call parent on a different method (`__soapCall()` instead of `soapCall()`). Are you sure this is correct? If so, you might want to change this to `$this->__soapCall()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
56		} catch (\Exception $e) {
57		static::$lastException = $e;
58		if (!static::$testing) {
59		throw $e;
60		}
61		}
62		}
63
64		/**
65		* setTestingClient
66		* Insert description here.
67		*
68		* @param $client
69		*
70		* @return
71		*/
72	4	public static function setTestingClient($client = null)
73		{
74	4	static::$testing = true;
75	4	static::$client = $client;
76	4	}
77
78		/**
79		* getTestingClient
80		* Insert description here.
81		*
82		* @return
83		*/
84	3	public static function getTestingClient()
85		{
86	3	return static::$client;
87		}
88
89		/**
90		* turnOffTestingClient
91		* Insert description here.
92		*
93		* @return
94		*/
95	1	public static function turnOffTestingClient()
96		{
97	1	static::$testing = false;
98	1	static::$client = null;
99	1	}
100		}
101

GitHub Access Token became invalid

Issues (33)

Security Analysis no request data

src/SoapClient.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

MohannadNaj / smsa-sdk

GitHub Access Token became invalid

Issues (33)

Security Analysis no request data

src/SoapClient.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like