MapMethods::mergeCommonData() - Code Metrics - MohannadNaj/smsa-sdk - Measure and Improve Code Quality continuously with Scrutinizer

MapMethods::mergeCommonData() A
last analyzed 2018-01-10 04:36 UTC

↳ Parent: MapMethods

Complexity

Conditions	4
Paths	3

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4

Importance

Changes

Metric	Value
cc	4
eloc	6
nc	3
nop	2
dl	0
loc	11
ccs	8
cts	8
cp	1
crap	4
rs	9.2
c	0
b	0
f	0

<?php

namespace SmsaSDK\Concerns;

use SmsaSDK\Config;

trait MapMethods
{
    /**
     * mergeCommonData
     * Insert description here.
     *
     * @param $methodHandler
     * @param $arguments
     *
     * @return
     */
    private function mergeCommonData($methodHandler, $arguments = [])
    {
        foreach (Config::getCommonData() as $key => $value) {
            $setterMethod = $this->getSetterMethodFromKey($key);
            if (method_exists($methodHandler, $setterMethod) && !array_key_exists($key, $arguments)) {
                $methodHandler->$setterMethod($value);
            }
        }

        return $methodHandler;
    }

    /**
     * getSetterMethodFromKey
     * Insert description here.
     *
     * @param $key
     *
     * @return
     */
    private function getSetterMethodFromKey($key)
    {
        return 'set'.ucfirst($key);
    }

    /**
     * fillNull
     * Insert description here.
     *
     * @param $arguments
     * @param $value
     *
     * @return
     */
    private function fillNull($arguments, $value)
    {
        $missingArguments = [];
        $keys = array_keys($arguments);
        $commonKeys = array_keys(Config::getCommonData());
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $properties = $this->getReflectionProperties($this->reflection);
class MyClass { }

$x = new MyClass();
$x->foo = true;

        foreach ($properties as $key) {
            if (!in_array($key, $keys)) {
                $missingArguments[] = $key;
            }
        }

        foreach ($missingArguments as $key) {
            $arguments[$key] = $value;
        }

        return $arguments;
    }

    /**
     * @param $arguments
     * @param $class
     *
     * @return mixed
     */
    private function prepareMethodHandler($arguments, $class)
    {
        $this->validate($arguments, $class);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        if ($this->nullValues !== null) {
            $arguments = $this->fillNull($arguments, $this->nullValues);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }

        $methodHandler = new $class();

        foreach ($arguments as $key => $value) {
            $setterMethod = $this->getSetterMethodFromKey($key);
            $methodHandler->$setterMethod($value);
        }

        $methodHandler = $this->mergeCommonData($methodHandler, $arguments);

        return $methodHandler;
    }
}


1		<?php
2
3		namespace SmsaSDK\Concerns;
4
5		use SmsaSDK\Config;
6
7		trait MapMethods
8		{
9		/**
10		* mergeCommonData
11		* Insert description here.
12		*
13		* @param $methodHandler
14		* @param $arguments
15		*
16		* @return
17		*/
18	3	private function mergeCommonData($methodHandler, $arguments = [])
19		{
20	3	foreach (Config::getCommonData() as $key => $value) {
21	3	$setterMethod = $this->getSetterMethodFromKey($key);
22	3	if (method_exists($methodHandler, $setterMethod) && !array_key_exists($key, $arguments)) {
23	3	$methodHandler->$setterMethod($value);
24	3	}
25	3	}
26
27	3	return $methodHandler;
28		}
29
30		/**
31		* getSetterMethodFromKey
32		* Insert description here.
33		*
34		* @param $key
35		*
36		* @return
37		*/
38	4	private function getSetterMethodFromKey($key)
39		{
40	4	return 'set'.ucfirst($key);
41		}
42
43		/**
44		* fillNull
45		* Insert description here.
46		*
47		* @param $arguments
48		* @param $value
49		*
50		* @return
51		*/
52	1	private function fillNull($arguments, $value)
53		{
54	1	$missingArguments = [];
55	1	$keys = array_keys($arguments);
56	1	$commonKeys = array_keys(Config::getCommonData());
		0 ignored issues – show Unused Code introduced 2018-01-10 02:45 UTC by Report Bug Copy Issue Report `$commonKeys` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
57	1	$properties = $this->getReflectionProperties($this->reflection);
		0 ignored issues – show Bug introduced 2018-01-10 02:45 UTC by Report Bug Copy Issue Report The property `reflection` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2018-01-10 02:45 UTC by Report Bug Copy Issue Report It seems like `getReflectionProperties()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
58
59	1	foreach ($properties as $key) {
60	1	if (!in_array($key, $keys)) {
61	1	$missingArguments[] = $key;
62	1	}
63	1	}
64
65	1	foreach ($missingArguments as $key) {
66	1	$arguments[$key] = $value;
67	1	}
68
69	1	return $arguments;
70		}
71
72		/**
73		* @param $arguments
74		* @param $class
75		*
76		* @return mixed
77		*/
78	6	private function prepareMethodHandler($arguments, $class)
79		{
80	6	$this->validate($arguments, $class);
		0 ignored issues – show Bug introduced 2018-01-10 02:45 UTC by Report Bug Copy Issue Report It seems like `validate()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
81
82	3	if ($this->nullValues !== null) {
83	1	$arguments = $this->fillNull($arguments, $this->nullValues);
		0 ignored issues – show Bug introduced 2018-01-10 02:45 UTC by Report Bug Copy Issue Report The property `nullValues` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
84	1	}
85
86	3	$methodHandler = new $class();
87
88	3	foreach ($arguments as $key => $value) {
89	3	$setterMethod = $this->getSetterMethodFromKey($key);
90	3	$methodHandler->$setterMethod($value);
91	3	}
92
93	3	$methodHandler = $this->mergeCommonData($methodHandler, $arguments);
94
95	3	return $methodHandler;
96		}
97		}
98

MohannadNaj / smsa-sdk

GitHub Access Token became invalid

MapMethods::mergeCommonData() A last analyzed 2018-01-10 04:36 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

MapMethods::mergeCommonData() A
last analyzed 2018-01-10 04:36 UTC