MoeCasts / laravel-wallet

src/Traits/CanPay.php

<?php

namespace Moecasts\Laravel\Wallet\Traits;

use Illuminate\Database\Eloquent\ModelNotFoundException;
use Moecasts\Laravel\Wallet\Exceptions\ProductEnded;
use Moecasts\Laravel\Wallet\Interfaces\Product;
use Moecasts\Laravel\Wallet\Interfaces\Refundable;
use Moecasts\Laravel\Wallet\Models\Transfer;

trait CanPay {
    public function pay(Product $product, string $action = Transfer::ACTION_PAID, bool $force = false): Transfer
    {
        if (! $product->canBePaid($action)) {
            throw new ProductEnded(trans('wallet::errors.product_stock'));

It seems like trans('wallet::errors.product_stock') can also be of type array; however, parameter $message of Moecasts\Laravel\Wallet\Exceptions\ProductEnded::__construct() does only seem to accept string, maybe add an additional type check?

        }

        if ($force) {
            return $this->forceTransfer(

It seems like forceTransfer() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $product,
                $product->getProductAmount($action),
                $product->getProductMeta($action),
                $action
            );
        }

        return $this->transfer(

It seems like transfer() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $product,
            $product->getProductAmount($action),
            $product->getProductMeta($action),
            $action
        );
    }

    public function forcePay(Product $product, string $action = Transfer::ACTION_PAID): Transfer
    {
        return $this->pay($product, $action, true);
    }

    public function safePay(Product $product, string $action = Transfer::ACTION_PAID, bool $force = false): ?Transfer
    {
        try {
            return $this->pay($product, $action, $force);
        } catch (\Throwable $throwable) {
            return null;
        }
    }

    public function paid(Product $product, string $action = Transfer::ACTION_PAID): ?Transfer
    {
        $action = [$action];

        $query = $this->holderTransfers();

It seems like holderTransfers() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $query
            ->where('refund', false)
            ->where('to_type', $product->getMorphClass())

The method getMorphClass() does not exist on Moecasts\Laravel\Wallet\Interfaces\Product. Since it exists in all sub-types, consider adding an abstract or default implementation to Moecasts\Laravel\Wallet\Interfaces\Product.

            ->where('to_id', $product->getKey())

The method getKey() does not exist on Moecasts\Laravel\Wallet\Interfaces\Product. Since it exists in all sub-types, consider adding an abstract or default implementation to Moecasts\Laravel\Wallet\Interfaces\Product.

            ->whereIn('action', $action)
            ->orderBy('id', 'desc')
            ->first();
    }

    public function refund(Refundable $product, string $action = Transfer::ACTION_PAID)
    {
        $transfer = $this->paid($product, $action);

        if (! $transfer) {
            throw (new ModelNotFoundException())
                ->setModel(config('wallet.transfer.model'));
        }

        return \DB::transaction(function () use ($transfer) {
            $transfer->withdraw->update([
                'confirmed' => false,
            ]);

            $transfer->deposit->update([
                'confirmed' => false,
            ]);

            $transfer->update([
                'refund' => true,
            ]);

            return $transfer->fromWallet->refreshBalance() &&
                $transfer->toWallet->refreshBalance();
        });
    }

    public function safeRefund(Product $product, string $action = Transfer::ACTION_PAID)
    {
        try {
            return $this->refund($product, $action);
        } catch (\Throwable $throwable) {
            return false;
        }
    }
}