Passed
Push — master ( 2e2cc3...b09f9f )
by Sebastian
04:26
created
src/Mailcode/Parser/Statement.php 2 patches
Indentation   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -26,24 +26,24 @@  discard block
 block discarded – undo
26 26
     const VALIDATION_EMPTY = 48801;
27 27
     const VALIDATION_UNQUOTED_STRING_LITERALS = 48802;
28 28
     
29
-   /**
30
-    * @var string
31
-    */
29
+    /**
30
+     * @var string
31
+     */
32 32
     protected $statement;
33 33
     
34
-   /**
35
-    * @var OperationResult
36
-    */
34
+    /**
35
+     * @var OperationResult
36
+     */
37 37
     protected $result;
38 38
     
39
-   /**
40
-    * @var Mailcode_Parser_Statement_Tokenizer
41
-    */
39
+    /**
40
+     * @var Mailcode_Parser_Statement_Tokenizer
41
+     */
42 42
     protected $tokenizer;
43 43
     
44
-   /**
45
-    * @var Mailcode_Parser_Statement_Info|NULL
46
-    */
44
+    /**
45
+     * @var Mailcode_Parser_Statement_Info|NULL
46
+     */
47 47
     protected $info;
48 48
 
49 49
     /**
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
         if($unknown)
113 113
         {
114 114
             $this->result->makeError(
115
-               t('Unquoted string literal found:').' ('.htmlspecialchars($unknown->getMatchedText()).')',
115
+                t('Unquoted string literal found:').' ('.htmlspecialchars($unknown->getMatchedText()).')',
116 116
                 self::VALIDATION_UNQUOTED_STRING_LITERALS
117 117
             );
118 118
         }
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
      */
57 57
     private $sourceCommand;
58 58
 
59
-    public function __construct(string $statement, bool $freeform=false, ?Mailcode_Commands_Command $sourceCommand=null)
59
+    public function __construct(string $statement, bool $freeform = false, ?Mailcode_Commands_Command $sourceCommand = null)
60 60
     {
61 61
         $this->sourceCommand = $sourceCommand;
62 62
         $this->statement = $statement;
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
     
92 92
     public function getInfo() : Mailcode_Parser_Statement_Info
93 93
     {
94
-        if($this->info instanceof Mailcode_Parser_Statement_Info)
94
+        if ($this->info instanceof Mailcode_Parser_Statement_Info)
95 95
         {
96 96
             return $this->info; 
97 97
         }
@@ -103,12 +103,12 @@  discard block
 block discarded – undo
103 103
     
104 104
     protected function validate() : void
105 105
     {
106
-        if($this->freeform)
106
+        if ($this->freeform)
107 107
         {
108 108
             return;
109 109
         }
110 110
 
111
-        if(!$this->tokenizer->hasTokens())
111
+        if (!$this->tokenizer->hasTokens())
112 112
         {
113 113
             $this->result->makeError(
114 114
                 t('Empty statement'),
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
         
121 121
         $unknown = $this->tokenizer->getFirstUnknown();
122 122
         
123
-        if($unknown)
123
+        if ($unknown)
124 124
         {
125 125
             $this->result->makeError(
126 126
                t('Unquoted string literal found:').' ('.htmlspecialchars($unknown->getMatchedText()).')',
Please login to merge, or discard this patch.
src/Mailcode/Commands/ShowBase.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
 
71 71
     protected function validateSyntax_urldeencode() : void
72 72
     {
73
-        if($this->isURLEncoded() && $this->getURLDecodeToken() !== null)
73
+        if ($this->isURLEncoded() && $this->getURLDecodeToken() !== null)
74 74
         {
75 75
             $this->validationResult->makeError(
76 76
                 t('Cannot enable URL decoding and encoding at the same time.'),
Please login to merge, or discard this patch.
src/Mailcode/Commands/Command/ShowVariable.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         $tokens = $this->params->getInfo()->getTokens();
48 48
         $allowed = $this->resolveActiveTokens();
49 49
 
50
-        if(count($tokens) > count($allowed))
50
+        if (count($tokens) > count($allowed))
51 51
         {
52 52
             $this->validationResult->makeError(
53 53
                 t('Unknown parameters found:').' '.
@@ -69,13 +69,13 @@  discard block
 block discarded – undo
69 69
         $allowed = array($this->getVariableToken());
70 70
 
71 71
         $token = $this->getURLEncodeToken();
72
-        if($token)
72
+        if ($token)
73 73
         {
74 74
             $allowed[] = $token;
75 75
         }
76 76
 
77 77
         $token = $this->getURLDecodeToken();
78
-        if($token)
78
+        if ($token)
79 79
         {
80 80
             $allowed[] = $token;
81 81
         }
Please login to merge, or discard this patch.
src/Mailcode/Commands/Command/Code.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
     {
92 92
         $lang = $this->params->getInfo()->getStringLiteralByIndex(0);
93 93
 
94
-        if($lang)
94
+        if ($lang)
95 95
         {
96 96
             $this->langToken = $lang;
97 97
             return;
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
     {
116 116
         // To keep PHPStan happy. If no token has been found, this
117 117
         // method will not be called.
118
-        if(!isset($this->langToken))
118
+        if (!isset($this->langToken))
119 119
         {
120 120
             return;
121 121
         }
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
         $name = $this->langToken->getText();
124 124
         $translator = new Mailcode_Translator();
125 125
 
126
-        if($translator->syntaxExists($name))
126
+        if ($translator->syntaxExists($name))
127 127
         {
128 128
             return;
129 129
         }
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
      */
147 147
     public function getSyntaxName() : string
148 148
     {
149
-        if(isset($this->langToken))
149
+        if (isset($this->langToken))
150 150
         {
151 151
             return $this->langToken->getText();
152 152
         }
Please login to merge, or discard this patch.
src/Mailcode/Commands/Normalizer.php 2 patches
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
     
38 38
     public function normalize() : string
39 39
     {
40
-        if(!$this->command->isValid())
40
+        if (!$this->command->isValid())
41 41
         {
42 42
             return '';
43 43
         }
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
     
58 58
     private function addType() : void
59 59
     {
60
-        if(!$this->command->supportsType() || !$this->command->hasType())
60
+        if (!$this->command->supportsType() || !$this->command->hasType())
61 61
         {
62 62
             return;
63 63
         }
@@ -67,12 +67,12 @@  discard block
 block discarded – undo
67 67
     
68 68
     private function addParams(Mailcode_Commands_Command $command) : void
69 69
     {
70
-        if(!$command->requiresParameters())
70
+        if (!$command->requiresParameters())
71 71
         {
72 72
             return;
73 73
         }
74 74
 
75
-        if($command->hasFreeformParameters())
75
+        if ($command->hasFreeformParameters())
76 76
         {
77 77
             $params = $command->getParams()->getStatementString();
78 78
         }
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
             $params = $command->getParams()->getNormalized();
82 82
         }
83 83
         
84
-        if(empty($params))
84
+        if (empty($params))
85 85
         {
86 86
             return;
87 87
         }
@@ -92,14 +92,14 @@  discard block
 block discarded – undo
92 92
     
93 93
     private function addLogicKeywords() : void
94 94
     {
95
-        if(!$this->command->supportsLogicKeywords())
95
+        if (!$this->command->supportsLogicKeywords())
96 96
         {
97 97
             return;
98 98
         }
99 99
         
100 100
         $keywords = $this->command->getLogicKeywords()->getKeywords();
101 101
         
102
-        foreach($keywords as $keyword)
102
+        foreach ($keywords as $keyword)
103 103
         {
104 104
             $this->parts[] = ' ';
105 105
             $this->parts[] = $keyword->getKeywordString(); // e.g. "if variable"
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -75,8 +75,7 @@
 block discarded – undo
75 75
         if($command->hasFreeformParameters())
76 76
         {
77 77
             $params = $command->getParams()->getStatementString();
78
-        }
79
-        else
78
+        } else
80 79
         {
81 80
             $params = $command->getParams()->getNormalized();
82 81
         }
Please login to merge, or discard this patch.
src/Mailcode/Interfaces/Commands/URLDecode.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,5 +12,5 @@
 block discarded – undo
12 12
      * @param bool $decode
13 13
      * @return $this
14 14
      */
15
-    public function setURLDecoding(bool $decode=true);
15
+    public function setURLDecoding(bool $decode = true);
16 16
 }
Please login to merge, or discard this patch.
src/Mailcode/Traits/Commands/Validation/URLEncode.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -34,9 +34,9 @@  discard block
 block discarded – undo
34 34
     {
35 35
         $keywords = $this->params->getInfo()->getKeywords();
36 36
 
37
-        foreach($keywords as $keyword)
37
+        foreach ($keywords as $keyword)
38 38
         {
39
-            if($keyword->isURLEncoded())
39
+            if ($keyword->isURLEncoded())
40 40
             {
41 41
                 $this->urlencodeToken = $keyword;
42 42
 
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
      * @param bool $encoding
52 52
      * @return $this
53 53
      */
54
-    abstract public function setURLEncoding(bool $encoding=true);
54
+    abstract public function setURLEncoding(bool $encoding = true);
55 55
 
56 56
     public function getURLEncodeToken() : ?Mailcode_Parser_Statement_Tokenizer_Token_Keyword
57 57
     {
Please login to merge, or discard this patch.
src/Mailcode/Traits/Commands/Validation/URLDecode.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -33,9 +33,9 @@  discard block
 block discarded – undo
33 33
     {
34 34
         $keywords = $this->params->getInfo()->getKeywords();
35 35
 
36
-        foreach($keywords as $keyword)
36
+        foreach ($keywords as $keyword)
37 37
         {
38
-            if($keyword->isURLDecode())
38
+            if ($keyword->isURLDecode())
39 39
             {
40 40
                 $this->urldecodeToken = $keyword;
41 41
                 break;
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
         }
44 44
     }
45 45
 
46
-    abstract public function setURLDecoding(bool $decode=true);
46
+    abstract public function setURLDecoding(bool $decode = true);
47 47
 
48 48
     public function getURLDecodeToken() : ?Mailcode_Parser_Statement_Tokenizer_Token_Keyword
49 49
     {
Please login to merge, or discard this patch.
src/Mailcode/Parser/Statement/Info/Keywords.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
     {
35 35
         $token = $this->info->getTokenByIndex($index);
36 36
 
37
-        if($token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Keyword)
37
+        if ($token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Keyword)
38 38
         {
39 39
             return $token;
40 40
         }
@@ -50,9 +50,9 @@  discard block
 block discarded – undo
50 50
         $result = array();
51 51
         $tokens = $this->info->getTokens();
52 52
 
53
-        foreach($tokens as $token)
53
+        foreach ($tokens as $token)
54 54
         {
55
-            if($token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Keyword)
55
+            if ($token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Keyword)
56 56
             {
57 57
                 $result[] = $token;
58 58
             }
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
      */
72 72
     public function setEnabled(string $keyword, bool $enabled) : Mailcode_Parser_Statement_Info_Keywords
73 73
     {
74
-        if($enabled)
74
+        if ($enabled)
75 75
         {
76 76
             return $this->add($keyword);
77 77
         }
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
     {
91 91
         $keyword = rtrim($keyword, ':').':';
92 92
 
93
-        if(!$this->hasKeyword($keyword))
93
+        if (!$this->hasKeyword($keyword))
94 94
         {
95 95
             $this->tokenizer->appendKeyword($keyword);
96 96
         }
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
 
136 136
         foreach ($keywords as $kw)
137 137
         {
138
-            if($kw->getKeyword() === $keyword)
138
+            if ($kw->getKeyword() === $keyword)
139 139
             {
140 140
                 return true;
141 141
             }
Please login to merge, or discard this patch.