Passed
Push — master ( acb001...8c805d )
by Sebastian
03:51
created
src/Mailcode/Parser/Safeguard/Formatter/Type/MarkVariables.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
     
61 61
     public function setTemplate(string $template) : Mailcode_Parser_Safeguard_Formatter_Type_MarkVariables
62 62
     {
63
-        if(substr_count($template, '%s') !== 1)
63
+        if (substr_count($template, '%s') !== 1)
64 64
         {
65 65
             throw new Mailcode_Exception(
66 66
                 'Invalid tag template',
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
         $parts = explode('%s', $this->getTemplate());
102 102
         $tag = array_shift($parts);
103 103
 
104
-        if($this->templateMode === self::TEMPLATE_MODE_INLINE)
104
+        if ($this->templateMode === self::TEMPLATE_MODE_INLINE)
105 105
         {
106 106
             $tag = str_replace('__STYLES__', $this->getInlineStyles(), $tag);
107 107
         }
@@ -129,12 +129,12 @@  discard block
 block discarded – undo
129 129
         $styles = '';
130 130
         $regex = '/\.'.self::DEFAULT_CLASS_NAME.'{([^}]+)}/';
131 131
 
132
-        if(preg_match($regex, $this->getCSS(), $matches))
132
+        if (preg_match($regex, $this->getCSS(), $matches))
133 133
         {
134 134
             $styles = $matches[1];
135 135
         }
136 136
 
137
-        if(empty($styles))
137
+        if (empty($styles))
138 138
         {
139 139
             throw new Mailcode_Exception(
140 140
                 'Cannot extract styles.',
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
         $file = MAILCODE_INSTALL_FOLDER.'/css/marked-variables.css';
192 192
         $path = realpath($file);
193 193
 
194
-        if($path !== false)
194
+        if ($path !== false)
195 195
         {
196 196
             return $path;
197 197
         }
Please login to merge, or discard this patch.
src/Mailcode/Translator/Syntax/ApacheVelocity/ShowDate.php 2 patches
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -24,15 +24,15 @@
 block discarded – undo
24 24
 {
25 25
     const ERROR_UNKNOWN_DATE_FORMAT_CHARACTER = 55501;
26 26
 
27
-   /**
28
-    * The date format used in the date variable. This is used to convert
29
-    * the native date to the format specified in the variable command.
30
-    */
27
+    /**
28
+     * The date format used in the date variable. This is used to convert
29
+     * the native date to the format specified in the variable command.
30
+     */
31 31
     const DEFAULT_INTERNAL_FORMAT = "yyyy-MM-dd'T'HH:mm:ss.SSSXXX";
32 32
 
33
-   /**
34
-    * @var string[]string
35
-    */
33
+    /**
34
+     * @var string[]string
35
+     */
36 36
     private $charTable = array(
37 37
         'd' => 'dd',
38 38
         'j' => 'd',
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -56,12 +56,12 @@  discard block
 block discarded – undo
56 56
         $varName = ltrim($command->getVariableName(), '$');
57 57
         $javaFormat = $this->translateFormat($command->getFormatString());
58 58
 
59
-        if(empty($internalFormat))
59
+        if (empty($internalFormat))
60 60
         {
61 61
             $internalFormat = self::DEFAULT_INTERNAL_FORMAT;
62 62
         }
63 63
 
64
-        if($command->isURLEncoded())
64
+        if ($command->isURLEncoded())
65 65
         {
66 66
             return sprintf(
67 67
                 '${esc.url($date.format("%s", $date.toDate("%s", $%s)))}',
@@ -84,9 +84,9 @@  discard block
 block discarded – undo
84 84
         $chars = ConvertHelper::string2array($formatString);
85 85
         $result = array();
86 86
         
87
-        foreach($chars as $char)
87
+        foreach ($chars as $char)
88 88
         {
89
-            if(!isset($this->charTable[$char]))
89
+            if (!isset($this->charTable[$char]))
90 90
             {
91 91
                 throw new Mailcode_Translator_Exception(
92 92
                     'Unknown date format string character',
Please login to merge, or discard this patch.
src/Mailcode/Translator/Syntax/ApacheVelocity/ShowNumber.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
             $locale
41 41
         );
42 42
 
43
-        if($command->isURLEncoded())
43
+        if ($command->isURLEncoded())
44 44
         {
45 45
             return sprintf(
46 46
                 '${esc.url($%s)}',
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
             $dc = '_';
93 93
         }
94 94
 
95
-        $type = $th . $dc;
95
+        $type = $th.$dc;
96 96
 
97 97
         if (isset($this->typeLocales[$type])) {
98 98
             return $this->typeLocales[$type];
@@ -105,12 +105,12 @@  discard block
 block discarded – undo
105 105
     {
106 106
         $result = '#';
107 107
 
108
-        if($format->hasThousandsSeparator())
108
+        if ($format->hasThousandsSeparator())
109 109
         {
110 110
             $result = '#,###';
111 111
         }
112 112
 
113
-        if($format->hasDecimals())
113
+        if ($format->hasDecimals())
114 114
         {
115 115
             $result .= '.'.str_repeat('#', $format->getDecimals());
116 116
         }
Please login to merge, or discard this patch.
src/Mailcode/Commands/Command/ShowDate.php 2 patches
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -22,15 +22,15 @@  discard block
 block discarded – undo
22 22
 {
23 23
     const VALIDATION_NOT_A_FORMAT_STRING = 55401;
24 24
     
25
-   /**
26
-    * The date format string.
27
-    * @var string
28
-    */
25
+    /**
26
+     * The date format string.
27
+     * @var string
28
+     */
29 29
     private $formatString;
30 30
     
31
-   /**
32
-    * @var Mailcode_Date_FormatInfo
33
-    */
31
+    /**
32
+     * @var Mailcode_Date_FormatInfo
33
+     */
34 34
     private $formatInfo;
35 35
 
36 36
     public function getName() : string
@@ -90,11 +90,11 @@  discard block
 block discarded – undo
90 90
         );
91 91
     }
92 92
     
93
-   /**
94
-    * Retrieves the format string used to format the date.
95
-    * 
96
-    * @return string A PHP compatible date format string.
97
-    */
93
+    /**
94
+     * Retrieves the format string used to format the date.
95
+     * 
96
+     * @return string A PHP compatible date format string.
97
+     */
98 98
     public function getFormatString() : string
99 99
     {
100 100
         return $this->formatString;
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         $tokens = $this->params->getInfo()->getStringLiterals();
66 66
 
67 67
         // no format specified? Use the default one.
68
-        if(empty($tokens))
68
+        if (empty($tokens))
69 69
         {
70 70
             return;
71 71
         }
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
     {
79 79
         $result = $this->formatInfo->validateFormat($format);
80 80
 
81
-        if($result->isValid())
81
+        if ($result->isValid())
82 82
         {
83 83
             $this->formatString = $format;
84 84
             return;
Please login to merge, or discard this patch.
src/Mailcode/Commands/Command/ShowNumber.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
          $tokens = $this->params->getInfo()->getStringLiterals();
67 67
          
68 68
          // no format specified? Use the default one.
69
-         if(empty($tokens))
69
+         if (empty($tokens))
70 70
          {
71 71
              return;
72 72
          }
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
     {
80 80
         $result = new Mailcode_Number_Info($format);
81 81
 
82
-        if($result->isValid())
82
+        if ($result->isValid())
83 83
         {
84 84
             $this->formatString = $format;
85 85
             return;
Please login to merge, or discard this patch.
Indentation   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -31,10 +31,10 @@  discard block
 block discarded – undo
31 31
     const VALIDATION_INVALID_DECIMAL_SEPARATOR = 72209;
32 32
     const VALIDATION_SEPARATORS_SAME_CHARACTER = 72210;
33 33
     
34
-   /**
35
-    * The default number format string.
36
-    * @var string
37
-    */
34
+    /**
35
+     * The default number format string.
36
+     * @var string
37
+     */
38 38
     private $formatString = Mailcode_Number_Info::DEFAULT_FORMAT;
39 39
     
40 40
     public function getName() : string
@@ -58,16 +58,16 @@  discard block
 block discarded – undo
58 58
 
59 59
     protected function validateSyntax_check_format() : void
60 60
     {
61
-         $tokens = $this->params->getInfo()->getStringLiterals();
61
+            $tokens = $this->params->getInfo()->getStringLiterals();
62 62
          
63
-         // no format specified? Use the default one.
64
-         if(empty($tokens))
65
-         {
66
-             return;
67
-         }
63
+            // no format specified? Use the default one.
64
+            if(empty($tokens))
65
+            {
66
+                return;
67
+            }
68 68
 
69
-         $token = array_pop($tokens);
70
-         $this->parseFormatString($token->getText());
69
+            $token = array_pop($tokens);
70
+            $this->parseFormatString($token->getText());
71 71
     }
72 72
 
73 73
     private function parseFormatString(string $format) : void
@@ -86,11 +86,11 @@  discard block
 block discarded – undo
86 86
         );
87 87
     }
88 88
     
89
-   /**
90
-    * Retrieves the format string used to format the number.
91
-    * 
92
-    * @return string
93
-    */
89
+    /**
90
+     * Retrieves the format string used to format the number.
91
+     * 
92
+     * @return string
93
+     */
94 94
     public function getFormatString() : string
95 95
     {
96 96
         return $this->formatString;
Please login to merge, or discard this patch.
src/Mailcode/Number/Info.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
     {
43 43
         $format = trim($format);
44 44
 
45
-        if(empty($format))
45
+        if (empty($format))
46 46
         {
47 47
             $format = self::DEFAULT_FORMAT;
48 48
         }
@@ -108,15 +108,15 @@  discard block
 block discarded – undo
108 108
     {
109 109
         $format = $this->format;
110 110
 
111
-        foreach($this->validations as $validation)
111
+        foreach ($this->validations as $validation)
112 112
         {
113 113
             $method = 'parse_'.$validation;
114 114
 
115
-            if(method_exists($this, $method))
115
+            if (method_exists($this, $method))
116 116
             {
117 117
                 $format = $this->$method($format);
118 118
 
119
-                if(!$this->isValid())
119
+                if (!$this->isValid())
120 120
                 {
121 121
                     return;
122 122
                 }
@@ -138,13 +138,13 @@  discard block
 block discarded – undo
138 138
 
139 139
     private function parse_padding(string $format) : string
140 140
     {
141
-        if(strstr($format, ':') === false) {
141
+        if (strstr($format, ':') === false) {
142 142
             return $format;
143 143
         }
144 144
 
145 145
         $parts = ConvertHelper::explodeTrim(':', $this->format);
146 146
 
147
-        if(count($parts) !== 2)
147
+        if (count($parts) !== 2)
148 148
         {
149 149
             $this->makeError(
150 150
                 t(
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
 
160 160
         $padding = $parts[1];
161 161
 
162
-        if(!preg_match('/\A[#]+\z/x', $padding))
162
+        if (!preg_match('/\A[#]+\z/x', $padding))
163 163
         {
164 164
             $this->makeError(
165 165
                 t('The padding may only contain hashes (%1$s given).', '<code>'.$padding.'</code>'),
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
 
177 177
     private function parse_number(string $format) : string
178 178
     {
179
-        if($format[0] !== '1')
179
+        if ($format[0] !== '1')
180 180
         {
181 181
             $this->makeError(
182 182
                 t('The first character of the format must be a %1$s.', '<code>1</code>'),
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
         $base = str_replace(array('.', ',', ' '), '', $format);
191 191
         $number = intval(substr($base, 0, 4));
192 192
 
193
-        if($number === 1000) {
193
+        if ($number === 1000) {
194 194
             return $format;
195 195
         }
196 196
 
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
         $separator = $format[1];
211 211
 
212 212
         // No thousands separator
213
-        if($separator === '0')
213
+        if ($separator === '0')
214 214
         {
215 215
             return $format;
216 216
         }
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
         // Valid thousands separator
219 219
         $validSeparators = array(' ', ',', '.');
220 220
 
221
-        if(in_array($separator, $validSeparators))
221
+        if (in_array($separator, $validSeparators))
222 222
         {
223 223
             $this->thousandsSeparator = $separator;
224 224
             $format = str_replace('1'.$separator, '1', $format);
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
 
255 255
     private function parse_separators(string $format) : string
256 256
     {
257
-        if(!empty($this->thousandsSeparator) && !empty($this->decimalsSeparator) && $this->thousandsSeparator === $this->decimalsSeparator)
257
+        if (!empty($this->thousandsSeparator) && !empty($this->decimalsSeparator) && $this->thousandsSeparator === $this->decimalsSeparator)
258 258
         {
259 259
             $this->makeError(
260 260
                 t(
@@ -270,14 +270,14 @@  discard block
 block discarded – undo
270 270
 
271 271
     private function parse_decimals(string $format) : string
272 272
     {
273
-        if(empty($this->decimalsSeparator))
273
+        if (empty($this->decimalsSeparator))
274 274
         {
275 275
             return $format;
276 276
         }
277 277
 
278 278
         $parts = ConvertHelper::explodeTrim($this->decimalsSeparator, $format);
279 279
 
280
-        if(!isset($parts[1]))
280
+        if (!isset($parts[1]))
281 281
         {
282 282
             $this->makeError(
283 283
                 t('Cannot determine the amount of decimals.').' '.
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
             return $format;
294 294
         }
295 295
 
296
-        if($this->validateDecimals($parts[1]))
296
+        if ($this->validateDecimals($parts[1]))
297 297
         {
298 298
             $this->decimals = strlen($parts[1]);
299 299
         }
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
303 303
 
304 304
     private function validateDecimals(string $decimals) : bool
305 305
     {
306
-        if(preg_match('/\A[0]+\z/x', $decimals)) {
306
+        if (preg_match('/\A[0]+\z/x', $decimals)) {
307 307
             return true;
308 308
         }
309 309
 
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
     {
323 323
         $validSeparators = array('.', ',');
324 324
 
325
-        if(in_array($separator, $validSeparators)) {
325
+        if (in_array($separator, $validSeparators)) {
326 326
             return true;
327 327
         }
328 328
 
@@ -344,7 +344,7 @@  discard block
 block discarded – undo
344 344
      */
345 345
     private function parse_regex(string $format) : string
346 346
     {
347
-        if(preg_match('/1[ ,.]?000|1[ ,.]?000[.,][0]+/x', $format))
347
+        if (preg_match('/1[ ,.]?000|1[ ,.]?000[.,][0]+/x', $format))
348 348
         {
349 349
             return $format;
350 350
         }
Please login to merge, or discard this patch.
src/Mailcode/Factory/CommandSets/Set/Show.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
         
34 34
         $this->instantiator->checkCommand($cmd);
35 35
         
36
-        if($cmd instanceof Mailcode_Commands_Command_ShowVariable)
36
+        if ($cmd instanceof Mailcode_Commands_Command_ShowVariable)
37 37
         {
38 38
             return $cmd;
39 39
         }
@@ -41,12 +41,12 @@  discard block
 block discarded – undo
41 41
         throw $this->instantiator->exceptionUnexpectedType('ShowVariable', $cmd);
42 42
     }
43 43
     
44
-    public function showDate(string $variableName, string $formatString="") : Mailcode_Commands_Command_ShowDate
44
+    public function showDate(string $variableName, string $formatString = "") : Mailcode_Commands_Command_ShowDate
45 45
     {
46 46
         $variableName = $this->instantiator->filterVariableName($variableName);
47 47
         
48 48
         $format = '';
49
-        if(!empty($formatString))
49
+        if (!empty($formatString))
50 50
         {
51 51
             $format = sprintf(
52 52
                 ' "%s"',
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
         
68 68
         $this->instantiator->checkCommand($cmd);
69 69
         
70
-        if($cmd instanceof Mailcode_Commands_Command_ShowDate)
70
+        if ($cmd instanceof Mailcode_Commands_Command_ShowDate)
71 71
         {
72 72
             return $cmd;
73 73
         }
@@ -75,12 +75,12 @@  discard block
 block discarded – undo
75 75
         throw $this->instantiator->exceptionUnexpectedType('ShowDate', $cmd);
76 76
     }
77 77
 
78
-    public function showNumber(string $variableName, string $formatString="") : Mailcode_Commands_Command_ShowNumber
78
+    public function showNumber(string $variableName, string $formatString = "") : Mailcode_Commands_Command_ShowNumber
79 79
     {
80 80
         $variableName = $this->instantiator->filterVariableName($variableName);
81 81
 
82 82
         $format = '';
83
-        if(!empty($formatString))
83
+        if (!empty($formatString))
84 84
         {
85 85
             $format = sprintf(
86 86
                 ' "%s"',
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 
102 102
         $this->instantiator->checkCommand($cmd);
103 103
 
104
-        if($cmd instanceof Mailcode_Commands_Command_ShowNumber)
104
+        if ($cmd instanceof Mailcode_Commands_Command_ShowNumber)
105 105
         {
106 106
             return $cmd;
107 107
         }
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
         
123 123
         $this->instantiator->checkCommand($cmd);
124 124
         
125
-        if($cmd instanceof Mailcode_Commands_Command_ShowSnippet)
125
+        if ($cmd instanceof Mailcode_Commands_Command_ShowSnippet)
126 126
         {
127 127
             return $cmd;
128 128
         }
Please login to merge, or discard this patch.
src/Mailcode/Traits/Commands/IfNumber.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
     {
51 51
         $value = $this->getRawNumber();
52 52
 
53
-        if(!is_numeric($value))
53
+        if (!is_numeric($value))
54 54
         {
55 55
             $this->validationResult->makeError(
56 56
                 t(
Please login to merge, or discard this patch.
src/Mailcode/Translator/Syntax/ApacheVelocity/ShowVariable.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
         $varName = ltrim($command->getVariableName(), '$');
26 26
 
27 27
         // Automatically URL escape the variable if it's in an URL.
28
-        if($command->isURLEncoded())
28
+        if ($command->isURLEncoded())
29 29
         {
30 30
             return sprintf(
31 31
                 '${esc.url($%s)}',
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
             );
34 34
         }
35 35
 
36
-        if($command->isURLDecoded())
36
+        if ($command->isURLDecoded())
37 37
         {
38 38
             return sprintf(
39 39
                 '${esc.unurl($%s)}',
Please login to merge, or discard this patch.