View GitHub Repository mailcode

Schedule Inspection
Subscribe
Passed
Push — master ( 151bf3...8309cc )
by Sebastian
02:26
created
Status
Category
Toggle Patches
src/Mailcode/Parser/Safeguard/Formatter/Location.php 2 patches
Indentation   +44 added lines, -44 removed lines patch added patch discarded remove patch 
@@ -24,34 +24,34 @@  discard block
 
 block discarded – undo
24 24 
 {
25 25 
     const ERROR_PLACEHOLDER_NOT_FOUND = 66001;
26 26
27 
-   /**
28 
-    * @var Mailcode_Parser_Safeguard_Formatter
29 
-    */
27 
+    /**
28 
+     * @var Mailcode_Parser_Safeguard_Formatter
29 
+     */
30 30 
     protected $formatter;
31 31
32 
-   /**
33 
-    * @var string
34 
-    */
32 
+    /**
33 
+     * @var string
34 
+     */
35 35 
     protected $append = '';
36 36
37 
-   /**
38 
-    * @var string
39 
-    */
37 
+    /**
38 
+     * @var string
39 
+     */
40 40 
     protected $prepend = '';
41 41
42 
-   /**
43 
-    * @var Mailcode_Parser_Safeguard_Placeholder
44 
-    */
42 
+    /**
43 
+     * @var Mailcode_Parser_Safeguard_Placeholder
44 
+     */
45 45 
     protected $placeholder;
46 46
47 
-   /**
48 
-    * @var Mailcode_StringContainer
49 
-    */
47 
+    /**
48 
+     * @var Mailcode_StringContainer
49 
+     */
50 50 
     protected $subject;
51 51
52 
-   /**
53 
-    * @var string[]
54 
-    */
52 
+    /**
53 
+     * @var string[]
54 
+     */
55 55 
     protected $log = array();
56 56
57 57 
     public function __construct(Mailcode_Parser_Safeguard_Formatter $formatter, Mailcode_Parser_Safeguard_Placeholder $placeholder)
 
@@ -67,22 +67,22 @@  discard block
 
 block discarded – undo
67 67
68 68 
     abstract public function requiresAdjustment() : bool;
69 69
70 
-   /**
71 
-    * @return int|boolean
72 
-    */
70 
+    /**
71 
+     * @return int|boolean
72 
+     */
73 73 
     public function getStartPosition()
74 74 
     {
75 75 
         return $this->subject->getSubstrPosition($this->placeholder->getReplacementText());
76 76 
     }
77 77
78 
-   /**
79 
-    * Checks whether the specified position within the string
80 
-    * is within another command's placeholder (excluding this
81 
-    * location's placeholder).
82 
-    *
83 
-    * @param int $position
84 
-    * @return bool
85 
-    */
78 
+    /**
79 
+     * Checks whether the specified position within the string
80 
+     * is within another command's placeholder (excluding this
81 
+     * location's placeholder).
82 
+     *
83 
+     * @param int $position
84 
+     * @return bool
85 
+     */
86 86 
     public function isWithinCommand(int $position) : bool
87 87 
     {
88 88 
         $placeholders = $this->formatter->getSafeguard()->getPlaceholders();
 
@@ -114,9 +114,9 @@  discard block
 
 block discarded – undo
114 114 
         return false;
115 115 
     }
116 116
117 
-   /**
118 
-    * @return int|boolean
119 
-    */
117 
+    /**
118 
+     * @return int|boolean
119 
+     */
120 120 
     public function getEndPosition()
121 121 
     {
122 122 
         $start = $this->getStartPosition();
 
@@ -139,14 +139,14 @@  discard block
 
 block discarded – undo
139 139 
         return $this->placeholder;
140 140 
     }
141 141
142 
-   /**
143 
-    * Replaces the placeholder with the specified replacement text.
144 
-    *
145 
-    * @param string $replacementText
146 
-    * @throws Mailcode_Exception
147 
-    *
148 
-    * @see Mailcode_Parser_Safeguard_Formatter_Location::ERROR_PLACEHOLDER_NOT_FOUND
149 
-    */
142 
+    /**
143 
+     * Replaces the placeholder with the specified replacement text.
144 
+     *
145 
+     * @param string $replacementText
146 
+     * @throws Mailcode_Exception
147 
+     *
148 
+     * @see Mailcode_Parser_Safeguard_Formatter_Location::ERROR_PLACEHOLDER_NOT_FOUND
149 
+     */
150 150 
     public function replaceWith(string $replacementText) : void
151 151 
     {
152 152 
         $needle = $this->placeholder->getReplacementText();
 
@@ -189,10 +189,10 @@  discard block
 
 block discarded – undo
189 189 
         );
190 190 
     }
191 191
192 
-   /**
193 
-    * Retrieves the location's log messages, if any.
194 
-    * @return string[]
195 
-    */
192 
+    /**
193 
+     * Retrieves the location's log messages, if any.
194 
+     * @return string[]
195 
+     */
196 196 
     public function getLog() : array
197 197 
     {
198 198 
         return $this->log;
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch 
@@ -89,23 +89,23 @@  discard block
 
 block discarded – undo
89 89
90 90 
         $placeholderID = $this->placeholder->getID();
91 91
92 
-        foreach($placeholders as $placeholder)
92 
+        foreach ($placeholders as $placeholder)
93 93 
         {
94 
-            if($placeholder->getID() === $placeholderID)
94 
+            if ($placeholder->getID() === $placeholderID)
95 95 
             {
96 96 
                 continue;
97 97 
             }
98 98
99 99 
             $start = $this->subject->getSubstrPosition($placeholder->getReplacementText());
100 100
101 
-            if($start === false)
101 
+            if ($start === false)
102 102 
             {
103 103 
                 continue;
104 104 
             }
105 105
106 106 
             $end = $start + $placeholder->getReplacementLength();
107 107
108 
-            if($position >= $start && $position <= $end)
108 
+            if ($position >= $start && $position <= $end)
109 109 
             {
110 110 
                 return true;
111 111 
             }
 
@@ -121,7 +121,7 @@  discard block
 
 block discarded – undo
121 121 
     {
122 122 
         $start = $this->getStartPosition();
123 123
124 
-        if($start !== false)
124 
+        if ($start !== false)
125 125 
         {
126 126 
             return $start + $this->placeholder->getReplacementLength();
127 127 
         }
 
@@ -151,7 +151,7 @@  discard block
 
 block discarded – undo
151 151 
     {
152 152 
         $needle = $this->placeholder->getReplacementText();
153 153
154 
-        if($this->subject->replaceSubstrings($needle, $replacementText))
154 
+        if ($this->subject->replaceSubstrings($needle, $replacementText))
155 155 
         {
156 156 
             return;
157 157 
         }
 
@@ -168,7 +168,7 @@  discard block
 
 block discarded – undo
168 168
169 169 
     public function format() : void
170 170 
     {
171 
-        if($this->requiresAdjustment() && (!empty($this->prepend) || !empty($this->append)))
171 
+        if ($this->requiresAdjustment() && (!empty($this->prepend) || !empty($this->append)))
172 172 
         {
173 173 
             $this->replaceWith(sprintf(
174 174 
                 '%s%s%s',
Please login to merge, or discard this patch.
src/Mailcode/Parser/Safeguard/Formatter.php 2 patches
Indentation   +24 added lines, -24 removed lines patch added patch discarded remove patch 
@@ -27,19 +27,19 @@  discard block
 
 block discarded – undo
27 27 
 {
28 28 
     const ERROR_INVALID_LOCATION_INSTANCE = 65601;
29 29
30 
-   /**
31 
-    * @var Mailcode_Parser_Safeguard_Formatting
32 
-    */
30 
+    /**
31 
+     * @var Mailcode_Parser_Safeguard_Formatting
32 
+     */
33 33 
     protected $formatting;
34 34
35 
-   /**
36 
-    * @var Mailcode_StringContainer
37 
-    */
35 
+    /**
36 
+     * @var Mailcode_StringContainer
37 
+     */
38 38 
     protected $subject;
39 39
40 
-   /**
41 
-    * @var string[]
42 
-    */
40 
+    /**
41 
+     * @var string[]
42 
+     */
43 43 
     protected $log = array();
44 44
45 45 
     public function __construct(Mailcode_Parser_Safeguard_Formatting $formatting)
 
@@ -93,12 +93,12 @@  discard block
 
 block discarded – undo
93 93 
         );
94 94 
     }
95 95
96 
-   /**
97 
-    * Retrieves all formatter-specific placeholder locations
98 
-    * in the subject string.
99 
-    *
100 
-    * @return Mailcode_Parser_Safeguard_Formatter_Location[]
101 
-    */
96 
+    /**
97 
+     * Retrieves all formatter-specific placeholder locations
98 
+     * in the subject string.
99 
+     *
100 
+     * @return Mailcode_Parser_Safeguard_Formatter_Location[]
101 
+     */
102 102 
     protected function resolveLocations() : array
103 103 
     {
104 104 
         $placeholders = $this->formatting->getSafeguard()->getPlaceholders();
 
@@ -113,12 +113,12 @@  discard block
 
 block discarded – undo
113 113 
         return $result;
114 114 
     }
115 115
116 
-   /**
117 
-    * Resolves the newline character used in the string.
118 
-    *
119 
-    * @param string $subject
120 
-    * @return string
121 
-    */
116 
+    /**
117 
+     * Resolves the newline character used in the string.
118 
+     *
119 
+     * @param string $subject
120 
+     * @return string
121 
+     */
122 122 
     protected function resolveNewlineChar(string $subject) : string
123 123 
     {
124 124 
         $eol = ConvertHelper::detectEOLCharacter($subject);
 
@@ -150,9 +150,9 @@  discard block
 
 block discarded – undo
150 150 
         );
151 151 
     }
152 152
153 
-   /**
154 
-    * @return string[]
155 
-    */
153 
+    /**
154 
+     * @return string[]
155 
+     */
156 156 
     public function getLog() : array
157 157 
     {
158 158 
         return $this->log;
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -77,7 +77,7 @@  discard block
 
 block discarded – undo
77 77
78 78 
         $instance = new $class($this, $placeholder);
79 79
80 
-        if($instance instanceof Mailcode_Parser_Safeguard_Formatter_Location)
80 
+        if ($instance instanceof Mailcode_Parser_Safeguard_Formatter_Location)
81 81 
         {
82 82 
             return $instance;
83 83 
         }
 
@@ -105,7 +105,7 @@  discard block
 
 block discarded – undo
105 105
106 106 
         $result = array();
107 107
108 
-        foreach($placeholders as $placeholder)
108 
+        foreach ($placeholders as $placeholder)
109 109 
         {
110 110 
             $result[] = $this->createLocation($placeholder);
111 111 
         }
 
@@ -123,7 +123,7 @@  discard block
 
 block discarded – undo
123 123 
     {
124 124 
         $eol = ConvertHelper::detectEOLCharacter($subject);
125 125
126 
-        if($eol)
126 
+        if ($eol)
127 127 
         {
128 128 
             $this->log(sprintf(
129 129 
                 'Detected EOL character: %s.',
Please login to merge, or discard this patch.