Passed
Push — master ( 174259...689687 )
by Sebastian
04:01
created
src/Mailcode/Commands/Command.php 1 patch
Spacing   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
     */
81 81
     protected $comment = '';
82 82
     
83
-    public function __construct(string $type='', string $paramsString='', string $matchedText='')
83
+    public function __construct(string $type = '', string $paramsString = '', string $matchedText = '')
84 84
     {
85 85
         $this->type = $type;
86 86
         $this->paramsString = html_entity_decode($paramsString);
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
     {
154 154
         $this->requireNonDummy();
155 155
         
156
-        if($this->hash === '') {
156
+        if ($this->hash === '') {
157 157
             $this->hash = md5($this->matchedText);
158 158
         }
159 159
         
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
     
163 163
     protected function requireNonDummy() : void
164 164
     {
165
-        if(!$this->isDummy())
165
+        if (!$this->isDummy())
166 166
         {
167 167
             return;
168 168
         }
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
     {
184 184
         $this->requireNonDummy();
185 185
         
186
-        if(isset($this->validationResult)) 
186
+        if (isset($this->validationResult)) 
187 187
         {
188 188
             return $this->validationResult;
189 189
         }
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
     
198 198
     public function getValidationResult() :  \AppUtils\OperationResult
199 199
     {
200
-        if(isset($this->validationResult)) 
200
+        if (isset($this->validationResult)) 
201 201
         {
202 202
             return $this->validationResult;
203 203
         }
@@ -213,11 +213,11 @@  discard block
 block discarded – undo
213 213
     {
214 214
         $validations = array_merge($this->validations, $this->getValidations());
215 215
         
216
-        foreach($validations as $validation)
216
+        foreach ($validations as $validation)
217 217
         {
218 218
             $method = 'validateSyntax_'.$validation;
219 219
             
220
-            if(!method_exists($this, $method))
220
+            if (!method_exists($this, $method))
221 221
             {
222 222
                 throw new Mailcode_Exception(
223 223
                     'Missing validation method',
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
             $this->$method();
234 234
             
235 235
             // break off at the first validation issue
236
-            if(!$this->validationResult->isValid())
236
+            if (!$this->validationResult->isValid())
237 237
             {
238 238
                 return;
239 239
             }
@@ -247,12 +247,12 @@  discard block
 block discarded – undo
247 247
     
248 248
     protected function validateSyntax_params() : void
249 249
     {
250
-        if(!$this->requiresParameters())
250
+        if (!$this->requiresParameters())
251 251
         {
252 252
             return;
253 253
         }
254 254
         
255
-        if(empty($this->paramsString))
255
+        if (empty($this->paramsString))
256 256
         {
257 257
             $this->validationResult->makeError(
258 258
                 t('Parameters have to be specified.'),
@@ -263,7 +263,7 @@  discard block
 block discarded – undo
263 263
         
264 264
         $this->params = $this->mailcode->getParser()->createStatement($this->paramsString);
265 265
         
266
-        if(!$this->params->isValid())
266
+        if (!$this->params->isValid())
267 267
         {
268 268
             $error = $this->params->getValidationResult();
269 269
             
@@ -276,14 +276,14 @@  discard block
 block discarded – undo
276 276
     
277 277
     protected function validateSyntax_type_supported() : void
278 278
     {
279
-        if(!$this->supportsType() || empty($this->type))
279
+        if (!$this->supportsType() || empty($this->type))
280 280
         {
281 281
             return;
282 282
         }
283 283
         
284 284
         $types = $this->getSupportedTypes();
285 285
 
286
-        if(!in_array($this->type, $types))
286
+        if (!in_array($this->type, $types))
287 287
         {
288 288
             $this->validationResult->makeError(
289 289
                 t('The command addon %1$s is not supported.', $this->type).' '.
@@ -297,7 +297,7 @@  discard block
 block discarded – undo
297 297
     
298 298
     protected function validateSyntax_type_unsupported() : void
299 299
     {
300
-        if($this->supportsType() || empty($this->type))
300
+        if ($this->supportsType() || empty($this->type))
301 301
         {
302 302
             return;
303 303
         }
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
     
316 316
     public function getType() : string
317 317
     {
318
-        if($this->supportsType())
318
+        if ($this->supportsType())
319 319
         {
320 320
             return $this->type;
321 321
         }
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
     
336 336
     public function getHighlighted() : string
337 337
     {
338
-        if(!$this->isValid())
338
+        if (!$this->isValid())
339 339
         {
340 340
             return '';
341 341
         }
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
     
347 347
     public function getParamsString() : string
348 348
     {
349
-        if($this->requiresParameters())
349
+        if ($this->requiresParameters())
350 350
         {
351 351
             return $this->paramsString;
352 352
         }
@@ -373,22 +373,22 @@  discard block
 block discarded – undo
373 373
     
374 374
     public final function getCommandType() : string
375 375
     {
376
-        if($this instanceof Mailcode_Commands_Command_Type_Closing)
376
+        if ($this instanceof Mailcode_Commands_Command_Type_Closing)
377 377
         {
378 378
             return 'Closing';
379 379
         }
380 380
         
381
-        if($this instanceof Mailcode_Commands_Command_Type_Opening)
381
+        if ($this instanceof Mailcode_Commands_Command_Type_Opening)
382 382
         {
383 383
             return 'Opening';
384 384
         }
385 385
         
386
-        if($this instanceof Mailcode_Commands_Command_Type_Sibling)
386
+        if ($this instanceof Mailcode_Commands_Command_Type_Sibling)
387 387
         {
388 388
             return 'Sibling';
389 389
         }
390 390
         
391
-        if($this instanceof Mailcode_Commands_Command_Type_Standalone)
391
+        if ($this instanceof Mailcode_Commands_Command_Type_Standalone)
392 392
         {
393 393
             return 'Standalone';
394 394
         }
@@ -405,7 +405,7 @@  discard block
 block discarded – undo
405 405
     
406 406
     public function getNormalized() : string
407 407
     {
408
-        if(!$this->isValid())
408
+        if (!$this->isValid())
409 409
         {
410 410
             return '';
411 411
         }
@@ -413,12 +413,12 @@  discard block
 block discarded – undo
413 413
         $parts = array();
414 414
         $parts[] = '{'.$this->getName();
415 415
         
416
-        if($this->supportsType() && $this->hasType())
416
+        if ($this->supportsType() && $this->hasType())
417 417
         {
418 418
             $parts[] = ' '.$this->getType();
419 419
         }
420 420
         
421
-        if($this->requiresParameters() && isset($this->params))
421
+        if ($this->requiresParameters() && isset($this->params))
422 422
         {
423 423
             $parts[] = ': ';
424 424
             $parts[] = $this->params->getNormalized();
Please login to merge, or discard this patch.
src/Mailcode/Commands/Command/ShowSnippet.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
     {
66 66
         $this->validate();
67 67
         
68
-        if(isset($this->variable))
68
+        if (isset($this->variable))
69 69
         {
70 70
             return $this->variable;
71 71
         }
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
         
96 96
         $var = $info->getVariableByIndex(0);
97 97
         
98
-        if($var)
98
+        if ($var)
99 99
         {
100 100
             $this->variable = $var->getVariable();
101 101
             return;
Please login to merge, or discard this patch.
src/Mailcode/Parser/Safeguard/Formatter.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
         $lastPos = 0;
49 49
         $positions = array();
50 50
         
51
-        while (($lastPos = mb_strpos($haystack, $needle, $lastPos))!== false)
51
+        while (($lastPos = mb_strpos($haystack, $needle, $lastPos)) !== false)
52 52
         {
53 53
             $positions[] = $lastPos;
54 54
             $lastPos = $lastPos + mb_strlen($needle);
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
     {
68 68
         $eol = ConvertHelper::detectEOLCharacter($subject);
69 69
         
70
-        if($eol)
70
+        if ($eol)
71 71
         {
72 72
             return $eol->getCharacter();
73 73
         }
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
         
89 89
         $result = array();
90 90
         
91
-        foreach($placeholders as $placeholder)
91
+        foreach ($placeholders as $placeholder)
92 92
         {
93 93
             $result[] = $placeholder->getReplacementText();
94 94
         }
Please login to merge, or discard this patch.
src/Mailcode/Parser/Safeguard/Formatter/SingleLines/Placeholder.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -90,21 +90,21 @@  discard block
 block discarded – undo
90 90
     protected function analyzePrepend(string $subject) : void
91 91
     {
92 92
         // we're at the beginning of the string
93
-        if($this->position == 0)
93
+        if ($this->position == 0)
94 94
         {
95 95
             return;
96 96
         }
97 97
         
98 98
         $prevPos = $this->position - $this->eolLength;
99 99
         
100
-        if($prevPos < 0)
100
+        if ($prevPos < 0)
101 101
         {
102 102
             $prevPos = 0;
103 103
         }
104 104
         
105 105
         $prev = mb_substr($subject, $prevPos, $this->eolLength);
106 106
         
107
-        if($prev !== $this->formatter->getEOLChar())
107
+        if ($prev !== $this->formatter->getEOLChar())
108 108
         {
109 109
             $this->prepend = true;
110 110
         }
@@ -117,21 +117,21 @@  discard block
 block discarded – undo
117 117
         $position = $this->position + $this->placeholderLength;
118 118
         
119 119
         // we're at the end of the string
120
-        if($position >= $subjectLength)
120
+        if ($position >= $subjectLength)
121 121
         {
122 122
             return;
123 123
         }
124 124
         
125 125
         $nextPos = $position + $this->eolLength;
126 126
         
127
-        if($nextPos > $subjectLength)
127
+        if ($nextPos > $subjectLength)
128 128
         {
129 129
             $nextPos = $subjectLength - $this->eolLength;
130 130
         }
131 131
         
132 132
         $next = mb_substr($subject, $nextPos, $this->eolLength);
133 133
         
134
-        if($next !== $this->formatter->getEOLChar())
134
+        if ($next !== $this->formatter->getEOLChar())
135 135
         {
136 136
             $this->append = true;
137 137
         }
Please login to merge, or discard this patch.
src/Mailcode/Parser/Safeguard/Formatter/SingleLines.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
         
43 43
         $total = count($placeholders);
44 44
         
45
-        for($i=0; $i < $total; $i++)
45
+        for ($i = 0; $i < $total; $i++)
46 46
         {
47 47
             $subject = $this->process($placeholders[$i], $subject);
48 48
         }
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
         $phLength = mb_strlen($placeholder);
67 67
         $offset = 0;
68 68
         
69
-        foreach($positions as $position)
69
+        foreach ($positions as $position)
70 70
         {
71 71
             // adjust the position if previous changes made the subject longer
72 72
             $position += $offset;
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
                 $position
79 79
             );
80 80
             
81
-            if(!$info->requiresAdjustment())
81
+            if (!$info->requiresAdjustment())
82 82
             {
83 83
                 continue;
84 84
             }
@@ -106,12 +106,12 @@  discard block
 block discarded – undo
106 106
         $prepend = '';
107 107
         $append = '';
108 108
         
109
-        if($info->requiresPrepend())
109
+        if ($info->requiresPrepend())
110 110
         {
111 111
             $prepend = $this->eol;
112 112
         }
113 113
         
114
-        if($info->requiresAppend())
114
+        if ($info->requiresAppend())
115 115
         {
116 116
             $append = $this->eol;
117 117
         }
@@ -132,9 +132,9 @@  discard block
 block discarded – undo
132 132
         
133 133
         $result = array();
134 134
         
135
-        foreach($placeholders as $placeholder)
135
+        foreach ($placeholders as $placeholder)
136 136
         {
137
-            if(!$placeholder->getCommand()->generatesContent())
137
+            if (!$placeholder->getCommand()->generatesContent())
138 138
             {
139 139
                 $result[] = $placeholder;
140 140
             }
Please login to merge, or discard this patch.
src/Mailcode/Parser/Safeguard.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
     */
135 135
     public function setDelimiter(string $delimiter) : Mailcode_Parser_Safeguard
136 136
     {
137
-        if(empty($delimiter))
137
+        if (empty($delimiter))
138 138
         {
139 139
             throw new Mailcode_Exception(
140 140
                 'Empty delimiter',
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
         $safe = str_replace(array_values($replaces), array_keys($replaces), $this->originalString);
172 172
 
173 173
         // If a formatter has been selected, let it modify the string.
174
-        if(isset($this->formatter))
174
+        if (isset($this->formatter))
175 175
         {
176 176
             $safe = $this->formatter->format($safe);
177 177
         }
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
     {
184 184
         $class = 'Mailcode\Mailcode_Parser_Safeguard_Formatter_'.$formatterID;
185 185
         
186
-        if(class_exists($class))
186
+        if (class_exists($class))
187 187
         {
188 188
             $this->formatter = new $class($this);
189 189
             
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
     {
210 210
         $formatter = $this->selectFormatter('SingleLines');
211 211
         
212
-        if($formatter instanceof Mailcode_Parser_Safeguard_Formatter_SingleLines)
212
+        if ($formatter instanceof Mailcode_Parser_Safeguard_Formatter_SingleLines)
213 213
         {
214 214
             return $formatter;
215 215
         }
@@ -231,17 +231,17 @@  discard block
 block discarded – undo
231 231
     * @param bool $highlighted
232 232
     * @return string[]string
233 233
     */
234
-    protected function getReplaces(bool $highlighted=false) : array
234
+    protected function getReplaces(bool $highlighted = false) : array
235 235
     {
236 236
         $placeholders = $this->getPlaceholders();
237 237
         
238 238
         $replaces = array();
239 239
         
240
-        foreach($placeholders as $placeholder)
240
+        foreach ($placeholders as $placeholder)
241 241
         {
242 242
             $replace = '';
243 243
             
244
-            if($highlighted)
244
+            if ($highlighted)
245 245
             {
246 246
                 $replace = $placeholder->getHighlightedText();
247 247
             }
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
     */
266 266
     public function getPlaceholders()
267 267
     {
268
-        if(isset($this->placeholders))
268
+        if (isset($this->placeholders))
269 269
         {
270 270
             return $this->placeholders;
271 271
         }
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
         
275 275
         $cmds = $this->getCollection()->getGroupedByHash();
276 276
         
277
-        foreach($cmds as $command)
277
+        foreach ($cmds as $command)
278 278
         {
279 279
             self::$counter++;
280 280
             
@@ -288,7 +288,7 @@  discard block
 block discarded – undo
288 288
         return $this->placeholders;
289 289
     }
290 290
     
291
-    protected function restore(string $string, bool $highlighted=false) : string
291
+    protected function restore(string $string, bool $highlighted = false) : string
292 292
     {
293 293
         $this->requireValidCollection();
294 294
         
@@ -296,9 +296,9 @@  discard block
 block discarded – undo
296 296
         
297 297
         $placeholderStrings = array_keys($replaces);
298 298
         
299
-        foreach($placeholderStrings as $search)
299
+        foreach ($placeholderStrings as $search)
300 300
         {
301
-            if(!strstr($string, $search))
301
+            if (!strstr($string, $search))
302 302
             {
303 303
                 throw new Mailcode_Exception(
304 304
                     'Command placeholder not found',
@@ -356,7 +356,7 @@  discard block
 block discarded – undo
356 356
     */
357 357
     public function getCollection() : Mailcode_Collection
358 358
     {
359
-        if(isset($this->collection))
359
+        if (isset($this->collection))
360 360
         {
361 361
             return $this->collection;
362 362
         }
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
378 378
     */
379 379
     protected function requireValidCollection() : void
380 380
     {
381
-        if($this->getCollection()->isValid())
381
+        if ($this->getCollection()->isValid())
382 382
         {
383 383
             return;
384 384
         }
@@ -401,7 +401,7 @@  discard block
 block discarded – undo
401 401
     */
402 402
     public function getPlaceholderStrings() : array
403 403
     {
404
-        if(isset($this->placeholderStrings))
404
+        if (isset($this->placeholderStrings))
405 405
         {
406 406
             return $this->placeholderStrings;
407 407
         }
@@ -410,7 +410,7 @@  discard block
 block discarded – undo
410 410
         
411 411
         $this->placeholderStrings = array();
412 412
         
413
-        foreach($placeholders as $placeholder)
413
+        foreach ($placeholders as $placeholder)
414 414
         {
415 415
             $this->placeholderStrings[] = $placeholder->getReplacementText();
416 416
         }
@@ -436,9 +436,9 @@  discard block
 block discarded – undo
436 436
     {
437 437
         $placeholders = $this->getPlaceholders();
438 438
         
439
-        foreach($placeholders as $placeholder)
439
+        foreach ($placeholders as $placeholder)
440 440
         {
441
-            if($placeholder->getID() === $id)
441
+            if ($placeholder->getID() === $id)
442 442
             {
443 443
                 return $placeholder;
444 444
             }
@@ -465,9 +465,9 @@  discard block
 block discarded – undo
465 465
     {
466 466
         $placeholders = $this->getPlaceholders();
467 467
         
468
-        foreach($placeholders as $placeholder)
468
+        foreach ($placeholders as $placeholder)
469 469
         {
470
-            if($placeholder->getReplacementText() === $string)
470
+            if ($placeholder->getReplacementText() === $string)
471 471
             {
472 472
                 return $placeholder;
473 473
             }
Please login to merge, or discard this patch.
src/Mailcode/Translator/Syntax/ApacheVelocity/ShowDate.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,9 +56,9 @@
 block discarded – undo
56 56
         $chars = ConvertHelper::string2array($formatString);
57 57
         $result = array();
58 58
         
59
-        foreach($chars as $char)
59
+        foreach ($chars as $char)
60 60
         {
61
-            if(!isset($this->charTable[$char]))
61
+            if (!isset($this->charTable[$char]))
62 62
             {
63 63
                 throw new Mailcode_Translator_Exception(
64 64
                     'Unknown date format string character',
Please login to merge, or discard this patch.
src/Mailcode/Date/FormatInfo/Character.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@
 block discarded – undo
87 87
     */
88 88
     public function getTypeLabel() : string
89 89
     {
90
-        switch($this->type)
90
+        switch ($this->type)
91 91
         {
92 92
             case Mailcode_Date_FormatInfo::CHARTYPE_DATE:
93 93
                 return t('Date');
Please login to merge, or discard this patch.
src/Mailcode/Date/FormatInfo.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
     
59 59
     public static function getInstance() : Mailcode_Date_FormatInfo
60 60
     {
61
-        if(!isset(self::$instance))
61
+        if (!isset(self::$instance))
62 62
         {
63 63
             self::$instance = new Mailcode_Date_FormatInfo();
64 64
         }
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
             array(self::CHARTYPE_PUNCTUATION, ' ', t('Space'))
91 91
         );
92 92
         
93
-        foreach($chars as $def)
93
+        foreach ($chars as $def)
94 94
         {
95 95
             $char = new Mailcode_Date_FormatInfo_Character(
96 96
                 $def[0],
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
         
130 130
         $trimmed = trim($formatString);
131 131
         
132
-        if(empty($trimmed))
132
+        if (empty($trimmed))
133 133
         {
134 134
             $result->makeError(
135 135
                 t('Empty date format.'),
@@ -142,15 +142,15 @@  discard block
 block discarded – undo
142 142
         $chars = ConvertHelper::string2array($formatString);
143 143
         $total = count($chars);
144 144
         
145
-        for($i=0; $i < $total; $i++)
145
+        for ($i = 0; $i < $total; $i++)
146 146
         {
147 147
             $char = $chars[$i];
148 148
             
149
-            if(!in_array($char, $this->allowedChars))
149
+            if (!in_array($char, $this->allowedChars))
150 150
             {
151 151
                 $result->makeError(
152 152
                     t('Invalid character in date format:').' '.
153
-                    t('%1$s at position %2$s.', '<code>'.$char.'</code>', $i+1),
153
+                    t('%1$s at position %2$s.', '<code>'.$char.'</code>', $i + 1),
154 154
                     self::VALIDATION_INVALID_FORMAT_CHARACTER
155 155
                 );
156 156
                 
@@ -182,11 +182,11 @@  discard block
 block discarded – undo
182 182
     {
183 183
         $grouped = array();
184 184
         
185
-        foreach($this->formatChars as $char)
185
+        foreach ($this->formatChars as $char)
186 186
         {
187 187
             $type = $char->getTypeLabel();
188 188
             
189
-            if(!isset($grouped[$type]))
189
+            if (!isset($grouped[$type]))
190 190
             {
191 191
                 $grouped[$type] = array();
192 192
             }
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
 
197 197
         $groups = array_keys($grouped);
198 198
         
199
-        foreach($groups as $group)
199
+        foreach ($groups as $group)
200 200
         {
201 201
             usort($grouped[$group], function(Mailcode_Date_FormatInfo_Character $a, Mailcode_Date_FormatInfo_Character $b)
202 202
             {
Please login to merge, or discard this patch.