Passed
Push — master ( f745df...75ee28 )
by Sebastian
03:57
created
src/Mailcode/Parser/Statement/Tokenizer/Token/Operand.php 1 patch
Indentation   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -30,10 +30,10 @@  discard block
 block discarded – undo
30 30
         return $this->getSign();
31 31
     }
32 32
     
33
-   /**
34
-    * Retrieves all known comparison operator signs.
35
-    * @return string[]
36
-    */
33
+    /**
34
+     * Retrieves all known comparison operator signs.
35
+     * @return string[]
36
+     */
37 37
     public static function getComparisonSigns() : array
38 38
     {
39 39
         return array(
@@ -46,10 +46,10 @@  discard block
 block discarded – undo
46 46
         );
47 47
     }
48 48
     
49
-   /**
50
-    * Retrieves all known arithmetic operator signs.
51
-    * @return string[]
52
-    */
49
+    /**
50
+     * Retrieves all known arithmetic operator signs.
51
+     * @return string[]
52
+     */
53 53
     public static function getArithmeticSigns() : array
54 54
     {
55 55
         return array(
@@ -60,11 +60,11 @@  discard block
 block discarded – undo
60 60
         );
61 61
     }
62 62
     
63
-   /**
64
-    * Whether the operator is comparison related (equals, not equals, smaller, greater...).
65
-    *  
66
-    * @return bool
67
-    */
63
+    /**
64
+     * Whether the operator is comparison related (equals, not equals, smaller, greater...).
65
+     *  
66
+     * @return bool
67
+     */
68 68
     public function isComparator() : bool
69 69
     {
70 70
         return 
@@ -76,11 +76,11 @@  discard block
 block discarded – undo
76 76
         $this->isSmallerOrEquals();
77 77
     }
78 78
     
79
-   /**
80
-    * Whether the operator is calculation related (minus, plus, divide, multiply).
81
-    * 
82
-    * @return bool
83
-    */
79
+    /**
80
+     * Whether the operator is calculation related (minus, plus, divide, multiply).
81
+     * 
82
+     * @return bool
83
+     */
84 84
     public function isCalculator() : bool
85 85
     {
86 86
         return 
Please login to merge, or discard this patch.
src/Mailcode/Factory/CommandSets/Set/Misc.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
     
35 35
         $this->instantiator->checkCommand($cmd);
36 36
         
37
-        if($cmd instanceof Mailcode_Commands_Command_Comment)
37
+        if ($cmd instanceof Mailcode_Commands_Command_Comment)
38 38
         {
39 39
             return $cmd;
40 40
         }
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
         throw $this->instantiator->exceptionUnexpectedType('Comment', $cmd);
43 43
     }
44 44
     
45
-    public function for(string $sourceVariable, string $loopVariable) : Mailcode_Commands_Command_For
45
+    public function for (string $sourceVariable, string $loopVariable) : Mailcode_Commands_Command_For
46 46
     {
47 47
         $sourceVariable = '$'.ltrim($sourceVariable, '$');
48 48
         $loopVariable = '$'.ltrim($loopVariable, '$');
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
         
65 65
         $this->instantiator->checkCommand($cmd);
66 66
         
67
-        if($cmd instanceof Mailcode_Commands_Command_For)
67
+        if ($cmd instanceof Mailcode_Commands_Command_For)
68 68
         {
69 69
             return $cmd;
70 70
         }
Please login to merge, or discard this patch.
src/Mailcode/Commands/Command/For.php 2 patches
Indentation   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -27,19 +27,19 @@
 block discarded – undo
27 27
     const VALIDATION_WRONG_KEYWORD = 49702;
28 28
     const VALIDATION_VARIABLE_NAME_IS_THE_SAME = 49703;
29 29
     
30
-   /**
31
-    * @var Mailcode_Parser_Statement_Tokenizer_Token_Variable|NULL
32
-    */
30
+    /**
31
+     * @var Mailcode_Parser_Statement_Tokenizer_Token_Variable|NULL
32
+     */
33 33
     private $loopVar;
34 34
     
35
-   /**
36
-    * @var Mailcode_Parser_Statement_Tokenizer_Token_Variable|NULL
37
-    */
35
+    /**
36
+     * @var Mailcode_Parser_Statement_Tokenizer_Token_Variable|NULL
37
+     */
38 38
     private $sourceVar;
39 39
     
40
-   /**
41
-    * @var Mailcode_Parser_Statement_Tokenizer_Token_Keyword|NULL
42
-    */
40
+    /**
41
+     * @var Mailcode_Parser_Statement_Tokenizer_Token_Keyword|NULL
42
+     */
43 43
     private $keyword;
44 44
     
45 45
     public function getName() : string
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
     
89 89
     public function getSourceVariable() : Mailcode_Variables_Variable
90 90
     {
91
-        if(isset($this->sourceVar))
91
+        if (isset($this->sourceVar))
92 92
         {
93 93
             return $this->sourceVar->getVariable();
94 94
         }
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
     
103 103
     public function getLoopVariable() : Mailcode_Variables_Variable
104 104
     {
105
-        if(isset($this->loopVar))
105
+        if (isset($this->loopVar))
106 106
         {
107 107
             return $this->loopVar->getVariable();
108 108
         }
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
         $this->keyword = $info->getKeywordByIndex(1);
123 123
         $this->sourceVar = $info->getVariableByIndex(2);
124 124
         
125
-        if(!$this->loopVar || !$this->keyword || !$this->sourceVar)
125
+        if (!$this->loopVar || !$this->keyword || !$this->sourceVar)
126 126
         {
127 127
             $this->validationResult->makeError(
128 128
                 t('Not a valid for loop.').' '.t('Is the %1$s keyword missing?', 'in:'),
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
     
136 136
     protected function validateSyntax_keyword() : void
137 137
     {
138
-        if($this->keyword->isForIn())
138
+        if ($this->keyword->isForIn())
139 139
         {
140 140
             return;
141 141
         }
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
     
149 149
     protected function validateSyntax_variable_names() : void
150 150
     {
151
-        if($this->sourceVar->getVariable()->getFullName() !== $this->loopVar->getVariable()->getFullName())
151
+        if ($this->sourceVar->getVariable()->getFullName() !== $this->loopVar->getVariable()->getFullName())
152 152
         {
153 153
             return;
154 154
         }
Please login to merge, or discard this patch.
src/Mailcode/Parser/Safeguard/Formatter/ReplacerType.php 2 patches
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -35,13 +35,13 @@
 block discarded – undo
35 35
         }
36 36
     }
37 37
     
38
-   /**
39
-    * Resolves the string with which this location needs to be
40
-    * replaced.
41
-    * 
42
-    * @param Mailcode_Parser_Safeguard_Formatter_Location $location
43
-    * @return string
44
-    */
38
+    /**
39
+     * Resolves the string with which this location needs to be
40
+     * replaced.
41
+     * 
42
+     * @param Mailcode_Parser_Safeguard_Formatter_Location $location
43
+     * @return string
44
+     */
45 45
     private function resolveReplacement(Mailcode_Parser_Safeguard_Formatter_Location $location) : string
46 46
     {
47 47
         if($location->requiresAdjustment())
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
     {
30 30
         $locations = $this->resolveLocations();
31 31
         
32
-        foreach($locations as $location)
32
+        foreach ($locations as $location)
33 33
         {
34 34
             $location->replaceWith($this->resolveReplacement($location));
35 35
             
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
     */
47 47
     private function resolveReplacement(Mailcode_Parser_Safeguard_Formatter_Location $location) : string
48 48
     {
49
-        if($location->requiresAdjustment())
49
+        if ($location->requiresAdjustment())
50 50
         {
51 51
             return $this->getReplaceString($location);
52 52
         }
Please login to merge, or discard this patch.
src/Mailcode/Parser/Safeguard/Formatter/Type/SingleLines.php 1 patch
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -23,14 +23,14 @@
 block discarded – undo
23 23
  */
24 24
 class Mailcode_Parser_Safeguard_Formatter_Type_SingleLines extends Mailcode_Parser_Safeguard_Formatter_FormatType
25 25
 {
26
-   /**
27
-    * @var string
28
-    */
26
+    /**
27
+     * @var string
28
+     */
29 29
     private $eol;
30 30
     
31
-   /**
32
-    * @var int
33
-    */
31
+    /**
32
+     * @var int
33
+     */
34 34
     private $eolLength;
35 35
     
36 36
     protected function initFormatting() : void
Please login to merge, or discard this patch.
src/Mailcode/Parser/Safeguard/Formatter/Type/SingleLines/Location.php 2 patches
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -25,14 +25,14 @@
 block discarded – undo
25 25
  */
26 26
 class Mailcode_Parser_Safeguard_Formatter_Type_SingleLines_Location extends Mailcode_Parser_Safeguard_Formatter_Location
27 27
 {
28
-   /**
29
-    * @var int
30
-    */
28
+    /**
29
+     * @var int
30
+     */
31 31
     protected $eolLength;
32 32
     
33
-   /**
34
-    * @var string
35
-    */
33
+    /**
34
+     * @var string
35
+     */
36 36
     protected $eol;
37 37
     
38 38
     protected function init() : void
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
         $position = $this->getStartPosition();
56 56
         
57 57
         // we're at the beginning of the string
58
-        if($position === false || $position === 0)
58
+        if ($position === false || $position === 0)
59 59
         {
60 60
             $this->log(sprintf(
61 61
                 'Prepend: NO | Position: [%s] | Not found, or at beginning of string.', 
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
         
68 68
         $prevPos = $position - $this->eolLength;
69 69
         
70
-        if($prevPos < 0)
70
+        if ($prevPos < 0)
71 71
         {
72 72
             $prevPos = 0;
73 73
         }
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
     
78 78
     protected function checkPreviousPosition(int $prevPos) : void
79 79
     {
80
-        if($this->isWithinCommand($prevPos))
80
+        if ($this->isWithinCommand($prevPos))
81 81
         {
82 82
             $this->log(sprintf(
83 83
                 'Prepend: NO | Position: [%s] | Is within a mailcode command.', 
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
         
90 90
         $match = $this->subject->getSubstr($prevPos, $this->eolLength);
91 91
         
92
-        if($match !== $this->formatter->getEOLChar())
92
+        if ($match !== $this->formatter->getEOLChar())
93 93
         {
94 94
             $this->log(sprintf(
95 95
                 'Prepend: YES | Position: [%s] | Characters: [%s] | Do not match the EOL character.',
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
         $position = $this->getEndPosition();
109 109
         
110 110
         // we're at the end of the string
111
-        if($position === false || $position >= $subjectLength)
111
+        if ($position === false || $position >= $subjectLength)
112 112
         {
113 113
             $this->log(sprintf(
114 114
                 'Append: NO | Position: [%s] | End of string, or too long | Subject length: [%s]',
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
         
122 122
         $nextPos = $position + $this->eolLength;
123 123
         
124
-        if($nextPos > $subjectLength)
124
+        if ($nextPos > $subjectLength)
125 125
         {
126 126
             $nextPos = $subjectLength - $this->eolLength;
127 127
         }
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
     
132 132
     protected function checkNextPosition(int $nextPos) : void
133 133
     {
134
-        if($this->isWithinCommand($nextPos))
134
+        if ($this->isWithinCommand($nextPos))
135 135
         {
136 136
             $this->log(sprintf(
137 137
                 'Append: YES | Position: [%s] | Is within a mailcode command.',
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
         
146 146
         $next = $this->subject->getSubstr($nextPos, $this->eolLength);
147 147
         
148
-        if($next !== $this->formatter->getEOLChar())
148
+        if ($next !== $this->formatter->getEOLChar())
149 149
         {
150 150
             $this->log(sprintf(
151 151
                 'Append: YES | Position: [%s] | Next characters: [%s] | Do not match the EOL character.',
Please login to merge, or discard this patch.
src/Mailcode/Parser/Safeguard/Formatter/Type/MarkVariables/Location.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
     
33 33
     public function requiresAdjustment(): bool
34 34
     {
35
-        if(!parent::requiresAdjustment())
35
+        if (!parent::requiresAdjustment())
36 36
         {
37 37
             return false;
38 38
         }
Please login to merge, or discard this patch.
src/Mailcode/Parser/Safeguard/Formatter/Type/HTMLHighlighting/Location.php 3 patches
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -119,8 +119,7 @@
 block discarded – undo
119 119
             if($closing)
120 120
             {
121 121
                 array_pop($stack);
122
-            }
123
-            else
122
+            } else
124 123
             {
125 124
                 $stack[] = $tagName;
126 125
             }
Please login to merge, or discard this patch.
Indentation   +36 added lines, -36 removed lines patch added patch discarded remove patch
@@ -24,14 +24,14 @@  discard block
 block discarded – undo
24 24
 {
25 25
     const COMMAND_MARKER = '__MAILCODE_COMMAND__';
26 26
     
27
-   /**
28
-    * @var boolean
29
-    */
27
+    /**
28
+     * @var boolean
29
+     */
30 30
     private $ancestryChecked = false;
31 31
     
32
-   /**
33
-    * @var array<int,array<int,string>>
34
-    */
32
+    /**
33
+     * @var array<int,array<int,string>>
34
+     */
35 35
     private $tagAncestry = array();
36 36
     
37 37
     protected function init() : void
@@ -43,12 +43,12 @@  discard block
 block discarded – undo
43 43
         return !$this->isInTagAttributes() && !$this->isInExcludedTag();
44 44
     }
45 45
     
46
-   /**
47
-    * Retrieves the part of the subject string that comes
48
-    * before the command.
49
-    * 
50
-    * @return string
51
-    */
46
+    /**
47
+     * Retrieves the part of the subject string that comes
48
+     * before the command.
49
+     * 
50
+     * @return string
51
+     */
52 52
     private function getHaystackBefore() : string
53 53
     {
54 54
         $pos = $this->getStartPosition();
@@ -65,12 +65,12 @@  discard block
 block discarded – undo
65 65
         return $this->subject->getSubstr(0, $pos).self::COMMAND_MARKER.'>';
66 66
     }
67 67
     
68
-   /**
69
-    * Whether the command is nested in one of the tags
70
-    * that have been added to the list of excluded tags.
71
-    * 
72
-    * @return bool
73
-    */
68
+    /**
69
+     * Whether the command is nested in one of the tags
70
+     * that have been added to the list of excluded tags.
71
+     * 
72
+     * @return bool
73
+     */
74 74
     protected function isInExcludedTag() : bool
75 75
     {
76 76
         $tagNames = $this->getParentTags();
@@ -86,12 +86,12 @@  discard block
 block discarded – undo
86 86
         return false;
87 87
     }
88 88
     
89
-   /**
90
-    * Retrieves a list of the command's parent HTML tags, from
91
-    * highest to lowest.
92
-    * 
93
-    * @return string[]
94
-    */
89
+    /**
90
+     * Retrieves a list of the command's parent HTML tags, from
91
+     * highest to lowest.
92
+     * 
93
+     * @return string[]
94
+     */
95 95
     private function getParentTags() : array
96 96
     {
97 97
         $tags = $this->getTagAncestry();
@@ -116,12 +116,12 @@  discard block
 block discarded – undo
116 116
         return $stack;
117 117
     }
118 118
     
119
-   /**
120
-    * Checks whether the command is located within the attributes
121
-    * of an HTML tag.
122
-    * 
123
-    * @return bool
124
-    */
119
+    /**
120
+     * Checks whether the command is located within the attributes
121
+     * of an HTML tag.
122
+     * 
123
+     * @return bool
124
+     */
125 125
     protected function isInTagAttributes() : bool
126 126
     {
127 127
         $tags = $this->getTagAncestry();
@@ -139,12 +139,12 @@  discard block
 block discarded – undo
139 139
         return false;
140 140
     }
141 141
     
142
-   /**
143
-    * Retrieves a list of tag names that come as parents 
144
-    * above the command.
145
-    * 
146
-    * @return array<int,array<int,string>>
147
-    */
142
+    /**
143
+     * Retrieves a list of tag names that come as parents 
144
+     * above the command.
145
+     * 
146
+     * @return array<int,array<int,string>>
147
+     */
148 148
     private function getTagAncestry() : array
149 149
     {
150 150
         if($this->ancestryChecked)
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
     {
54 54
         $pos = $this->getStartPosition();
55 55
         
56
-        if(is_bool($pos))
56
+        if (is_bool($pos))
57 57
         {
58 58
             return '';
59 59
         }
@@ -75,9 +75,9 @@  discard block
 block discarded – undo
75 75
     {
76 76
         $tagNames = $this->getParentTags();
77 77
         
78
-        foreach($tagNames as $tagName)
78
+        foreach ($tagNames as $tagName)
79 79
         {
80
-            if($this->formatter->isTagExcluded($tagName))
80
+            if ($this->formatter->isTagExcluded($tagName))
81 81
             {
82 82
                 return true;
83 83
             }
@@ -99,11 +99,11 @@  discard block
 block discarded – undo
99 99
         // Create a stack of all direct parent tags of the command.
100 100
         // Handles closing tags as well.
101 101
         $stack = array();
102
-        foreach($tags[2] as $idx => $tagName)
102
+        foreach ($tags[2] as $idx => $tagName)
103 103
         {
104 104
             $closing = $tags[1][$idx] === '/';
105 105
             
106
-            if($closing)
106
+            if ($closing)
107 107
             {
108 108
                 array_pop($stack);
109 109
             }
@@ -128,9 +128,9 @@  discard block
 block discarded – undo
128 128
         
129 129
         // This check is easy: if the command is in the attribute
130 130
         // of any of the tags, we will find the command marker in there.
131
-        foreach($tags[3] as $attributes)
131
+        foreach ($tags[3] as $attributes)
132 132
         {
133
-            if(strstr($attributes, self::COMMAND_MARKER))
133
+            if (strstr($attributes, self::COMMAND_MARKER))
134 134
             {
135 135
                 return true;
136 136
             }
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
     */
148 148
     private function getTagAncestry() : array
149 149
     {
150
-        if($this->ancestryChecked)
150
+        if ($this->ancestryChecked)
151 151
         {
152 152
             return $this->tagAncestry;
153 153
         }
Please login to merge, or discard this patch.
src/Mailcode/Parser/Safeguard/Formatter/FormatType.php 2 patches
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -25,11 +25,11 @@
 block discarded – undo
25 25
         return PHP_INT_MAX;
26 26
     }
27 27
 
28
-   /**
29
-    * Formats the specified string according to the formatter.
30
-    * Retrieve the updated string from the string container used
31
-    * to create the formatter, or use `getSubjectString()`.
32
-    */
28
+    /**
29
+     * Formats the specified string according to the formatter.
30
+     * Retrieve the updated string from the string container used
31
+     * to create the formatter, or use `getSubjectString()`.
32
+     */
33 33
     public function format() : void
34 34
     {
35 35
         $locations = $this->resolveLocations();
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
     {
35 35
         $locations = $this->resolveLocations();
36 36
         
37
-        foreach($locations as $location)
37
+        foreach ($locations as $location)
38 38
         {
39 39
             $location->format();
40 40
             
Please login to merge, or discard this patch.