Passed
Push — master ( 77b992...62880d )
by Sebastian
02:14
created
src/Mailcode/Variables/Variable.php 2 patches
Indentation   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -29,29 +29,29 @@
 block discarded – undo
29 29
     
30 30
     const VALIDATION_ERROR_NAME_NUMERIC = 48202;
31 31
     
32
-   /**
33
-    * @var string
34
-    */
32
+    /**
33
+     * @var string
34
+     */
35 35
     protected $path;
36 36
     
37
-   /**
38
-    * @var string
39
-    */
37
+    /**
38
+     * @var string
39
+     */
40 40
     protected $name;
41 41
     
42
-   /**
43
-    * @var string
44
-    */
42
+    /**
43
+     * @var string
44
+     */
45 45
     protected $matchedText;
46 46
     
47
-   /**
48
-    * @var string
49
-    */
47
+    /**
48
+     * @var string
49
+     */
50 50
     protected $hash = '';
51 51
     
52
-   /**
53
-    * @var OperationResult
54
-    */
52
+    /**
53
+     * @var OperationResult
54
+     */
55 55
     protected $validationResult = null;
56 56
     
57 57
     public function __construct(string $path, string $name, string $matchedText)
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
     
84 84
     public function getHash() : string
85 85
     {
86
-        if(empty($this->hash))
86
+        if (empty($this->hash))
87 87
         {
88 88
             $this->hash = md5($this->matchedText);
89 89
         }
@@ -107,14 +107,14 @@  discard block
 block discarded – undo
107 107
     
108 108
     protected function validate() : void
109 109
     {
110
-        if(isset($this->validationResult))
110
+        if (isset($this->validationResult))
111 111
         {
112 112
             return;
113 113
         }
114 114
         
115 115
         $this->validationResult = new OperationResult($this);
116 116
         
117
-        if(is_numeric(substr($this->path, 0, 1))) 
117
+        if (is_numeric(substr($this->path, 0, 1))) 
118 118
         {
119 119
             $this->validationResult->makeError(
120 120
                 t(
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
             );
127 127
         }
128 128
         
129
-        if(is_numeric(substr($this->name, 0, 1)))
129
+        if (is_numeric(substr($this->name, 0, 1)))
130 130
         {
131 131
             $this->validationResult->makeError(
132 132
                 t(
Please login to merge, or discard this patch.
src/Mailcode/Variables/Collection/Regular.php 2 patches
Indentation   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -20,9 +20,9 @@  discard block
 block discarded – undo
20 20
  */
21 21
 class Mailcode_Variables_Collection_Regular extends Mailcode_Variables_Collection
22 22
 {
23
-   /**
24
-    * @var Mailcode_Variables_Collection_Invalid
25
-    */
23
+    /**
24
+     * @var Mailcode_Variables_Collection_Invalid
25
+     */
26 26
     protected $invalid;
27 27
 
28 28
     protected function init() : void
@@ -47,30 +47,30 @@  discard block
 block discarded – undo
47 47
         return $this;
48 48
     }
49 49
 
50
-   /**
51
-    * Whether any of the variables in the collection are invalid.
52
-    * 
53
-    * @return bool
54
-    */
50
+    /**
51
+     * Whether any of the variables in the collection are invalid.
52
+     * 
53
+     * @return bool
54
+     */
55 55
     public function hasInvalid() : bool
56 56
     {
57 57
         return isset($this->invalid) && $this->invalid->hasVariables();
58 58
     }
59 59
     
60
-   /**
61
-    * Retrieves the collection of invalid variables, if any.
62
-    * Behaves like a variables collection.
63
-    * 
64
-    * @return Mailcode_Variables_Collection_Invalid
65
-    */
60
+    /**
61
+     * Retrieves the collection of invalid variables, if any.
62
+     * Behaves like a variables collection.
63
+     * 
64
+     * @return Mailcode_Variables_Collection_Invalid
65
+     */
66 66
     public function getInvalid() : Mailcode_Variables_Collection_Invalid
67 67
     {
68 68
         return $this->invalid;
69 69
     }
70 70
     
71
-   /**
72
-    * @return Mailcode_Variables_Collection_Regular
73
-    */
71
+    /**
72
+     * @return Mailcode_Variables_Collection_Regular
73
+     */
74 74
     public function mergeWith(Mailcode_Variables_Collection $collection) : Mailcode_Variables_Collection
75 75
     {
76 76
         parent::mergeWith($collection);
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
     
33 33
     public function add(Mailcode_Variables_Variable $variable) : Mailcode_Variables_Collection
34 34
     {
35
-        if(!$variable->isValid())
35
+        if (!$variable->isValid())
36 36
         {
37 37
             return $this->addInvalid($variable);
38 38
         }
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
         parent::mergeWith($collection);
77 77
         
78 78
         // also inherit any invalid variables
79
-        if($collection instanceof Mailcode_Variables_Collection_Regular)
79
+        if ($collection instanceof Mailcode_Variables_Collection_Regular)
80 80
         {
81 81
             $invalid = $collection->getInvalid();
82 82
             
Please login to merge, or discard this patch.
src/Mailcode/Variables/Collection/Invalid.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
 {
25 25
     public function add(Mailcode_Variables_Variable $variable) : Mailcode_Variables_Collection
26 26
     {
27
-        if($variable->isValid())
27
+        if ($variable->isValid())
28 28
         {
29 29
             return $this;
30 30
         }
Please login to merge, or discard this patch.
src/Mailcode/Variables/Collection.php 2 patches
Indentation   +54 added lines, -54 removed lines patch added patch discarded remove patch
@@ -20,11 +20,11 @@  discard block
 block discarded – undo
20 20
  */
21 21
 abstract class Mailcode_Variables_Collection
22 22
 {
23
-   /**
24
-    * Stores variables by their hash.
25
-    * 
26
-    * @var array[string]Mailcode_Variables_Variable
27
-    */
23
+    /**
24
+     * Stores variables by their hash.
25
+     * 
26
+     * @var array[string]Mailcode_Variables_Variable
27
+     */
28 28
     protected $variables = array();
29 29
     
30 30
     public function __construct()
@@ -56,12 +56,12 @@  discard block
 block discarded – undo
56 56
         return count($this->variables);
57 57
     }
58 58
     
59
-   /**
60
-    * Checks whether the collection contains a variable with the specified name.
61
-    * 
62
-    * @param string $fullName The variable name, with or without $ sign.
63
-    * @return bool
64
-    */
59
+    /**
60
+     * Checks whether the collection contains a variable with the specified name.
61
+     * 
62
+     * @param string $fullName The variable name, with or without $ sign.
63
+     * @return bool
64
+     */
65 65
     public function hasVariableName(string $fullName) : bool
66 66
     {
67 67
         $fullName = $this->fixName($fullName);
@@ -77,14 +77,14 @@  discard block
 block discarded – undo
77 77
         return false;
78 78
     }
79 79
     
80
-   /**
81
-    * Retrieves a collection of all variable instances for
82
-    * the specified name (there can be several with differing
83
-    * matched texts because of spacing).
84
-    * 
85
-    * @param string $fullName
86
-    * @return Mailcode_Variables_Collection
87
-    */
80
+    /**
81
+     * Retrieves a collection of all variable instances for
82
+     * the specified name (there can be several with differing
83
+     * matched texts because of spacing).
84
+     * 
85
+     * @param string $fullName
86
+     * @return Mailcode_Variables_Collection
87
+     */
88 88
     public function getByFullName(string $fullName) : Mailcode_Variables_Collection
89 89
     {
90 90
         $fullName = $this->fixName($fullName);
@@ -102,12 +102,12 @@  discard block
 block discarded – undo
102 102
         return $collection;
103 103
     }
104 104
     
105
-   /**
106
-    * Prepends the $ sign to a variable name if it does not have it.
107
-    * 
108
-    * @param string $fullName
109
-    * @return string
110
-    */
105
+    /**
106
+     * Prepends the $ sign to a variable name if it does not have it.
107
+     * 
108
+     * @param string $fullName
109
+     * @return string
110
+     */
111 111
     protected function fixName(string $fullName) : string
112 112
     {
113 113
         if(substr($fullName, 0, 1) === '$')
@@ -118,22 +118,22 @@  discard block
 block discarded – undo
118 118
         return '$'.$fullName;
119 119
     }
120 120
     
121
-   /**
122
-    * Retrieves all variables, grouped by their hash - meaning
123
-    * unique matched strings.
124
-    * 
125
-    * @return Mailcode_Variables_Variable[]
126
-    */
121
+    /**
122
+     * Retrieves all variables, grouped by their hash - meaning
123
+     * unique matched strings.
124
+     * 
125
+     * @return Mailcode_Variables_Variable[]
126
+     */
127 127
     public function getGroupedByHash()
128 128
     {
129 129
         return $this->sortVariables($this->variables);
130 130
     }
131 131
     
132
-   /**
133
-    * Retrieves all variables, grouped by their name. 
134
-    * 
135
-    * @return Mailcode_Variables_Variable[]
136
-    */
132
+    /**
133
+     * Retrieves all variables, grouped by their name. 
134
+     * 
135
+     * @return Mailcode_Variables_Variable[]
136
+     */
137 137
     public function getGroupedByName()
138 138
     {
139 139
         $entries = array();
@@ -146,10 +146,10 @@  discard block
 block discarded – undo
146 146
         return $this->sortVariables($entries);
147 147
     }
148 148
     
149
-   /**
150
-    * Retrieves the full names of the variables that are present in the collection.
151
-    * @return string[]
152
-    */
149
+    /**
150
+     * Retrieves the full names of the variables that are present in the collection.
151
+     * @return string[]
152
+     */
153 153
     public function getNames() : array
154 154
     {
155 155
         $result = array();
@@ -167,13 +167,13 @@  discard block
 block discarded – undo
167 167
         return $result;
168 168
     }
169 169
     
170
-   /**
171
-    * Takes a list of variables and sorts them, throwing away
172
-    * the source array's keys.
173
-    * 
174
-    * @param array $entries
175
-    * @return Mailcode_Variables_Variable[]
176
-    */
170
+    /**
171
+     * Takes a list of variables and sorts them, throwing away
172
+     * the source array's keys.
173
+     * 
174
+     * @param array $entries
175
+     * @return Mailcode_Variables_Variable[]
176
+     */
177 177
     protected function sortVariables(array $entries)
178 178
     {
179 179
         $result = array_values($entries);
@@ -186,13 +186,13 @@  discard block
 block discarded – undo
186 186
         return $result;
187 187
     }
188 188
 
189
-   /**
190
-    *  Merges the variables collection with the target collection
191
-    *  by inheriting all that collection's variables.
192
-    *  
193
-    * @param Mailcode_Variables_Collection $collection
194
-    * @return Mailcode_Variables_Collection
195
-    */
189
+    /**
190
+     *  Merges the variables collection with the target collection
191
+     *  by inheriting all that collection's variables.
192
+     *  
193
+     * @param Mailcode_Variables_Collection $collection
194
+     * @return Mailcode_Variables_Collection
195
+     */
196 196
     public function mergeWith(Mailcode_Variables_Collection $collection) : Mailcode_Variables_Collection
197 197
     {
198 198
         $variables = $collection->getGroupedByHash();
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -66,9 +66,9 @@  discard block
 block discarded – undo
66 66
     {
67 67
         $fullName = $this->fixName($fullName);
68 68
         
69
-        foreach($this->variables as $variable)
69
+        foreach ($this->variables as $variable)
70 70
         {
71
-            if($variable->getFullName() === $fullName)
71
+            if ($variable->getFullName() === $fullName)
72 72
             {
73 73
                 return true;
74 74
             }
@@ -91,9 +91,9 @@  discard block
 block discarded – undo
91 91
         
92 92
         $collection = new Mailcode_Variables_Collection_Regular();
93 93
         
94
-        foreach($this->variables as $variable)
94
+        foreach ($this->variables as $variable)
95 95
         {
96
-            if($variable->getFullName() === $fullName)
96
+            if ($variable->getFullName() === $fullName)
97 97
             {
98 98
                 $collection->add($variable);
99 99
             }
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
     */
111 111
     protected function fixName(string $fullName) : string
112 112
     {
113
-        if(substr($fullName, 0, 1) === '$')
113
+        if (substr($fullName, 0, 1) === '$')
114 114
         {
115 115
             return $fullName;
116 116
         }
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
     {
139 139
         $entries = array();
140 140
         
141
-        foreach($this->variables as $variable)
141
+        foreach ($this->variables as $variable)
142 142
         {
143 143
             $entries[$variable->getFullName()] = $variable;
144 144
         }
@@ -154,11 +154,11 @@  discard block
 block discarded – undo
154 154
     {
155 155
         $result = array();
156 156
         
157
-        foreach($this->variables as $variable)
157
+        foreach ($this->variables as $variable)
158 158
         {
159 159
             $name = $variable->getFullName();
160 160
             
161
-            if(!in_array($name, $result))
161
+            if (!in_array($name, $result))
162 162
             {
163 163
                 $result[] = $name;
164 164
             }
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
     {
198 198
         $variables = $collection->getGroupedByHash();
199 199
         
200
-        foreach($variables as $variable)
200
+        foreach ($variables as $variable)
201 201
         {
202 202
             $this->add($variable);
203 203
         }
Please login to merge, or discard this patch.
src/Mailcode/Collection.php 2 patches
Indentation   +28 added lines, -28 removed lines patch added patch discarded remove patch
@@ -20,9 +20,9 @@  discard block
 block discarded – undo
20 20
  */
21 21
 class Mailcode_Collection
22 22
 {
23
-   /**
24
-    * @var Mailcode_Commands_Command[]
25
-    */
23
+    /**
24
+     * @var Mailcode_Commands_Command[]
25
+     */
26 26
     protected $commands = array();
27 27
     
28 28
     /**
@@ -30,12 +30,12 @@  discard block
 block discarded – undo
30 30
      */
31 31
     protected $errors = array();
32 32
     
33
-   /**
34
-    * Adds a command to the collection.
35
-    * 
36
-    * @param Mailcode_Commands_Command $command
37
-    * @return Mailcode_Collection
38
-    */
33
+    /**
34
+     * Adds a command to the collection.
35
+     * 
36
+     * @param Mailcode_Commands_Command $command
37
+     * @return Mailcode_Collection
38
+     */
39 39
     public function addCommand(Mailcode_Commands_Command $command) : Mailcode_Collection
40 40
     {
41 41
         $hash = $command->getHash();
@@ -47,21 +47,21 @@  discard block
 block discarded – undo
47 47
         return $this;
48 48
     }
49 49
     
50
-   /**
51
-    * Whether there are any commands in the collection.
52
-    * 
53
-    * @return bool
54
-    */
50
+    /**
51
+     * Whether there are any commands in the collection.
52
+     * 
53
+     * @return bool
54
+     */
55 55
     public function hasCommands() : bool
56 56
     {
57 57
         return !empty($this->commands);
58 58
     }
59 59
     
60
-   /**
61
-    * Counts the amount of commands in the collection.
62
-    * 
63
-    * @return int
64
-    */
60
+    /**
61
+     * Counts the amount of commands in the collection.
62
+     * 
63
+     * @return int
64
+     */
65 65
     public function countCommands() : int
66 66
     {
67 67
         return count($this->commands);
@@ -81,9 +81,9 @@  discard block
 block discarded – undo
81 81
         $this->errors[] = new Mailcode_Collection_Error_Command($command);
82 82
     }
83 83
     
84
-   /**
85
-    * @return Mailcode_Collection_Error[]
86
-    */
84
+    /**
85
+     * @return Mailcode_Collection_Error[]
86
+     */
87 87
     public function getErrors()
88 88
     {
89 89
         return $this->errors;
@@ -94,14 +94,14 @@  discard block
 block discarded – undo
94 94
         return empty($this->errors);
95 95
     }
96 96
     
97
-   /**
98
-    * Retrieves all commands that were detected.
99
-    * 
100
-    * @return \Mailcode\Mailcode_Commands_Command[]
101
-    */
97
+    /**
98
+     * Retrieves all commands that were detected.
99
+     * 
100
+     * @return \Mailcode\Mailcode_Commands_Command[]
101
+     */
102 102
     public function getCommands()
103 103
     {
104
-       return $this->commands;
104
+        return $this->commands;
105 105
     }
106 106
     
107 107
     public function addCommands(array $commands) : Mailcode_Collection
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
     {
41 41
         $hash = $command->getHash();
42 42
         
43
-        if(!isset($this->commands[$hash])) {
43
+        if (!isset($this->commands[$hash])) {
44 44
             $this->commands[$hash] = $command;
45 45
         }
46 46
         
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
     
107 107
     public function addCommands(array $commands) : Mailcode_Collection
108 108
     {
109
-        foreach($commands as $command)
109
+        foreach ($commands as $command)
110 110
         {
111 111
             $this->addCommand($command);
112 112
         }
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
     {
126 126
         $collection = new Mailcode_Variables_Collection_Regular();
127 127
         
128
-        foreach($this->commands as $command)
128
+        foreach ($this->commands as $command)
129 129
         {
130 130
             $collection->mergeWith($command->getVariables());
131 131
         }
Please login to merge, or discard this patch.
src/Mailcode/Variables.php 2 patches
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -22,12 +22,12 @@
 block discarded – undo
22 22
 {
23 23
     const REGEX_VARIABLE_NAME = '/\$\s*([A-Z0-9]+)\s*\.\s*([A-Z0-9]+)/sx';
24 24
     
25
-   /**
26
-    * Parses the specified string to find all variable names contained within, if any.
27
-    * 
28
-    * @param string $subject
29
-    * @return Mailcode_Variables_Collection_Regular
30
-    */
25
+    /**
26
+     * Parses the specified string to find all variable names contained within, if any.
27
+     * 
28
+     * @param string $subject
29
+     * @return Mailcode_Variables_Collection_Regular
30
+     */
31 31
     public function parseString(string $subject) : Mailcode_Variables_Collection_Regular
32 32
     {
33 33
         $collection = new Mailcode_Variables_Collection_Regular();
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,12 +35,12 @@
 block discarded – undo
35 35
         $matches = array();
36 36
         preg_match_all(self::REGEX_VARIABLE_NAME, $subject, $matches, PREG_PATTERN_ORDER);
37 37
         
38
-        if(!isset($matches[0]) || empty($matches[0]))
38
+        if (!isset($matches[0]) || empty($matches[0]))
39 39
         {
40 40
             return $collection;
41 41
         }
42 42
         
43
-        foreach($matches[0] as $idx => $matchedText)
43
+        foreach ($matches[0] as $idx => $matchedText)
44 44
         {
45 45
             $path = $matches[1][$idx];
46 46
             $name = $matches[2][$idx];
Please login to merge, or discard this patch.