Passed
Push — master ( a80c4b...f51294 )
by Sebastian
02:39
created
src/Mailcode/Variables.php 3 patches
Indentation   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -22,17 +22,17 @@
 block discarded – undo
22 22
 {
23 23
     const REGEX_VARIABLE_NAME = '/\$\s*([A-Z0-9_]+)\s*\.\s*([A-Z0-9_]+)|\$\s*([A-Z0-9_]+)/six';
24 24
     
25
-   /**
26
-    * @var Mailcode_Variables_Collection_Regular
27
-    */
25
+    /**
26
+     * @var Mailcode_Variables_Collection_Regular
27
+     */
28 28
     protected $collection;
29 29
     
30
-   /**
31
-    * Parses the specified string to find all variable names contained within, if any.
32
-    * 
33
-    * @param string $subject
34
-    * @return Mailcode_Variables_Collection_Regular
35
-    */
30
+    /**
31
+     * Parses the specified string to find all variable names contained within, if any.
32
+     * 
33
+     * @param string $subject
34
+     * @return Mailcode_Variables_Collection_Regular
35
+     */
36 36
     public function parseString(string $subject) : Mailcode_Variables_Collection_Regular
37 37
     {
38 38
         $this->collection = new Mailcode_Variables_Collection_Regular();
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -40,14 +40,14 @@  discard block
 block discarded – undo
40 40
         $matches = array();
41 41
         preg_match_all(self::REGEX_VARIABLE_NAME, $subject, $matches, PREG_PATTERN_ORDER);
42 42
         
43
-        if(!isset($matches[0]) || empty($matches[0]))
43
+        if (!isset($matches[0]) || empty($matches[0]))
44 44
         {
45 45
             return $this->collection;
46 46
         }
47 47
         
48
-        foreach($matches[0] as $idx => $matchedText)
48
+        foreach ($matches[0] as $idx => $matchedText)
49 49
         {
50
-            if(!empty($matches[3][$idx]))
50
+            if (!empty($matches[3][$idx]))
51 51
             {
52 52
                 $this->addSingle($matches[3][$idx], $matchedText);
53 53
             }
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
     protected function addSingle(string $name, string $matchedText) : void
64 64
     {
65 65
         // ignore US style numbers like $451
66
-        if(is_numeric($name))
66
+        if (is_numeric($name))
67 67
         {
68 68
             return;
69 69
         }
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
     protected function addPathed(string $path, string $name, string $matchedText) : void
75 75
     {
76 76
         // ignore US style numbers like $45.12
77
-        if(is_numeric($path.'.'.$name))
77
+        if (is_numeric($path.'.'.$name))
78 78
         {
79 79
             return;
80 80
         }
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -50,8 +50,7 @@
 block discarded – undo
50 50
             if(!empty($matches[3][$idx]))
51 51
             {
52 52
                 $this->addSingle($matches[3][$idx], $matchedText);
53
-            }
54
-            else 
53
+            } else 
55 54
             {
56 55
                 $this->addPathed($matches[1][$idx], $matches[2][$idx], $matchedText);
57 56
             }
Please login to merge, or discard this patch.
src/Mailcode.php 2 patches
Indentation   +45 added lines, -45 removed lines patch added patch discarded remove patch
@@ -26,51 +26,51 @@  discard block
 block discarded – undo
26 26
  */
27 27
 class Mailcode
28 28
 {
29
-   /**
30
-    * @var Mailcode_Parser|NULL
31
-    */
29
+    /**
30
+     * @var Mailcode_Parser|NULL
31
+     */
32 32
     protected $parser = null;
33 33
     
34
-   /**
35
-    * @var Mailcode_Commands|NULL
36
-    */
34
+    /**
35
+     * @var Mailcode_Commands|NULL
36
+     */
37 37
     protected $commands = null;
38 38
     
39
-   /**
40
-    * @var Mailcode_Variables|NULL
41
-    */
39
+    /**
40
+     * @var Mailcode_Variables|NULL
41
+     */
42 42
     protected $variables = null;
43 43
     
44
-   /**
45
-    * @var Mailcode_Translator|NULL
46
-    */
44
+    /**
45
+     * @var Mailcode_Translator|NULL
46
+     */
47 47
     protected $translator = null;
48 48
     
49
-   /**
50
-    * Creates a new mailcode instance.
51
-    * @return Mailcode
52
-    */
49
+    /**
50
+     * Creates a new mailcode instance.
51
+     * @return Mailcode
52
+     */
53 53
     public static function create() : Mailcode
54 54
     {
55 55
         return new Mailcode();
56 56
     }
57 57
     
58
-   /**
59
-    * Parses the string to detect all commands contained within.
60
-    * 
61
-    * @param string $string
62
-    * @return Mailcode_Collection
63
-    */
58
+    /**
59
+     * Parses the string to detect all commands contained within.
60
+     * 
61
+     * @param string $string
62
+     * @return Mailcode_Collection
63
+     */
64 64
     public function parseString(string $string) : Mailcode_Collection
65 65
     {
66 66
         return $this->getParser()->parseString($string);
67 67
     }
68 68
     
69
-   /**
70
-    * Retrieves the string parser instance used to detect commands.
71
-    * 
72
-    * @return Mailcode_Parser
73
-    */
69
+    /**
70
+     * Retrieves the string parser instance used to detect commands.
71
+     * 
72
+     * @return Mailcode_Parser
73
+     */
74 74
     public function getParser() : Mailcode_Parser
75 75
     {
76 76
         if(!isset($this->parser)) 
@@ -81,12 +81,12 @@  discard block
 block discarded – undo
81 81
         return $this->parser;
82 82
     }
83 83
     
84
-   /**
85
-    * Retrieves the commands collection, which is used to
86
-    * access information on the available commands.
87
-    * 
88
-    * @return Mailcode_Commands
89
-    */
84
+    /**
85
+     * Retrieves the commands collection, which is used to
86
+     * access information on the available commands.
87
+     * 
88
+     * @return Mailcode_Commands
89
+     */
90 90
     public function getCommands() : Mailcode_Commands
91 91
     {
92 92
         if(!isset($this->commands)) 
@@ -102,12 +102,12 @@  discard block
 block discarded – undo
102 102
         return $this->getParser()->createSafeguard($subject);
103 103
     }
104 104
     
105
-   /**
106
-    * Attempts to find all variables in the target string.
107
-    * 
108
-    * @param string $subject
109
-    * @return Mailcode_Variables_Collection_Regular
110
-    */
105
+    /**
106
+     * Attempts to find all variables in the target string.
107
+     * 
108
+     * @param string $subject
109
+     * @return Mailcode_Variables_Collection_Regular
110
+     */
111 111
     public function findVariables(string $subject) : Mailcode_Variables_Collection_Regular
112 112
     {
113 113
         return $this->createVariables()->parseString($subject);
@@ -123,12 +123,12 @@  discard block
 block discarded – undo
123 123
         return $this->variables;
124 124
     }
125 125
     
126
-   /**
127
-    * Creates the translator, which can be used to convert commands
128
-    * to another supported syntax.
129
-    * 
130
-    * @return Mailcode_Translator
131
-    */
126
+    /**
127
+     * Creates the translator, which can be used to convert commands
128
+     * to another supported syntax.
129
+     * 
130
+     * @return Mailcode_Translator
131
+     */
132 132
     public function createTranslator() : Mailcode_Translator
133 133
     {
134 134
         if(!isset($this->translator))
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
     */
74 74
     public function getParser() : Mailcode_Parser
75 75
     {
76
-        if(!isset($this->parser)) 
76
+        if (!isset($this->parser)) 
77 77
         {
78 78
             $this->parser = new Mailcode_Parser($this);
79 79
         }
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
     */
90 90
     public function getCommands() : Mailcode_Commands
91 91
     {
92
-        if(!isset($this->commands)) 
92
+        if (!isset($this->commands)) 
93 93
         {
94 94
             $this->commands = new Mailcode_Commands();
95 95
         }
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
     
116 116
     public function createVariables() : Mailcode_Variables
117 117
     {
118
-        if(!isset($this->variables))
118
+        if (!isset($this->variables))
119 119
         {
120 120
             $this->variables = new Mailcode_Variables();
121 121
         }
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
     */
132 132
     public function createTranslator() : Mailcode_Translator
133 133
     {
134
-        if(!isset($this->translator))
134
+        if (!isset($this->translator))
135 135
         {
136 136
             $this->translator = new Mailcode_Translator(); 
137 137
         }
Please login to merge, or discard this patch.
src/Mailcode/Commands/Command/Comment.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
         $this->paramsString = trim($this->paramsString);
26 26
         
27 27
         // automatically quote the parameters, since comments don't require any.
28
-        if(substr($this->paramsString, 0, 1) != '"')
28
+        if (substr($this->paramsString, 0, 1) != '"')
29 29
         {
30 30
             $this->paramsString = '"'.$this->paramsString.'"';
31 31
         }
Please login to merge, or discard this patch.
src/Mailcode/Collection.php 2 patches
Indentation   +51 added lines, -51 removed lines patch added patch discarded remove patch
@@ -24,9 +24,9 @@  discard block
 block discarded – undo
24 24
 {
25 25
     const ERROR_CANNOT_RETRIEVE_FIRST_ERROR = 52301;
26 26
     
27
-   /**
28
-    * @var Mailcode_Commands_Command[]
29
-    */
27
+    /**
28
+     * @var Mailcode_Commands_Command[]
29
+     */
30 30
     protected $commands = array();
31 31
     
32 32
     /**
@@ -34,17 +34,17 @@  discard block
 block discarded – undo
34 34
      */
35 35
     protected $errors = array();
36 36
     
37
-   /**
38
-    * @var OperationResult|NULL
39
-    */
37
+    /**
38
+     * @var OperationResult|NULL
39
+     */
40 40
     protected $validationResult;
41 41
     
42
-   /**
43
-    * Adds a command to the collection.
44
-    * 
45
-    * @param Mailcode_Commands_Command $command
46
-    * @return Mailcode_Collection
47
-    */
42
+    /**
43
+     * Adds a command to the collection.
44
+     * 
45
+     * @param Mailcode_Commands_Command $command
46
+     * @return Mailcode_Collection
47
+     */
48 48
     public function addCommand(Mailcode_Commands_Command $command) : Mailcode_Collection
49 49
     {
50 50
         $this->commands[] = $command;
@@ -56,21 +56,21 @@  discard block
 block discarded – undo
56 56
         return $this;
57 57
     }
58 58
     
59
-   /**
60
-    * Whether there are any commands in the collection.
61
-    * 
62
-    * @return bool
63
-    */
59
+    /**
60
+     * Whether there are any commands in the collection.
61
+     * 
62
+     * @return bool
63
+     */
64 64
     public function hasCommands() : bool
65 65
     {
66 66
         return !empty($this->commands);
67 67
     }
68 68
     
69
-   /**
70
-    * Counts the amount of commands in the collection.
71
-    * 
72
-    * @return int
73
-    */
69
+    /**
70
+     * Counts the amount of commands in the collection.
71
+     * 
72
+     * @return int
73
+     */
74 74
     public function countCommands() : int
75 75
     {
76 76
         return count($this->commands);
@@ -90,9 +90,9 @@  discard block
 block discarded – undo
90 90
         $this->errors[] = new Mailcode_Collection_Error_Command($command);
91 91
     }
92 92
     
93
-   /**
94
-    * @return Mailcode_Collection_Error[]
95
-    */
93
+    /**
94
+     * @return Mailcode_Collection_Error[]
95
+     */
96 96
     public function getErrors()
97 97
     {
98 98
         $result = $this->getValidationResult();
@@ -134,25 +134,25 @@  discard block
 block discarded – undo
134 134
         return empty($errors);
135 135
     }
136 136
     
137
-   /**
138
-    * Retrieves all commands that were detected, in the exact order
139
-    * they were found.
140
-    * 
141
-    * @return \Mailcode\Mailcode_Commands_Command[]
142
-    */
137
+    /**
138
+     * Retrieves all commands that were detected, in the exact order
139
+     * they were found.
140
+     * 
141
+     * @return \Mailcode\Mailcode_Commands_Command[]
142
+     */
143 143
     public function getCommands()
144 144
     {
145
-       return $this->commands;
145
+        return $this->commands;
146 146
     }
147 147
     
148
-   /**
149
-    * Retrieves all unique commands by their matched
150
-    * string hash: this ensures only commands that were
151
-    * written the exact same way (including spacing)
152
-    * are returned.
153
-    * 
154
-    * @return \Mailcode\Mailcode_Commands_Command[]
155
-    */
148
+    /**
149
+     * Retrieves all unique commands by their matched
150
+     * string hash: this ensures only commands that were
151
+     * written the exact same way (including spacing)
152
+     * are returned.
153
+     * 
154
+     * @return \Mailcode\Mailcode_Commands_Command[]
155
+     */
156 156
     public function getGroupedByHash()
157 157
     {
158 158
         $hashes = array();
@@ -170,12 +170,12 @@  discard block
 block discarded – undo
170 170
         return array_values($hashes);
171 171
     }
172 172
 
173
-   /**
174
-    * Adds several commands at once.
175
-    * 
176
-    * @param Mailcode_Commands_Command[] $commands
177
-    * @return Mailcode_Collection
178
-    */
173
+    /**
174
+     * Adds several commands at once.
175
+     * 
176
+     * @param Mailcode_Commands_Command[] $commands
177
+     * @return Mailcode_Collection
178
+     */
179 179
     public function addCommands(array $commands) : Mailcode_Collection
180 180
     {
181 181
         foreach($commands as $command)
@@ -234,11 +234,11 @@  discard block
 block discarded – undo
234 234
         return false;
235 235
     }
236 236
     
237
-   /**
238
-    * Retrieves only show variable commands in the collection, if any.
239
-    * 
240
-    * @return \Mailcode\Mailcode_Commands_Command_ShowVariable[]
241
-    */
237
+    /**
238
+     * Retrieves only show variable commands in the collection, if any.
239
+     * 
240
+     * @return \Mailcode\Mailcode_Commands_Command_ShowVariable[]
241
+     */
242 242
     public function getShowVariableCommands()
243 243
     {
244 244
         $result = array();
Please login to merge, or discard this patch.
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
         
100 100
         $errors = $this->errors;
101 101
         
102
-        if(!$result->isValid())
102
+        if (!$result->isValid())
103 103
         {
104 104
             $errors[] = new Mailcode_Collection_Error_Message(
105 105
                 '',
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
     {
116 116
         $errors = $this->getErrors();
117 117
         
118
-        if(!empty($errors))
118
+        if (!empty($errors))
119 119
         {
120 120
             return array_shift($errors);
121 121
         }
@@ -157,11 +157,11 @@  discard block
 block discarded – undo
157 157
     {
158 158
         $hashes = array();
159 159
         
160
-        foreach($this->commands as $command)
160
+        foreach ($this->commands as $command)
161 161
         {
162 162
             $hash = $command->getHash();
163 163
             
164
-            if(!isset($hashes[$hash]))
164
+            if (!isset($hashes[$hash]))
165 165
             {
166 166
                 $hashes[$hash] = $command;
167 167
             }
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
     */
179 179
     public function addCommands(array $commands) : Mailcode_Collection
180 180
     {
181
-        foreach($commands as $command)
181
+        foreach ($commands as $command)
182 182
         {
183 183
             $this->addCommand($command);
184 184
         }
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
     {
198 198
         $collection = new Mailcode_Variables_Collection_Regular();
199 199
         
200
-        foreach($this->commands as $command)
200
+        foreach ($this->commands as $command)
201 201
         {
202 202
             $collection->mergeWith($command->getVariables());
203 203
         }
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
     
208 208
     public function getValidationResult() : OperationResult
209 209
     {
210
-        if($this->validationResult instanceof OperationResult)
210
+        if ($this->validationResult instanceof OperationResult)
211 211
         {
212 212
             return $this->validationResult;
213 213
         }
@@ -223,9 +223,9 @@  discard block
 block discarded – undo
223 223
     {
224 224
         $errors = $this->getErrors();
225 225
         
226
-        foreach($errors as $error)
226
+        foreach ($errors as $error)
227 227
         {
228
-            if($error->getCode() === $code)
228
+            if ($error->getCode() === $code)
229 229
             {
230 230
                 return true;
231 231
             }
@@ -243,9 +243,9 @@  discard block
 block discarded – undo
243 243
     {
244 244
         $result = array();
245 245
         
246
-        foreach($this->commands as $command)
246
+        foreach ($this->commands as $command)
247 247
         {
248
-            if($command instanceof Mailcode_Commands_Command_ShowVariable)
248
+            if ($command instanceof Mailcode_Commands_Command_ShowVariable)
249 249
             {
250 250
                 $result[] = $command;
251 251
             }
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
     {
259 259
         $commands = $this->getCommands();
260 260
         
261
-        if(!empty($commands))
261
+        if (!empty($commands))
262 262
         {
263 263
             return array_shift($commands);
264 264
         }
Please login to merge, or discard this patch.
src/Mailcode/Translator/Syntax/ApacheVelocity.php 2 patches
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -20,13 +20,13 @@
 block discarded – undo
20 20
  */
21 21
 abstract class Mailcode_Translator_Syntax_ApacheVelocity extends Mailcode_Translator_Command
22 22
 {
23
-   /**
24
-    * Filters the string for use in an Apache Velocity (Java)
25
-    * regex string: escapes all special characters.
26
-    * 
27
-    * @param string $string
28
-    * @return string
29
-    */
23
+    /**
24
+     * Filters the string for use in an Apache Velocity (Java)
25
+     * regex string: escapes all special characters.
26
+     * 
27
+     * @param string $string
28
+     * @return string
29
+     */
30 30
     protected function filterRegexString(string $string) : string
31 31
     {
32 32
         $escape = array(
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
             ')'
49 49
         );
50 50
         
51
-        foreach($escape as $char)
51
+        foreach ($escape as $char)
52 52
         {
53 53
             $string = str_replace($char, '\\'.$char, $string);
54 54
         }
Please login to merge, or discard this patch.
src/Mailcode/Translator/Syntax.php 2 patches
Indentation   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -23,9 +23,9 @@  discard block
 block discarded – undo
23 23
 {
24 24
     const ERROR_UNKNOWN_COMMAND_TYPE = 50401;
25 25
     
26
-   /**
27
-    * @var string
28
-    */
26
+    /**
27
+     * @var string
28
+     */
29 29
     protected $typeID;
30 30
     
31 31
     public function __construct(string $typeID)
@@ -33,22 +33,22 @@  discard block
 block discarded – undo
33 33
         $this->typeID = $typeID;
34 34
     }
35 35
     
36
-   /**
37
-    * Retrieves the syntax' type ID, e.g. "ApacheVelocity".
38
-    * @return string
39
-    */
36
+    /**
37
+     * Retrieves the syntax' type ID, e.g. "ApacheVelocity".
38
+     * @return string
39
+     */
40 40
     public function getTypeID() : string
41 41
     {
42 42
         return $this->typeID;
43 43
     }
44 44
     
45
-   /**
46
-    * Translates a single command to the target syntax.
47
-    * 
48
-    * @param Mailcode_Commands_Command $command
49
-    * @throws Mailcode_Translator_Exception
50
-    * @return string
51
-    */
45
+    /**
46
+     * Translates a single command to the target syntax.
47
+     * 
48
+     * @param Mailcode_Commands_Command $command
49
+     * @throws Mailcode_Translator_Exception
50
+     * @return string
51
+     */
52 52
     public function translateCommand(Mailcode_Commands_Command $command) : string
53 53
     {
54 54
         $translator = $this->createTranslator($command);
@@ -81,13 +81,13 @@  discard block
 block discarded – undo
81 81
         return $translator;
82 82
     }
83 83
     
84
-   /**
85
-    * Translates all safeguarded commands in the subject string to the 
86
-    * target syntax in one go.
87
-    * 
88
-    * @param Mailcode_Parser_Safeguard $safeguard
89
-    * @return string
90
-    */
84
+    /**
85
+     * Translates all safeguarded commands in the subject string to the 
86
+     * target syntax in one go.
87
+     * 
88
+     * @param Mailcode_Parser_Safeguard $safeguard
89
+     * @return string
90
+     */
91 91
     public function translateSafeguard(Mailcode_Parser_Safeguard $safeguard) : string
92 92
     {
93 93
         $subject = $safeguard->makeSafe();
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
             $command->getID()
65 65
         );
66 66
         
67
-        if(!class_exists($class))
67
+        if (!class_exists($class))
68 68
         {
69 69
             throw new Mailcode_Translator_Exception(
70 70
                 sprintf('Unknown command %s in translator', $command->getID()),
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
     {
93 93
         $subject = $safeguard->makeSafe();
94 94
         
95
-        if(!$safeguard->hasPlaceholders())
95
+        if (!$safeguard->hasPlaceholders())
96 96
         {
97 97
             return $subject;
98 98
         }
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
         
102 102
         $replaces = array();
103 103
         
104
-        foreach($placeholders as $placeholder)
104
+        foreach ($placeholders as $placeholder)
105 105
         {
106 106
             $replaces[$placeholder->getReplacementText()] = $this->translateCommand($placeholder->getCommand());
107 107
         }
Please login to merge, or discard this patch.
src/Mailcode/Commands/Command/SetVariable.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -25,9 +25,9 @@
 block discarded – undo
25 25
     
26 26
     const VALIDATION_NOT_ASSIGNMENT_STATEMENT = 48501;
27 27
     
28
-   /**
29
-    * @var Mailcode_Parser_Statement_Tokenizer_Type_Value
30
-    */
28
+    /**
29
+     * @var Mailcode_Parser_Statement_Tokenizer_Type_Value
30
+     */
31 31
     protected $value;
32 32
     
33 33
     public function getName() : string
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
     {
69 69
         $variable = $this->params->getInfo()->getVariableByIndex(0);
70 70
         
71
-        if($variable)
71
+        if ($variable)
72 72
         {
73 73
             return $variable->getVariable();
74 74
         }
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
     
97 97
     protected function validateSyntax_assignment() : void
98 98
     {
99
-        if($this->params->getInfo()->isVariableAssignment())
99
+        if ($this->params->getInfo()->isVariableAssignment())
100 100
         {
101 101
             return;
102 102
         }
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
         
114 114
         $value = $info->getTokenByIndex(2);
115 115
         
116
-        if($value instanceof Mailcode_Parser_Statement_Tokenizer_Type_Value)
116
+        if ($value instanceof Mailcode_Parser_Statement_Tokenizer_Type_Value)
117 117
         {
118 118
             $this->value = $value;
119 119
             return;
Please login to merge, or discard this patch.
src/Mailcode/Commands/Command/ShowVariable.php 2 patches
Indentation   +30 added lines, -30 removed lines patch added patch discarded remove patch
@@ -26,9 +26,9 @@  discard block
 block discarded – undo
26 26
     
27 27
     const VALIDATION_VARIABLE_COUNT_MISMATCH = 48402;
28 28
     
29
-   /**
30
-    * @var Mailcode_Variables_Variable|NULL
31
-    */
29
+    /**
30
+     * @var Mailcode_Variables_Variable|NULL
31
+     */
32 32
     protected $variable;
33 33
     
34 34
     public function getName() : string
@@ -56,15 +56,15 @@  discard block
 block discarded – undo
56 56
         return true;
57 57
     }
58 58
     
59
-   /**
60
-    * Retrieves the variable to show.
61
-    * 
62
-    * NOTE: Only available once the command has been
63
-    * validated. Always use isValid() first.
64
-    * 
65
-    * @throws Mailcode_Exception
66
-    * @return Mailcode_Variables_Variable
67
-    */
59
+    /**
60
+     * Retrieves the variable to show.
61
+     * 
62
+     * NOTE: Only available once the command has been
63
+     * validated. Always use isValid() first.
64
+     * 
65
+     * @throws Mailcode_Exception
66
+     * @return Mailcode_Variables_Variable
67
+     */
68 68
     public function getVariable() : Mailcode_Variables_Variable
69 69
     {
70 70
         $this->validate();
@@ -81,15 +81,15 @@  discard block
 block discarded – undo
81 81
         );
82 82
     }
83 83
     
84
-   /**
85
-    * Retrieves the full name of the variable to show.
86
-    * 
87
-    * NOTE: Only available once the command has been
88
-    * validated. Always use isValid() first.
89
-    * 
90
-    * @throws Mailcode_Exception
91
-    * @return string
92
-    */
84
+    /**
85
+     * Retrieves the full name of the variable to show.
86
+     * 
87
+     * NOTE: Only available once the command has been
88
+     * validated. Always use isValid() first.
89
+     * 
90
+     * @throws Mailcode_Exception
91
+     * @return string
92
+     */
93 93
     public function getVariableName() : string
94 94
     {
95 95
         return $this->getVariable()->getFullName();
@@ -97,19 +97,19 @@  discard block
 block discarded – undo
97 97
 
98 98
     protected function validateSyntax_require_variable() : void
99 99
     {
100
-         $vars = $this->getVariables()->getGroupedByName();
101
-         $amount = count($vars);
100
+            $vars = $this->getVariables()->getGroupedByName();
101
+            $amount = count($vars);
102 102
          
103
-         if($amount === 1)
104
-         {
105
-             $this->variable = array_pop($vars);
106
-             return;
107
-         }
103
+            if($amount === 1)
104
+            {
105
+                $this->variable = array_pop($vars);
106
+                return;
107
+            }
108 108
          
109
-         $this->validationResult->makeError(
109
+            $this->validationResult->makeError(
110 110
             t('Command has %1$s variables, %2$s expected.', $amount, 1),
111 111
             self::VALIDATION_VARIABLE_COUNT_MISMATCH
112
-         );
112
+            );
113 113
     }
114 114
     
115 115
     protected function getValidations() : array
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
     {
70 70
         $this->validate();
71 71
         
72
-        if($this->variable instanceof Mailcode_Variables_Variable)
72
+        if ($this->variable instanceof Mailcode_Variables_Variable)
73 73
         {
74 74
             return $this->variable;
75 75
         }
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
          $vars = $this->getVariables()->getGroupedByName();
101 101
          $amount = count($vars);
102 102
          
103
-         if($amount === 1)
103
+         if ($amount === 1)
104 104
          {
105 105
              $this->variable = array_pop($vars);
106 106
              return;
Please login to merge, or discard this patch.
src/Mailcode/Commands/Command.php 2 patches
Indentation   +70 added lines, -70 removed lines patch added patch discarded remove patch
@@ -31,53 +31,53 @@  discard block
 block discarded – undo
31 31
     const VALIDATION_UNKNOWN_COMMAND_NAME = 48304;
32 32
     const VALIDATION_INVALID_PARAMS_STATEMENT = 48305;
33 33
 
34
-   /**
35
-    * @var string
36
-    */
34
+    /**
35
+     * @var string
36
+     */
37 37
     protected $type = '';
38 38
 
39
-   /**
40
-    * @var string
41
-    */
39
+    /**
40
+     * @var string
41
+     */
42 42
     protected $paramsString = '';
43 43
     
44
-   /**
45
-    * @var string
46
-    */
44
+    /**
45
+     * @var string
46
+     */
47 47
     protected $matchedText = '';
48 48
 
49
-   /**
50
-    * @var string
51
-    */
49
+    /**
50
+     * @var string
51
+     */
52 52
     protected $hash = '';
53 53
     
54
-   /**
55
-    * @var \AppUtils\OperationResult
56
-    */
54
+    /**
55
+     * @var \AppUtils\OperationResult
56
+     */
57 57
     protected $validationResult = null;
58 58
     
59
-   /**
60
-    * @var \Mailcode\Mailcode
61
-    */
59
+    /**
60
+     * @var \Mailcode\Mailcode
61
+     */
62 62
     protected $mailcode;
63 63
     
64
-   /**
65
-    * @var \Mailcode\Mailcode_Parser_Statement
66
-    */
64
+    /**
65
+     * @var \Mailcode\Mailcode_Parser_Statement
66
+     */
67 67
     protected $params;
68 68
 
69
-   /**
70
-    * @var string[] 
71
-    */
69
+    /**
70
+     * @var string[] 
71
+     */
72 72
     protected $validations = array(
73 73
         'params',
74 74
         'type_supported',
75 75
         'type_unsupported'
76 76
     );
77 77
     
78
-   /**
79
-    * @var string
80
-    */
78
+    /**
79
+     * @var string
80
+     */
81 81
     protected $comment = '';
82 82
     
83 83
     public function __construct(string $type='', string $paramsString='', string $matchedText='')
@@ -95,9 +95,9 @@  discard block
 block discarded – undo
95 95
         
96 96
     }
97 97
     
98
-   /**
99
-    * @return string The ID of the command = the name of the command class file.
100
-    */
98
+    /**
99
+     * @return string The ID of the command = the name of the command class file.
100
+     */
101 101
     public function getID() : string
102 102
     {
103 103
         // account for commands with types: If_Variable should still return If.
@@ -106,14 +106,14 @@  discard block
 block discarded – undo
106 106
         return array_shift($tokens);
107 107
     }
108 108
     
109
-   /**
110
-    * Sets an optional comment that is not used anywhere, but
111
-    * can be used by the application to track why a command is
112
-    * used somewhere. 
113
-    * 
114
-    * @param string $comment
115
-    * @return Mailcode_Commands_Command
116
-    */
109
+    /**
110
+     * Sets an optional comment that is not used anywhere, but
111
+     * can be used by the application to track why a command is
112
+     * used somewhere. 
113
+     * 
114
+     * @param string $comment
115
+     * @return Mailcode_Commands_Command
116
+     */
117 117
     public function setComment(string $comment) : Mailcode_Commands_Command
118 118
     {
119 119
         $this->comment = $comment;
@@ -121,34 +121,34 @@  discard block
 block discarded – undo
121 121
         return $this;
122 122
     }
123 123
     
124
-   /**
125
-    * Retrieves the previously set comment, if any.
126
-    * 
127
-    * @return string
128
-    */
124
+    /**
125
+     * Retrieves the previously set comment, if any.
126
+     * 
127
+     * @return string
128
+     */
129 129
     public function getComment() : string
130 130
     {
131 131
         return $this->comment;
132 132
     }
133 133
     
134
-   /**
135
-    * Checks whether this is a dummy command, which is only
136
-    * used to access information on the command type. It cannot
137
-    * be used as an actual live command.
138
-    * 
139
-    * @return bool
140
-    */
134
+    /**
135
+     * Checks whether this is a dummy command, which is only
136
+     * used to access information on the command type. It cannot
137
+     * be used as an actual live command.
138
+     * 
139
+     * @return bool
140
+     */
141 141
     public function isDummy() : bool
142 142
     {
143 143
         return $this->type === '__dummy';
144 144
     }
145 145
     
146
-   /**
147
-    * Retrieves a hash of the actual matched command string,
148
-    * which is used in collections to detect duplicate commands.
149
-    * 
150
-    * @return string
151
-    */
146
+    /**
147
+     * Retrieves a hash of the actual matched command string,
148
+     * which is used in collections to detect duplicate commands.
149
+     * 
150
+     * @return string
151
+     */
152 152
     public function getHash() : string
153 153
     {
154 154
         $this->requireNonDummy();
@@ -240,9 +240,9 @@  discard block
 block discarded – undo
240 240
         }
241 241
     }
242 242
     
243
-   /**
244
-    * @return string[]
245
-    */
243
+    /**
244
+     * @return string[]
245
+     */
246 246
     abstract protected function getValidations() : array;
247 247
     
248 248
     protected function validateSyntax_params() : void
@@ -429,22 +429,22 @@  discard block
 block discarded – undo
429 429
         return implode('', $parts);
430 430
     }
431 431
     
432
-   /**
433
-    * Retrieves the names of all the command's supported types: the part
434
-    * between the command name and the colon. Example: {command type: params}.
435
-    * 
436
-    * @return string[]
437
-    */
432
+    /**
433
+     * Retrieves the names of all the command's supported types: the part
434
+     * between the command name and the colon. Example: {command type: params}.
435
+     * 
436
+     * @return string[]
437
+     */
438 438
     public function getSupportedTypes() : array
439 439
     {
440 440
         return array();
441 441
     }
442 442
     
443
-   /**
444
-    * Retrieves all variable names used in the command.
445
-    * 
446
-    * @return Mailcode_Variables_Collection_Regular
447
-    */
443
+    /**
444
+     * Retrieves all variable names used in the command.
445
+     * 
446
+     * @return Mailcode_Variables_Collection_Regular
447
+     */
448 448
     public function getVariables() : Mailcode_Variables_Collection_Regular
449 449
     {
450 450
         return Mailcode::create()->findVariables($this->paramsString);
Please login to merge, or discard this patch.
Spacing   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
     */
81 81
     protected $comment = '';
82 82
     
83
-    public function __construct(string $type='', string $paramsString='', string $matchedText='')
83
+    public function __construct(string $type = '', string $paramsString = '', string $matchedText = '')
84 84
     {
85 85
         $this->type = $type;
86 86
         $this->paramsString = html_entity_decode($paramsString);
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
     {
154 154
         $this->requireNonDummy();
155 155
         
156
-        if($this->hash === '') {
156
+        if ($this->hash === '') {
157 157
             $this->hash = md5($this->matchedText);
158 158
         }
159 159
         
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
     
163 163
     protected function requireNonDummy() : void
164 164
     {
165
-        if(!$this->isDummy())
165
+        if (!$this->isDummy())
166 166
         {
167 167
             return;
168 168
         }
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
     {
184 184
         $this->requireNonDummy();
185 185
         
186
-        if(isset($this->validationResult)) 
186
+        if (isset($this->validationResult)) 
187 187
         {
188 188
             return $this->validationResult;
189 189
         }
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
     
198 198
     public function getValidationResult() :  \AppUtils\OperationResult
199 199
     {
200
-        if(isset($this->validationResult)) 
200
+        if (isset($this->validationResult)) 
201 201
         {
202 202
             return $this->validationResult;
203 203
         }
@@ -213,11 +213,11 @@  discard block
 block discarded – undo
213 213
     {
214 214
         $validations = array_merge($this->validations, $this->getValidations());
215 215
         
216
-        foreach($validations as $validation)
216
+        foreach ($validations as $validation)
217 217
         {
218 218
             $method = 'validateSyntax_'.$validation;
219 219
             
220
-            if(!method_exists($this, $method))
220
+            if (!method_exists($this, $method))
221 221
             {
222 222
                 throw new Mailcode_Exception(
223 223
                     'Missing validation method',
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
             $this->$method();
234 234
             
235 235
             // break off at the first validation issue
236
-            if(!$this->validationResult->isValid())
236
+            if (!$this->validationResult->isValid())
237 237
             {
238 238
                 return;
239 239
             }
@@ -247,12 +247,12 @@  discard block
 block discarded – undo
247 247
     
248 248
     protected function validateSyntax_params() : void
249 249
     {
250
-        if(!$this->requiresParameters())
250
+        if (!$this->requiresParameters())
251 251
         {
252 252
             return;
253 253
         }
254 254
         
255
-        if(empty($this->paramsString))
255
+        if (empty($this->paramsString))
256 256
         {
257 257
             $this->validationResult->makeError(
258 258
                 t('Parameters have to be specified.'),
@@ -263,7 +263,7 @@  discard block
 block discarded – undo
263 263
         
264 264
         $this->params = $this->mailcode->getParser()->createStatement($this->paramsString);
265 265
         
266
-        if(!$this->params->isValid())
266
+        if (!$this->params->isValid())
267 267
         {
268 268
             $error = $this->params->getValidationResult();
269 269
             
@@ -276,14 +276,14 @@  discard block
 block discarded – undo
276 276
     
277 277
     protected function validateSyntax_type_supported() : void
278 278
     {
279
-        if(!$this->supportsType() || empty($this->type))
279
+        if (!$this->supportsType() || empty($this->type))
280 280
         {
281 281
             return;
282 282
         }
283 283
         
284 284
         $types = $this->getSupportedTypes();
285 285
 
286
-        if(!in_array($this->type, $types))
286
+        if (!in_array($this->type, $types))
287 287
         {
288 288
             $this->validationResult->makeError(
289 289
                 t('The command addon %1$s is not supported.', $this->type).' '.
@@ -297,7 +297,7 @@  discard block
 block discarded – undo
297 297
     
298 298
     protected function validateSyntax_type_unsupported() : void
299 299
     {
300
-        if($this->supportsType() || empty($this->type))
300
+        if ($this->supportsType() || empty($this->type))
301 301
         {
302 302
             return;
303 303
         }
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
     
316 316
     public function getType() : string
317 317
     {
318
-        if($this->supportsType())
318
+        if ($this->supportsType())
319 319
         {
320 320
             return $this->type;
321 321
         }
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
     
336 336
     public function getHighlighted() : string
337 337
     {
338
-        if(!$this->isValid())
338
+        if (!$this->isValid())
339 339
         {
340 340
             return '';
341 341
         }
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
     
347 347
     public function getParamsString() : string
348 348
     {
349
-        if($this->requiresParameters())
349
+        if ($this->requiresParameters())
350 350
         {
351 351
             return $this->paramsString;
352 352
         }
@@ -373,22 +373,22 @@  discard block
 block discarded – undo
373 373
     
374 374
     public final function getCommandType() : string
375 375
     {
376
-        if($this instanceof Mailcode_Commands_Command_Type_Closing)
376
+        if ($this instanceof Mailcode_Commands_Command_Type_Closing)
377 377
         {
378 378
             return 'Closing';
379 379
         }
380 380
         
381
-        if($this instanceof Mailcode_Commands_Command_Type_Opening)
381
+        if ($this instanceof Mailcode_Commands_Command_Type_Opening)
382 382
         {
383 383
             return 'Opening';
384 384
         }
385 385
         
386
-        if($this instanceof Mailcode_Commands_Command_Type_Sibling)
386
+        if ($this instanceof Mailcode_Commands_Command_Type_Sibling)
387 387
         {
388 388
             return 'Sibling';
389 389
         }
390 390
         
391
-        if($this instanceof Mailcode_Commands_Command_Type_Standalone)
391
+        if ($this instanceof Mailcode_Commands_Command_Type_Standalone)
392 392
         {
393 393
             return 'Standalone';
394 394
         }
@@ -405,7 +405,7 @@  discard block
 block discarded – undo
405 405
     
406 406
     public function getNormalized() : string
407 407
     {
408
-        if(!$this->isValid())
408
+        if (!$this->isValid())
409 409
         {
410 410
             return '';
411 411
         }
@@ -413,12 +413,12 @@  discard block
 block discarded – undo
413 413
         $parts = array();
414 414
         $parts[] = '{'.$this->getName();
415 415
         
416
-        if($this->supportsType() && $this->hasType())
416
+        if ($this->supportsType() && $this->hasType())
417 417
         {
418 418
             $parts[] = ' '.$this->getType();
419 419
         }
420 420
         
421
-        if($this->requiresParameters() && isset($this->params))
421
+        if ($this->requiresParameters() && isset($this->params))
422 422
         {
423 423
             $parts[] = ': ';
424 424
             $parts[] = $this->params->getNormalized();
Please login to merge, or discard this patch.