Inspection of "Added changes." - Mistralys/mailcode - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 38d7a4...ed3505 )

by Sebastian

created 2024-02-26 12:52 UTC

Status

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -48,13 +48,13 @@
 block discarded – undo
     <body>
     	<p>
     		<?php 
-    		    pts('This showcases the command\'s syntax highlighting.');
-    		    pts(
-    		        'It is based on the %1$s color scheme%2$s:',
-    		        '<a href="https://ethanschoonover.com/solarized/">"Solarized"',
-    		        '</a>'
-		        );
-    		?>
+                pts('This showcases the command\'s syntax highlighting.');
+                pts(
+                    'It is based on the %1$s color scheme%2$s:',
+                    '<a href="https://ethanschoonover.com/solarized/">"Solarized"',
+                    '</a>'
+                );
+            ?>
 		</p>
 		<br>
     	<div class="commands">

Please login to merge, or discard this patch.

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@  discard block
 block discarded – undo
     $autoload = realpath($root.'/../vendor/autoload.php');
     
     // we need the autoloader to be present
-    if($autoload === false) 
+    if ($autoload === false) 
     {
         die('<b>ERROR:</b> Autoloader not present. Run composer update first.');
     }
@@ -65,19 +65,19 @@  discard block
 block discarded – undo
                     Mailcode_Factory::misc()->comment('Some comments here'),
                     Mailcode_Factory::show()->snippet('snippet_name'),
                     Mailcode_Factory::show()->date('DATE.VARIABLE'),
-                    Mailcode_Factory::if()->if('1 + 1 == 2'),
-                    Mailcode_Factory::if()->contains('CUSTOMER.NAME', array('John')),
-                    Mailcode_Factory::if()->varEquals('NUMBER', '124'),
+                    Mailcode_Factory::if ()->if('1 + 1 == 2'),
+                    Mailcode_Factory::if ()->contains('CUSTOMER.NAME', array('John')),
+                    Mailcode_Factory::if ()->varEquals('NUMBER', '124'),
                 );
                 
-                $and = Mailcode_Factory::elseIf()->varEqualsString('STRINGVAR', 'John');
+                $and = Mailcode_Factory::elseIf ()->varEqualsString('STRINGVAR', 'John');
                 $and->getLogicKeywords()->appendOR('$STRINGVAR == "Steve"', "variable");
                 
                 $commands[] = $and;
                 
                 $commands[] = Mailcode_Factory::misc()->end();
                 
-                foreach($commands as $command)
+                foreach ($commands as $command)
                 {
                     ?>
                     	<p>

Please login to merge, or discard this patch.

Braces +6 added lines, -2 removed lines patch added patch discarded remove patch

@@ -65,12 +65,16 @@
 block discarded – undo
                     Mailcode_Factory::misc()->comment('Some comments here'),
                     Mailcode_Factory::show()->snippet('snippet_name'),
                     Mailcode_Factory::show()->date('DATE.VARIABLE'),
-                    Mailcode_Factory::if()->if('1 + 1 == 2'),
+                    Mailcode_Factory::if() {
+                        ->if('1 + 1 == 2'),
                     Mailcode_Factory::if()->contains('CUSTOMER.NAME', array('John')),
                     Mailcode_Factory::if()->varEquals('NUMBER', '124'),
                 );
+                    }
                 
-                $and = Mailcode_Factory::elseIf()->varEqualsString('STRINGVAR', 'John');
+                $and = Mailcode_Factory::elseIf() {
+                    ->varEqualsString('STRINGVAR', 'John');
+                }
                 $and->getLogicKeywords()->appendOR('$STRINGVAR == "Steve"', "variable");
                 
                 $commands[] = $and;

Please login to merge, or discard this patch.

src/Mailcode/Parser/Statement/Validator/TokenType.php 2 patches

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -72,12 +72,12 @@  discard block
 block discarded – undo
     protected function isMatch(Mailcode_Parser_Statement_Tokenizer_Token $token, int $index) : bool
     {
         // filter out tokens of other types
-        if(!is_a($token, $this->getTokenClass()))
+        if (!is_a($token, $this->getTokenClass()))
         {
             return false;
         }
         
-        if($this->searchIndex >= 0 && $index !== $this->searchIndex)
+        if ($this->searchIndex >= 0 && $index !== $this->searchIndex)
         {
             return false;
         }
@@ -96,9 +96,9 @@  discard block
 block discarded – undo
     {
         $tokens = $this->params->getTokens();
         
-        foreach($tokens as $index => $token)
+        foreach ($tokens as $index => $token)
         {
-            if($this->isMatch($token, $index))
+            if ($this->isMatch($token, $index))
             {
                 return $token;
             }
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
     {
         $token = $this->findToken();
         
-        if($token instanceof Mailcode_Parser_Statement_Tokenizer_Token && is_a($token, $this->getTokenClass()))
+        if ($token instanceof Mailcode_Parser_Statement_Tokenizer_Token && is_a($token, $this->getTokenClass()))
         {
             $this->token = $token;
             return true;

Please login to merge, or discard this patch.

Indentation +52 added lines, -52 removed lines patch added patch discarded remove patch

@@ -22,53 +22,53 @@  discard block
 block discarded – undo
 {
     public const VALIDATION_ERROR_COMMAND_WITHOUT_PARAMETERS = 62401;
     
-   /**
-    * @var integer
-    */
+    /**
+     * @var integer
+     */
     protected $searchIndex = -1;
     
-   /**
-    * @var Mailcode_Parser_Statement_Tokenizer_Token|NULL
-    */
+    /**
+     * @var Mailcode_Parser_Statement_Tokenizer_Token|NULL
+     */
     protected $token;
     
-   /**
-    * Retrieves the class name of the token type to 
-    * limit the token search to. Only a token of this
-    * type will be stored.
-    * 
-    * @return string
-    */
+    /**
+     * Retrieves the class name of the token type to 
+     * limit the token search to. Only a token of this
+     * type will be stored.
+     * 
+     * @return string
+     */
     abstract protected function getTokenClass() : string;
     
-   /**
-    * Allows the validator to apply custom search
-    * criteria to the tokens that are searched 
-    * through to find the target token.
-    * 
-    * NOTE: Should return true if there are no
-    * custom criteria to apply.
-    * 
-    * @param Mailcode_Parser_Statement_Tokenizer_Token $token
-    * @return bool
-    */
+    /**
+     * Allows the validator to apply custom search
+     * criteria to the tokens that are searched 
+     * through to find the target token.
+     * 
+     * NOTE: Should return true if there are no
+     * custom criteria to apply.
+     * 
+     * @param Mailcode_Parser_Statement_Tokenizer_Token $token
+     * @return bool
+     */
     abstract protected function _isMatch(Mailcode_Parser_Statement_Tokenizer_Token $token) : bool;
     
-   /**
-    * @return Mailcode_Parser_Statement_Tokenizer_Token
-    */
+    /**
+     * @return Mailcode_Parser_Statement_Tokenizer_Token
+     */
     abstract public function getToken();
     
-   /**
-    * Checks if the specified token matches the current
-    * search criteria (index, type...). If the token is
-    * a match, the `_isMatch()` method is called to allow
-    * the validator class to apply some custom criteria. 
-    * 
-    * @param Mailcode_Parser_Statement_Tokenizer_Token $token
-    * @param int $index
-    * @return bool
-    */
+    /**
+     * Checks if the specified token matches the current
+     * search criteria (index, type...). If the token is
+     * a match, the `_isMatch()` method is called to allow
+     * the validator class to apply some custom criteria. 
+     * 
+     * @param Mailcode_Parser_Statement_Tokenizer_Token $token
+     * @param int $index
+     * @return bool
+     */
     protected function isMatch(Mailcode_Parser_Statement_Tokenizer_Token $token, int $index) : bool
     {
         // filter out tokens of other types
@@ -85,13 +85,13 @@  discard block
 block discarded – undo
         return $this->_isMatch($token);
     }
     
-   /**
-    * Attempts to find a token in the statement
-    * that matches the current criteria, and the
-    * first one it finds is returned.
-    * 
-    * @return Mailcode_Parser_Statement_Tokenizer_Token|NULL
-    */
+    /**
+     * Attempts to find a token in the statement
+     * that matches the current criteria, and the
+     * first one it finds is returned.
+     * 
+     * @return Mailcode_Parser_Statement_Tokenizer_Token|NULL
+     */
     protected function findToken() : ?Mailcode_Parser_Statement_Tokenizer_Token
     {
         $tokens = $this->params->getTokens();
@@ -120,14 +120,14 @@  discard block
 block discarded – undo
         return false;
     }
     
-   /**
-    * Searches for a specific token index.
-    * 
-    * NOTE: only relevant when trying to find a single token.
-    * 
-    * @param int $index
-    * @return $this
-    */
+    /**
+     * Searches for a specific token index.
+     * 
+     * NOTE: only relevant when trying to find a single token.
+     * 
+     * @param int $index
+     * @return $this
+     */
     public function setIndex(int $index) : Mailcode_Parser_Statement_Validator_TokenType
     {
         $this->searchIndex = $index;

Please login to merge, or discard this patch.

src/Mailcode/Parser/Statement/Validator/Type.php 2 patches

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -20,9 +20,9 @@  discard block
 block discarded – undo
  */
 abstract class Mailcode_Parser_Statement_Validator_Type
 {
-   /**
-    * @var Mailcode_Parser_Statement
-    */
+    /**
+     * @var Mailcode_Parser_Statement
+     */
     protected $statement;
     
     /**
@@ -30,14 +30,14 @@  discard block
 block discarded – undo
      */
     protected $params;
     
-   /**
-    * @var boolean
-    */
+    /**
+     * @var boolean
+     */
     private $valid = true;
     
-   /**
-    * @var boolean
-    */
+    /**
+     * @var boolean
+     */
     private $validated = false;
     
     public function __construct(Mailcode_Parser_Statement $statement)
@@ -53,9 +53,9 @@  discard block
 block discarded – undo
         
     }
     
-   /**
-    * @return $this
-    */
+    /**
+     * @return $this
+     */
     public function validate() : Mailcode_Parser_Statement_Validator_Type
     {
         if(!$this->validated)

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -58,7 +58,7 @@
 block discarded – undo
     */
     public function validate() : Mailcode_Parser_Statement_Validator_Type
     {
-        if(!$this->validated)
+        if (!$this->validated)
         {
             $this->valid = $this->_validate();
             $this->validated = true;

Please login to merge, or discard this patch.

src/Mailcode/Parser/Statement/Validator/Type/Keyword.php 2 patches

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -50,7 +50,7 @@
 block discarded – undo
     
     public function getToken() : Mailcode_Parser_Statement_Tokenizer_Token_Keyword
     {
-        if($this->token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Keyword)
+        if ($this->token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Keyword)
         {
             return $this->token;
         }

Please login to merge, or discard this patch.

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -22,10 +22,10 @@
 block discarded – undo
 {
     public const ERROR_NO_KEYWORD_TOKEN_FOUND = 62701;
     
-   /**
-    * The name of the keyword, with ":" appended.
-    * @var string
-    */
+    /**
+     * The name of the keyword, with ":" appended.
+     * @var string
+     */
     protected $keywordName;
     
     public function __construct(Mailcode_Parser_Statement $statement, string $keywordName)

Please login to merge, or discard this patch.

src/Mailcode/Parser/Statement/Validator/Type/Value.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@
 block discarded – undo
     
     public function getToken() : Mailcode_Parser_Statement_Tokenizer_ValueInterface
     {
-        if($this->token instanceof Mailcode_Parser_Statement_Tokenizer_ValueInterface)
+        if ($this->token instanceof Mailcode_Parser_Statement_Tokenizer_ValueInterface)
         {
             return $this->token;
         }

Please login to merge, or discard this patch.

src/Mailcode/Parser/Statement/Validator/Type/StringLiteral.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@
 block discarded – undo
     
     public function getToken() : Mailcode_Parser_Statement_Tokenizer_Token_StringLiteral
     {
-        if($this->token instanceof Mailcode_Parser_Statement_Tokenizer_Token_StringLiteral)
+        if ($this->token instanceof Mailcode_Parser_Statement_Tokenizer_Token_StringLiteral)
         {
             return $this->token;
         }

Please login to merge, or discard this patch.

src/Mailcode/Parser/Statement/Validator/Type/Operand.php 2 patches

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -41,7 +41,7 @@  discard block
 block discarded – undo
     
     protected function _isMatch(Mailcode_Parser_Statement_Tokenizer_Token $token) : bool
     {
-        if(!empty($this->sign) && $token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Operand)
+        if (!empty($this->sign) && $token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Operand)
         {
             return $token->getSign() === $this->sign;
         }
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
     
     public function getToken() : Mailcode_Parser_Statement_Tokenizer_Token_Operand
     {
-        if($this->token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Operand)
+        if ($this->token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Operand)
         {
             return $this->token;
         }

Please login to merge, or discard this patch.

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -22,9 +22,9 @@
 block discarded – undo
 {
     public const ERROR_NO_OPERAND_TOKEN_FOUND = 62901;
     
-   /**
-    * @var string
-    */
+    /**
+     * @var string
+     */
     private $sign = '';
     
     protected function getTokenClass() : string

Please login to merge, or discard this patch.

src/Mailcode/Parser/Statement/Validator/Type/Variable.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@
 block discarded – undo
     
     public function getToken() : Mailcode_Parser_Statement_Tokenizer_Token_Variable
     {
-        if($this->token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Variable)
+        if ($this->token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Variable)
         {
             return $this->token;
         }

Please login to merge, or discard this patch.

src/Mailcode/Traits/Commands/IfVariable.php 1 patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -36,9 +36,9 @@
 block discarded – undo
         );
     }
     
-   /**
-    * @return array<string>
-    */
+    /**
+     * @return array<string>
+     */
     protected function getAllowedOperands() : array
     {
         return Mailcode_Parser_Statement_Tokenizer_Token_Operand::getComparisonSigns();

Please login to merge, or discard this patch.

		@@ -72,12 +72,12 @@ discard block
		block discarded – undo
72	72	protected function isMatch(Mailcode_Parser_Statement_Tokenizer_Token $token, int $index) : bool
73	73	{
74	74	// filter out tokens of other types
75		- if(!is_a($token, $this->getTokenClass()))
	75	+ if (!is_a($token, $this->getTokenClass()))
76	76	{
77	77	return false;
78	78	}
79	79
80		- if($this->searchIndex >= 0 && $index !== $this->searchIndex)
	80	+ if ($this->searchIndex >= 0 && $index !== $this->searchIndex)
81	81	{
82	82	return false;
83	83	}
		@@ -96,9 +96,9 @@ discard block
		block discarded – undo
96	96	{
97	97	$tokens = $this->params->getTokens();
98	98
99		- foreach($tokens as $index => $token)
	99	+ foreach ($tokens as $index => $token)
100	100	{
101		- if($this->isMatch($token, $index))
	101	+ if ($this->isMatch($token, $index))
102	102	{
103	103	return $token;
104	104	}
		@@ -111,7 +111,7 @@ discard block
		block discarded – undo
111	111	{
112	112	$token = $this->findToken();
113	113
114		- if($token instanceof Mailcode_Parser_Statement_Tokenizer_Token && is_a($token, $this->getTokenClass()))
	114	+ if ($token instanceof Mailcode_Parser_Statement_Tokenizer_Token && is_a($token, $this->getTokenClass()))
115	115	{
116	116	$this->token = $token;
117	117	return true;

		@@ -48,13 +48,13 @@
		block discarded – undo
48	48	<body>
49	49	<p>
50	50	<?php
51		- pts('This showcases the command\'s syntax highlighting.');
52		- pts(
53		- 'It is based on the %1$s color scheme%2$s:',
54		- '<a href="https://ethanschoonover.com/solarized/">"Solarized"',
55		- '</a>'
56		- );
57		- ?>
	51	+ pts('This showcases the command\'s syntax highlighting.');
	52	+ pts(
	53	+ 'It is based on the %1$s color scheme%2$s:',
	54	+ '<a href="https://ethanschoonover.com/solarized/">"Solarized"',
	55	+ '</a>'
	56	+ );
	57	+ ?>
58	58	</p>
59	59	<br>
60	60	<div class="commands">

		@@ -17,7 +17,7 @@ discard block
		block discarded – undo
17	17	$autoload = realpath($root.'/../vendor/autoload.php');
18	18
19	19	// we need the autoloader to be present
20		- if($autoload === false)
	20	+ if ($autoload === false)
21	21	{
22	22	die('<b>ERROR:</b> Autoloader not present. Run composer update first.');
23	23	}
		@@ -65,19 +65,19 @@ discard block
		block discarded – undo
65	65	Mailcode_Factory::misc()->comment('Some comments here'),
66	66	Mailcode_Factory::show()->snippet('snippet_name'),
67	67	Mailcode_Factory::show()->date('DATE.VARIABLE'),
68		- Mailcode_Factory::if()->if('1 + 1 == 2'),
69		- Mailcode_Factory::if()->contains('CUSTOMER.NAME', array('John')),
70		- Mailcode_Factory::if()->varEquals('NUMBER', '124'),
	68	+ Mailcode_Factory::if ()->if('1 + 1 == 2'),
	69	+ Mailcode_Factory::if ()->contains('CUSTOMER.NAME', array('John')),
	70	+ Mailcode_Factory::if ()->varEquals('NUMBER', '124'),
71	71	);
72	72
73		- $and = Mailcode_Factory::elseIf()->varEqualsString('STRINGVAR', 'John');
	73	+ $and = Mailcode_Factory::elseIf ()->varEqualsString('STRINGVAR', 'John');
74	74	$and->getLogicKeywords()->appendOR('$STRINGVAR == "Steve"', "variable");
75	75
76	76	$commands[] = $and;
77	77
78	78	$commands[] = Mailcode_Factory::misc()->end();
79	79
80		- foreach($commands as $command)
	80	+ foreach ($commands as $command)
81	81	{
82	82	?>
83	83	<p>

		@@ -65,12 +65,16 @@
		block discarded – undo
65	65	Mailcode_Factory::misc()->comment('Some comments here'),
66	66	Mailcode_Factory::show()->snippet('snippet_name'),
67	67	Mailcode_Factory::show()->date('DATE.VARIABLE'),
68		- Mailcode_Factory::if()->if('1 + 1 == 2'),
	68	+ Mailcode_Factory::if() {
	69	+ ->if('1 + 1 == 2'),
69	70	Mailcode_Factory::if()->contains('CUSTOMER.NAME', array('John')),
70	71	Mailcode_Factory::if()->varEquals('NUMBER', '124'),
71	72	);
	73	+ }
72	74
73		- $and = Mailcode_Factory::elseIf()->varEqualsString('STRINGVAR', 'John');
	75	+ $and = Mailcode_Factory::elseIf() {
	76	+ ->varEqualsString('STRINGVAR', 'John');
	77	+ }
74	78	$and->getLogicKeywords()->appendOR('$STRINGVAR == "Steve"', "variable");
75	79
76	80	$commands[] = $and;

		@@ -22,53 +22,53 @@ discard block
		block discarded – undo
22	22	{
23	23	public const VALIDATION_ERROR_COMMAND_WITHOUT_PARAMETERS = 62401;
24	24
25		- /**
26		- * @var integer
27		- */
	25	+ /**
	26	+ * @var integer
	27	+ */
28	28	protected $searchIndex = -1;
29	29
30		- /**
31		- * @var Mailcode_Parser_Statement_Tokenizer_Token\|NULL
32		- */
	30	+ /**
	31	+ * @var Mailcode_Parser_Statement_Tokenizer_Token\|NULL
	32	+ */
33	33	protected $token;
34	34
35		- /**
36		- * Retrieves the class name of the token type to
37		- * limit the token search to. Only a token of this
38		- * type will be stored.
39		- *
40		- * @return string
41		- */
	35	+ /**
	36	+ * Retrieves the class name of the token type to
	37	+ * limit the token search to. Only a token of this
	38	+ * type will be stored.
	39	+ *
	40	+ * @return string
	41	+ */
42	42	abstract protected function getTokenClass() : string;
43	43
44		- /**
45		- * Allows the validator to apply custom search
46		- * criteria to the tokens that are searched
47		- * through to find the target token.
48		- *
49		- * NOTE: Should return true if there are no
50		- * custom criteria to apply.
51		- *
52		- * @param Mailcode_Parser_Statement_Tokenizer_Token $token
53		- * @return bool
54		- */
	44	+ /**
	45	+ * Allows the validator to apply custom search
	46	+ * criteria to the tokens that are searched
	47	+ * through to find the target token.
	48	+ *
	49	+ * NOTE: Should return true if there are no
	50	+ * custom criteria to apply.
	51	+ *
	52	+ * @param Mailcode_Parser_Statement_Tokenizer_Token $token
	53	+ * @return bool
	54	+ */
55	55	abstract protected function _isMatch(Mailcode_Parser_Statement_Tokenizer_Token $token) : bool;
56	56
57		- /**
58		- * @return Mailcode_Parser_Statement_Tokenizer_Token
59		- */
	57	+ /**
	58	+ * @return Mailcode_Parser_Statement_Tokenizer_Token
	59	+ */
60	60	abstract public function getToken();
61	61
62		- /**
63		- * Checks if the specified token matches the current
64		- * search criteria (index, type...). If the token is
65		- * a match, the `_isMatch()` method is called to allow
66		- * the validator class to apply some custom criteria.
67		- *
68		- * @param Mailcode_Parser_Statement_Tokenizer_Token $token
69		- * @param int $index
70		- * @return bool
71		- */
	62	+ /**
	63	+ * Checks if the specified token matches the current
	64	+ * search criteria (index, type...). If the token is
	65	+ * a match, the `_isMatch()` method is called to allow
	66	+ * the validator class to apply some custom criteria.
	67	+ *
	68	+ * @param Mailcode_Parser_Statement_Tokenizer_Token $token
	69	+ * @param int $index
	70	+ * @return bool
	71	+ */
72	72	protected function isMatch(Mailcode_Parser_Statement_Tokenizer_Token $token, int $index) : bool
73	73	{
74	74	// filter out tokens of other types
		@@ -85,13 +85,13 @@ discard block
		block discarded – undo
85	85	return $this->_isMatch($token);
86	86	}
87	87
88		- /**
89		- * Attempts to find a token in the statement
90		- * that matches the current criteria, and the
91		- * first one it finds is returned.
92		- *
93		- * @return Mailcode_Parser_Statement_Tokenizer_Token\|NULL
94		- */
	88	+ /**
	89	+ * Attempts to find a token in the statement
	90	+ * that matches the current criteria, and the
	91	+ * first one it finds is returned.
	92	+ *
	93	+ * @return Mailcode_Parser_Statement_Tokenizer_Token\|NULL
	94	+ */
95	95	protected function findToken() : ?Mailcode_Parser_Statement_Tokenizer_Token
96	96	{
97	97	$tokens = $this->params->getTokens();
		@@ -120,14 +120,14 @@ discard block
		block discarded – undo
120	120	return false;
121	121	}
122	122
123		- /**
124		- * Searches for a specific token index.
125		- *
126		- * NOTE: only relevant when trying to find a single token.
127		- *
128		- * @param int $index
129		- * @return $this
130		- */
	123	+ /**
	124	+ * Searches for a specific token index.
	125	+ *
	126	+ * NOTE: only relevant when trying to find a single token.
	127	+ *
	128	+ * @param int $index
	129	+ * @return $this
	130	+ */
131	131	public function setIndex(int $index) : Mailcode_Parser_Statement_Validator_TokenType
132	132	{
133	133	$this->searchIndex = $index;

		@@ -20,9 +20,9 @@ discard block
		block discarded – undo
20	20	*/
21	21	abstract class Mailcode_Parser_Statement_Validator_Type
22	22	{
23		- /**
24		- * @var Mailcode_Parser_Statement
25		- */
	23	+ /**
	24	+ * @var Mailcode_Parser_Statement
	25	+ */
26	26	protected $statement;
27	27
28	28	/**
		@@ -30,14 +30,14 @@ discard block
		block discarded – undo
30	30	*/
31	31	protected $params;
32	32
33		- /**
34		- * @var boolean
35		- */
	33	+ /**
	34	+ * @var boolean
	35	+ */
36	36	private $valid = true;
37	37
38		- /**
39		- * @var boolean
40		- */
	38	+ /**
	39	+ * @var boolean
	40	+ */
41	41	private $validated = false;
42	42
43	43	public function __construct(Mailcode_Parser_Statement $statement)
		@@ -53,9 +53,9 @@ discard block
		block discarded – undo
53	53
54	54	}
55	55
56		- /**
57		- * @return $this
58		- */
	56	+ /**
	57	+ * @return $this
	58	+ */
59	59	public function validate() : Mailcode_Parser_Statement_Validator_Type
60	60	{
61	61	if(!$this->validated)

		@@ -58,7 +58,7 @@
		block discarded – undo
58	58	*/
59	59	public function validate() : Mailcode_Parser_Statement_Validator_Type
60	60	{
61		- if(!$this->validated)
	61	+ if (!$this->validated)
62	62	{
63	63	$this->valid = $this->_validate();
64	64	$this->validated = true;

		@@ -50,7 +50,7 @@
		block discarded – undo
50	50
51	51	public function getToken() : Mailcode_Parser_Statement_Tokenizer_Token_Keyword
52	52	{
53		- if($this->token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Keyword)
	53	+ if ($this->token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Keyword)
54	54	{
55	55	return $this->token;
56	56	}

		@@ -22,10 +22,10 @@
		block discarded – undo
22	22	{
23	23	public const ERROR_NO_KEYWORD_TOKEN_FOUND = 62701;
24	24
25		- /**
26		- * The name of the keyword, with ":" appended.
27		- * @var string
28		- */
	25	+ /**
	26	+ * The name of the keyword, with ":" appended.
	27	+ * @var string
	28	+ */
29	29	protected $keywordName;
30	30
31	31	public function __construct(Mailcode_Parser_Statement $statement, string $keywordName)

		@@ -34,7 +34,7 @@
		block discarded – undo
34	34
35	35	public function getToken() : Mailcode_Parser_Statement_Tokenizer_ValueInterface
36	36	{
37		- if($this->token instanceof Mailcode_Parser_Statement_Tokenizer_ValueInterface)
	37	+ if ($this->token instanceof Mailcode_Parser_Statement_Tokenizer_ValueInterface)
38	38	{
39	39	return $this->token;
40	40	}

		@@ -41,7 +41,7 @@ discard block
		block discarded – undo
41	41
42	42	protected function _isMatch(Mailcode_Parser_Statement_Tokenizer_Token $token) : bool
43	43	{
44		- if(!empty($this->sign) && $token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Operand)
	44	+ if (!empty($this->sign) && $token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Operand)
45	45	{
46	46	return $token->getSign() === $this->sign;
47	47	}
		@@ -51,7 +51,7 @@ discard block
		block discarded – undo
51	51
52	52	public function getToken() : Mailcode_Parser_Statement_Tokenizer_Token_Operand
53	53	{
54		- if($this->token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Operand)
	54	+ if ($this->token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Operand)
55	55	{
56	56	return $this->token;
57	57	}

		@@ -22,9 +22,9 @@
		block discarded – undo
22	22	{
23	23	public const ERROR_NO_OPERAND_TOKEN_FOUND = 62901;
24	24
25		- /**
26		- * @var string
27		- */
	25	+ /**
	26	+ * @var string
	27	+ */
28	28	private $sign = '';
29	29
30	30	protected function getTokenClass() : string

		@@ -36,9 +36,9 @@
		block discarded – undo
36	36	);
37	37	}
38	38
39		- /**
40		- * @return array<string>
41		- */
	39	+ /**
	40	+ * @return array<string>
	41	+ */
42	42	protected function getAllowedOperands() : array
43	43	{
44	44	return Mailcode_Parser_Statement_Tokenizer_Token_Operand::getComparisonSigns();

Mistralys / mailcode

Push — master ( 38d7a4...ed3505 )

Status

Category

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Braces +6 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +52 added lines, -52 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch