Passed
Pull Request — master (#10)
by
unknown
08:56
created
localization/index.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
     $autoload = realpath($root.'/../vendor/autoload.php');
13 13
     
14 14
     // we need the autoloader to be present
15
-    if($autoload === false) 
15
+    if ($autoload === false) 
16 16
     {
17 17
         die('<b>ERROR:</b> Autoloader not present. Run composer update first.');
18 18
     }
Please login to merge, or discard this patch.
src/Mailcode/Variables/Collection/Regular.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
     
33 33
     public function add(Mailcode_Variables_Variable $variable) : Mailcode_Variables_Collection
34 34
     {
35
-        if(!$variable->isValid())
35
+        if (!$variable->isValid())
36 36
         {
37 37
             return $this->addInvalid($variable);
38 38
         }
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
         parent::mergeWith($collection);
77 77
         
78 78
         // also inherit any invalid variables
79
-        if($collection instanceof Mailcode_Variables_Collection_Regular)
79
+        if ($collection instanceof Mailcode_Variables_Collection_Regular)
80 80
         {
81 81
             $invalid = $collection->getInvalid();
82 82
             
Please login to merge, or discard this patch.
src/functions.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
  */
24 24
 function init() : void
25 25
 {
26
-    if(!class_exists('\AppLocalize\Localization')) {
26
+    if (!class_exists('\AppLocalize\Localization')) {
27 27
         return;
28 28
     }
29 29
     
Please login to merge, or discard this patch.
src/Mailcode/Factory/Exception.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
     * @param \Exception|NULL $previous
33 33
     * @param Mailcode_Commands_Command|NULL $command
34 34
     */
35
-    public function __construct(string $message, $details=null, $code=null, $previous=null, Mailcode_Commands_Command $command=null)
35
+    public function __construct(string $message, $details = null, $code = null, $previous = null, Mailcode_Commands_Command $command = null)
36 36
     {
37 37
         parent::__construct($message, $details, $code, $previous);
38 38
         
Please login to merge, or discard this patch.
src/Mailcode/Date/FormatInfo/Character.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@
 block discarded – undo
87 87
     */
88 88
     public function getTypeLabel() : string
89 89
     {
90
-        switch($this->type)
90
+        switch ($this->type)
91 91
         {
92 92
             case Mailcode_Date_FormatInfo::CHARTYPE_DATE:
93 93
                 return t('Date');
Please login to merge, or discard this patch.
src/Mailcode/Date/FormatInfo.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
     
59 59
     public static function getInstance() : Mailcode_Date_FormatInfo
60 60
     {
61
-        if(!isset(self::$instance))
61
+        if (!isset(self::$instance))
62 62
         {
63 63
             self::$instance = new Mailcode_Date_FormatInfo();
64 64
         }
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
             array(self::CHARTYPE_PUNCTUATION, ' ', t('Space'))
91 91
         );
92 92
         
93
-        foreach($chars as $def)
93
+        foreach ($chars as $def)
94 94
         {
95 95
             $char = new Mailcode_Date_FormatInfo_Character(
96 96
                 $def[0],
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
         
130 130
         $trimmed = trim($formatString);
131 131
         
132
-        if(empty($trimmed))
132
+        if (empty($trimmed))
133 133
         {
134 134
             $result->makeError(
135 135
                 t('Empty date format.'),
@@ -142,15 +142,15 @@  discard block
 block discarded – undo
142 142
         $chars = ConvertHelper::string2array($formatString);
143 143
         $total = count($chars);
144 144
         
145
-        for($i=0; $i < $total; $i++)
145
+        for ($i = 0; $i < $total; $i++)
146 146
         {
147 147
             $char = $chars[$i];
148 148
             
149
-            if(!in_array($char, $this->allowedChars))
149
+            if (!in_array($char, $this->allowedChars))
150 150
             {
151 151
                 $result->makeError(
152 152
                     t('Invalid character in date format:').' '.
153
-                    t('%1$s at position %2$s.', '<code>'.$char.'</code>', $i+1),
153
+                    t('%1$s at position %2$s.', '<code>'.$char.'</code>', $i + 1),
154 154
                     self::VALIDATION_INVALID_FORMAT_CHARACTER
155 155
                 );
156 156
                 
@@ -182,11 +182,11 @@  discard block
 block discarded – undo
182 182
     {
183 183
         $grouped = array();
184 184
         
185
-        foreach($this->formatChars as $char)
185
+        foreach ($this->formatChars as $char)
186 186
         {
187 187
             $type = $char->getTypeLabel();
188 188
             
189
-            if(!isset($grouped[$type]))
189
+            if (!isset($grouped[$type]))
190 190
             {
191 191
                 $grouped[$type] = array();
192 192
             }
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
 
197 197
         $groups = array_keys($grouped);
198 198
         
199
-        foreach($groups as $group)
199
+        foreach ($groups as $group)
200 200
         {
201 201
             usort($grouped[$group], function(Mailcode_Date_FormatInfo_Character $a, Mailcode_Date_FormatInfo_Character $b)
202 202
             {
Please login to merge, or discard this patch.
src/Mailcode/Factory/CommandSets/Set.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
         
42 42
         $this->instantiator->checkCommand($cmd);
43 43
         
44
-        if($cmd instanceof Mailcode_Commands_Command_End)
44
+        if ($cmd instanceof Mailcode_Commands_Command_End)
45 45
         {
46 46
             return $cmd;
47 47
         }
Please login to merge, or discard this patch.
src/Mailcode/Factory/CommandSets/IfBase.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
         
32 32
         $this->instantiator->checkCommand($cmd);
33 33
         
34
-        if($cmd instanceof Mailcode_Commands_Command_Else)
34
+        if ($cmd instanceof Mailcode_Commands_Command_Else)
35 35
         {
36 36
             return $cmd;
37 37
         }
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,8 @@  discard block
 block discarded – undo
20 20
  */
21 21
 abstract class Mailcode_Factory_CommandSets_IfBase extends Mailcode_Factory_CommandSets_Set
22 22
 {
23
-    public function else() : Mailcode_Commands_Command_Else
23
+    public function else {
24
+        () : Mailcode_Commands_Command_Else
24 25
     {
25 26
         $cmd = Mailcode::create()->getCommands()->createCommand(
26 27
             'Else',
@@ -28,6 +29,7 @@  discard block
 block discarded – undo
28 29
             '',
29 30
             '{else}'
30 31
         );
32
+    }
31 33
         
32 34
         $this->instantiator->checkCommand($cmd);
33 35
         
Please login to merge, or discard this patch.
src/Mailcode/Translator/Syntax/ApacheVelocity/Base/AbstractIf.php 2 patches
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,8 +40,7 @@
 block discarded – undo
40 40
             if($keyCommand instanceof Mailcode_Commands_IfBase)
41 41
             {
42 42
                 $body .= ' '.$this->getSign($keyword).' '.$this->translateBody($keyCommand);
43
-            }
44
-            else
43
+            } else
45 44
             {
46 45
                 throw new Mailcode_Exception(
47 46
                     'Keyword command type does not match expected base class.',
Please login to merge, or discard this patch.
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
         // IF type.
40 40
         $method = 'translate'.$this->getIfType($command);
41 41
 
42
-        if(method_exists($this, $method))
42
+        if (method_exists($this, $method))
43 43
         {
44 44
             return strval($this->$method($command));
45 45
         }
@@ -53,11 +53,11 @@  discard block
 block discarded – undo
53 53
         
54 54
         $keywords = $command->getLogicKeywords()->getKeywords();
55 55
         
56
-        foreach($keywords as $keyword)
56
+        foreach ($keywords as $keyword)
57 57
         {
58 58
             $keyCommand = $keyword->getCommand();
59 59
             
60
-            if($keyCommand instanceof Mailcode_Commands_IfBase)
60
+            if ($keyCommand instanceof Mailcode_Commands_IfBase)
61 61
             {
62 62
                 $body .= ' '.$this->getSign($keyword).' '.$this->translateBody($keyCommand);
63 63
             }
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
     
81 81
     protected function getSign(Mailcode_Commands_LogicKeywords_Keyword $keyword) : string
82 82
     {
83
-        switch($keyword->getName())
83
+        switch ($keyword->getName())
84 84
         {
85 85
             case 'and':
86 86
                 return '&&';
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
     {
114 114
         $sign = '';
115 115
         
116
-        if($notEmpty)
116
+        if ($notEmpty)
117 117
         {
118 118
             $sign = '!';
119 119
         }
@@ -129,12 +129,12 @@  discard block
 block discarded – undo
129 129
     {
130 130
         $params = $command->getParams();
131 131
 
132
-        if(!$params)
132
+        if (!$params)
133 133
         {
134 134
             return '';
135 135
         }
136 136
 
137
-        if($command->hasFreeformParameters())
137
+        if ($command->hasFreeformParameters())
138 138
         {
139 139
             return $params->getStatementString();
140 140
         }
@@ -142,18 +142,18 @@  discard block
 block discarded – undo
142 142
         return $params->getNormalized();
143 143
     }
144 144
     
145
-    protected function _translateVariable(Mailcode_Variables_Variable $variable, string $comparator, string $value, bool $insensitive=false) : string
145
+    protected function _translateVariable(Mailcode_Variables_Variable $variable, string $comparator, string $value, bool $insensitive = false) : string
146 146
     {
147 147
         $booleanCheck = strtolower(trim($value, '"'));
148 148
         $fullName = $variable->getFullName();
149 149
 
150
-        if(in_array($booleanCheck, array('true', 'false')))
150
+        if (in_array($booleanCheck, array('true', 'false')))
151 151
         {
152 152
             $insensitive = true;
153 153
             $value = '"'.$booleanCheck.'"';
154 154
         }
155 155
 
156
-        if($insensitive)
156
+        if ($insensitive)
157 157
         {
158 158
             $fullName .= '.toLowerCase()';
159 159
             $value = mb_strtolower($value);
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
     protected function _translateSearch(string $mode, Mailcode_Variables_Variable $variable, bool $caseSensitive, string $searchTerm) : string
186 186
     {
187 187
         $method = $mode.'With';
188
-        if($caseSensitive)
188
+        if ($caseSensitive)
189 189
         {
190 190
             $method = $mode.'WithIgnoreCase';
191 191
         }
Please login to merge, or discard this patch.