Passed
Push — master ( 72fab6...1a6285 )
by Sebastian
03:35
created
src/Mailcode/Parser.php 3 patches
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -146,8 +146,7 @@  discard block
 block discarded – undo
146 146
         if($cmd instanceof Mailcode_Commands_Command_Type_Opening)
147 147
         {
148 148
             $this->stack[] = $cmd;
149
-        }
150
-        else if($cmd instanceof Mailcode_Commands_Command_Type_Closing)
149
+        } else if($cmd instanceof Mailcode_Commands_Command_Type_Closing)
151 150
         {
152 151
             array_pop($this->stack);
153 152
         }
@@ -177,13 +176,11 @@  discard block
 block discarded – undo
177 176
         if(!empty($matches[1][$index]))
178 177
         {
179 178
             $name = $matches[1][$index];
180
-        }
181
-        else if(!empty($matches[2][$index]))
179
+        } else if(!empty($matches[2][$index]))
182 180
         {
183 181
             $name = $matches[2][$index];
184 182
             $params = $matches[3][$index];
185
-        }
186
-        else if(!empty($matches[4][$index]))
183
+        } else if(!empty($matches[4][$index]))
187 184
         {
188 185
             $name = $matches[4][$index];
189 186
             $type = $matches[5][$index];
Please login to merge, or discard this patch.
Indentation   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -42,11 +42,11 @@  discard block
 block discarded – undo
42 42
         $this->commands = $this->mailcode->getCommands();
43 43
     }
44 44
     
45
-   /**
46
-    * Gets the regex format string used to detect commands.
47
-    * 
48
-    * @return string
49
-    */
45
+    /**
46
+     * Gets the regex format string used to detect commands.
47
+     * 
48
+     * @return string
49
+     */
50 50
     protected static function getRegex() : string
51 51
     {
52 52
         return '/'.implode('|', self::COMMAND_REGEX_PARTS).'/sixU';
@@ -183,14 +183,14 @@  discard block
 block discarded – undo
183 183
         throw new Mailcode_Exception('Not a command', '', self::ERROR_NOT_A_COMMAND);
184 184
     }
185 185
     
186
-   /**
187
-    * Parses a single regex match: determines which named group
188
-    * matches, and retrieves the according information.
189
-    * 
190
-    * @param array<int,array<int,string>>$matches The regex results array.
191
-    * @param int $index The matched index.
192
-    * @return Mailcode_Parser_Match
193
-    */
186
+    /**
187
+     * Parses a single regex match: determines which named group
188
+     * matches, and retrieves the according information.
189
+     * 
190
+     * @param array<int,array<int,string>>$matches The regex results array.
191
+     * @param int $index The matched index.
192
+     * @return Mailcode_Parser_Match
193
+     */
194 194
     protected function parseMatch(array $matches, int $index) : Mailcode_Parser_Match
195 195
     {
196 196
         $name = ''; // the command name, e.g. "showvar"
@@ -228,14 +228,14 @@  discard block
 block discarded – undo
228 228
         );
229 229
     }
230 230
     
231
-   /**
232
-    * Creates an instance of the safeguard tool, which
233
-    * is used to safeguard commands in a string with placeholders.
234
-    * 
235
-    * @param string $subject The string to use to safeguard commands in.
236
-    * @return Mailcode_Parser_Safeguard
237
-    * @see Mailcode_Parser_Safeguard
238
-    */
231
+    /**
232
+     * Creates an instance of the safeguard tool, which
233
+     * is used to safeguard commands in a string with placeholders.
234
+     * 
235
+     * @param string $subject The string to use to safeguard commands in.
236
+     * @return Mailcode_Parser_Safeguard
237
+     * @see Mailcode_Parser_Safeguard
238
+     */
239 239
     public function createSafeguard(string $subject) : Mailcode_Parser_Safeguard
240 240
     {
241 241
         return new Mailcode_Parser_Safeguard($this, $subject);
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 
73 73
         $result = new ParseResult($collection, $preParser);
74 74
 
75
-        if(!$collection->isValid())
75
+        if (!$collection->isValid())
76 76
         {
77 77
             return $result;
78 78
         }
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
         
85 85
         $total = count($matches[0]);
86 86
 
87
-        for($i=0; $i < $total; $i++)
87
+        for ($i = 0; $i < $total; $i++)
88 88
         {
89 89
             $match = $this->parseMatch($matches, $i);
90 90
             
@@ -154,17 +154,17 @@  discard block
 block discarded – undo
154 154
     private function handleNesting(Mailcode_Commands_Command $cmd) : void
155 155
     {
156 156
         // Set the command's parent from the stack, if any is present.
157
-        if(!empty($this->stack))
157
+        if (!empty($this->stack))
158 158
         {
159 159
             $cmd->setParent($this->getStackLast());
160 160
         }
161 161
 
162 162
         // Handle opening and closing commands, adding and removing from the stack.
163
-        if($cmd instanceof Mailcode_Commands_Command_Type_Opening)
163
+        if ($cmd instanceof Mailcode_Commands_Command_Type_Opening)
164 164
         {
165 165
             $this->stack[] = $cmd;
166 166
         }
167
-        else if($cmd instanceof Mailcode_Commands_Command_Type_Closing)
167
+        else if ($cmd instanceof Mailcode_Commands_Command_Type_Closing)
168 168
         {
169 169
             array_pop($this->stack);
170 170
         }
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
     {
179 179
         $cmd = $this->stack[array_key_last($this->stack)];
180 180
 
181
-        if($cmd instanceof Mailcode_Commands_Command)
181
+        if ($cmd instanceof Mailcode_Commands_Command)
182 182
         {
183 183
             return $cmd;
184 184
         }
@@ -207,16 +207,16 @@  discard block
 block discarded – undo
207 207
         // 5 = parameter type command, type
208 208
         // 6 = parameter type command, params
209 209
         
210
-        if(!empty($matches[1][$index]))
210
+        if (!empty($matches[1][$index]))
211 211
         {
212 212
             $name = $matches[1][$index];
213 213
         }
214
-        else if(!empty($matches[2][$index]))
214
+        else if (!empty($matches[2][$index]))
215 215
         {
216 216
             $name = $matches[2][$index];
217 217
             $params = $matches[3][$index];
218 218
         }
219
-        else if(!empty($matches[4][$index]))
219
+        else if (!empty($matches[4][$index]))
220 220
         {
221 221
             $name = $matches[4][$index];
222 222
             $type = $matches[5][$index];
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
      * @param Mailcode_Commands_Command|null $sourceCommand
254 254
      * @return Mailcode_Parser_Statement
255 255
      */
256
-    public function createStatement(string $statement, bool $freeform=false, ?Mailcode_Commands_Command $sourceCommand=null) : Mailcode_Parser_Statement
256
+    public function createStatement(string $statement, bool $freeform = false, ?Mailcode_Commands_Command $sourceCommand = null) : Mailcode_Parser_Statement
257 257
     {
258 258
         return new Mailcode_Parser_Statement($statement, $freeform, $sourceCommand);
259 259
     }
Please login to merge, or discard this patch.
src/Mailcode/Parser/Safeguard/Formatter/Type/MarkVariables.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
     
61 61
     public function setTemplate(string $template) : Mailcode_Parser_Safeguard_Formatter_Type_MarkVariables
62 62
     {
63
-        if(substr_count($template, '%s') !== 1)
63
+        if (substr_count($template, '%s') !== 1)
64 64
         {
65 65
             throw new Mailcode_Exception(
66 66
                 'Invalid tag template',
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
         $parts = explode('%s', $this->getTemplate());
102 102
         $tag = array_shift($parts);
103 103
 
104
-        if($this->templateMode === self::TEMPLATE_MODE_INLINE)
104
+        if ($this->templateMode === self::TEMPLATE_MODE_INLINE)
105 105
         {
106 106
             $tag = str_replace('__STYLES__', $this->getInlineStyles(), $tag);
107 107
         }
@@ -129,12 +129,12 @@  discard block
 block discarded – undo
129 129
         $styles = '';
130 130
         $regex = '/\.'.self::DEFAULT_CLASS_NAME.'{([^}]+)}/';
131 131
 
132
-        if(preg_match($regex, $this->getCSS(), $matches))
132
+        if (preg_match($regex, $this->getCSS(), $matches))
133 133
         {
134 134
             $styles = $matches[1];
135 135
         }
136 136
 
137
-        if(empty($styles))
137
+        if (empty($styles))
138 138
         {
139 139
             throw new Mailcode_Exception(
140 140
                 'Cannot extract styles.',
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
         $file = MAILCODE_INSTALL_FOLDER.'/css/marked-variables.css';
192 192
         $path = realpath($file);
193 193
 
194
-        if($path !== false)
194
+        if ($path !== false)
195 195
         {
196 196
             return $path;
197 197
         }
Please login to merge, or discard this patch.
src/Mailcode/Number/Info.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
     {
43 43
         $format = trim($format);
44 44
 
45
-        if(empty($format))
45
+        if (empty($format))
46 46
         {
47 47
             $format = self::DEFAULT_FORMAT;
48 48
         }
@@ -108,15 +108,15 @@  discard block
 block discarded – undo
108 108
     {
109 109
         $format = $this->format;
110 110
 
111
-        foreach($this->validations as $validation)
111
+        foreach ($this->validations as $validation)
112 112
         {
113 113
             $method = 'parse_'.$validation;
114 114
 
115
-            if(method_exists($this, $method))
115
+            if (method_exists($this, $method))
116 116
             {
117 117
                 $format = $this->$method($format);
118 118
 
119
-                if(!$this->isValid())
119
+                if (!$this->isValid())
120 120
                 {
121 121
                     return;
122 122
                 }
@@ -138,13 +138,13 @@  discard block
 block discarded – undo
138 138
 
139 139
     private function parse_padding(string $format) : string
140 140
     {
141
-        if(strstr($format, ':') === false) {
141
+        if (strstr($format, ':') === false) {
142 142
             return $format;
143 143
         }
144 144
 
145 145
         $parts = ConvertHelper::explodeTrim(':', $this->format);
146 146
 
147
-        if(count($parts) !== 2)
147
+        if (count($parts) !== 2)
148 148
         {
149 149
             $this->makeError(
150 150
                 t(
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
 
160 160
         $padding = $parts[1];
161 161
 
162
-        if(!preg_match('/\A[#]+\z/x', $padding))
162
+        if (!preg_match('/\A[#]+\z/x', $padding))
163 163
         {
164 164
             $this->makeError(
165 165
                 t('The padding may only contain hashes (%1$s given).', '<code>'.$padding.'</code>'),
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
 
177 177
     private function parse_number(string $format) : string
178 178
     {
179
-        if($format[0] !== '1')
179
+        if ($format[0] !== '1')
180 180
         {
181 181
             $this->makeError(
182 182
                 t('The first character of the format must be a %1$s.', '<code>1</code>'),
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
         $base = str_replace(array('.', ',', ' '), '', $format);
191 191
         $number = intval(substr($base, 0, 4));
192 192
 
193
-        if($number === 1000) {
193
+        if ($number === 1000) {
194 194
             return $format;
195 195
         }
196 196
 
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
         $separator = $format[1];
211 211
 
212 212
         // No thousands separator
213
-        if($separator === '0')
213
+        if ($separator === '0')
214 214
         {
215 215
             return $format;
216 216
         }
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
         // Valid thousands separator
219 219
         $validSeparators = array(' ', ',', '.');
220 220
 
221
-        if(in_array($separator, $validSeparators))
221
+        if (in_array($separator, $validSeparators))
222 222
         {
223 223
             $this->thousandsSeparator = $separator;
224 224
             $format = str_replace('1'.$separator, '1', $format);
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
 
255 255
     private function parse_separators(string $format) : string
256 256
     {
257
-        if(!empty($this->thousandsSeparator) && !empty($this->decimalsSeparator) && $this->thousandsSeparator === $this->decimalsSeparator)
257
+        if (!empty($this->thousandsSeparator) && !empty($this->decimalsSeparator) && $this->thousandsSeparator === $this->decimalsSeparator)
258 258
         {
259 259
             $this->makeError(
260 260
                 t(
@@ -270,14 +270,14 @@  discard block
 block discarded – undo
270 270
 
271 271
     private function parse_decimals(string $format) : string
272 272
     {
273
-        if(empty($this->decimalsSeparator))
273
+        if (empty($this->decimalsSeparator))
274 274
         {
275 275
             return $format;
276 276
         }
277 277
 
278 278
         $parts = ConvertHelper::explodeTrim($this->decimalsSeparator, $format);
279 279
 
280
-        if(!isset($parts[1]))
280
+        if (!isset($parts[1]))
281 281
         {
282 282
             $this->makeError(
283 283
                 t('Cannot determine the amount of decimals.').' '.
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
             return $format;
294 294
         }
295 295
 
296
-        if($this->validateDecimals($parts[1]))
296
+        if ($this->validateDecimals($parts[1]))
297 297
         {
298 298
             $this->decimals = strlen($parts[1]);
299 299
         }
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
303 303
 
304 304
     private function validateDecimals(string $decimals) : bool
305 305
     {
306
-        if(preg_match('/\A[0]+\z/x', $decimals)) {
306
+        if (preg_match('/\A[0]+\z/x', $decimals)) {
307 307
             return true;
308 308
         }
309 309
 
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
     {
323 323
         $validSeparators = array('.', ',');
324 324
 
325
-        if(in_array($separator, $validSeparators)) {
325
+        if (in_array($separator, $validSeparators)) {
326 326
             return true;
327 327
         }
328 328
 
@@ -344,7 +344,7 @@  discard block
 block discarded – undo
344 344
      */
345 345
     private function parse_regex(string $format) : string
346 346
     {
347
-        if(preg_match('/1[ ,.]?000|1[ ,.]?000[.,][0]+/x', $format))
347
+        if (preg_match('/1[ ,.]?000|1[ ,.]?000[.,][0]+/x', $format))
348 348
         {
349 349
             return $format;
350 350
         }
Please login to merge, or discard this patch.
src/Mailcode/Traits/Commands/IfNumber.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
     {
51 51
         $value = $this->getRawNumber();
52 52
 
53
-        if(!is_numeric($value))
53
+        if (!is_numeric($value))
54 54
         {
55 55
             $this->validationResult->makeError(
56 56
                 t(
Please login to merge, or discard this patch.
src/Mailcode/Translator.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
      */
33 33
     public function createSyntax(string $name) : Mailcode_Translator_Syntax
34 34
     {
35
-        if($this->syntaxExists($name))
35
+        if ($this->syntaxExists($name))
36 36
         {
37 37
             return new Mailcode_Translator_Syntax($name);
38 38
         }
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
         $names = $this->getSyntaxNames();
60 60
         $result = array();
61 61
 
62
-        foreach($names as $name)
62
+        foreach ($names as $name)
63 63
         {
64 64
             $result[] = $this->createSyntax($name);
65 65
         }
Please login to merge, or discard this patch.
src/Mailcode/Commands/ShowBase.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
 
71 71
     protected function validateSyntax_urldeencode() : void
72 72
     {
73
-        if($this->isURLEncoded() && $this->getURLDecodeToken() !== null)
73
+        if ($this->isURLEncoded() && $this->getURLDecodeToken() !== null)
74 74
         {
75 75
             $this->validationResult->makeError(
76 76
                 t('Cannot enable URL decoding and encoding at the same time.'),
Please login to merge, or discard this patch.
src/Mailcode/Parser/Statement/Info/Variables.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
         $operand = $this->info->getOperandByIndex(1);
34 34
         $value = $this->info->getTokenByIndex(2);
35 35
 
36
-        if($variable && $operand && $value && $operand->isAssignment())
36
+        if ($variable && $operand && $value && $operand->isAssignment())
37 37
         {
38 38
             return true;
39 39
         }
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
         $operand = $this->info->getOperandByIndex(1);
53 53
         $value = $this->info->getTokenByIndex(2);
54 54
 
55
-        if($variable && $operand && $value && $operand->isComparator())
55
+        if ($variable && $operand && $value && $operand->isComparator())
56 56
         {
57 57
             return true;
58 58
         }
@@ -71,9 +71,9 @@  discard block
 block discarded – undo
71 71
         $result = array();
72 72
         $tokens = $this->tokenizer->getTokens();
73 73
 
74
-        foreach($tokens as $token)
74
+        foreach ($tokens as $token)
75 75
         {
76
-            if($token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Variable)
76
+            if ($token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Variable)
77 77
             {
78 78
                 $result[] = $token->getVariable();
79 79
             }
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
     {
95 95
         $token = $this->info->getTokenByIndex($index);
96 96
 
97
-        if($token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Variable)
97
+        if ($token instanceof Mailcode_Parser_Statement_Tokenizer_Token_Variable)
98 98
         {
99 99
             return $token;
100 100
         }
Please login to merge, or discard this patch.
src/Mailcode/Parser/Statement/Tokenizer/Process.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
      * @param string $matchedText
67 67
      * @param mixed $subject
68 68
      */
69
-    protected function registerToken(string $type, string $matchedText, $subject=null) : void
69
+    protected function registerToken(string $type, string $matchedText, $subject = null) : void
70 70
     {
71 71
         $this->tokensTemporary[] = $this->createToken($type, $matchedText, $subject);
72 72
     }
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
      * @param mixed $subject
78 78
      * @return Mailcode_Parser_Statement_Tokenizer_Token
79 79
      */
80
-    public function createToken(string $type, string $matchedText, $subject=null) : Mailcode_Parser_Statement_Tokenizer_Token
80
+    public function createToken(string $type, string $matchedText, $subject = null) : Mailcode_Parser_Statement_Tokenizer_Token
81 81
     {
82 82
         $token = $this->tokenizer->createToken($type, $matchedText, $subject);
83 83
         $tokenID = $token->getID();
@@ -93,9 +93,9 @@  discard block
 block discarded – undo
93 93
 
94 94
     protected function getTokenByID(string $tokenID) : ?Mailcode_Parser_Statement_Tokenizer_Token
95 95
     {
96
-        foreach($this->tokensTemporary as $token)
96
+        foreach ($this->tokensTemporary as $token)
97 97
         {
98
-            if($token->getID() === $tokenID)
98
+            if ($token->getID() === $tokenID)
99 99
             {
100 100
                 return $token;
101 101
             }
Please login to merge, or discard this patch.
src/Mailcode/Parser/Statement/Tokenizer/Process/Keywords.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -10,9 +10,9 @@
 block discarded – undo
10 10
     {
11 11
         $keywords = Mailcode_Commands_Keywords::getAll();
12 12
 
13
-        foreach($keywords as $keyword)
13
+        foreach ($keywords as $keyword)
14 14
         {
15
-            if(strstr($this->tokenized, $keyword))
15
+            if (strstr($this->tokenized, $keyword))
16 16
             {
17 17
                 $this->registerToken('Keyword', $keyword);
18 18
             }
Please login to merge, or discard this patch.