Mailcode_Traits_Commands_Validation_ParseParams::validateSyntax_params_parse()

Complexity

Conditions	3
Paths	3

Size

Total Lines	25
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    protected function validateSyntax_params_parse() : void
    {
        if(!$this->requiresParameters())
        {
            return;
        }

        $this->params = $this->mailcode->getParser()->createStatement(
            $this->paramsString,
            $this->hasFreeformParameters()

It seems like hasFreeformParameters() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        );

        if(!$this->params->isValid())
        {
            $error = $this->params->getValidationResult();

            $this->validationResult->makeError(
                t('Invalid parameters:').' '.$error->getErrorMessage(),
                Mailcode_Commands_Command::VALIDATION_INVALID_PARAMS_STATEMENT
            );

            return;
        }

        $this->validator = new Mailcode_Parser_Statement_Validator($this->params);
    }