Test Failed
Pull Request — master (#13)
by Sebastian
05:15
created
src/Mailcode.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
     */
78 78
     public function getParser() : Mailcode_Parser
79 79
     {
80
-        if(!isset($this->parser)) 
80
+        if (!isset($this->parser)) 
81 81
         {
82 82
             $this->parser = new Mailcode_Parser($this);
83 83
         }
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
     */
94 94
     public function getCommands() : Mailcode_Commands
95 95
     {
96
-        if(!isset($this->commands)) 
96
+        if (!isset($this->commands)) 
97 97
         {
98 98
             $this->commands = new Mailcode_Commands();
99 99
         }
@@ -118,14 +118,14 @@  discard block
 block discarded – undo
118 118
      * @param Mailcode_Commands_Command|null $sourceCommand
119 119
      * @return Mailcode_Variables_Collection_Regular
120 120
      */
121
-    public function findVariables(string $subject, ?Mailcode_Commands_Command $sourceCommand=null) : Mailcode_Variables_Collection_Regular
121
+    public function findVariables(string $subject, ?Mailcode_Commands_Command $sourceCommand = null) : Mailcode_Variables_Collection_Regular
122 122
     {
123 123
         return $this->createVariables()->parseString($subject, $sourceCommand);
124 124
     }
125 125
     
126 126
     public function createVariables() : Mailcode_Variables
127 127
     {
128
-        if(!isset($this->variables))
128
+        if (!isset($this->variables))
129 129
         {
130 130
             $this->variables = new Mailcode_Variables();
131 131
         }
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
     */
142 142
     public function createTranslator() : Mailcode_Translator
143 143
     {
144
-        if(!isset($this->translator))
144
+        if (!isset($this->translator))
145 145
         {
146 146
             $this->translator = new Mailcode_Translator(); 
147 147
         }
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
         return self::$logger;
190 190
     }
191 191
 
192
-    public static function setDebugging(bool $enabled=true) : void
192
+    public static function setDebugging(bool $enabled = true) : void
193 193
     {
194 194
         self::$debug = $enabled;
195 195
     }
@@ -204,9 +204,9 @@  discard block
 block discarded – undo
204 204
      * @param array<string|int,mixed> $context
205 205
      * @return void
206 206
      */
207
-    public static function debug(string $message, array $context=array()) : void
207
+    public static function debug(string $message, array $context = array()) : void
208 208
     {
209
-        if(self::$debug && isset(self::$logger))
209
+        if (self::$debug && isset(self::$logger))
210 210
         {
211 211
             self::$logger->debug($message, $context);
212 212
         }
Please login to merge, or discard this patch.
src/Mailcode/Commands/Command/ShowURL/AutoTrackingID.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
     {
49 49
         $instanceID = $command->getInstanceID();
50 50
 
51
-        if(isset(self::$generated[$instanceID]))
51
+        if (isset(self::$generated[$instanceID]))
52 52
         {
53 53
             return self::$generated[$instanceID];
54 54
         }
@@ -85,11 +85,11 @@  discard block
 block discarded – undo
85 85
 
86 86
     private static function generateIDString(TrackingIDInterface $command) : string
87 87
     {
88
-        if(isset(self::$customGenerator))
88
+        if (isset(self::$customGenerator))
89 89
         {
90 90
             $result = call_user_func(self::$customGenerator, $command);
91 91
 
92
-            if(is_string($result))
92
+            if (is_string($result))
93 93
             {
94 94
                 return $result;
95 95
             }
Please login to merge, or discard this patch.
src/Mailcode/Parser.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 
73 73
         $result = new ParseResult($collection, $preParser);
74 74
 
75
-        if(!$collection->isValid())
75
+        if (!$collection->isValid())
76 76
         {
77 77
             return $result;
78 78
         }
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
         
85 85
         $total = count($matches[0]);
86 86
 
87
-        for($i=0; $i < $total; $i++)
87
+        for ($i = 0; $i < $total; $i++)
88 88
         {
89 89
             $match = $this->parseMatch($matches, $i);
90 90
             
@@ -154,17 +154,17 @@  discard block
 block discarded – undo
154 154
     private function handleNesting(Mailcode_Commands_Command $cmd) : void
155 155
     {
156 156
         // Set the command's parent from the stack, if any is present.
157
-        if(!empty($this->stack))
157
+        if (!empty($this->stack))
158 158
         {
159 159
             $cmd->setParent($this->getStackLast());
160 160
         }
161 161
 
162 162
         // Handle opening and closing commands, adding and removing from the stack.
163
-        if($cmd instanceof Mailcode_Commands_Command_Type_Opening)
163
+        if ($cmd instanceof Mailcode_Commands_Command_Type_Opening)
164 164
         {
165 165
             $this->stack[] = $cmd;
166 166
         }
167
-        else if($cmd instanceof Mailcode_Commands_Command_Type_Closing)
167
+        else if ($cmd instanceof Mailcode_Commands_Command_Type_Closing)
168 168
         {
169 169
             array_pop($this->stack);
170 170
         }
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
     {
179 179
         $cmd = $this->stack[array_key_last($this->stack)];
180 180
 
181
-        if($cmd instanceof Mailcode_Commands_Command)
181
+        if ($cmd instanceof Mailcode_Commands_Command)
182 182
         {
183 183
             return $cmd;
184 184
         }
@@ -207,16 +207,16 @@  discard block
 block discarded – undo
207 207
         // 5 = parameter type command, type
208 208
         // 6 = parameter type command, params
209 209
         
210
-        if(!empty($matches[1][$index]))
210
+        if (!empty($matches[1][$index]))
211 211
         {
212 212
             $name = $matches[1][$index];
213 213
         }
214
-        else if(!empty($matches[2][$index]))
214
+        else if (!empty($matches[2][$index]))
215 215
         {
216 216
             $name = $matches[2][$index];
217 217
             $params = $matches[3][$index];
218 218
         }
219
-        else if(!empty($matches[4][$index]))
219
+        else if (!empty($matches[4][$index]))
220 220
         {
221 221
             $name = $matches[4][$index];
222 222
             $type = $matches[5][$index];
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
      * @param Mailcode_Commands_Command|null $sourceCommand
254 254
      * @return Mailcode_Parser_Statement
255 255
      */
256
-    public function createStatement(string $statement, bool $freeform=false, ?Mailcode_Commands_Command $sourceCommand=null) : Mailcode_Parser_Statement
256
+    public function createStatement(string $statement, bool $freeform = false, ?Mailcode_Commands_Command $sourceCommand = null) : Mailcode_Parser_Statement
257 257
     {
258 258
         return new Mailcode_Parser_Statement($statement, $freeform, $sourceCommand);
259 259
     }
Please login to merge, or discard this patch.
src/Mailcode/Parser/PreParser.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
      */
117 117
     public static function getContent(int $id) : string
118 118
     {
119
-        if(isset(self::$contents[$id]))
119
+        if (isset(self::$contents[$id]))
120 120
         {
121 121
             return self::$contents[$id];
122 122
         }
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
      */
140 140
     public static function clearContent(int $id) : void
141 141
     {
142
-        if(isset(self::$contents[$id]))
142
+        if (isset(self::$contents[$id]))
143 143
         {
144 144
             unset(self::$contents[$id]);
145 145
         }
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
      */
157 157
     public function parse() : self
158 158
     {
159
-        if($this->parsed)
159
+        if ($this->parsed)
160 160
         {
161 161
             return $this;
162 162
         }
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 
167 167
         $this->detectCommands();
168 168
 
169
-        foreach($this->commands as $commandDef)
169
+        foreach ($this->commands as $commandDef)
170 170
         {
171 171
             $this->processCommand($commandDef);
172 172
         }
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
         $commands = Mailcode::create()->getCommands()->getContentCommands();
188 188
         $result = array();
189 189
 
190
-        foreach($commands as $command)
190
+        foreach ($commands as $command)
191 191
         {
192 192
             $result[] = $command->getName();
193 193
         }
@@ -260,9 +260,9 @@  discard block
 block discarded – undo
260 260
 
261 261
     private function validateCommandContents() : void
262 262
     {
263
-        foreach($this->commands as $command)
263
+        foreach ($this->commands as $command)
264 264
         {
265
-            if(!$command->validateContent($this, $this->collection))
265
+            if (!$command->validateContent($this, $this->collection))
266 266
             {
267 267
                 return;
268 268
             }
@@ -274,12 +274,12 @@  discard block
 block discarded – undo
274 274
         $openingCommands = $this->detectOpeningCommands();
275 275
         $closingCommands = $this->detectClosingCommands();
276 276
 
277
-        if(!$this->validateCommandsList($openingCommands, $closingCommands))
277
+        if (!$this->validateCommandsList($openingCommands, $closingCommands))
278 278
         {
279 279
             return;
280 280
         }
281 281
 
282
-        foreach($openingCommands as $idx => $def)
282
+        foreach ($openingCommands as $idx => $def)
283 283
         {
284 284
             $this->commands[] = new CommandDef(
285 285
                 $def['name'],
@@ -300,20 +300,20 @@  discard block
 block discarded – undo
300 300
         $opening = count($openingCommands);
301 301
         $closing = count($closingCommands);
302 302
         $max = $opening;
303
-        if($closing > $max) {
303
+        if ($closing > $max) {
304 304
             $max = $closing;
305 305
         }
306 306
 
307
-        for($i=0; $i < $max; $i++)
307
+        for ($i = 0; $i < $max; $i++)
308 308
         {
309 309
             // command closed that was never opened
310
-            if(!isset($openingCommands[$i]))
310
+            if (!isset($openingCommands[$i]))
311 311
             {
312 312
                 return $this->addErrorClosedNeverOpened($closingCommands[$i]['matchedText']);
313 313
             }
314 314
 
315 315
             // command opened that was never closed
316
-            if(!isset($closingCommands[$i]))
316
+            if (!isset($closingCommands[$i]))
317 317
             {
318 318
                 return $this->addErrorNeverClosed(
319 319
                     $openingCommands[$i]['matchedText'],
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
             }
323 323
 
324 324
             // command closed does not match opening
325
-            if($openingCommands[$i]['name'] !== $closingCommands[$i]['name'])
325
+            if ($openingCommands[$i]['name'] !== $closingCommands[$i]['name'])
326 326
             {
327 327
                 return $this->addErrorClosingMismatch(
328 328
                     $openingCommands[$i]['name'],
@@ -377,7 +377,7 @@  discard block
 block discarded – undo
377 377
 
378 378
         $result = array();
379 379
 
380
-        foreach($matches[0] as $idx => $matchedText)
380
+        foreach ($matches[0] as $idx => $matchedText)
381 381
         {
382 382
             $result[] = array(
383 383
                 'name' => strtolower(trim((string)$matches[1][$idx])),
@@ -461,7 +461,7 @@  discard block
 block discarded – undo
461 461
             $matchedText,
462 462
             t(
463 463
                 'The command is never closed with a matching %1$s command.',
464
-                sb()->code('{' . $name . '}')
464
+                sb()->code('{'.$name.'}')
465 465
             ),
466 466
             Mailcode_Commands_CommonConstants::VALIDATION_MISSING_CONTENT_CLOSING_TAG
467 467
         );
@@ -485,7 +485,7 @@  discard block
 block discarded – undo
485 485
                 )
486 486
                 ->t(
487 487
                     'It must be closed with a matching %1$s command.',
488
-                    sb()->code('{' . $name . '}')
488
+                    sb()->code('{'.$name.'}')
489 489
                 ),
490 490
             Mailcode_Commands_CommonConstants::VALIDATION_CONTENT_CLOSING_MISMATCHED_TAG
491 491
         );
Please login to merge, or discard this patch.
src/Mailcode/Parser/PreParser/Debugger.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -30,22 +30,22 @@  discard block
 block discarded – undo
30 30
      */
31 31
     public function debugOpeningCommands(array $matches) : void
32 32
     {
33
-        if(!Mailcode::isDebugEnabled())
33
+        if (!Mailcode::isDebugEnabled())
34 34
         {
35 35
             return;
36 36
         }
37 37
 
38 38
         Mailcode::debug('Opening command matches:');
39 39
 
40
-        if(empty($matches))
40
+        if (empty($matches))
41 41
         {
42 42
             Mailcode::debug('...None found.');
43 43
             return;
44 44
         }
45 45
 
46
-        foreach($matches[0] as $idx => $matchedText)
46
+        foreach ($matches[0] as $idx => $matchedText)
47 47
         {
48
-            $number = $idx+1;
48
+            $number = $idx + 1;
49 49
 
50 50
             Mailcode::debug(sprintf('...#%02d matched: [%s]', $number, $matchedText));
51 51
             Mailcode::debug(sprintf('...#%02d name...: [%s]', $number, $matches[1][$idx]));
@@ -59,22 +59,22 @@  discard block
 block discarded – undo
59 59
      */
60 60
     public function debugClosingCommands(array $commands) : void
61 61
     {
62
-        if(!Mailcode::isDebugEnabled())
62
+        if (!Mailcode::isDebugEnabled())
63 63
         {
64 64
             return;
65 65
         }
66 66
 
67 67
         Mailcode::debug('Closing command matches:', $commands);
68 68
 
69
-        if(empty($commands))
69
+        if (empty($commands))
70 70
         {
71 71
             Mailcode::debug('...None found.');
72 72
             return;
73 73
         }
74 74
 
75
-        foreach($commands as $idx => $command)
75
+        foreach ($commands as $idx => $command)
76 76
         {
77
-            $number = $idx+1;
77
+            $number = $idx + 1;
78 78
 
79 79
             Mailcode::debug(sprintf('...#%02d matched: [%s]', $number, $command['matchedText']));
80 80
             Mailcode::debug(sprintf('...#%02d name...: [%s]', $number, $command['name']));
@@ -83,14 +83,14 @@  discard block
 block discarded – undo
83 83
 
84 84
     public function debugCommandDef(CommandDef $commandDef) : void
85 85
     {
86
-        if(!Mailcode::isDebugEnabled())
86
+        if (!Mailcode::isDebugEnabled())
87 87
         {
88 88
             return;
89 89
         }
90 90
 
91 91
         Mailcode::debug('Command definition:', $commandDef->toArray());
92 92
 
93
-        if(defined('TESTS_ROOT'))
93
+        if (defined('TESTS_ROOT'))
94 94
         {
95 95
             print_r($commandDef->toArray());
96 96
         }
Please login to merge, or discard this patch.
src/Mailcode/Collection.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
      */
46 46
     public function addCommand(Mailcode_Commands_Command $command) : Mailcode_Collection
47 47
     {
48
-        if($this->finalized)
48
+        if ($this->finalized)
49 49
         {
50 50
             throw new Mailcode_Exception(
51 51
                 'Cannot add commands to a finalized collection',
@@ -87,9 +87,9 @@  discard block
 block discarded – undo
87 87
     {
88 88
         $keep = array();
89 89
 
90
-        foreach($this->commands as $existing)
90
+        foreach ($this->commands as $existing)
91 91
         {
92
-            if($existing !== $command)
92
+            if ($existing !== $command)
93 93
             {
94 94
                 $keep[] = $existing;
95 95
             }
@@ -126,11 +126,11 @@  discard block
 block discarded – undo
126 126
 
127 127
         $hashes = array();
128 128
         
129
-        foreach($this->commands as $command)
129
+        foreach ($this->commands as $command)
130 130
         {
131 131
             $hash = $command->getHash();
132 132
             
133
-            if(!isset($hashes[$hash]))
133
+            if (!isset($hashes[$hash]))
134 134
             {
135 135
                 $hashes[$hash] = $command;
136 136
             }
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
      */
149 149
     public function addCommands(array $commands) : Mailcode_Collection
150 150
     {
151
-        foreach($commands as $command)
151
+        foreach ($commands as $command)
152 152
         {
153 153
             $this->addCommand($command);
154 154
         }
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
 
172 172
         $collection = new Mailcode_Variables_Collection_Regular();
173 173
         
174
-        foreach($this->commands as $command)
174
+        foreach ($this->commands as $command)
175 175
         {
176 176
             $collection->mergeWith($command->getVariables());
177 177
         }
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
211 211
     {
212 212
         $this->validate();
213 213
 
214
-        if(isset($this->validationResult))
214
+        if (isset($this->validationResult))
215 215
         {
216 216
             return $this->validationResult;
217 217
         }
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
 
226 226
     private function validate() : void
227 227
     {
228
-        if(isset($this->validationResult) || $this->validating)
228
+        if (isset($this->validationResult) || $this->validating)
229 229
         {
230 230
             return;
231 231
         }
@@ -245,9 +245,9 @@  discard block
 block discarded – undo
245 245
     {
246 246
         $errors = $this->getErrors();
247 247
         
248
-        foreach($errors as $error)
248
+        foreach ($errors as $error)
249 249
         {
250
-            if($error->getCode() === $code)
250
+            if ($error->getCode() === $code)
251 251
             {
252 252
                 return true;
253 253
             }
@@ -282,7 +282,7 @@  discard block
 block discarded – undo
282 282
 
283 283
         $errors = $this->errors;
284 284
 
285
-        if(!$result->isValid())
285
+        if (!$result->isValid())
286 286
         {
287 287
             $errors[] = new Mailcode_Collection_Error_Message(
288 288
                 '',
@@ -298,7 +298,7 @@  discard block
 block discarded – undo
298 298
     {
299 299
         $errors = $this->getErrors();
300 300
 
301
-        if(!empty($errors))
301
+        if (!empty($errors))
302 302
         {
303 303
             return array_shift($errors);
304 304
         }
@@ -319,11 +319,11 @@  discard block
 block discarded – undo
319 319
 
320 320
     private function validateNesting() : void
321 321
     {
322
-        foreach($this->commands as $command)
322
+        foreach ($this->commands as $command)
323 323
         {
324 324
             $command->validateNesting();
325 325
 
326
-            if(!$command->isValid()) {
326
+            if (!$command->isValid()) {
327 327
                 $this->addInvalidCommand($command);
328 328
             }
329 329
         }
@@ -400,7 +400,7 @@  discard block
 block discarded – undo
400 400
     {
401 401
         $commands = $this->getCommands();
402 402
         
403
-        if(!empty($commands))
403
+        if (!empty($commands))
404 404
         {
405 405
             return array_shift($commands);
406 406
         }
@@ -432,16 +432,16 @@  discard block
 block discarded – undo
432 432
      */
433 433
     private function pruneProtectedContentCommands() : void
434 434
     {
435
-        if(!$this->isValid())
435
+        if (!$this->isValid())
436 436
         {
437 437
             return;
438 438
         }
439 439
 
440 440
         $keep = array();
441 441
 
442
-        foreach($this->commands as $command)
442
+        foreach ($this->commands as $command)
443 443
         {
444
-            if(!$command->hasContentParent())
444
+            if (!$command->hasContentParent())
445 445
             {
446 446
                 $keep[] = $command;
447 447
             }
@@ -458,7 +458,7 @@  discard block
 block discarded – undo
458 458
         $errors = $this->getErrors();
459 459
         $result = array();
460 460
 
461
-        foreach($errors as $error)
461
+        foreach ($errors as $error)
462 462
         {
463 463
             $result[] = $error->getCode();
464 464
         }
Please login to merge, or discard this patch.
src/Mailcode/Parser/Safeguard/URLAnalyzer.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -58,24 +58,24 @@  discard block
 block discarded – undo
58 58
     private function analyzeURL(string $url) : void
59 59
     {
60 60
         // Ignore phone URLs
61
-        if(stripos($url, 'tel:') !== false)
61
+        if (stripos($url, 'tel:') !== false)
62 62
         {
63 63
             return;
64 64
         }
65 65
 
66 66
         $placeholders = $this->safeguard->getPlaceholdersCollection()->getAll();
67 67
 
68
-        foreach($placeholders as $placeholder)
68
+        foreach ($placeholders as $placeholder)
69 69
         {
70 70
             $command = $placeholder->getCommand();
71 71
 
72 72
             // The URL is not found in the replacement text
73
-            if(strpos($url, $placeholder->getReplacementText()) === false)
73
+            if (strpos($url, $placeholder->getReplacementText()) === false)
74 74
             {
75 75
                 continue;
76 76
             }
77 77
 
78
-            if($command instanceof URLEncodingInterface)
78
+            if ($command instanceof URLEncodingInterface)
79 79
             {
80 80
                 $this->applyEncoding($command);
81 81
             }
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 
85 85
     private function applyEncoding(URLEncodingInterface $command) : void
86 86
     {
87
-        if(!$command->isURLDecoded())
87
+        if (!$command->isURLDecoded())
88 88
         {
89 89
             $command->setURLEncoding();
90 90
         }
Please login to merge, or discard this patch.
src/Mailcode/Parser/Statement/Tokenizer/SpecialChars.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@
 block discarded – undo
101 101
     {
102 102
         $replaces = array();
103 103
 
104
-        foreach(self::$charsEncoded as $char => $placeholder)
104
+        foreach (self::$charsEncoded as $char => $placeholder)
105 105
         {
106 106
             $escaped = self::$charsEscaped[$char];
107 107
 
Please login to merge, or discard this patch.
src/Mailcode/Parser/Statement/Tokenizer/Token/Variable.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
      */
29 29
     public function getVariable() : Mailcode_Variables_Variable
30 30
     {
31
-        if($this->subject instanceof Mailcode_Variables_Variable)
31
+        if ($this->subject instanceof Mailcode_Variables_Variable)
32 32
         {
33 33
             return $this->subject;
34 34
         }
Please login to merge, or discard this patch.