Test Failed
Pull Request — master (#13)
by Sebastian
05:15
created
src/Mailcode/Traits/Commands/Validation/TrackingIDTrait.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
     {
46 46
         $token = $this->getTrackingIDToken();
47 47
 
48
-        if($token === null)
48
+        if ($token === null)
49 49
         {
50 50
             return '';
51 51
         }
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 
59 59
     private function filterTrackingID(string $trackingID) : string
60 60
     {
61
-        if(empty($trackingID))
61
+        if (empty($trackingID))
62 62
         {
63 63
             return AutoTrackingID::generate($this);
64 64
         }
@@ -75,19 +75,19 @@  discard block
 block discarded – undo
75 75
 
76 76
     private function initTrackingToken() : void
77 77
     {
78
-        if(!$this->isTrackingEnabled())
78
+        if (!$this->isTrackingEnabled())
79 79
         {
80 80
             $this->clearTrackingIDToken();
81 81
             return;
82 82
         }
83 83
 
84
-        if(isset($this->trackingIDToken))
84
+        if (isset($this->trackingIDToken))
85 85
         {
86 86
             return;
87 87
         }
88 88
 
89 89
         $token = $this->detectToken();
90
-        if($token === null)
90
+        if ($token === null)
91 91
         {
92 92
             $token = $this->requireParams()
93 93
                 ->getInfo()
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
         $this->trackingIDToken = null;
103 103
 
104 104
         $token = $this->detectToken();
105
-        if($token !== null)
105
+        if ($token !== null)
106 106
         {
107 107
             $this->requireParams()
108 108
                 ->getInfo()
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
     {
115 115
         $token = $this->getTrackingIDToken();
116 116
 
117
-        if($token !== null)
117
+        if ($token !== null)
118 118
         {
119 119
             $token->setText($this->filterTrackingID($trackingID));
120 120
         }
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
             ->getInfo()
129 129
             ->getStringLiterals();
130 130
 
131
-        if(empty($literals))
131
+        if (empty($literals))
132 132
         {
133 133
             return null;
134 134
         }
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
 
138 138
         $id = $trackingID->getText();
139 139
 
140
-        if(strpos($id, '=') === false)
140
+        if (strpos($id, '=') === false)
141 141
         {
142 142
             return $trackingID;
143 143
         }
Please login to merge, or discard this patch.
src/Mailcode/Commands/Command/For.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
 
147 147
         if (!$this->loopVar || !$this->keyword || !$this->sourceVar) {
148 148
             $this->validationResult->makeError(
149
-                t('Not a valid for loop.') . ' ' . t('Is the %1$s keyword missing?', 'in:'),
149
+                t('Not a valid for loop.').' '.t('Is the %1$s keyword missing?', 'in:'),
150 150
                 self::VALIDATION_INVALID_FOR_STATEMENT
151 151
             );
152 152
 
@@ -191,8 +191,8 @@  discard block
 block discarded – undo
191 191
         }
192 192
 
193 193
         $this->validationResult->makeError(
194
-            t('The source variable is not a list variable:') . ' ' .
195
-            t('Expected a variable without dot, like %1$s.', '<code>$' . t('LIST') . '</code>'),
194
+            t('The source variable is not a list variable:').' '.
195
+            t('Expected a variable without dot, like %1$s.', '<code>$'.t('LIST').'</code>'),
196 196
             self::VALIDATION_VARIABLE_NAME_WITH_DOT
197 197
         );
198 198
     }
Please login to merge, or discard this patch.
src/Mailcode/Commands/Command/SetVariable.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
         // allowed ones.
125 125
         if (!in_array($sign, $allowed)) {
126 126
             $this->validationResult->makeError(
127
-                t('The %1$s sign is not allowed in this command.', '<code>' . $sign . '</code>'),
127
+                t('The %1$s sign is not allowed in this command.', '<code>'.$sign.'</code>'),
128 128
                 Mailcode_Commands_CommonConstants::VALIDATION_INVALID_OPERAND
129 129
             );
130 130
         }
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
 
151 151
         throw new Mailcode_Exception(
152 152
             'No variable found.',
153
-            'Statement does not start with a variable: [' . $this->paramsString . ']',
153
+            'Statement does not start with a variable: ['.$this->paramsString.']',
154 154
             Mailcode_Commands_CommonConstants::ERROR_NO_VARIABLE_AVAILABLE
155 155
         );
156 156
     }
Please login to merge, or discard this patch.
src/Mailcode/Exception.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 {
23 23
     public function __construct(string $message, ?string $details = null, $code = null, $previous = null)
24 24
     {
25
-        if(defined('TESTS_ROOT') && !empty($details)) {
25
+        if (defined('TESTS_ROOT') && !empty($details)) {
26 26
             $message .= PHP_EOL.
27 27
                 'Details:'.PHP_EOL.
28 28
                 $details;
Please login to merge, or discard this patch.
src/Mailcode/Parser/Statement/Tokenizer/Process/Variables.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@  discard block
 block discarded – undo
11 11
         $vars = Mailcode::create()->findVariables($this->tokenized, $this->tokenizer->getSourceCommand())->getGroupedByHash();
12 12
 
13 13
         $names = array();
14
-        foreach($vars as $var)
14
+        foreach ($vars as $var)
15 15
         {
16 16
             $names[$var->getMatchedText()] = $var;
17 17
         }
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
             return strlen($b) - strlen($a);
24 24
         });
25 25
 
26
-        foreach($names as $name => $var)
26
+        foreach ($names as $name => $var)
27 27
         {
28 28
             $this->registerToken('Variable', $name, $var);
29 29
         }
Please login to merge, or discard this patch.
src/Mailcode/Variables/Collection.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -62,9 +62,9 @@  discard block
 block discarded – undo
62 62
     {
63 63
         $fullName = $this->fixName($fullName);
64 64
         
65
-        foreach($this->variables as $variable)
65
+        foreach ($this->variables as $variable)
66 66
         {
67
-            if($variable->getFullName() === $fullName)
67
+            if ($variable->getFullName() === $fullName)
68 68
             {
69 69
                 return true;
70 70
             }
@@ -87,9 +87,9 @@  discard block
 block discarded – undo
87 87
         
88 88
         $collection = new Mailcode_Variables_Collection_Regular();
89 89
         
90
-        foreach($this->variables as $variable)
90
+        foreach ($this->variables as $variable)
91 91
         {
92
-            if($variable->getFullName() === $fullName)
92
+            if ($variable->getFullName() === $fullName)
93 93
             {
94 94
                 $collection->add($variable);
95 95
             }
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
     {
120 120
         $entries = array();
121 121
         
122
-        foreach($this->variables as $variable)
122
+        foreach ($this->variables as $variable)
123 123
         {
124 124
             $entries[$variable->getHash()] = $variable;
125 125
         }
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
     {
137 137
         $entries = array();
138 138
         
139
-        foreach($this->variables as $variable)
139
+        foreach ($this->variables as $variable)
140 140
         {
141 141
             $entries[$variable->getFullName()] = $variable;
142 142
         }
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
     {
156 156
         $entries = array();
157 157
 
158
-        foreach($this->variables as $variable)
158
+        foreach ($this->variables as $variable)
159 159
         {
160 160
             $entries[$variable->getUniqueName()] = $variable;
161 161
         }
@@ -180,11 +180,11 @@  discard block
 block discarded – undo
180 180
     {
181 181
         $result = array();
182 182
         
183
-        foreach($this->variables as $variable)
183
+        foreach ($this->variables as $variable)
184 184
         {
185 185
             $name = $variable->getFullName();
186 186
             
187
-            if(!in_array($name, $result))
187
+            if (!in_array($name, $result))
188 188
             {
189 189
                 $result[] = $name;
190 190
             }
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
     {
224 224
         $variables = $collection->getGroupedByHash();
225 225
         
226
-        foreach($variables as $variable)
226
+        foreach ($variables as $variable)
227 227
         {
228 228
             $this->add($variable);
229 229
         }
@@ -235,7 +235,7 @@  discard block
 block discarded – undo
235 235
     {
236 236
         $variables = $this->getAll();
237 237
         
238
-        if(!empty($variables))
238
+        if (!empty($variables))
239 239
         {
240 240
             return array_shift($variables);
241 241
         }
Please login to merge, or discard this patch.
src/Mailcode/Translator/Syntax/ApacheVelocity/ShowSnippet.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
     {
30 30
         $varName = undollarize($command->getVariableName());
31 31
 
32
-        if($command->isHTMLEnabled())
32
+        if ($command->isHTMLEnabled())
33 33
         {
34 34
             $statement = sprintf(
35 35
                 '%s.replaceAll($esc.newline, "<br/>")',
Please login to merge, or discard this patch.
src/Mailcode/Traits/Commands/Validation/ListPropertyVariable.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
         // Split the variable name by the dot
45 45
         $parts = explode('.', undollarize($var->getFullName()));
46 46
 
47
-        if(count($parts) !== 2)
47
+        if (count($parts) !== 2)
48 48
         {
49 49
             $this->validationResult->makeError(
50 50
                 t('The variable %1$s is not a list property:', '<code>'.$var->getFullName().'</code>').' '.
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
      */
77 77
     public function getListVariable() : Mailcode_Variables_Variable
78 78
     {
79
-        if(isset($this->listVariable))
79
+        if (isset($this->listVariable))
80 80
         {
81 81
             return $this->listVariable;
82 82
         }
Please login to merge, or discard this patch.
src/Mailcode/Factory/CommandSets/Set/Misc.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -59,12 +59,12 @@
 block discarded – undo
59 59
      * @throws Mailcode_Exception
60 60
      * @throws Mailcode_Factory_Exception
61 61
      */
62
-    public function for(string $sourceVariable, string $loopVariable, $breakAtValue = ''): Mailcode_Commands_Command_For
62
+    public function for (string $sourceVariable, string $loopVariable, $breakAtValue = ''): Mailcode_Commands_Command_For
63 63
     {
64 64
         $sourceVariable = dollarize($sourceVariable);
65 65
         $loopVariable = dollarize($loopVariable);
66 66
 
67
-        if($breakAtValue instanceof Mailcode_Variables_Variable) {
67
+        if ($breakAtValue instanceof Mailcode_Variables_Variable) {
68 68
             $breakAtValue = $breakAtValue->getFullName();
69 69
         }
70 70
 
Please login to merge, or discard this patch.