Mailcode\Mailcode_Traits_Commands_ProtectedContent

Complexity

Total Complexity

9

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Importance

Changes	4
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	validateSyntax_content_id()	0	16	2
A	getNormalized()	0	3	1
A	getContent()	0	3	1
A	getContentIDToken()	0	3	1
A	getContentTrimmed()	0	3	1
A	loadContent()	0	7	1
A	getContentID()	0	8	2

<?php

declare(strict_types=1);

namespace Mailcode;

/**
 * @see Mailcode_Interfaces_Commands_ProtectedContent
 */
trait Mailcode_Traits_Commands_ProtectedContent
{
    /**
     * @var string
     */
    protected string $content = '';

    public function getContent() : string
    {
        return $this->content;
    }

    public function getContentTrimmed() : string
    {
        return trim($this->content);
    }

    protected ?Mailcode_Parser_Statement_Tokenizer_Token_Number $contentIDToken = null;

    public function getContentIDToken() : ?Mailcode_Parser_Statement_Tokenizer_Token_Number
    {
        return $this->contentIDToken;
    }

    protected function validateSyntax_content_id() : void
    {
        $contentIDToken = $this->requireParams()

It seems like requireParams() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            ->getInfo()
            ->getTokenByIndex(0);

        if($contentIDToken instanceof Mailcode_Parser_Statement_Tokenizer_Token_Number)
        {
            $this->contentIDToken = $contentIDToken;
            $this->loadContent();
            return;
        }

        $this->validationResult->makeError(
            t('The content ID parameter is missing.'),
            Mailcode_Interfaces_Commands_ProtectedContent::VALIDATION_ERROR_CONTENT_ID_MISSING
        );
    }

    public function getContentID() : int
    {
        if(isset($this->contentIDToken))
        {
            return (int)$this->contentIDToken->getValue();

The method getValue() does not exist on null.

        }

        return 0;
    }

    private function loadContent() : void
    {
        $contentID = $this->getContentID();

        $this->content = Mailcode_Parser_PreParser::getContent($contentID);

        Mailcode_Parser_PreParser::clearContent($contentID);
    }

    public function getNormalized() : string
    {
        return (new Mailcode_Commands_Normalizer_ProtectedContent($this))->normalize();

$this of type Mailcode\Mailcode_Traits_Commands_ProtectedContent is incompatible with the type Mailcode\Mailcode_Commands_Command expected by parameter $command of Mailcode\Mailcode_Commands_Normalizer_ProtectedContent::__construct().

    }
}