Passed
Push — master ( 707ba4...19aa6f )
by Sebastian
02:43
created
src/Mailcode/Commands/Command/ShowDate.php 2 patches
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -22,15 +22,15 @@  discard block
 block discarded – undo
22 22
 {
23 23
     const VALIDATION_NOT_A_FORMAT_STRING = 55401;
24 24
     
25
-   /**
26
-    * The date format string.
27
-    * @var string
28
-    */
25
+    /**
26
+     * The date format string.
27
+     * @var string
28
+     */
29 29
     private $formatString;
30 30
     
31
-   /**
32
-    * @var Mailcode_Date_FormatInfo
33
-    */
31
+    /**
32
+     * @var Mailcode_Date_FormatInfo
33
+     */
34 34
     private $formatInfo;
35 35
 
36 36
     public function getName() : string
@@ -90,11 +90,11 @@  discard block
 block discarded – undo
90 90
         );
91 91
     }
92 92
     
93
-   /**
94
-    * Retrieves the format string used to format the date.
95
-    * 
96
-    * @return string A PHP compatible date format string.
97
-    */
93
+    /**
94
+     * Retrieves the format string used to format the date.
95
+     * 
96
+     * @return string A PHP compatible date format string.
97
+     */
98 98
     public function getFormatString() : string
99 99
     {
100 100
         return $this->formatString;
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         $tokens = $this->params->getInfo()->getStringLiterals();
66 66
 
67 67
         // no format specified? Use the default one.
68
-        if(empty($tokens))
68
+        if (empty($tokens))
69 69
         {
70 70
             return;
71 71
         }
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
     {
79 79
         $result = $this->formatInfo->validateFormat($format);
80 80
 
81
-        if($result->isValid())
81
+        if ($result->isValid())
82 82
         {
83 83
             $this->formatString = $format;
84 84
             return;
Please login to merge, or discard this patch.
src/Mailcode/Commands/Command/ShowNumber.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
          $tokens = $this->params->getInfo()->getStringLiterals();
67 67
          
68 68
          // no format specified? Use the default one.
69
-         if(empty($tokens))
69
+         if (empty($tokens))
70 70
          {
71 71
              return;
72 72
          }
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
     {
80 80
         $result = new Mailcode_Number_Info($format);
81 81
 
82
-        if($result->isValid())
82
+        if ($result->isValid())
83 83
         {
84 84
             $this->formatString = $format;
85 85
             return;
Please login to merge, or discard this patch.
Indentation   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -31,10 +31,10 @@  discard block
 block discarded – undo
31 31
     const VALIDATION_INVALID_DECIMAL_SEPARATOR = 72209;
32 32
     const VALIDATION_SEPARATORS_SAME_CHARACTER = 72210;
33 33
     
34
-   /**
35
-    * The default number format string.
36
-    * @var string
37
-    */
34
+    /**
35
+     * The default number format string.
36
+     * @var string
37
+     */
38 38
     private $formatString = Mailcode_Number_Info::DEFAULT_FORMAT;
39 39
     
40 40
     public function getName() : string
@@ -58,16 +58,16 @@  discard block
 block discarded – undo
58 58
 
59 59
     protected function validateSyntax_check_format() : void
60 60
     {
61
-         $tokens = $this->params->getInfo()->getStringLiterals();
61
+            $tokens = $this->params->getInfo()->getStringLiterals();
62 62
          
63
-         // no format specified? Use the default one.
64
-         if(empty($tokens))
65
-         {
66
-             return;
67
-         }
63
+            // no format specified? Use the default one.
64
+            if(empty($tokens))
65
+            {
66
+                return;
67
+            }
68 68
 
69
-         $token = array_pop($tokens);
70
-         $this->parseFormatString($token->getText());
69
+            $token = array_pop($tokens);
70
+            $this->parseFormatString($token->getText());
71 71
     }
72 72
 
73 73
     private function parseFormatString(string $format) : void
@@ -86,11 +86,11 @@  discard block
 block discarded – undo
86 86
         );
87 87
     }
88 88
     
89
-   /**
90
-    * Retrieves the format string used to format the number.
91
-    * 
92
-    * @return string
93
-    */
89
+    /**
90
+     * Retrieves the format string used to format the number.
91
+     * 
92
+     * @return string
93
+     */
94 94
     public function getFormatString() : string
95 95
     {
96 96
         return $this->formatString;
Please login to merge, or discard this patch.
src/Mailcode/Number/Info.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
     {
43 43
         $format = trim($format);
44 44
 
45
-        if(empty($format))
45
+        if (empty($format))
46 46
         {
47 47
             $format = self::DEFAULT_FORMAT;
48 48
         }
@@ -108,15 +108,15 @@  discard block
 block discarded – undo
108 108
     {
109 109
         $format = $this->format;
110 110
 
111
-        foreach($this->validations as $validation)
111
+        foreach ($this->validations as $validation)
112 112
         {
113 113
             $method = 'parse_'.$validation;
114 114
 
115
-            if(method_exists($this, $method))
115
+            if (method_exists($this, $method))
116 116
             {
117 117
                 $format = $this->$method($format);
118 118
 
119
-                if(!$this->isValid())
119
+                if (!$this->isValid())
120 120
                 {
121 121
                     return;
122 122
                 }
@@ -138,13 +138,13 @@  discard block
 block discarded – undo
138 138
 
139 139
     private function parse_padding(string $format) : string
140 140
     {
141
-        if(strstr($format, ':') === false) {
141
+        if (strstr($format, ':') === false) {
142 142
             return $format;
143 143
         }
144 144
 
145 145
         $parts = ConvertHelper::explodeTrim(':', $this->format);
146 146
 
147
-        if(count($parts) !== 2)
147
+        if (count($parts) !== 2)
148 148
         {
149 149
             $this->makeError(
150 150
                 t(
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
 
160 160
         $padding = $parts[1];
161 161
 
162
-        if(!preg_match('/\A[#]+\z/x', $padding))
162
+        if (!preg_match('/\A[#]+\z/x', $padding))
163 163
         {
164 164
             $this->makeError(
165 165
                 t('The padding may only contain hashes (%1$s given).', '<code>'.$padding.'</code>'),
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
 
177 177
     private function parse_number(string $format) : string
178 178
     {
179
-        if($format[0] !== '1')
179
+        if ($format[0] !== '1')
180 180
         {
181 181
             $this->makeError(
182 182
                 t('The first character of the format must be a %1$s.', '<code>1</code>'),
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
         $base = str_replace(array('.', ',', ' '), '', $format);
191 191
         $number = intval(substr($base, 0, 4));
192 192
 
193
-        if($number === 1000) {
193
+        if ($number === 1000) {
194 194
             return $format;
195 195
         }
196 196
 
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
         $separator = $format[1];
211 211
 
212 212
         // No thousands separator
213
-        if($separator === '0')
213
+        if ($separator === '0')
214 214
         {
215 215
             return $format;
216 216
         }
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
         // Valid thousands separator
219 219
         $validSeparators = array(' ', ',', '.');
220 220
 
221
-        if(in_array($separator, $validSeparators))
221
+        if (in_array($separator, $validSeparators))
222 222
         {
223 223
             $this->thousandsSeparator = $separator;
224 224
             $format = str_replace('1'.$separator, '1', $format);
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
 
255 255
     private function parse_separators(string $format) : string
256 256
     {
257
-        if(!empty($this->thousandsSeparator) && !empty($this->decimalsSeparator) && $this->thousandsSeparator === $this->decimalsSeparator)
257
+        if (!empty($this->thousandsSeparator) && !empty($this->decimalsSeparator) && $this->thousandsSeparator === $this->decimalsSeparator)
258 258
         {
259 259
             $this->makeError(
260 260
                 t(
@@ -270,14 +270,14 @@  discard block
 block discarded – undo
270 270
 
271 271
     private function parse_decimals(string $format) : string
272 272
     {
273
-        if(empty($this->decimalsSeparator))
273
+        if (empty($this->decimalsSeparator))
274 274
         {
275 275
             return $format;
276 276
         }
277 277
 
278 278
         $parts = ConvertHelper::explodeTrim($this->decimalsSeparator, $format);
279 279
 
280
-        if(!isset($parts[1]))
280
+        if (!isset($parts[1]))
281 281
         {
282 282
             $this->makeError(
283 283
                 t('Cannot determine the amount of decimals.').' '.
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
             return $format;
294 294
         }
295 295
 
296
-        if($this->validateDecimals($parts[1]))
296
+        if ($this->validateDecimals($parts[1]))
297 297
         {
298 298
             $this->decimals = strlen($parts[1]);
299 299
         }
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
303 303
 
304 304
     private function validateDecimals(string $decimals) : bool
305 305
     {
306
-        if(preg_match('/\A[0]+\z/x', $decimals)) {
306
+        if (preg_match('/\A[0]+\z/x', $decimals)) {
307 307
             return true;
308 308
         }
309 309
 
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
     {
323 323
         $validSeparators = array('.', ',');
324 324
 
325
-        if(in_array($separator, $validSeparators)) {
325
+        if (in_array($separator, $validSeparators)) {
326 326
             return true;
327 327
         }
328 328
 
@@ -344,7 +344,7 @@  discard block
 block discarded – undo
344 344
      */
345 345
     private function parse_regex(string $format) : string
346 346
     {
347
-        if(preg_match('/1[ ,.]?000|1[ ,.]?000[.,][0]+/x', $format))
347
+        if (preg_match('/1[ ,.]?000|1[ ,.]?000[.,][0]+/x', $format))
348 348
         {
349 349
             return $format;
350 350
         }
Please login to merge, or discard this patch.
src/Mailcode/Traits/Commands/IfNumber.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
     {
51 51
         $value = $this->getRawNumber();
52 52
 
53
-        if(!is_numeric($value))
53
+        if (!is_numeric($value))
54 54
         {
55 55
             $this->validationResult->makeError(
56 56
                 t(
Please login to merge, or discard this patch.
src/Mailcode/Translator/Syntax/ApacheVelocity/ShowVariable.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
         $varName = ltrim($command->getVariableName(), '$');
26 26
 
27 27
         // Automatically URL escape the variable if it's in an URL.
28
-        if($command->isURLEncoded())
28
+        if ($command->isURLEncoded())
29 29
         {
30 30
             return sprintf(
31 31
                 '${esc.url($%s)}',
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
             );
34 34
         }
35 35
 
36
-        if($command->isURLDecoded())
36
+        if ($command->isURLDecoded())
37 37
         {
38 38
             return sprintf(
39 39
                 '${esc.unurl($%s)}',
Please login to merge, or discard this patch.
src/Mailcode/Translator/Syntax/ApacheVelocity/ShowSnippet.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
             $varName
35 35
         );
36 36
 
37
-        if($command->isURLEncoded())
37
+        if ($command->isURLEncoded())
38 38
         {
39 39
             return sprintf(
40 40
                 '${esc.url($%s)}',
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
             );
43 43
         }
44 44
 
45
-        if($command->isURLDecoded())
45
+        if ($command->isURLDecoded())
46 46
         {
47 47
             return sprintf(
48 48
                 '${esc.unurl($%s)}',
Please login to merge, or discard this patch.
src/Mailcode/Translator.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
      */
33 33
     public function createSyntax(string $name) : Mailcode_Translator_Syntax
34 34
     {
35
-        if($this->syntaxExists($name))
35
+        if ($this->syntaxExists($name))
36 36
         {
37 37
             return new Mailcode_Translator_Syntax($name);
38 38
         }
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
         $names = $this->getSyntaxNames();
60 60
         $result = array();
61 61
 
62
-        foreach($names as $name)
62
+        foreach ($names as $name)
63 63
         {
64 64
             $result[] = $this->createSyntax($name);
65 65
         }
Please login to merge, or discard this patch.
src/Mailcode/Parser/Statement.php 2 patches
Indentation   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -26,24 +26,24 @@  discard block
 block discarded – undo
26 26
     const VALIDATION_EMPTY = 48801;
27 27
     const VALIDATION_UNQUOTED_STRING_LITERALS = 48802;
28 28
     
29
-   /**
30
-    * @var string
31
-    */
29
+    /**
30
+     * @var string
31
+     */
32 32
     protected $statement;
33 33
     
34
-   /**
35
-    * @var OperationResult
36
-    */
34
+    /**
35
+     * @var OperationResult
36
+     */
37 37
     protected $result;
38 38
     
39
-   /**
40
-    * @var Mailcode_Parser_Statement_Tokenizer
41
-    */
39
+    /**
40
+     * @var Mailcode_Parser_Statement_Tokenizer
41
+     */
42 42
     protected $tokenizer;
43 43
     
44
-   /**
45
-    * @var Mailcode_Parser_Statement_Info|NULL
46
-    */
44
+    /**
45
+     * @var Mailcode_Parser_Statement_Info|NULL
46
+     */
47 47
     protected $info;
48 48
 
49 49
     /**
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
         if($unknown)
113 113
         {
114 114
             $this->result->makeError(
115
-               t('Unquoted string literal found:').' ('.htmlspecialchars($unknown->getMatchedText()).')',
115
+                t('Unquoted string literal found:').' ('.htmlspecialchars($unknown->getMatchedText()).')',
116 116
                 self::VALIDATION_UNQUOTED_STRING_LITERALS
117 117
             );
118 118
         }
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
      */
57 57
     private $sourceCommand;
58 58
 
59
-    public function __construct(string $statement, bool $freeform=false, ?Mailcode_Commands_Command $sourceCommand=null)
59
+    public function __construct(string $statement, bool $freeform = false, ?Mailcode_Commands_Command $sourceCommand = null)
60 60
     {
61 61
         $this->sourceCommand = $sourceCommand;
62 62
         $this->statement = $statement;
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
     
92 92
     public function getInfo() : Mailcode_Parser_Statement_Info
93 93
     {
94
-        if($this->info instanceof Mailcode_Parser_Statement_Info)
94
+        if ($this->info instanceof Mailcode_Parser_Statement_Info)
95 95
         {
96 96
             return $this->info; 
97 97
         }
@@ -103,12 +103,12 @@  discard block
 block discarded – undo
103 103
     
104 104
     protected function validate() : void
105 105
     {
106
-        if($this->freeform)
106
+        if ($this->freeform)
107 107
         {
108 108
             return;
109 109
         }
110 110
 
111
-        if(!$this->tokenizer->hasTokens())
111
+        if (!$this->tokenizer->hasTokens())
112 112
         {
113 113
             $this->result->makeError(
114 114
                 t('Empty statement'),
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
         
121 121
         $unknown = $this->tokenizer->getFirstUnknown();
122 122
         
123
-        if($unknown)
123
+        if ($unknown)
124 124
         {
125 125
             $this->result->makeError(
126 126
                t('Unquoted string literal found:').' ('.htmlspecialchars($unknown->getMatchedText()).')',
Please login to merge, or discard this patch.
src/Mailcode/Commands/ShowBase.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
 
71 71
     protected function validateSyntax_urldeencode() : void
72 72
     {
73
-        if($this->isURLEncoded() && $this->getURLDecodeToken() !== null)
73
+        if ($this->isURLEncoded() && $this->getURLDecodeToken() !== null)
74 74
         {
75 75
             $this->validationResult->makeError(
76 76
                 t('Cannot enable URL decoding and encoding at the same time.'),
Please login to merge, or discard this patch.