Passed
Push — master ( 9adcd8...42367a )
by Sebastian
02:21
created
localization/index.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
     $autoload = realpath($root.'/../vendor/autoload.php');
13 13
     
14 14
     // we need the autoloader to be present
15
-    if($autoload === false) 
15
+    if ($autoload === false) 
16 16
     {
17 17
         die('<b>ERROR:</b> Autoloader not present. Run composer update first.');
18 18
     }
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
      */
23 23
     require_once $autoload;
24 24
     
25
-    if(!class_exists('\AppLocalize\Localization')) 
25
+    if (!class_exists('\AppLocalize\Localization')) 
26 26
     {
27 27
         die(
28 28
             '<b>ERROR:</b> The translation user interface requires the 
Please login to merge, or discard this patch.
src/RequestHelper.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -97,10 +97,10 @@  discard block
 block discarded – undo
97 97
         $contentLength = 0;
98 98
         if (!empty($this->variables)) {
99 99
             foreach ($this->variables as $name => $value) {
100
-                $this->data .= '--' . $this->mimeBoundary . $this->eol;
101
-                $this->data .= 'Content-Disposition: form-data; name="' . $name . '"' . $this->eol;
100
+                $this->data .= '--'.$this->mimeBoundary.$this->eol;
101
+                $this->data .= 'Content-Disposition: form-data; name="'.$name.'"'.$this->eol;
102 102
                 $this->data .= $this->eol;
103
-                $this->data .= $value . $this->eol;
103
+                $this->data .= $value.$this->eol;
104 104
 
105 105
                 $contentLength += strlen($value);
106 106
             }
@@ -108,17 +108,17 @@  discard block
 block discarded – undo
108 108
 
109 109
         if (!empty($this->files)) {
110 110
             foreach ($this->files as $varName => $def) {
111
-                $this->data .= '--' . $this->mimeBoundary . $this->eol;
112
-                $this->data .= 'Content-Disposition: form-data; name="' . $varName . '"; filename="' . $def['fileName'] . '"' . $this->eol;
113
-                $this->data .= 'Content-Type: ' . $def['contentType'] . '; charset=' . $def['encoding'];
114
-                $this->data .= $this->eol . $this->eol;
115
-                $this->data .= $def['content'] . $this->eol;
111
+                $this->data .= '--'.$this->mimeBoundary.$this->eol;
112
+                $this->data .= 'Content-Disposition: form-data; name="'.$varName.'"; filename="'.$def['fileName'].'"'.$this->eol;
113
+                $this->data .= 'Content-Type: '.$def['contentType'].'; charset='.$def['encoding'];
114
+                $this->data .= $this->eol.$this->eol;
115
+                $this->data .= $def['content'].$this->eol;
116 116
 
117 117
                 $contentLength += strlen($def['content']);
118 118
             }
119 119
         }
120 120
 
121
-        $this->data .= "--" . $this->mimeBoundary . "--" . $this->eol . $this->eol; // finish with two eol's!!
121
+        $this->data .= "--".$this->mimeBoundary."--".$this->eol.$this->eol; // finish with two eol's!!
122 122
 
123 123
         //echo '<pre>'.print_r($this->data,true).'</pre>';
124 124
 
@@ -126,8 +126,8 @@  discard block
 block discarded – undo
126 126
             'http' => array(
127 127
                 'method' => 'POST',
128 128
                 'header' =>
129
-                    'Content-Length: ' . $contentLength . $this->eol .
130
-                    'Content-Type: multipart/form-data; charset=UTF-8; boundary=' . $this->mimeBoundary . $this->eol
129
+                    'Content-Length: '.$contentLength.$this->eol.
130
+                    'Content-Type: multipart/form-data; charset=UTF-8; boundary='.$this->mimeBoundary.$this->eol
131 131
             ,
132 132
                 'content' => $this->data
133 133
             )
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
             $errorMessage = error_get_last();
142 142
             throw new RequestHelper_Exception(
143 143
                 'Request failed.',
144
-                'Request error message: ' . $errorMessage['message'] . ' in ' . $errorMessage['file'] . ':' . $errorMessage['line'],
144
+                'Request error message: '.$errorMessage['message'].' in '.$errorMessage['file'].':'.$errorMessage['line'],
145 145
                 self::ERROR_REQUEST_FAILED
146 146
             );
147 147
         }
Please login to merge, or discard this patch.
src/functions.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -8,9 +8,9 @@  discard block
 block discarded – undo
8 8
  * @param mixed $value
9 9
  * @return \AppUtils\NumberInfo
10 10
  */
11
-function parseNumber($value, $forceNew=false)
11
+function parseNumber($value, $forceNew = false)
12 12
 {
13
-    if($value instanceof NumberInfo && $forceNew !== true) {
13
+    if ($value instanceof NumberInfo && $forceNew !== true) {
14 14
         return $value;
15 15
     }
16 16
     
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
     $args = func_get_args();
80 80
     
81 81
     // is the localization package installed?
82
-    if(class_exists('\AppLocalize\Localization')) 
82
+    if (class_exists('\AppLocalize\Localization')) 
83 83
     {
84 84
         return call_user_func_array('\AppLocalize\t', $args);
85 85
     }
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
  */
96 96
 function init()
97 97
 {
98
-    if(!class_exists('\AppLocalize\Localization')) {
98
+    if (!class_exists('\AppLocalize\Localization')) {
99 99
         return;
100 100
     }
101 101
     
Please login to merge, or discard this patch.
src/SVNHelper.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
     {
66 66
         $this->isWindows = substr(PHP_OS, 0, 3) == 'WIN';
67 67
         
68
-        if($this->isWindows) {
68
+        if ($this->isWindows) {
69 69
             $this->normalize['from'] = '/';
70 70
             $this->normalize['to'] = '\\';
71 71
         }
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
         //
81 81
         // NOTE: In case of symlinks, this resolves the symlink to its source (WIN/NIX)
82 82
         $realPath = realpath($this->sourcePath);
83
-        if(!is_dir($realPath)) {
83
+        if (!is_dir($realPath)) {
84 84
             throw new SVNHelper_Exception(
85 85
                 'Local repository path does not exist',
86 86
                 sprintf(
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
         $result = array();
99 99
         preg_match_all('%([^:]+):(.+)@(https|http|svn)://(.+)%sm', $repURL, $result, PREG_PATTERN_ORDER);
100 100
         
101
-        if(!isset($result[1]) || !isset($result[1][0])) {
101
+        if (!isset($result[1]) || !isset($result[1][0])) {
102 102
             throw new SVNHelper_Exception(
103 103
                 'Invalid SVN repository URL',
104 104
                 'The SVN URL must have the following format: [username:password@http://domain.com/path/to/rep].',
@@ -131,18 +131,18 @@  discard block
 block discarded – undo
131 131
     * @throws SVNHelper_Exception
132 132
     * @return string
133 133
     */
134
-    public function normalizePath($path, $relativize=false)
134
+    public function normalizePath($path, $relativize = false)
135 135
     {
136
-        if(empty($path)) {
136
+        if (empty($path)) {
137 137
             return '';
138 138
         }
139 139
         
140
-        if($relativize) 
140
+        if ($relativize) 
141 141
         {
142 142
             $path = $this->normalizePath($path);
143 143
 
144 144
             // path is absolute, and does not match the realpath or the source path?
145
-            if(strstr($path, ':'.$this->getSlash()) && (!stristr($path, $this->path) && !stristr($path, $this->sourcePath))) {
145
+            if (strstr($path, ':'.$this->getSlash()) && (!stristr($path, $this->path) && !stristr($path, $this->sourcePath))) {
146 146
                 throw new SVNHelper_Exception(
147 147
                     'Cannot relativize path outside of repository',
148 148
                     sprintf(
@@ -223,14 +223,14 @@  discard block
 block discarded – undo
223 223
     */
224 224
     protected function filterPath($path)
225 225
     {
226
-        if(empty($path)) {
226
+        if (empty($path)) {
227 227
             return '';
228 228
         }
229 229
         
230 230
         $path = $this->getPath().'/'.$this->relativizePath($path);
231 231
         
232 232
         $real = realpath($path);
233
-        if($real !== false) {
233
+        if ($real !== false) {
234 234
             return $real;
235 235
         }
236 236
         
@@ -257,13 +257,13 @@  discard block
 block discarded – undo
257 257
         $key = $type.':'.$relativePath;
258 258
         
259 259
         $relativePath = $this->normalizePath($relativePath, true);
260
-        if(isset($this->targets[$key])) {
260
+        if (isset($this->targets[$key])) {
261 261
             return $this->targets[$key];
262 262
         }
263 263
 
264 264
         $target = null;
265 265
         
266
-        switch($type)
266
+        switch ($type)
267 267
         {
268 268
             case 'File':
269 269
                 $target = new SVNHelper_Target_File($this, $relativePath);
@@ -396,7 +396,7 @@  discard block
 block discarded – undo
396 396
     */
397 397
     public function addFolder($path)
398 398
     {
399
-        if(is_dir($path)) {
399
+        if (is_dir($path)) {
400 400
             return $this->getFolder($path);
401 401
         }
402 402
         
@@ -404,12 +404,12 @@  discard block
 block discarded – undo
404 404
         $tokens = explode($this->getSlash(), $path);
405 405
         
406 406
         $target = $this->path;
407
-        foreach($tokens as $folder) 
407
+        foreach ($tokens as $folder) 
408 408
         {
409 409
             $target .= $this->getSlash().$folder;
410
-            if(file_exists($target)) 
410
+            if (file_exists($target)) 
411 411
             {
412
-                if(!is_dir($target)) {
412
+                if (!is_dir($target)) {
413 413
                     throw new SVNHelper_Exception(
414 414
                         'Target folder is a file',
415 415
                         sprintf(
@@ -423,7 +423,7 @@  discard block
 block discarded – undo
423 423
                 continue;
424 424
             }
425 425
             
426
-            if(!mkdir($target, 0777)) {
426
+            if (!mkdir($target, 0777)) {
427 427
                 throw new SVNHelper_Exception(
428 428
                     'Cannot create folder',
429 429
                     sprintf(
@@ -453,7 +453,7 @@  discard block
 block discarded – undo
453 453
     */
454 454
     public static function setLogCallback($callback)
455 455
     {
456
-        if(!is_callable($callback)) {
456
+        if (!is_callable($callback)) {
457 457
             throw new SVNHelper_Exception(
458 458
                 'Not a valid logging callback',
459 459
                 'The specified argument is not callable.',
@@ -466,7 +466,7 @@  discard block
 block discarded – undo
466 466
     
467 467
     public static function log($message)
468 468
     {
469
-        if(isset(self::$logCallback)) {
469
+        if (isset(self::$logCallback)) {
470 470
             call_user_func(self::$logCallback, 'SVNHelper | '.$message);
471 471
         }
472 472
     }
Please login to merge, or discard this patch.
src/SVNHelper/Exception.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
     
18 18
     protected $logging = true;
19 19
     
20
-    public function __construct($message, $details=null, $code=null, $previous=null)
20
+    public function __construct($message, $details = null, $code = null, $previous = null)
21 21
     {
22 22
         parent::__construct($message, $details, $code, $previous);
23 23
         
@@ -31,17 +31,17 @@  discard block
 block discarded – undo
31 31
     
32 32
     public function __destruct()
33 33
     {
34
-        if(!$this->logging) {
34
+        if (!$this->logging) {
35 35
             return;
36 36
         }
37 37
         
38 38
         $loggers = SVNHelper::getExceptionLoggers();
39 39
         
40
-        if(empty($loggers)) {
40
+        if (empty($loggers)) {
41 41
             return;
42 42
         }
43 43
         
44
-        foreach($loggers as $callback) {
44
+        foreach ($loggers as $callback) {
45 45
             call_user_func($callback, $this);
46 46
         }
47 47
     }
Please login to merge, or discard this patch.
src/SVNHelper/CommandError.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@
 block discarded – undo
101 101
     public function hasAnyErrorCode($codes)
102 102
     {
103 103
         $items = array();
104
-        foreach($codes as $code) {
104
+        foreach ($codes as $code) {
105 105
             $items[] = ltrim($code, 'e');
106 106
         }
107 107
         
Please login to merge, or discard this patch.
src/SVNHelper/Target.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
         $this->url = $this->helper->getURL().'/'.$this->relativePath;
29 29
         
30 30
         $path = $this->helper->getPath();
31
-        if(!empty($relativePath)) {
31
+        if (!empty($relativePath)) {
32 32
             $path .= $this->helper->getSlash().$this->relativePath;
33 33
         }
34 34
         
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
         // this is relevant).
39 39
         $this->path = realpath($path);
40 40
         
41
-        if(!$this->path || !file_exists($this->path)) {
41
+        if (!$this->path || !file_exists($this->path)) {
42 42
             throw new SVNHelper_Exception(
43 43
                 'File not found',
44 44
                 sprintf(
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
     
147 147
     public function runAdd()
148 148
     {
149
-        if(!$this->isVersioned()) {
149
+        if (!$this->isVersioned()) {
150 150
             $this->createAdd()->execute();
151 151
             $this->clearCache();
152 152
         }
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
     */
177 177
     public function getInfo()
178 178
     {
179
-        if(!isset($this->cache['info'])) {
179
+        if (!isset($this->cache['info'])) {
180 180
             $this->cache['info'] = $this->helper->createInfo($this);
181 181
         }
182 182
         
@@ -194,12 +194,12 @@  discard block
 block discarded – undo
194 194
     */
195 195
     public function runCommit($message)
196 196
     {
197
-        if(!$this->isVersioned()) {
197
+        if (!$this->isVersioned()) {
198 198
             $this->log('Adding the unversioned file.');
199 199
             $this->runAdd();
200 200
         }
201 201
         
202
-        if(!$this->isCommitted()) {
202
+        if (!$this->isCommitted()) {
203 203
             $this->createCommit($message)->execute();
204 204
             $this->clearCache();
205 205
         }
Please login to merge, or discard this patch.
src/SVNHelper/CommandException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
      */
19 19
     protected $result;
20 20
     
21
-    public function __construct($message, $details, $code, SVNHelper_CommandResult $result, $previous=null)
21
+    public function __construct($message, $details, $code, SVNHelper_CommandResult $result, $previous = null)
22 22
     {
23 23
         parent::__construct($message, $details, $code, $previous);
24 24
         $this->result = $result;
Please login to merge, or discard this patch.
src/SVNHelper/Command.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
     
57 57
     public function execute()
58 58
     {
59
-        if(isset($this->result)) {
59
+        if (isset($this->result)) {
60 60
             return $this->result;
61 61
         }
62 62
         
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
         putenv('LC_ALL='.$locale);
67 67
         
68 68
         $this->result = $this->_execute();
69
-        if(!$this->result instanceof SVNHelper_CommandResult) {
69
+        if (!$this->result instanceof SVNHelper_CommandResult) {
70 70
             throw new SVNHelper_Exception(
71 71
                 'Not a valid SVN command result',
72 72
                 sprintf(
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
     
83 83
     abstract protected function _execute();
84 84
 
85
-    protected function buildCommand($mode, $path=null, $params=array())
85
+    protected function buildCommand($mode, $path = null, $params = array())
86 86
     {
87 87
         $params[] = 'non-interactive';
88 88
         $params[] = 'username '.$this->helper->getAuthUser();
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
         
91 91
         $cmd = 'svn '.$mode.' '.$path.' ';
92 92
         
93
-        foreach($params as $param) {
93
+        foreach ($params as $param) {
94 94
             $cmd .= '--'.$param.' ';
95 95
         }
96 96
         
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
     * @param array $params
109 109
     * @return SVNHelper_CommandResult
110 110
     */
111
-    protected function execCommand($mode, $path=null, $params=array())
111
+    protected function execCommand($mode, $path = null, $params = array())
112 112
     {
113 113
         $relative = $this->helper->relativizePath($path);
114 114
         
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
         exec($cmd, $output);
124 124
         
125 125
         $lines = array();
126
-        foreach($output as $line) {
126
+        foreach ($output as $line) {
127 127
             $lines[] = mb_strtolower(trim(utf8_encode($line)));
128 128
         }
129 129
         
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
         //
136 136
         // Can happen for example when the path is not under version
137 137
         // control.
138
-        if(isset($lines[0]) && substr($lines[0], 0, 7) == 'skipped')
138
+        if (isset($lines[0]) && substr($lines[0], 0, 7) == 'skipped')
139 139
         {
140 140
             $tokens = explode('--', $lines[0]);
141 141
             $message = trim(array_pop($tokens));
@@ -156,20 +156,20 @@  discard block
 block discarded – undo
156 156
         // svn: w123456: warning message
157 157
         else
158 158
         {
159
-            foreach($lines as $line) 
159
+            foreach ($lines as $line) 
160 160
             {
161
-                if(strstr($line, 'svn:')) 
161
+                if (strstr($line, 'svn:')) 
162 162
                 {
163 163
                     $result = array();
164 164
                     preg_match_all('/svn:[ ]*(e|warning:[ ]*w)([0-9]+):(.*)/', $line, $result, PREG_PATTERN_ORDER);
165 165
                     
166
-                    if(isset($result[1]) && isset($result[1][0])) 
166
+                    if (isset($result[1]) && isset($result[1][0])) 
167 167
                     {
168 168
                         $message = trim($result[3][0]);
169 169
                         $code = trim($result[2][0]);
170 170
                         $type = self::SVN_ERROR_TYPE_ERROR;
171 171
                         
172
-                        if($result[1][0] != 'e') {
172
+                        if ($result[1][0] != 'e') {
173 173
                             $type = self::SVN_ERROR_TYPE_WARNING;
174 174
                         }
175 175
 
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
         
183 183
         $result = new SVNHelper_CommandResult($this, $cmd, $lines, $errorMessages);
184 184
         
185
-        if($result->isError()) {
185
+        if ($result->isError()) {
186 186
             $this->log(sprintf('[%s] | Command returned errors.', $relative));
187 187
         } 
188 188
         
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
     
206 206
     protected function throwExceptionUnexpected(SVNHelper_CommandResult $result)
207 207
     {
208
-        if($result->isConnectionFailed()) {
208
+        if ($result->isConnectionFailed()) {
209 209
             $this->throwException(
210 210
                 t('Could not connect to the remote SVN repository'), 
211 211
                 '', 
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
214 214
             );
215 215
         }
216 216
         
217
-        if($result->hasConflicts()) {
217
+        if ($result->hasConflicts()) {
218 218
             $this->throwException(
219 219
                 t('SVN command reported conflicts'), 
220 220
                 '', 
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
             );
224 224
         }
225 225
         
226
-        if($result->hasLocks()) {
226
+        if ($result->hasLocks()) {
227 227
             $this->throwException(
228 228
                 t('The target SVN folder or file is locked.'), 
229 229
                 '', 
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
         );
241 241
     }
242 242
     
243
-    protected function throwException($message, $details, $code, SVNHelper_CommandResult $result, $previous=null)
243
+    protected function throwException($message, $details, $code, SVNHelper_CommandResult $result, $previous = null)
244 244
     {
245 245
         $body = 
246 246
         '<p>'.
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
         '</p>'.
256 256
         '<ul>';
257 257
             $errors = $result->getErrorMessages();
258
-            foreach($errors as $error) {
258
+            foreach ($errors as $error) {
259 259
                 $body .= 
260 260
                 '<li>'.
261 261
                     $error.
Please login to merge, or discard this patch.