AppUtils\HTMLHelper::injectAtEnd()

Complexity

Conditions	3
Paths	3

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function injectAtEnd(string $text, string $html) : string
    {
        preg_match_all('%<([A-Z][A-Z0-9]*)\b[^>]*>(.*?)</\1>%si', $html, $result, PREG_PATTERN_ORDER);

        if(empty($result[1])) {
            return '<p>'.$text.'</p>';
        }

        $tagName = array_pop($result[1]);
        $pos = strrpos($html, '</'.$tagName.'>');

        if(in_array(strtolower($tagName), self::$newParaTags)) {
            $replace = '</'.$tagName.'><p>'.$text.'</p>';
        } else {
            $replace = $text.'</'.$tagName.'>';
        }

        return substr_replace($html, $replace, $pos, strlen($html));

The expression return substr_replace($html, $replace, $pos, strlen($html)) could return the type array which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }