URLInfo_Normalizer::normalize_url() - Code Metrics - Inspection of "Moved the normalizing out to a separate class." - Mistralys/application-utils - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 7ae6f1...8efc25 )

by Sebastian

created 2020-01-04 18:46 UTC

URLInfo_Normalizer::normalize_url() A

↳ Parent: URLInfo_Normalizer

Complexity

Conditions	4
Paths	8

Size

Total Lines	18
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	9
c	1
b	0
f	0
nc	8
nop	0
dl	0
loc	18
rs	9.9666

<?php
/**
 * File containing the {@see AppUtils\URLInfo_Normalizer} class.
 *
 * @package Application Utils
 * @subpackage URLInfo
 * @see AppUtils\URLInfo_Normalizer
 */

declare(strict_types=1);

namespace AppUtils;

/**
 * Handles normalizing an URL.
 *
 * @package Application Utils
 * @subpackage URLInfo
 * @author Sebastian Mordziol <[email protected]>
 */
class URLInfo_Normalizer
{
    /**
     * @var URLInfo
     */
    protected $info;
    
    public function __construct(URLInfo $info)
    {
        $this->info = $info;
    }
    
    public function normalize() : string
    {
        $method = 'normalize_'.$this->info->getType();
        
        return (string)$this->$method();
    }
    
    protected function normalize_fragment() : string
    {
        return '#'.$this->info->getFragment();
    }
    
    protected function normalize_phone() : string
    {
        return 'tel://'.$this->info->getHost();
    }
    
    protected function normalize_email() : string
    {
        return 'mailto:'.$this->info->getPath();
    }
    
    protected function normalize_url() : string
    {
        $normalized = $this->info->getScheme().'://'.$this->info->getHost();
        
        if($this->info->hasPath()) {
            $normalized .= $this->info->getPath();
        }
        
        $params = $this->info->getParams();
        if(!empty($params)) {
            $normalized .= '?'.http_build_query($params);
        }
        
        if($this->info->hasFragment()) {
            $normalized .= '#'.$this->info->getFragment();
        }
        
        return $normalized;
    }
}


1			<?php
2			/**
3			* File containing the {@see AppUtils\URLInfo_Normalizer} class.
4			*
5			* @package Application Utils
6			* @subpackage URLInfo
7			* @see AppUtils\URLInfo_Normalizer
8			*/
9
10			declare(strict_types=1);
11
12			namespace AppUtils;
13
14			/**
15			* Handles normalizing an URL.
16			*
17			* @package Application Utils
18			* @subpackage URLInfo
19			* @author Sebastian Mordziol <[email protected]>
20			*/
21			class URLInfo_Normalizer
22			{
23			/**
24			* @var URLInfo
25			*/
26			protected $info;
27
28			public function __construct(URLInfo $info)
29			{
30			$this->info = $info;
31			}
32
33			public function normalize() : string
34			{
35			$method = 'normalize_'.$this->info->getType();
36
37			return (string)$this->$method();
38			}
39
40			protected function normalize_fragment() : string
41			{
42			return '#'.$this->info->getFragment();
43			}
44
45			protected function normalize_phone() : string
46			{
47			return 'tel://'.$this->info->getHost();
48			}
49
50			protected function normalize_email() : string
51			{
52			return 'mailto:'.$this->info->getPath();
53			}
54
55			protected function normalize_url() : string
56			{
57			$normalized = $this->info->getScheme().'://'.$this->info->getHost();
58
59			if($this->info->hasPath()) {
60			$normalized .= $this->info->getPath();
61			}
62
63			$params = $this->info->getParams();
64			if(!empty($params)) {
65			$normalized .= '?'.http_build_query($params);
66			}
67
68			if($this->info->hasFragment()) {
69			$normalized .= '#'.$this->info->getFragment();
70			}
71
72			return $normalized;
73			}
74			}
75

Mistralys / application-utils

Push — master ( 7ae6f1...8efc25 )

URLInfo_Normalizer::normalize_url() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like