Passed
Pull Request — master (#4)
by
unknown
05:15
created
src/IniHelper.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -35,12 +35,12 @@  discard block
 block discarded – undo
35 35
     {
36 36
         $section = $this->addSection(self::SECTION_DEFAULT);
37 37
         
38
-        if(empty($iniString)) {
38
+        if (empty($iniString)) {
39 39
             return;
40 40
         }
41 41
         
42 42
         $eol = ConvertHelper::detectEOLCharacter($iniString);
43
-        if($eol !== null) {
43
+        if ($eol !== null) {
44 44
             $this->eol = $eol->getCharacter();
45 45
         }
46 46
         
@@ -48,11 +48,11 @@  discard block
 block discarded – undo
48 48
         
49 49
         $total = count($lines);
50 50
         
51
-        for($i=0; $i < $total; $i++) 
51
+        for ($i = 0; $i < $total; $i++) 
52 52
         {
53 53
             $line = new IniHelper_Line($lines[$i], $i);
54 54
             
55
-            if($line->isSection()) {
55
+            if ($line->isSection()) {
56 56
                 $section = $this->addSection($line->getSectionName());
57 57
             }
58 58
 
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
         $iniPath = FileHelper::requireFileExists($iniPath);
83 83
         
84 84
         $content = file_get_contents($iniPath);
85
-        if($content !== false) {
85
+        if ($content !== false) {
86 86
             return self::createFromString($content);
87 87
         }
88 88
         
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
     */
128 128
     public function addSection(string $name) : IniHelper_Section
129 129
     {
130
-        if(!isset($this->sections[$name])) {
130
+        if (!isset($this->sections[$name])) {
131 131
             $this->sections[$name] = new IniHelper_Section($this, $name);
132 132
         }
133 133
         
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
     */
143 143
     public function getSection(string $name) : ?IniHelper_Section
144 144
     {
145
-        if(isset($this->sections[$name])) {
145
+        if (isset($this->sections[$name])) {
146 146
             return $this->sections[$name];
147 147
         }
148 148
         
@@ -158,9 +158,9 @@  discard block
 block discarded – undo
158 158
     {
159 159
         $result = array();
160 160
         
161
-        foreach($this->sections as $section)
161
+        foreach ($this->sections as $section)
162 162
         {
163
-            if($section->isDefault()) 
163
+            if ($section->isDefault()) 
164 164
             {
165 165
                 $result = array_merge($result, $section->toArray());
166 166
             } 
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
     {
201 201
         $parts = array();
202 202
         
203
-        foreach($this->sections as $section)
203
+        foreach ($this->sections as $section)
204 204
         {
205 205
             $parts[] = $section->toString();
206 206
         }
@@ -243,8 +243,8 @@  discard block
 block discarded – undo
243 243
     */
244 244
     public function sectionExists(string $name) : bool
245 245
     {
246
-        foreach($this->sections as $section) {
247
-            if($section->getName() === $name) {
246
+        foreach ($this->sections as $section) {
247
+            if ($section->getName() === $name) {
248 248
                 return true;
249 249
             }
250 250
         }
@@ -273,7 +273,7 @@  discard block
 block discarded – undo
273 273
     {
274 274
         $path = $this->parsePath($path);
275 275
         
276
-        if(!$this->sectionExists($path['section'])) {
276
+        if (!$this->sectionExists($path['section'])) {
277 277
             return array();
278 278
         }
279 279
         
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
284 284
     {
285 285
         $path = explode($this->pathSeparator, $path);
286 286
         
287
-        if(count($path) === 1)
287
+        if (count($path) === 1)
288 288
         {
289 289
             return array(
290 290
                 'section' => self::SECTION_DEFAULT,
Please login to merge, or discard this patch.
src/JSHelper.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -95,20 +95,20 @@  discard block
 block discarded – undo
95 95
         $quoteStyle = array_shift($params);
96 96
         $method = array_shift($params);
97 97
         
98
-        $call = $method . '(';
98
+        $call = $method.'(';
99 99
         
100 100
         $total = count($params);
101
-        if($total > 0) {
102
-            for($i=0; $i < $total; $i++) 
101
+        if ($total > 0) {
102
+            for ($i = 0; $i < $total; $i++) 
103 103
             {
104 104
                 $call .= self::phpVariable2JS($params[$i], $quoteStyle);
105
-                if($i < ($total-1)) {
105
+                if ($i < ($total - 1)) {
106 106
                     $call .= ',';
107 107
                 }
108 108
             }
109 109
         }
110 110
         
111
-        return $call . ');';
111
+        return $call.');';
112 112
     }
113 113
 
114 114
    /**
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
     */
133 133
     public static function buildVariable(string $varName, $varValue) : string
134 134
     {
135
-        return $varName . "=" . self::phpVariable2JS($varValue) . ';';
135
+        return $varName."=".self::phpVariable2JS($varValue).';';
136 136
     }
137 137
     
138 138
    /**
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
     * @param int $quoteStyle The quote style to use for strings
145 145
     * @return string
146 146
     */
147
-    public static function phpVariable2JS($variable, int $quoteStyle=self::QUOTE_STYLE_DOUBLE) : string
147
+    public static function phpVariable2JS($variable, int $quoteStyle = self::QUOTE_STYLE_DOUBLE) : string
148 148
     {
149 149
         // after much profiling, this variant of the method offers
150 150
         // the best performance. Repeat scalar values are cached 
@@ -152,22 +152,22 @@  discard block
 block discarded – undo
152 152
         
153 153
         $type = gettype($variable);
154 154
         $hash = null;
155
-        if(is_scalar($variable) === true) 
155
+        if (is_scalar($variable) === true) 
156 156
         {
157 157
             $hash = $variable;
158 158
         
159
-            if($hash === true) 
159
+            if ($hash === true) 
160 160
             { 
161 161
                 $hash = 'true'; 
162 162
             } 
163
-            else if($hash === false) 
163
+            else if ($hash === false) 
164 164
             { 
165 165
                 $hash = 'false'; 
166 166
             }
167 167
             
168 168
             $hash .= '-'.$quoteStyle.'-'.$type;
169 169
             
170
-            if(isset(self::$variableCache[$hash])) {
170
+            if (isset(self::$variableCache[$hash])) {
171 171
                 return self::$variableCache[$hash];
172 172
             }
173 173
         }
@@ -175,19 +175,19 @@  discard block
 block discarded – undo
175 175
         $result = 'null';
176 176
 
177 177
         // one gettype call is better than a strict if-else.
178
-        switch($type) 
178
+        switch ($type) 
179 179
         {
180 180
             case 'double':
181 181
             case 'string':
182 182
                 $string = json_encode($variable);
183 183
                 
184
-                if($string === false) 
184
+                if ($string === false) 
185 185
                 {
186 186
                     $string = '';
187 187
                 } 
188
-                else if($quoteStyle === self::QUOTE_STYLE_SINGLE) 
188
+                else if ($quoteStyle === self::QUOTE_STYLE_SINGLE) 
189 189
                 {
190
-                    $string = mb_substr($string, 1, mb_strlen($string)-2);
190
+                    $string = mb_substr($string, 1, mb_strlen($string) - 2);
191 191
                     $string = "'".str_replace("'", "\'", $string)."'";
192 192
                 }
193 193
                 
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
                 break;
196 196
                 
197 197
             case 'boolean':
198
-                if($variable === true) {
198
+                if ($variable === true) {
199 199
                     $result = 'true';
200 200
                 } else {
201 201
                     $result = 'false';
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
         }
214 214
 
215 215
         // cache cacheable values
216
-        if($hash !== null) 
216
+        if ($hash !== null) 
217 217
         {
218 218
             self::$variableCache[$hash] = $result;
219 219
         }
@@ -245,7 +245,7 @@  discard block
 block discarded – undo
245 245
     {
246 246
         self::$elementCounter++;
247 247
 
248
-        return self::$idPrefix . self::$elementCounter;
248
+        return self::$idPrefix.self::$elementCounter;
249 249
     }
250 250
     
251 251
    /**
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
319 319
      * @see JSHelper::JS_REGEX_OBJECT
320 320
      * @see JSHelper::JS_REGEX_JSON
321 321
      */
322
-    public static function buildRegexStatement(string $regex, string $statementType=self::JS_REGEX_OBJECT) : string
322
+    public static function buildRegexStatement(string $regex, string $statementType = self::JS_REGEX_OBJECT) : string
323 323
     {
324 324
         $regex = trim($regex);
325 325
         $separator = substr($regex, 0, 1);
@@ -327,7 +327,7 @@  discard block
 block discarded – undo
327 327
         array_shift($parts);
328 328
         
329 329
         $modifiers = array_pop($parts);
330
-        if($modifiers == $separator) {
330
+        if ($modifiers == $separator) {
331 331
             $modifiers = '';
332 332
         }
333 333
         
@@ -343,7 +343,7 @@  discard block
 block discarded – undo
343 343
         // convert the anchors that are not supported in js regexes
344 344
         $format = str_replace(array('\\A', '\\Z', '\\z'), array('^', '$', ''), $format);
345 345
         
346
-        if($statementType==self::JS_REGEX_JSON)
346
+        if ($statementType == self::JS_REGEX_JSON)
347 347
         {
348 348
             return ConvertHelper::var2json(array(
349 349
                 'format' => $format,
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
             ));
352 352
         }
353 353
         
354
-        if(!empty($modifiers)) {
354
+        if (!empty($modifiers)) {
355 355
             return sprintf(
356 356
                 'new RegExp(%s, %s)',
357 357
                 ConvertHelper::var2json($format),
Please login to merge, or discard this patch.
src/ConvertHelper/WordWrapper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@
 block discarded – undo
63 63
         return $this->getBoolOption('cut');
64 64
     }
65 65
     
66
-    public function setCuttingEnabled(bool $enabled=true) : ConvertHelper_WordWrapper
66
+    public function setCuttingEnabled(bool $enabled = true) : ConvertHelper_WordWrapper
67 67
     {
68 68
         $this->setOption('cut', $enabled);
69 69
         return $this;
Please login to merge, or discard this patch.
src/ConvertHelper/IntervalConverter.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
     
37 37
     public function __construct()
38 38
     {
39
-        if(class_exists('\AppLocalize\Localization')) {
39
+        if (class_exists('\AppLocalize\Localization')) {
40 40
             \AppLocalize\Localization::onLocaleChanged(array($this, 'handle_localeChanged'));
41 41
         }
42 42
     }
@@ -69,17 +69,17 @@  discard block
 block discarded – undo
69 69
         $keep = $this->resolveTokens($interval);
70 70
 
71 71
         $parts = array();
72
-        foreach($keep as $token)
72
+        foreach ($keep as $token)
73 73
         {
74 74
             $value = $interval->getToken($token);
75
-            if($value === 0) {
75
+            if ($value === 0) {
76 76
                 continue;
77 77
             }
78 78
             
79 79
             $parts[] = $this->translateToken($token, $interval);
80 80
         }
81 81
         
82
-        if(count($parts) == 1) {
82
+        if (count($parts) == 1) {
83 83
             return $parts[0];
84 84
         }
85 85
         
@@ -101,10 +101,10 @@  discard block
 block discarded – undo
101 101
         $value = $interval->getToken($token);
102 102
         
103 103
         $suffix = 'p';
104
-        if($value == 1) { $suffix = 's'; }
104
+        if ($value == 1) { $suffix = 's'; }
105 105
         $token .= $suffix;
106 106
         
107
-        if(!isset(self::$texts[$token]))
107
+        if (!isset(self::$texts[$token]))
108 108
         {
109 109
             throw new ConvertHelper_Exception(
110 110
                 'Missing interval translation',
@@ -134,9 +134,9 @@  discard block
 block discarded – undo
134 134
     {
135 135
         $offset = 0;
136 136
         
137
-        foreach($this->tokens as $token) 
137
+        foreach ($this->tokens as $token) 
138 138
         {
139
-            if($interval->getToken($token) > 0) 
139
+            if ($interval->getToken($token) > 0) 
140 140
             {
141 141
                 return array_slice($this->tokens, $offset);
142 142
             }
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
     */
153 153
     protected function initTexts() : void
154 154
     {
155
-        if(isset(self::$texts)) {
155
+        if (isset(self::$texts)) {
156 156
             return;
157 157
         }
158 158
         
Please login to merge, or discard this patch.
src/ZIPHelper.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
     
31 31
     const ERROR_OPENING_ZIP_FILE = 338003;
32 32
     
33
-    const ERROR_CANNOT_SAVE_FILE_TO_DISK =338004;
33
+    const ERROR_CANNOT_SAVE_FILE_TO_DISK = 338004;
34 34
     
35 35
     protected $options = array(
36 36
         'WriteThreshold' => 100
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
     * 
81 81
     * @see FileHelper::ERROR_SOURCE_FILE_DOES_NOT_EXIST
82 82
     */
83
-    public function addFile(string $filePath, ?string $zipPath=null) : bool
83
+    public function addFile(string $filePath, ?string $zipPath = null) : bool
84 84
     {
85 85
         $this->open();
86 86
         
@@ -126,16 +126,16 @@  discard block
 block discarded – undo
126 126
     
127 127
     protected function open()
128 128
     {
129
-        if($this->open) {
129
+        if ($this->open) {
130 130
             return;
131 131
         }
132 132
         
133
-        if(!isset($this->zip)) {
133
+        if (!isset($this->zip)) {
134 134
             $this->zip = new \ZipArchive();
135 135
         }
136 136
         
137 137
         $flag = null;
138
-        if(!file_exists($this->file)) {
138
+        if (!file_exists($this->file)) {
139 139
             $flag = \ZipArchive::CREATE;
140 140
         }
141 141
         
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
     {
176 176
         $this->fileTracker++;
177 177
 
178
-        if($this->options['WriteThreshold'] < 1) {
178
+        if ($this->options['WriteThreshold'] < 1) {
179 179
             return;
180 180
         }
181 181
         
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
     
189 189
     protected function close()
190 190
     {
191
-        if(!$this->open) {
191
+        if (!$this->open) {
192 192
             return;
193 193
         }
194 194
         
@@ -197,8 +197,8 @@  discard block
 block discarded – undo
197 197
             throw new ZIPHelper_Exception(
198 198
                 'Could not save ZIP file to disk',
199 199
                 sprintf(
200
-                    'Tried saving the ZIP file [%1$s], but the write failed. This can have several causes, ' .
201
-                    'including adding files that do not exist on disk, trying to create an empty zip, ' .
200
+                    'Tried saving the ZIP file [%1$s], but the write failed. This can have several causes, '.
201
+                    'including adding files that do not exist on disk, trying to create an empty zip, '.
202 202
                     'or trying to save to a directory that does not exist.',
203 203
                     $this->file
204 204
                 ),
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
     {
214 214
         $this->open();
215 215
         
216
-        if($this->countFiles() < 1) 
216
+        if ($this->countFiles() < 1) 
217 217
         {
218 218
             throw new ZIPHelper_Exception(
219 219
                 'No files in the zip file',
@@ -237,17 +237,17 @@  discard block
 block discarded – undo
237 237
      * @throws ZIPHelper_Exception
238 238
      * @return string The file name that was sent (useful in case none was specified).
239 239
      */
240
-    public function download(?string $fileName=null) : string
240
+    public function download(?string $fileName = null) : string
241 241
     {
242 242
         $this->save();
243 243
         
244
-        if(empty($fileName)) {
244
+        if (empty($fileName)) {
245 245
             $fileName = basename($this->file);
246 246
         }
247 247
         
248 248
         header('Content-type: application/zip');
249
-        header('Content-Disposition: attachment; filename=' . $fileName);
250
-        header('Content-length: ' . filesize($this->file));
249
+        header('Content-Disposition: attachment; filename='.$fileName);
250
+        header('Content-length: '.filesize($this->file));
251 251
         header('Pragma: no-cache');
252 252
         header('Expires: 0');
253 253
         readfile($this->file);
@@ -262,7 +262,7 @@  discard block
 block discarded – undo
262 262
     * @param string|NULL $fileName Override the ZIP's file name for the download
263 263
     * @see ZIPHelper::download()
264 264
     */
265
-    public function downloadAndDelete(?string $fileName=null)
265
+    public function downloadAndDelete(?string $fileName = null)
266 266
     {
267 267
         $this->download($fileName);
268 268
         
@@ -277,9 +277,9 @@  discard block
 block discarded – undo
277 277
     * @param string|NULL $outputFolder If no folder is specified, uses the target file's folder.
278 278
     * @return boolean
279 279
     */
280
-    public function extractAll(?string $outputFolder=null) : bool
280
+    public function extractAll(?string $outputFolder = null) : bool
281 281
     {
282
-        if(empty($outputFolder)) {
282
+        if (empty($outputFolder)) {
283 283
             $outputFolder = dirname($this->file);
284 284
         }
285 285
         
Please login to merge, or discard this patch.
src/SVNHelper/CommandResult.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -41,8 +41,8 @@  discard block
 block discarded – undo
41 41
         $this->commandLine = $commandLine;
42 42
         $this->output = $output;
43 43
         
44
-        foreach($errors as $error) {
45
-            if($error->isError()) {
44
+        foreach ($errors as $error) {
45
+            if ($error->isError()) {
46 46
                 $this->errors[] = $error;
47 47
             } else {
48 48
                 $this->warnings[] = $error;
@@ -62,8 +62,8 @@  discard block
 block discarded – undo
62 62
     
63 63
     public function hasErrorCode($code)
64 64
     {
65
-        foreach($this->errors as $error) {
66
-            if($error->getCode() == $code) {
65
+        foreach ($this->errors as $error) {
66
+            if ($error->getCode() == $code) {
67 67
                 return true;
68 68
             }
69 69
         }
@@ -92,11 +92,11 @@  discard block
 block discarded – undo
92 92
     * @param bool $asString
93 93
     * @return string|string[]
94 94
     */
95
-    public function getErrorMessages(bool $asString=false)
95
+    public function getErrorMessages(bool $asString = false)
96 96
     {
97
-        if($asString) {
97
+        if ($asString) {
98 98
             $lines = array();
99
-            foreach($this->errors as $error) {
99
+            foreach ($this->errors as $error) {
100 100
                 $lines[] = (string)$error;
101 101
             }
102 102
             
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
         }
105 105
         
106 106
         $messages = array();
107
-        foreach($this->errors as $error) {
107
+        foreach ($this->errors as $error) {
108 108
             $messages[] = (string)$error;
109 109
         }
110 110
         
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
     
124 124
     public function getLastLine()
125 125
     {
126
-        return $this->output[count($this->output)-1];
126
+        return $this->output[count($this->output) - 1];
127 127
     }
128 128
     
129 129
     public function getFirstLine()
@@ -138,8 +138,8 @@  discard block
 block discarded – undo
138 138
     
139 139
     public function isConnectionFailed()
140 140
     {
141
-        foreach($this->errors as $error) {
142
-            if($error->isConnectionFailed()) {
141
+        foreach ($this->errors as $error) {
142
+            if ($error->isConnectionFailed()) {
143 143
                 return true;
144 144
             }
145 145
         }
@@ -149,8 +149,8 @@  discard block
 block discarded – undo
149 149
     
150 150
     public function hasConflicts()
151 151
     {
152
-        foreach($this->errors as $error) {
153
-            if($error->isConflict()) {
152
+        foreach ($this->errors as $error) {
153
+            if ($error->isConflict()) {
154 154
                 return true;
155 155
             }
156 156
         }
@@ -160,8 +160,8 @@  discard block
 block discarded – undo
160 160
     
161 161
     public function hasLocks()
162 162
     {
163
-        foreach($this->errors as $error) {
164
-            if($error->isLock()) {
163
+        foreach ($this->errors as $error) {
164
+            if ($error->isLock()) {
165 165
                 return true;
166 166
             }
167 167
         }
Please login to merge, or discard this patch.
src/Transliteration.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
      * The converted string will be all lowercase.
61 61
      * @return Transliteration
62 62
      */
63
-    public function setLowercase(bool $lowercase=true) : Transliteration
63
+    public function setLowercase(bool $lowercase = true) : Transliteration
64 64
     {
65 65
         $this->setOption('lowercase', $lowercase);
66 66
 
@@ -97,8 +97,8 @@  discard block
 block discarded – undo
97 97
 
98 98
         $result = implode('', $keep);
99 99
 
100
-        while (strstr($result, $space . $space)) {
101
-            $result = str_replace($space . $space, $space, $result);
100
+        while (strstr($result, $space.$space)) {
101
+            $result = str_replace($space.$space, $space, $result);
102 102
         }
103 103
 
104 104
         $result = trim($result, $space);
Please login to merge, or discard this patch.
src/ConvertHelper/ByteConverter.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
         $this->bytes = $bytes;
34 34
         
35 35
         // correct negative values
36
-        if($this->bytes < 0) 
36
+        if ($this->bytes < 0) 
37 37
         {
38 38
             $this->bytes = 0;
39 39
         }
@@ -49,19 +49,19 @@  discard block
 block discarded – undo
49 49
     {
50 50
         $sizes = $this->getSizesSorted($base);   
51 51
 
52
-        if($this->bytes >= $sizes[0]->getBytes()) 
52
+        if ($this->bytes >= $sizes[0]->getBytes()) 
53 53
         {
54 54
             $total = count($sizes);
55 55
             
56
-            for($i=0; $i < $total; $i++)
56
+            for ($i = 0; $i < $total; $i++)
57 57
             {
58 58
                 $size = $sizes[$i];
59 59
                 
60
-                if(!isset($sizes[($i+1)])) {
60
+                if (!isset($sizes[($i + 1)])) {
61 61
                     return $size;
62 62
                 }
63 63
                 
64
-                if($this->bytes >= $size->getBytes() && $this->bytes < $sizes[($i+1)]->getBytes()) {
64
+                if ($this->bytes >= $size->getBytes() && $this->bytes < $sizes[($i + 1)]->getBytes()) {
65 65
                     return $size;
66 66
                 }
67 67
             }
@@ -99,11 +99,11 @@  discard block
 block discarded – undo
99 99
     * @see ConvertHelper_StorageSizeEnum::BASE_10
100 100
     * @see ConvertHelper_StorageSizeEnum::BASE_2
101 101
     */
102
-    public function toString(int $precision, int $base=ConvertHelper_StorageSizeEnum::BASE_10) : string
102
+    public function toString(int $precision, int $base = ConvertHelper_StorageSizeEnum::BASE_10) : string
103 103
     {
104 104
         $size = $this->detectSize($base);
105 105
         
106
-        return round($this->bytes / $size->getBytes(), $precision) . ' ' . $size->getSuffix();
106
+        return round($this->bytes / $size->getBytes(), $precision).' '.$size->getSuffix();
107 107
     }
108 108
     
109 109
    /**
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
     * @param int $precision Amount of decimals (rounded up)
127 127
     * @return float
128 128
     */
129
-    public function toKilobytes(int $precision=1) : float
129
+    public function toKilobytes(int $precision = 1) : float
130 130
     {
131 131
         return $this->toNumber($precision, 'kb');
132 132
     }
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
     * @param int $precision Amount of decimals (rounded up)
138 138
     * @return float
139 139
     */
140
-    public function toMegabytes(int $precision=1) : float
140
+    public function toMegabytes(int $precision = 1) : float
141 141
     {
142 142
         return $this->toNumber($precision, 'mb');
143 143
     }
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
     * @param int $precision Amount of decimals (rounded up)
149 149
     * @return float
150 150
     */
151
-    public function toGigabytes(int $precision=1) : float
151
+    public function toGigabytes(int $precision = 1) : float
152 152
     {
153 153
         return $this->toNumber($precision, 'gb');
154 154
     }
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
     * @param int $precision Amount of decimals (rounded up)
160 160
     * @return float
161 161
     */
162
-    public function toTerabytes(int $precision=1) : float
162
+    public function toTerabytes(int $precision = 1) : float
163 163
     {
164 164
         return $this->toNumber($precision, 'tb');
165 165
     }
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
     * @param int $precision Amount of decimals (rounded up)
171 171
     * @return float
172 172
     */
173
-    public function toPetabytes(int $precision=1) : float
173
+    public function toPetabytes(int $precision = 1) : float
174 174
     {
175 175
         return $this->toNumber($precision, 'pb');
176 176
     }
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
      * @param int $precision Amount of decimals (rounded up)
182 182
      * @return float
183 183
      */
184
-    public function toKibibytes(int $precision=1) : float
184
+    public function toKibibytes(int $precision = 1) : float
185 185
     {
186 186
         return $this->toNumber($precision, 'kib');
187 187
     }
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
      * @param int $precision Amount of decimals (rounded up)
193 193
      * @return float
194 194
      */
195
-    public function toMebibytes(int $precision=1) : float
195
+    public function toMebibytes(int $precision = 1) : float
196 196
     {
197 197
         return $this->toNumber($precision, 'mib');
198 198
     }
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
      * @param int $precision Amount of decimals (rounded up)
204 204
      * @return float
205 205
      */
206
-    public function toGibibytes(int $precision=1) : float
206
+    public function toGibibytes(int $precision = 1) : float
207 207
     {
208 208
         return $this->toNumber($precision, 'gib');
209 209
     }
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
214 214
      * @param int $precision Amount of decimals (rounded up)
215 215
      * @return float
216 216
      */
217
-    public function toTebibytes(int $precision=1) : float
217
+    public function toTebibytes(int $precision = 1) : float
218 218
     {
219 219
         return $this->toNumber($precision, 'tib');
220 220
     }
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
      * @param int $precision Amount of decimals (rounded up)
226 226
      * @return float
227 227
      */
228
-    public function toPebibytes(int $precision=1) : float
228
+    public function toPebibytes(int $precision = 1) : float
229 229
     {
230 230
         return $this->toNumber($precision, 'pib');
231 231
     }
Please login to merge, or discard this patch.
src/ConvertHelper/SizeNotation.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
     * @return string
100 100
     * @see ConvertHelper::bytes2readable()
101 101
     */
102
-    public function toString(int $precision=1) : string
102
+    public function toString(int $precision = 1) : string
103 103
     {
104 104
         return ConvertHelper::bytes2readable($this->bytes, $precision, $this->getBase());
105 105
     }
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
     */
111 111
     public function getBase() : int
112 112
     {
113
-        if($this->isValid()) {
113
+        if ($this->isValid()) {
114 114
             return $this->sizeDefinition->getBase(); 
115 115
         }
116 116
         
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
     */
127 127
     public function getSizeDefinition() : ?ConvertHelper_StorageSizeEnum_Size
128 128
     {
129
-        if($this->isValid()) {
129
+        if ($this->isValid()) {
130 130
             return $this->sizeDefinition;
131 131
         }
132 132
         
@@ -175,18 +175,18 @@  discard block
 block discarded – undo
175 175
     
176 176
     protected function parseSize() : void
177 177
     {
178
-        if(!$this->detectParts()) {
178
+        if (!$this->detectParts()) {
179 179
             return;
180 180
         }
181 181
         
182 182
         // we detected units in the string: all good.
183
-        if($this->units !== null)
183
+        if ($this->units !== null)
184 184
         {
185 185
             return;
186 186
         }
187 187
         
188 188
         // just a numeric value: we assume this means we're dealing with bytes.
189
-        if(is_numeric($this->number)) 
189
+        if (is_numeric($this->number)) 
190 190
         {
191 191
             $this->units = 'b';
192 192
             return;
@@ -212,12 +212,12 @@  discard block
 block discarded – undo
212 212
         
213 213
         $number = $this->sizeString;
214 214
         
215
-        foreach($units as $unit)
215
+        foreach ($units as $unit)
216 216
         {
217
-            if(stristr($number, $unit))
217
+            if (stristr($number, $unit))
218 218
             {
219 219
                 // there are more than 1 unit defined in the string
220
-                if($this->units !== null)
220
+                if ($this->units !== null)
221 221
                 {
222 222
                     $this->setError(
223 223
                         t(
@@ -273,14 +273,14 @@  discard block
 block discarded – undo
273 273
     {
274 274
         $this->parseSize();
275 275
         
276
-        if(!$this->valid) {
276
+        if (!$this->valid) {
277 277
             return;
278 278
         }
279 279
         
280 280
         $int = intval($this->number);
281 281
         
282 282
         // negative values
283
-        if($int < 0) 
283
+        if ($int < 0) 
284 284
         {
285 285
             $this->setError(
286 286
                 t('Negative values cannot be used as size.'),
Please login to merge, or discard this patch.