Passed
Push — master ( 12a81e...e685ae )
by Sebastian
02:29
created
src/RequestHelper/Boundaries.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
     */
140 140
     public function render() : string
141 141
     {
142
-        if(empty($this->boundaries)) 
142
+        if (empty($this->boundaries)) 
143 143
         {
144 144
             throw new RequestHelper_Exception(
145 145
                 'No mime boundaries added',
@@ -150,13 +150,13 @@  discard block
 block discarded – undo
150 150
         
151 151
         $result = '';
152 152
         
153
-        foreach($this->boundaries as $boundary)
153
+        foreach ($this->boundaries as $boundary)
154 154
         {
155 155
             $result .= $boundary->render();
156 156
         }
157 157
         
158
-        $result .= "--" . $this->getMimeBoundary() . "--" . 
159
-        $this->getEOL() . $this->getEOL(); // always finish with two eol's!!
158
+        $result .= "--".$this->getMimeBoundary()."--". 
159
+        $this->getEOL().$this->getEOL(); // always finish with two eol's!!
160 160
         
161 161
         return $result;
162 162
     }
Please login to merge, or discard this patch.
src/URLInfo/Normalizer.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
     * @param bool $enable Whether to turn it on or off.
40 40
     * @return URLInfo_Normalizer
41 41
     */
42
-    public function enableAuth(bool $enable=true) : URLInfo_Normalizer
42
+    public function enableAuth(bool $enable = true) : URLInfo_Normalizer
43 43
     {
44 44
         $this->auth = $enable;
45 45
         return $this;
@@ -86,48 +86,48 @@  discard block
 block discarded – undo
86 86
     
87 87
     protected function renderAuth(string $normalized) : string
88 88
     {
89
-        if(!$this->info->hasUsername() || !$this->auth) {
89
+        if (!$this->info->hasUsername() || !$this->auth) {
90 90
             return $normalized;
91 91
         }
92 92
          
93
-        return $normalized . urlencode($this->info->getUsername()).':'.urlencode($this->info->getPassword()).'@';
93
+        return $normalized.urlencode($this->info->getUsername()).':'.urlencode($this->info->getPassword()).'@';
94 94
     }
95 95
     
96 96
     protected function renderPort(string $normalized) : string
97 97
     {
98
-        if(!$this->info->hasPort()) {
98
+        if (!$this->info->hasPort()) {
99 99
             return $normalized;
100 100
         }
101 101
         
102
-        return $normalized . ':'.$this->info->getPort();
102
+        return $normalized.':'.$this->info->getPort();
103 103
     }
104 104
     
105 105
     protected function renderPath(string $normalized) : string
106 106
     {
107
-        if(!$this->info->hasPath()) {
107
+        if (!$this->info->hasPath()) {
108 108
             return $normalized; 
109 109
         }
110 110
         
111
-        return $normalized . $this->info->getPath();
111
+        return $normalized.$this->info->getPath();
112 112
     }
113 113
     
114 114
     protected function renderParams(string $normalized) : string
115 115
     {
116 116
         $params = $this->info->getParams();
117 117
         
118
-        if(empty($params)) {
118
+        if (empty($params)) {
119 119
             return $normalized;
120 120
         }
121 121
         
122
-        return $normalized . '?'.http_build_query($params);
122
+        return $normalized.'?'.http_build_query($params);
123 123
     }
124 124
     
125 125
     protected function renderFragment(string $normalized) : string
126 126
     {
127
-        if(!$this->info->hasFragment()) {
127
+        if (!$this->info->hasFragment()) {
128 128
             return $normalized;
129 129
         }
130 130
         
131
-        return $normalized . '#'.$this->info->getFragment();
131
+        return $normalized.'#'.$this->info->getFragment();
132 132
     }
133 133
 }
Please login to merge, or discard this patch.
src/URLInfo.php 1 patch
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
     {
201 201
         $port = $this->getInfoKey('port');
202 202
         
203
-        if(!empty($port)) {
203
+        if (!empty($port)) {
204 204
             return (int)$port;
205 205
         }
206 206
         
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
     
281 281
     protected function getInfoKey(string $name) : string
282 282
     {
283
-        if(isset($this->info[$name])) {
283
+        if (isset($this->info[$name])) {
284 284
             return (string)$this->info[$name];
285 285
         }
286 286
         
@@ -309,13 +309,13 @@  discard block
 block discarded – undo
309 309
         return $this->normalize(false);
310 310
     }
311 311
     
312
-    protected function normalize(bool $auth=true) : string
312
+    protected function normalize(bool $auth = true) : string
313 313
     {
314
-        if(!$this->isValid()) {
314
+        if (!$this->isValid()) {
315 315
             return '';
316 316
         }
317 317
         
318
-        if(!isset($this->normalizer)) {
318
+        if (!isset($this->normalizer)) {
319 319
             $this->normalizer = new URLInfo_Normalizer($this);
320 320
         }
321 321
         
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
     */
346 346
     public function getHighlighted() : string
347 347
     {
348
-        if(!$this->isValid()) {
348
+        if (!$this->isValid()) {
349 349
             return '';
350 350
         }
351 351
         
@@ -387,14 +387,14 @@  discard block
 block discarded – undo
387 387
     */
388 388
     public function getParams() : array
389 389
     {
390
-        if(!$this->paramExclusion || empty($this->excludedParams)) {
390
+        if (!$this->paramExclusion || empty($this->excludedParams)) {
391 391
             return $this->info['params'];
392 392
         }
393 393
         
394 394
         $keep = array();
395
-        foreach($this->info['params'] as $name => $value) 
395
+        foreach ($this->info['params'] as $name => $value) 
396 396
         {
397
-            if(!isset($this->excludedParams[$name])) {
397
+            if (!isset($this->excludedParams[$name])) {
398 398
                 $keep[$name] = $value;
399 399
             }
400 400
         }
@@ -420,7 +420,7 @@  discard block
 block discarded – undo
420 420
     */
421 421
     public function getParam(string $name) : string
422 422
     {
423
-        if(isset($this->info['params'][$name])) {
423
+        if (isset($this->info['params'][$name])) {
424 424
             return $this->info['params'][$name];
425 425
         }
426 426
         
@@ -439,7 +439,7 @@  discard block
 block discarded – undo
439 439
     */
440 440
     public function excludeParam(string $name, string $reason) : URLInfo
441 441
     {
442
-        if(!isset($this->excludedParams[$name]))
442
+        if (!isset($this->excludedParams[$name]))
443 443
         {
444 444
             $this->excludedParams[$name] = $reason;
445 445
             $this->setParamExclusion();
@@ -465,7 +465,7 @@  discard block
 block discarded – undo
465 465
     
466 466
     public function getTypeLabel() : string
467 467
     {
468
-        if(!isset(self::$typeLabels))
468
+        if (!isset(self::$typeLabels))
469 469
         {
470 470
             self::$typeLabels = array(
471 471
                 self::TYPE_EMAIL => t('Email'),
@@ -477,7 +477,7 @@  discard block
 block discarded – undo
477 477
         
478 478
         $type = $this->getType();
479 479
         
480
-        if(!isset(self::$typeLabels[$type]))
480
+        if (!isset(self::$typeLabels[$type]))
481 481
         {
482 482
             throw new BaseException(
483 483
                 sprintf('Unknown URL type label for type [%s].', $type),
@@ -497,7 +497,7 @@  discard block
 block discarded – undo
497 497
     * @param bool $highlight
498 498
     * @return URLInfo
499 499
     */
500
-    public function setHighlightExcluded(bool $highlight=true) : URLInfo
500
+    public function setHighlightExcluded(bool $highlight = true) : URLInfo
501 501
     {
502 502
         $this->highlightExcluded = $highlight;
503 503
         return $this;
@@ -545,7 +545,7 @@  discard block
 block discarded – undo
545 545
      * @see URLInfo::isParamExclusionEnabled()
546 546
      * @see URLInfo::setHighlightExcluded()
547 547
      */
548
-    public function setParamExclusion(bool $enabled=true) : URLInfo
548
+    public function setParamExclusion(bool $enabled = true) : URLInfo
549 549
     {
550 550
         $this->paramExclusion = $enabled;
551 551
         return $this;
@@ -571,13 +571,13 @@  discard block
 block discarded – undo
571 571
     */
572 572
     public function containsExcludedParams() : bool
573 573
     {
574
-        if(empty($this->excludedParams)) {
574
+        if (empty($this->excludedParams)) {
575 575
             return false;
576 576
         }
577 577
         
578 578
         $names = array_keys($this->info['params']);
579
-        foreach($names as $name) {
580
-            if(isset($this->excludedParams[$name])) {
579
+        foreach ($names as $name) {
580
+            if (isset($this->excludedParams[$name])) {
581 581
                 return true;
582 582
             }
583 583
         }
@@ -593,7 +593,7 @@  discard block
 block discarded – undo
593 593
 
594 594
     public function offsetSet($offset, $value) 
595 595
     {
596
-        if(in_array($offset, $this->infoKeys)) {
596
+        if (in_array($offset, $this->infoKeys)) {
597 597
             $this->info[$offset] = $value;
598 598
         }
599 599
     }
@@ -610,11 +610,11 @@  discard block
 block discarded – undo
610 610
     
611 611
     public function offsetGet($offset) 
612 612
     {
613
-        if($offset === 'port') {
613
+        if ($offset === 'port') {
614 614
             return $this->getPort();
615 615
         }
616 616
         
617
-        if(in_array($offset, $this->infoKeys)) {
617
+        if (in_array($offset, $this->infoKeys)) {
618 618
             return $this->getInfoKey($offset);
619 619
         }
620 620
         
@@ -646,12 +646,12 @@  discard block
 block discarded – undo
646 646
     * @return bool
647 647
     * @throws BaseException
648 648
     */
649
-    public function tryConnect(bool $verifySSL=true) : bool
649
+    public function tryConnect(bool $verifySSL = true) : bool
650 650
     {
651 651
         requireCURL();
652 652
         
653 653
         $ch = curl_init();
654
-        if(!is_resource($ch))
654
+        if (!is_resource($ch))
655 655
         {
656 656
             throw new BaseException(
657 657
                 'Could not initialize a new cURL instance.',
@@ -667,13 +667,13 @@  discard block
 block discarded – undo
667 667
         curl_setopt($ch, CURLOPT_TIMEOUT, 10);
668 668
         curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);
669 669
         
670
-        if(!$verifySSL) 
670
+        if (!$verifySSL) 
671 671
         {
672 672
             curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, false);
673 673
             curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);
674 674
         }
675 675
         
676
-        if($this->hasUsername()) 
676
+        if ($this->hasUsername()) 
677 677
         {
678 678
             curl_setopt($ch, CURLOPT_USERNAME, $this->getUsername());
679 679
             curl_setopt($ch, CURLOPT_PASSWORD, $this->getPassword());
Please login to merge, or discard this patch.
src/RequestHelper.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
         // CURL will complain about an empty response when the 
211 211
         // server sends a 100-continue code. That should not be
212 212
         // regarded as an error.
213
-        if($output === false && $this->response->getCode() !== 100)
213
+        if ($output === false && $this->response->getCode() !== 100)
214 214
         {
215 215
             $this->response->setError(
216 216
                 curl_errno($ch),
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
243 243
     protected function createCURL(URLInfo $url)
244 244
     {
245 245
         $ch = curl_init();
246
-        if(!is_resource($ch))
246
+        if (!is_resource($ch))
247 247
         {
248 248
             throw new RequestHelper_Exception(
249 249
                 'Could not initialize a new cURL instance.',
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
         }
254 254
 
255 255
         $this->setHeader('Content-Length', (string)$this->boundaries->getContentLength());
256
-        $this->setHeader('Content-Type', 'multipart/form-data; charset=UTF-8; boundary=' . $this->mimeBoundary);
256
+        $this->setHeader('Content-Type', 'multipart/form-data; charset=UTF-8; boundary='.$this->mimeBoundary);
257 257
         
258 258
         //curl_setopt($ch, CURLOPT_VERBOSE, true);
259 259
         curl_setopt($ch, CURLOPT_POST, true);
@@ -264,13 +264,13 @@  discard block
 block discarded – undo
264 264
         curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);
265 265
         curl_setopt($ch, CURLOPT_HTTPHEADER, $this->renderHeaders());
266 266
         
267
-        if($this->verifySSL)
267
+        if ($this->verifySSL)
268 268
         {
269 269
             curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, false);
270 270
             curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);
271 271
         }
272 272
         
273
-        if($url->hasUsername())
273
+        if ($url->hasUsername())
274 274
         {
275 275
             curl_setopt($ch, CURLOPT_USERNAME, $url->getUsername());
276 276
             curl_setopt($ch, CURLOPT_PASSWORD, $url->getPassword());
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
     {
291 291
         $result = array();
292 292
         
293
-        foreach($this->headers as $name => $value) {
293
+        foreach ($this->headers as $name => $value) {
294 294
             $result[] = $name.': '.$value;
295 295
         }
296 296
         
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
303 303
     */
304 304
     public function getResponseHeader() : array
305 305
     {
306
-        if(isset($this->response)) {
306
+        if (isset($this->response)) {
307 307
             return $this->response->getHeaders();
308 308
         }
309 309
 
Please login to merge, or discard this patch.
src/ConvertHelper.php 1 patch
Spacing   +93 added lines, -93 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
             $amount = substr_count($line, "\t") - $min;
60 60
             $line = trim($line);
61 61
             if ($amount >= 1) {
62
-                $line = str_repeat("\t", $amount) . $line;
62
+                $line = str_repeat("\t", $amount).$line;
63 63
             }
64 64
 
65 65
             $converted[] = $line;
@@ -131,10 +131,10 @@  discard block
 block discarded – undo
131 131
 
132 132
         // specifically handle zero
133 133
         if ($seconds <= 0) {
134
-            return '0 ' . t('seconds');
134
+            return '0 '.t('seconds');
135 135
         }
136 136
         
137
-        if($seconds < 1) {
137
+        if ($seconds < 1) {
138 138
             return t('less than a second');
139 139
         }
140 140
 
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
         foreach ($units as $def) {
143 143
             $quot = intval($seconds / $def['value']);
144 144
             if ($quot) {
145
-                $item = $quot . ' ';
145
+                $item = $quot.' ';
146 146
                 if (abs($quot) > 1) {
147 147
                     $item .= $def['plural'];
148 148
                 } else {
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
             return $last;
160 160
         }
161 161
 
162
-        return implode(', ', $tokens) . ' ' . t('and') . ' ' . $last;
162
+        return implode(', ', $tokens).' '.t('and').' '.$last;
163 163
     }
164 164
 
165 165
    /**
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
     {
179 179
          $converter = new ConvertHelper_DurationConverter();
180 180
          
181
-         if($datefrom instanceof \DateTime)
181
+         if ($datefrom instanceof \DateTime)
182 182
          {
183 183
              $converter->setDateFrom($datefrom);
184 184
          }
@@ -187,11 +187,11 @@  discard block
 block discarded – undo
187 187
              $converter->setDateFrom(self::timestamp2date($datefrom)); 
188 188
          }
189 189
 
190
-         if($dateto instanceof \DateTime)
190
+         if ($dateto instanceof \DateTime)
191 191
          {
192 192
              $converter->setDateTo($dateto);
193 193
          }
194
-         else if($dateto > 0)
194
+         else if ($dateto > 0)
195 195
          {
196 196
              $converter->setDateTo(self::timestamp2date($dateto));
197 197
          }
@@ -211,9 +211,9 @@  discard block
 block discarded – undo
211 211
         return $geshi->parse_code();
212 212
     }
213 213
     
214
-    public static function highlight_xml($xml, $formatSource=false)
214
+    public static function highlight_xml($xml, $formatSource = false)
215 215
     {
216
-        if($formatSource) 
216
+        if ($formatSource) 
217 217
         {
218 218
             $dom = new \DOMDocument();
219 219
             $dom->loadXML($xml);
@@ -280,16 +280,16 @@  discard block
 block discarded – undo
280 280
             return $text;
281 281
         }
282 282
 
283
-        $text = trim(mb_substr($text, 0, $targetLength)) . $append;
283
+        $text = trim(mb_substr($text, 0, $targetLength)).$append;
284 284
 
285 285
         return $text;
286 286
     }
287 287
 
288
-    public static function var_dump($var, $html=true) : string
288
+    public static function var_dump($var, $html = true) : string
289 289
     {
290 290
         $info = parseVariable($var);
291 291
         
292
-        if($html) {
292
+        if ($html) {
293 293
             return $info->toHTML();
294 294
         }
295 295
         
@@ -304,11 +304,11 @@  discard block
 block discarded – undo
304 304
     * @param bool $html Whether to style the dump as HTML.
305 305
     * @return string
306 306
     */
307
-    public static function print_r($var, bool $return=false, bool $html=true) : string
307
+    public static function print_r($var, bool $return = false, bool $html = true) : string
308 308
     {
309 309
         $result = parseVariable($var)->enableType()->toString();
310 310
         
311
-        if($html) 
311
+        if ($html) 
312 312
         {
313 313
             $result = 
314 314
             '<pre style="background:#fff;color:#333;padding:16px;border:solid 1px #bbb;border-radius:4px">'.
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
             '</pre>';
317 317
         }
318 318
         
319
-        if(!$return) 
319
+        if (!$return) 
320 320
         {
321 321
             echo $result;
322 322
         }
@@ -344,17 +344,17 @@  discard block
 block discarded – undo
344 344
     */
345 345
     public static function string2bool($string) : bool
346 346
     {
347
-        if($string === '' || $string === null || !is_scalar($string)) 
347
+        if ($string === '' || $string === null || !is_scalar($string)) 
348 348
         {
349 349
             return false;
350 350
         }
351 351
         
352
-        if(is_bool($string)) 
352
+        if (is_bool($string)) 
353 353
         {
354 354
             return $string;
355 355
         }
356 356
 
357
-        if(array_key_exists($string, self::$booleanStrings)) 
357
+        if (array_key_exists($string, self::$booleanStrings)) 
358 358
         {
359 359
             return self::$booleanStrings[$string];
360 360
         }
@@ -409,10 +409,10 @@  discard block
 block discarded – undo
409 409
     public static function date2listLabel(\DateTime $date, $includeTime = false, $shortMonth = false)
410 410
     {
411 411
         $today = new \DateTime();
412
-        if($date->format('d.m.Y') == $today->format('d.m.Y')) {
412
+        if ($date->format('d.m.Y') == $today->format('d.m.Y')) {
413 413
             $label = t('Today');
414 414
         } else {
415
-            $label = $date->format('d') . '. ' . self::month2string((int)$date->format('m'), $shortMonth) . ' ';
415
+            $label = $date->format('d').'. '.self::month2string((int)$date->format('m'), $shortMonth).' ';
416 416
             if ($date->format('Y') != date('Y')) {
417 417
                 $label .= $date->format('Y');
418 418
             }
@@ -503,28 +503,28 @@  discard block
 block discarded – undo
503 503
         $hexAlphabet = array('0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C', 'D', 'E', 'F');
504 504
         
505 505
         $stack = array();
506
-        foreach(self::$controlChars as $char)
506
+        foreach (self::$controlChars as $char)
507 507
         {
508 508
             $tokens = explode('-', $char);
509 509
             $start = $tokens[0];
510 510
             $end = $tokens[1];
511 511
             $prefix = substr($start, 0, 3);
512 512
             $range = array();
513
-            foreach($hexAlphabet as $number) {
513
+            foreach ($hexAlphabet as $number) {
514 514
                 $range[] = $prefix.$number;
515 515
             }
516 516
             
517 517
             $use = false;
518
-            foreach($range as $number) {
519
-                if($number == $start) {
518
+            foreach ($range as $number) {
519
+                if ($number == $start) {
520 520
                     $use = true;
521 521
                 }
522 522
                 
523
-                if($use) {
523
+                if ($use) {
524 524
                     $stack[] = $number;
525 525
                 }
526 526
                 
527
-                if($number == $end) {
527
+                if ($number == $end) {
528 528
                     break;
529 529
                 }
530 530
             }
@@ -545,7 +545,7 @@  discard block
 block discarded – undo
545 545
         $chars = self::getControlCharactersAsHex();
546 546
         
547 547
         $result = array();
548
-        foreach($chars as $char) {
548
+        foreach ($chars as $char) {
549 549
             $result[] = hex2bin($char);
550 550
         }
551 551
         
@@ -563,14 +563,14 @@  discard block
 block discarded – undo
563 563
         $chars = self::getControlCharactersAsHex();
564 564
         
565 565
         $result = array();
566
-        foreach($chars as $char) {
566
+        foreach ($chars as $char) {
567 567
             $result[] = '\u'.strtolower($char);
568 568
         }
569 569
         
570 570
         return $result;
571 571
     }
572 572
     
573
-    protected static $controlChars =  array(
573
+    protected static $controlChars = array(
574 574
         '0000-0008', // control chars
575 575
         '000E-000F', // control chars
576 576
         '0010-001F', // control chars
@@ -592,19 +592,19 @@  discard block
 block discarded – undo
592 592
      */
593 593
     public static function stripControlCharacters(string $string) : string
594 594
     {
595
-        if(empty($string)) {
595
+        if (empty($string)) {
596 596
             return $string;
597 597
         }
598 598
         
599 599
         // create the regex from the unicode characters list
600
-        if(!isset(self::$controlCharsRegex)) 
600
+        if (!isset(self::$controlCharsRegex)) 
601 601
         {
602 602
             $chars = self::getControlCharactersAsHex();
603 603
 
604 604
             // we use the notation \x{0000} to specify the unicode character key
605 605
             // in the regular expression.
606 606
             $stack = array();
607
-            foreach($chars as $char) {
607
+            foreach ($chars as $char) {
608 608
                 $stack[] = '\x{'.$char.'}';
609 609
             }
610 610
             
@@ -635,12 +635,12 @@  discard block
 block discarded – undo
635 635
         $output = '';
636 636
         $split = str_split($unicodeChar);
637 637
         
638
-        foreach($split as $octet) 
638
+        foreach ($split as $octet) 
639 639
         {
640 640
             $ordInt = ord($octet);
641 641
             // Convert from int (base 10) to hex (base 16), for PHP \x syntax
642 642
             $ordHex = base_convert((string)$ordInt, 10, 16);
643
-            $output .= '\x' . $ordHex;
643
+            $output .= '\x'.$ordHex;
644 644
         }
645 645
         
646 646
         return $output;
@@ -673,19 +673,19 @@  discard block
 block discarded – undo
673 673
     
674 674
     protected static function convertScalarForComparison($scalar)
675 675
     {
676
-        if($scalar === '' || is_null($scalar)) {
676
+        if ($scalar === '' || is_null($scalar)) {
677 677
             return null;
678 678
         }
679 679
         
680
-        if(is_bool($scalar)) {
680
+        if (is_bool($scalar)) {
681 681
             return self::bool2string($scalar);
682 682
         }
683 683
         
684
-        if(is_array($scalar)) {
684
+        if (is_array($scalar)) {
685 685
             $scalar = md5(serialize($scalar));
686 686
         }
687 687
         
688
-        if($scalar !== null && !is_scalar($scalar)) {
688
+        if ($scalar !== null && !is_scalar($scalar)) {
689 689
             throw new ConvertHelper_Exception(
690 690
                 'Not a scalar value in comparison',
691 691
                 null,
@@ -734,7 +734,7 @@  discard block
 block discarded – undo
734 734
     public static function bool2string($boolean, bool $yesno = false) : string
735 735
     {
736 736
         // allow 'yes', 'true', 'no', 'false' string notations as well
737
-        if(!is_bool($boolean)) {
737
+        if (!is_bool($boolean)) {
738 738
             $boolean = self::string2bool($boolean);
739 739
         }
740 740
         
@@ -775,15 +775,15 @@  discard block
 block discarded – undo
775 775
     public static function array2attributeString($array)
776 776
     {
777 777
         $tokens = array();
778
-        foreach($array as $attr => $value) {
779
-            if($value == '' || $value == null) {
778
+        foreach ($array as $attr => $value) {
779
+            if ($value == '' || $value == null) {
780 780
                 continue;
781 781
             }
782 782
             
783 783
             $tokens[] = $attr.'="'.$value.'"';
784 784
         }
785 785
         
786
-        if(empty($tokens)) {
786
+        if (empty($tokens)) {
787 787
             return '';
788 788
         }
789 789
         
@@ -798,10 +798,10 @@  discard block
 block discarded – undo
798 798
     * @param string $string
799 799
     * @return string
800 800
     */
801
-    public static function string2attributeJS($string, $quoted=true)
801
+    public static function string2attributeJS($string, $quoted = true)
802 802
     {
803 803
         $converted = addslashes(htmlspecialchars(strip_tags($string), ENT_QUOTES, 'UTF-8'));
804
-        if($quoted) {
804
+        if ($quoted) {
805 805
             $converted = "'".$converted."'";
806 806
         } 
807 807
         
@@ -819,11 +819,11 @@  discard block
 block discarded – undo
819 819
     */
820 820
     public static function isBoolean($value) : bool
821 821
     {
822
-        if(is_bool($value)) {
822
+        if (is_bool($value)) {
823 823
             return true;
824 824
         }
825 825
         
826
-        if(!is_scalar($value)) {
826
+        if (!is_scalar($value)) {
827 827
             return false;
828 828
         }
829 829
         
@@ -839,7 +839,7 @@  discard block
 block discarded – undo
839 839
     public static function array2styleString(array $subject) : string
840 840
     {
841 841
         $tokens = array();
842
-        foreach($subject as $name => $value) {
842
+        foreach ($subject as $name => $value) {
843 843
             $tokens[] = $name.':'.$value;
844 844
         }
845 845
         
@@ -897,7 +897,7 @@  discard block
 block discarded – undo
897 897
     * 
898 898
     * @see JSHelper::buildRegexStatement()
899 899
     */
900
-    public static function regex2js(string $regex, string $statementType=JSHelper::JS_REGEX_OBJECT)
900
+    public static function regex2js(string $regex, string $statementType = JSHelper::JS_REGEX_OBJECT)
901 901
     {
902 902
         return JSHelper::buildRegexStatement($regex, $statementType);
903 903
     }
@@ -914,11 +914,11 @@  discard block
 block discarded – undo
914 914
     * @throws ConvertHelper_Exception
915 915
     * @return string
916 916
     */
917
-    public static function var2json($variable, int $options=0, int $depth=512) : string
917
+    public static function var2json($variable, int $options = 0, int $depth = 512) : string
918 918
     {
919 919
         $result = json_encode($variable, $options, $depth);
920 920
         
921
-        if($result !== false) {
921
+        if ($result !== false) {
922 922
             return $result;
923 923
         }
924 924
         
@@ -943,10 +943,10 @@  discard block
 block discarded – undo
943 943
     public static function stripUTFBom($string)
944 944
     {
945 945
         $boms = FileHelper::getUTFBOMs();
946
-        foreach($boms as $bomChars) {
946
+        foreach ($boms as $bomChars) {
947 947
             $length = mb_strlen($bomChars);
948 948
             $text = mb_substr($string, 0, $length);
949
-            if($text==$bomChars) {
949
+            if ($text == $bomChars) {
950 950
                 return mb_substr($string, $length);
951 951
             }
952 952
         }
@@ -963,7 +963,7 @@  discard block
 block discarded – undo
963 963
     */
964 964
     public static function string2utf8($string)
965 965
     {
966
-        if(!self::isStringASCII($string)) {
966
+        if (!self::isStringASCII($string)) {
967 967
             return \ForceUTF8\Encoding::toUTF8($string);
968 968
         }
969 969
         
@@ -981,11 +981,11 @@  discard block
 block discarded – undo
981 981
     */
982 982
     public static function isStringASCII($string) : bool
983 983
     {
984
-        if($string === '' || $string === NULL) {
984
+        if ($string === '' || $string === NULL) {
985 985
             return true;
986 986
         }
987 987
         
988
-        if(!is_string($string)) {
988
+        if (!is_string($string)) {
989 989
             return false;
990 990
         }
991 991
         
@@ -1019,7 +1019,7 @@  discard block
 block discarded – undo
1019 1019
     * @param array $options
1020 1020
     * @return float
1021 1021
     */
1022
-    public static function matchString($source, $target, $options=array())
1022
+    public static function matchString($source, $target, $options = array())
1023 1023
     {
1024 1024
         $defaults = array(
1025 1025
             'maxLevenshtein' => 10,
@@ -1029,12 +1029,12 @@  discard block
 block discarded – undo
1029 1029
         $options = array_merge($defaults, $options);
1030 1030
         
1031 1031
         // avoid doing this via levenshtein
1032
-        if($source == $target) {
1032
+        if ($source == $target) {
1033 1033
             return 100;
1034 1034
         }
1035 1035
         
1036 1036
         $diff = levenshtein($source, $target);
1037
-        if($diff > $options['maxLevenshtein']) {
1037
+        if ($diff > $options['maxLevenshtein']) {
1038 1038
             return 0;
1039 1039
         }
1040 1040
         
@@ -1118,24 +1118,24 @@  discard block
 block discarded – undo
1118 1118
     * @see ConvertHelper::INTERVAL_HOURS
1119 1119
     * @see ConvertHelper::INTERVAL_DAYS
1120 1120
     */
1121
-    public static function interval2total(\DateInterval $interval, $unit=self::INTERVAL_SECONDS) : int
1121
+    public static function interval2total(\DateInterval $interval, $unit = self::INTERVAL_SECONDS) : int
1122 1122
     {
1123 1123
         $total = (int)$interval->format('%a');
1124 1124
         if ($unit == self::INTERVAL_DAYS) {
1125 1125
             return $total;
1126 1126
         }
1127 1127
         
1128
-        $total = ($total * 24) + ((int)$interval->h );
1128
+        $total = ($total * 24) + ((int)$interval->h);
1129 1129
         if ($unit == self::INTERVAL_HOURS) {
1130 1130
             return $total;
1131 1131
         }
1132 1132
     
1133
-        $total = ($total * 60) + ((int)$interval->i );
1133
+        $total = ($total * 60) + ((int)$interval->i);
1134 1134
         if ($unit == self::INTERVAL_MINUTES) {
1135 1135
             return $total;
1136 1136
         }
1137 1137
 
1138
-        $total = ($total * 60) + ((int)$interval->s );
1138
+        $total = ($total * 60) + ((int)$interval->s);
1139 1139
         if ($unit == self::INTERVAL_SECONDS) {
1140 1140
             return $total;
1141 1141
         }
@@ -1164,13 +1164,13 @@  discard block
 block discarded – undo
1164 1164
     * @param bool $short
1165 1165
     * @return string|NULL
1166 1166
     */
1167
-    public static function date2dayName(\DateTime $date, bool $short=false)
1167
+    public static function date2dayName(\DateTime $date, bool $short = false)
1168 1168
     {
1169 1169
         $day = $date->format('l');
1170 1170
         $invariant = self::getDayNamesInvariant();
1171 1171
         
1172 1172
         $idx = array_search($day, $invariant);
1173
-        if($idx !== false) {
1173
+        if ($idx !== false) {
1174 1174
             $localized = self::getDayNames($short);
1175 1175
             return $localized[$idx];
1176 1176
         }
@@ -1193,10 +1193,10 @@  discard block
 block discarded – undo
1193 1193
     * @param bool $short
1194 1194
     * @return array
1195 1195
     */
1196
-    public static function getDayNames(bool $short=false) : array
1196
+    public static function getDayNames(bool $short = false) : array
1197 1197
     {
1198
-        if($short) {
1199
-            if(!isset(self::$daysShort)) {
1198
+        if ($short) {
1199
+            if (!isset(self::$daysShort)) {
1200 1200
                 self::$daysShort = array(
1201 1201
                     t('Mon'),
1202 1202
                     t('Tue'),
@@ -1211,7 +1211,7 @@  discard block
 block discarded – undo
1211 1211
             return self::$daysShort;
1212 1212
         }
1213 1213
         
1214
-        if(!isset(self::$days)) {
1214
+        if (!isset(self::$days)) {
1215 1215
             self::$days = array(
1216 1216
                 t('Monday'),
1217 1217
                 t('Tuesday'),
@@ -1236,17 +1236,17 @@  discard block
 block discarded – undo
1236 1236
      */
1237 1237
     public static function implodeWithAnd(array $list, $sep = ', ', $conjunction = null)
1238 1238
     {
1239
-        if(empty($list)) {
1239
+        if (empty($list)) {
1240 1240
             return '';
1241 1241
         }
1242 1242
         
1243
-        if(empty($conjunction)) {
1243
+        if (empty($conjunction)) {
1244 1244
             $conjunction = t('and');
1245 1245
         }
1246 1246
         
1247 1247
         $last = array_pop($list);
1248
-        if($list) {
1249
-            return implode($sep, $list) . $conjunction . ' ' . $last;
1248
+        if ($list) {
1249
+            return implode($sep, $list).$conjunction.' '.$last;
1250 1250
         }
1251 1251
         
1252 1252
         return $last;
@@ -1265,7 +1265,7 @@  discard block
 block discarded – undo
1265 1265
     public static function string2array(string $string) : array
1266 1266
     {
1267 1267
         $result = preg_split('//u', $string, null, PREG_SPLIT_NO_EMPTY);
1268
-        if($result !== false) {
1268
+        if ($result !== false) {
1269 1269
             return $result;
1270 1270
         }
1271 1271
         
@@ -1280,12 +1280,12 @@  discard block
 block discarded – undo
1280 1280
     */
1281 1281
     public static function isStringHTML(string $string) : bool
1282 1282
     {
1283
-        if(preg_match('%<[a-z/][\s\S]*>%siU', $string)) {
1283
+        if (preg_match('%<[a-z/][\s\S]*>%siU', $string)) {
1284 1284
             return true;
1285 1285
         }
1286 1286
         
1287 1287
         $decoded = html_entity_decode($string);
1288
-        if($decoded !== $string) {
1288
+        if ($decoded !== $string) {
1289 1289
             return true;
1290 1290
         }
1291 1291
         
@@ -1394,14 +1394,14 @@  discard block
 block discarded – undo
1394 1394
     * @param bool $caseInsensitive
1395 1395
     * @return ConvertHelper_StringMatch[]
1396 1396
     */
1397
-    public static function findString(string $needle, string $haystack, bool $caseInsensitive=false)
1397
+    public static function findString(string $needle, string $haystack, bool $caseInsensitive = false)
1398 1398
     {
1399
-        if($needle === '') {
1399
+        if ($needle === '') {
1400 1400
             return array();
1401 1401
         }
1402 1402
         
1403 1403
         $function = 'mb_strpos';
1404
-        if($caseInsensitive) {
1404
+        if ($caseInsensitive) {
1405 1405
             $function = 'mb_stripos';
1406 1406
         }
1407 1407
         
@@ -1409,7 +1409,7 @@  discard block
 block discarded – undo
1409 1409
         $positions = array();
1410 1410
         $length = mb_strlen($needle);
1411 1411
         
1412
-        while( ($pos = $function($haystack, $needle, $pos)) !== false) 
1412
+        while (($pos = $function($haystack, $needle, $pos)) !== false) 
1413 1413
         {
1414 1414
             $match = mb_substr($haystack, $pos, $length);
1415 1415
             $positions[] = new ConvertHelper_StringMatch($pos, $match);
@@ -1429,7 +1429,7 @@  discard block
 block discarded – undo
1429 1429
     */
1430 1430
     public static function explodeTrim(string $delimiter, string $string) : array
1431 1431
     {
1432
-        if(empty($string) || empty($delimiter)) {
1432
+        if (empty($string) || empty($delimiter)) {
1433 1433
             return array();
1434 1434
         }
1435 1435
         
@@ -1437,8 +1437,8 @@  discard block
 block discarded – undo
1437 1437
         $tokens = array_map('trim', $tokens);
1438 1438
         
1439 1439
         $keep = array();
1440
-        foreach($tokens as $token) {
1441
-            if($token !== '') {
1440
+        foreach ($tokens as $token) {
1441
+            if ($token !== '') {
1442 1442
                 $keep[] = $token;
1443 1443
             }
1444 1444
         }
@@ -1456,11 +1456,11 @@  discard block
 block discarded – undo
1456 1456
     */
1457 1457
     public static function detectEOLCharacter(string $subjectString) : ?ConvertHelper_EOL
1458 1458
     {
1459
-        if(empty($subjectString)) {
1459
+        if (empty($subjectString)) {
1460 1460
             return null;
1461 1461
         }
1462 1462
         
1463
-        if(!isset(self::$eolChars))
1463
+        if (!isset(self::$eolChars))
1464 1464
         {
1465 1465
             $cr = chr((int)hexdec('0d'));
1466 1466
             $lf = chr((int)hexdec('0a'));
@@ -1491,18 +1491,18 @@  discard block
 block discarded – undo
1491 1491
         
1492 1492
         $max = 0;
1493 1493
         $results = array();
1494
-        foreach(self::$eolChars as $def) 
1494
+        foreach (self::$eolChars as $def) 
1495 1495
         {
1496 1496
             $amount = substr_count($subjectString, $def['char']);
1497 1497
             
1498
-            if($amount > $max)
1498
+            if ($amount > $max)
1499 1499
             {
1500 1500
                 $max = $amount;
1501 1501
                 $results[] = $def;
1502 1502
             }
1503 1503
         }
1504 1504
         
1505
-        if(empty($results)) {
1505
+        if (empty($results)) {
1506 1506
             return null;
1507 1507
         }
1508 1508
         
@@ -1522,9 +1522,9 @@  discard block
 block discarded – undo
1522 1522
     */
1523 1523
     public static function arrayRemoveKeys(array &$array, array $keys) : void
1524 1524
     {
1525
-        foreach($keys as $key) 
1525
+        foreach ($keys as $key) 
1526 1526
         {
1527
-            if(array_key_exists($key, $array)) {
1527
+            if (array_key_exists($key, $array)) {
1528 1528
                 unset($array[$key]); 
1529 1529
             }
1530 1530
         }
@@ -1539,17 +1539,17 @@  discard block
 block discarded – undo
1539 1539
     */
1540 1540
     public static function isInteger($value) : bool
1541 1541
     {
1542
-        if(is_int($value)) {
1542
+        if (is_int($value)) {
1543 1543
             return true;
1544 1544
         }
1545 1545
         
1546 1546
         // booleans get converted to numbers, so they would
1547 1547
         // actually match the regex.
1548
-        if(is_bool($value)) {
1548
+        if (is_bool($value)) {
1549 1549
             return false;
1550 1550
         }
1551 1551
         
1552
-        if(is_string($value) && $value !== '') {
1552
+        if (is_string($value) && $value !== '') {
1553 1553
             return preg_match('/\A-?\d+\z/', $value) === 1;
1554 1554
         }
1555 1555
         
Please login to merge, or discard this patch.