Passed
Pull Request — master (#2)
by
unknown
04:39
created
src/Request/Param/Validator/Array.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -28,11 +28,11 @@
 block discarded – undo
28 28
     protected function _validate()
29 29
     {
30 30
         // subvalues cannot be arrays
31
-        if($this->isSubvalue) {
31
+        if ($this->isSubvalue) {
32 32
             return $this->value;
33 33
         }
34 34
         
35
-        if(is_array($this->value)) {
35
+        if (is_array($this->value)) {
36 36
             return $this->value;
37 37
         }
38 38
         
Please login to merge, or discard this patch.
src/Request/Param/Validator/Valueslist.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -33,22 +33,22 @@
 block discarded – undo
33 33
         
34 34
         // if we are validating a subvalue, it means we are 
35 35
         // validating a single value in the existing list.
36
-        if($this->isSubvalue) 
36
+        if ($this->isSubvalue) 
37 37
         {
38
-            if(in_array($this->value, $allowed)) {
38
+            if (in_array($this->value, $allowed)) {
39 39
                 return $this->value;
40 40
             }
41 41
             
42 42
             return null;
43 43
         }
44 44
         
45
-        if(!is_array($this->value)) {
45
+        if (!is_array($this->value)) {
46 46
             return array();
47 47
         }
48 48
         
49 49
         $keep = array();
50
-        foreach($this->value as $item) {
51
-            if(in_array($item, $allowed)) {
50
+        foreach ($this->value as $item) {
51
+            if (in_array($item, $allowed)) {
52 52
                 $keep[] = $item;
53 53
             }
54 54
         }
Please login to merge, or discard this patch.
src/RequestHelper/Boundaries/Boundary.php 2 patches
Indentation   +47 added lines, -47 removed lines patch added patch discarded remove patch
@@ -19,34 +19,34 @@  discard block
 block discarded – undo
19 19
  */
20 20
 class RequestHelper_Boundaries_Boundary
21 21
 {
22
-   /**
23
-    * @var string
24
-    */
22
+    /**
23
+     * @var string
24
+     */
25 25
     protected $content;
26 26
     
27
-   /**
28
-    * @var array
29
-    */
27
+    /**
28
+     * @var array
29
+     */
30 30
     protected $dispositionParams = array();
31 31
 
32
-   /**
33
-    * @var string
34
-    */
32
+    /**
33
+     * @var string
34
+     */
35 35
     protected $contentType = '';
36 36
 
37
-   /**
38
-    * @var string
39
-    */
37
+    /**
38
+     * @var string
39
+     */
40 40
     protected $contentEncoding = '';
41 41
     
42
-   /**
43
-    * @var RequestHelper_Boundaries
44
-    */
42
+    /**
43
+     * @var RequestHelper_Boundaries
44
+     */
45 45
     protected $boundaries;
46 46
     
47
-   /**
48
-    * @var string
49
-    */
47
+    /**
48
+     * @var string
49
+     */
50 50
     protected $transferEncoding = '';
51 51
     
52 52
     public function __construct(RequestHelper_Boundaries $boundaries, string $content)
@@ -60,46 +60,46 @@  discard block
 block discarded – undo
60 60
         return strlen($this->content);
61 61
     }
62 62
     
63
-   /**
64
-    * Sets the name of the request parameter.
65
-    * 
66
-    * @param string $name
67
-    * @return RequestHelper_Boundaries_Boundary
68
-    */
63
+    /**
64
+     * Sets the name of the request parameter.
65
+     * 
66
+     * @param string $name
67
+     * @return RequestHelper_Boundaries_Boundary
68
+     */
69 69
     public function setName(string $name) : RequestHelper_Boundaries_Boundary
70 70
     {
71 71
         return $this->setDispositionParam('name', $name);
72 72
     }
73 73
     
74
-   /**
75
-    * Sets the filename to use for the content, if applicable.
76
-    *  
77
-    * @param string $fileName
78
-    * @return RequestHelper_Boundaries_Boundary
79
-    */
74
+    /**
75
+     * Sets the filename to use for the content, if applicable.
76
+     *  
77
+     * @param string $fileName
78
+     * @return RequestHelper_Boundaries_Boundary
79
+     */
80 80
     public function setFileName(string $fileName) : RequestHelper_Boundaries_Boundary
81 81
     {
82 82
         return $this->setDispositionParam('filename', $fileName);
83 83
     }
84 84
     
85
-   /**
86
-    * Sets the content type to use for the content.
87
-    * 
88
-    * @param string $contentType
89
-    * @return RequestHelper_Boundaries_Boundary
90
-    */
85
+    /**
86
+     * Sets the content type to use for the content.
87
+     * 
88
+     * @param string $contentType
89
+     * @return RequestHelper_Boundaries_Boundary
90
+     */
91 91
     public function setContentType(string $contentType) : RequestHelper_Boundaries_Boundary
92 92
     {
93 93
         $this->contentType = $contentType;
94 94
         return $this;
95 95
     }
96 96
     
97
-   /**
98
-    * Sets the encoding to specify for the content.
99
-    * 
100
-    * @param string $encoding An encoding string, e.g. "UTF-8", "ASCII"
101
-    * @return RequestHelper_Boundaries_Boundary
102
-    */
97
+    /**
98
+     * Sets the encoding to specify for the content.
99
+     * 
100
+     * @param string $encoding An encoding string, e.g. "UTF-8", "ASCII"
101
+     * @return RequestHelper_Boundaries_Boundary
102
+     */
103 103
     public function setContentEncoding(string $encoding) : RequestHelper_Boundaries_Boundary
104 104
     {
105 105
         $this->contentEncoding = $encoding;
@@ -119,11 +119,11 @@  discard block
 block discarded – undo
119 119
         return $this;
120 120
     }
121 121
     
122
-   /**
123
-    * Renders the mime boundary text.
124
-    * 
125
-    * @return string
126
-    */
122
+    /**
123
+     * Renders the mime boundary text.
124
+     * 
125
+     * @return string
126
+     */
127 127
     public function render()
128 128
     {
129 129
         $eol = $this->boundaries->getEOL();
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -132,12 +132,12 @@  discard block
 block discarded – undo
132 132
         $lines[] = '--'.$this->boundaries->getMimeBoundary();
133 133
         $lines[] = $this->renderContentDisposition();
134 134
         
135
-        if(!empty($this->contentType)) 
135
+        if (!empty($this->contentType)) 
136 136
         {
137 137
             $lines[] = $this->renderContentType();
138 138
         }
139 139
         
140
-        if(!empty($this->transferEncoding))
140
+        if (!empty($this->transferEncoding))
141 141
         {
142 142
             $lines[] = $this->renderTransferEncoding();
143 143
         }
@@ -152,9 +152,9 @@  discard block
 block discarded – undo
152 152
     {
153 153
         $result = 'Content-Disposition: form-data';
154 154
         
155
-        foreach($this->dispositionParams as $name => $value) 
155
+        foreach ($this->dispositionParams as $name => $value) 
156 156
         {
157
-            $result .= '; '.$name.'="' . $value . '"';
157
+            $result .= '; '.$name.'="'.$value.'"';
158 158
         }   
159 159
         
160 160
         return $result;
@@ -162,11 +162,11 @@  discard block
 block discarded – undo
162 162
     
163 163
     protected function renderContentType() : string
164 164
     {
165
-        $result = 'Content-Type: ' . $this->contentType; 
165
+        $result = 'Content-Type: '.$this->contentType; 
166 166
         
167
-        if(!empty($this->contentEncoding)) 
167
+        if (!empty($this->contentEncoding)) 
168 168
         {
169
-            $result .= '; charset="' . $this->contentEncoding.'"';
169
+            $result .= '; charset="'.$this->contentEncoding.'"';
170 170
         }
171 171
         
172 172
         return $result;
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
     
175 175
     protected function renderTransferEncoding() : string
176 176
     {
177
-        $result = 'Content-Transfer-Encoding: ' . $this->transferEncoding;
177
+        $result = 'Content-Transfer-Encoding: '.$this->transferEncoding;
178 178
         
179 179
         return $result;
180 180
     }
Please login to merge, or discard this patch.
src/RequestHelper/Boundaries.php 2 patches
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -83,12 +83,12 @@  discard block
 block discarded – undo
83 83
     */
84 84
     public function addFile(string $varName, string $fileName, string $content, string $contentType = '', string $encoding = '') : RequestHelper_Boundaries
85 85
     {
86
-        if(empty($contentType))
86
+        if (empty($contentType))
87 87
         {
88 88
             $contentType = (string)FileHelper::detectMimeType($fileName);
89 89
         }
90 90
         
91
-        if(empty($encoding))
91
+        if (empty($encoding))
92 92
         {
93 93
             $encoding = RequestHelper::ENCODING_UTF8;
94 94
             $content = ConvertHelper::string2utf8($content);
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
     */
154 154
     public function render() : string
155 155
     {
156
-        if(empty($this->boundaries)) 
156
+        if (empty($this->boundaries)) 
157 157
         {
158 158
             throw new RequestHelper_Exception(
159 159
                 'No mime boundaries added',
@@ -164,13 +164,13 @@  discard block
 block discarded – undo
164 164
         
165 165
         $result = '';
166 166
         
167
-        foreach($this->boundaries as $boundary)
167
+        foreach ($this->boundaries as $boundary)
168 168
         {
169 169
             $result .= $boundary->render();
170 170
         }
171 171
         
172
-        $result .= "--" . $this->getMimeBoundary() . "--" . 
173
-        $this->getEOL() . $this->getEOL(); // always finish with two eol's!!
172
+        $result .= "--".$this->getMimeBoundary()."--". 
173
+        $this->getEOL().$this->getEOL(); // always finish with two eol's!!
174 174
         
175 175
         return $result;
176 176
     }
Please login to merge, or discard this patch.
Indentation   +52 added lines, -52 removed lines patch added patch discarded remove patch
@@ -22,19 +22,19 @@  discard block
 block discarded – undo
22 22
 {
23 23
     const ERROR_NO_BOUNDARIES_SPECIFIED = 44401;
24 24
     
25
-   /**
26
-    * @var RequestHelper
27
-    */
25
+    /**
26
+     * @var RequestHelper
27
+     */
28 28
     protected $helper;
29 29
 
30
-   /**
31
-    * @var RequestHelper_Boundaries_Boundary[]
32
-    */
30
+    /**
31
+     * @var RequestHelper_Boundaries_Boundary[]
32
+     */
33 33
     protected $boundaries = array();
34 34
     
35
-   /**
36
-    * @var integer
37
-    */
35
+    /**
36
+     * @var integer
37
+     */
38 38
     protected $contentLength = 0;
39 39
     
40 40
     public function __construct(RequestHelper $helper)
@@ -42,31 +42,31 @@  discard block
 block discarded – undo
42 42
         $this->helper = $helper;
43 43
     }
44 44
     
45
-   /**
46
-    * Retrieves the string that is used to separate mime boundaries in the body.
47
-    * 
48
-    * @return string
49
-    */
45
+    /**
46
+     * Retrieves the string that is used to separate mime boundaries in the body.
47
+     * 
48
+     * @return string
49
+     */
50 50
     public function getMimeBoundary() : string
51 51
     {
52 52
         return $this->helper->getMimeBoundary();
53 53
     }
54 54
     
55
-   /**
56
-    * Retrieves the end of line character(s) used in the body.
57
-    * 
58
-    * @return string
59
-    */
55
+    /**
56
+     * Retrieves the end of line character(s) used in the body.
57
+     * 
58
+     * @return string
59
+     */
60 60
     public function getEOL() : string
61 61
     {
62 62
         return $this->helper->getEOL();
63 63
     }
64 64
     
65
-   /**
66
-    * Retrieves the total content length of all boundary contents.
67
-    * 
68
-    * @return int
69
-    */
65
+    /**
66
+     * Retrieves the total content length of all boundary contents.
67
+     * 
68
+     * @return int
69
+     */
70 70
     public function getContentLength() : int
71 71
     {
72 72
         // this must use strlen, and not mb_strlen: the content length
@@ -75,15 +75,15 @@  discard block
 block discarded – undo
75 75
         return strlen($this->render());
76 76
     }
77 77
     
78
-   /**
79
-    * Adds a file to be sent with the request.
80
-    *
81
-    * @param string $varName The variable name to send the file in
82
-    * @param string $fileName The name of the file as it should be received at the destination
83
-    * @param string $content The raw content of the file
84
-    * @param string $contentType The content type, use the constants to specify this
85
-    * @param string $encoding The encoding of the file, use the constants to specify this
86
-    */
78
+    /**
79
+     * Adds a file to be sent with the request.
80
+     *
81
+     * @param string $varName The variable name to send the file in
82
+     * @param string $fileName The name of the file as it should be received at the destination
83
+     * @param string $content The raw content of the file
84
+     * @param string $contentType The content type, use the constants to specify this
85
+     * @param string $encoding The encoding of the file, use the constants to specify this
86
+     */
87 87
     public function addFile(string $varName, string $fileName, string $content, string $contentType = '', string $encoding = '') : RequestHelper_Boundaries
88 88
     {
89 89
         if(empty($contentType))
@@ -107,13 +107,13 @@  discard block
 block discarded – undo
107 107
         return $this->addBoundary($boundary);
108 108
     }
109 109
     
110
-   /**
111
-    * Adds arbitrary content.
112
-    *
113
-    * @param string $varName
114
-    * @param string $content
115
-    * @param string $contentType
116
-    */
110
+    /**
111
+     * Adds arbitrary content.
112
+     *
113
+     * @param string $varName
114
+     * @param string $content
115
+     * @param string $contentType
116
+     */
117 117
     public function addContent(string $varName, string $content, string $contentType) : RequestHelper_Boundaries
118 118
     {
119 119
         $content = ConvertHelper::string2utf8($content);
@@ -127,13 +127,13 @@  discard block
 block discarded – undo
127 127
         return $this->addBoundary($boundary);
128 128
     }
129 129
     
130
-   /**
131
-    * Adds a variable to be sent with the request. If it
132
-    * already exists, its value is overwritten.
133
-    *
134
-    * @param string $name
135
-    * @param string $value
136
-    */
130
+    /**
131
+     * Adds a variable to be sent with the request. If it
132
+     * already exists, its value is overwritten.
133
+     *
134
+     * @param string $name
135
+     * @param string $value
136
+     */
137 137
     public function addVariable(string $name, string $value) : RequestHelper_Boundaries
138 138
     {
139 139
         $boundary = $this->createBoundary($value)
@@ -149,11 +149,11 @@  discard block
 block discarded – undo
149 149
         return $this;
150 150
     }
151 151
     
152
-   /**
153
-    * Renders the response body with all mime boundaries.
154
-    * 
155
-    * @return string
156
-    */
152
+    /**
153
+     * Renders the response body with all mime boundaries.
154
+     * 
155
+     * @return string
156
+     */
157 157
     public function render() : string
158 158
     {
159 159
         if(empty($this->boundaries)) 
Please login to merge, or discard this patch.
src/URLInfo/Highlighter.php 2 patches
Indentation   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -20,9 +20,9 @@  discard block
 block discarded – undo
20 20
  */
21 21
 class URLInfo_Highlighter
22 22
 {
23
-   /**
24
-    * @var URLInfo
25
-    */
23
+    /**
24
+     * @var URLInfo
25
+     */
26 26
     protected $info;
27 27
     
28 28
     public function __construct(URLInfo $info)
@@ -158,13 +158,13 @@  discard block
 block discarded – undo
158 158
         );
159 159
     }
160 160
     
161
-   /**
162
-    * Fetches all parameters in the URL, regardless of 
163
-    * whether parameter exclusion is enabled, so they
164
-    * can be highlighted is need be.
165
-    * 
166
-    * @return array
167
-    */
161
+    /**
162
+     * Fetches all parameters in the URL, regardless of 
163
+     * whether parameter exclusion is enabled, so they
164
+     * can be highlighted is need be.
165
+     * 
166
+     * @return array
167
+     */
168 168
     protected function resolveParams() : array
169 169
     {
170 170
         $previous = $this->info->isParamExclusionEnabled();
Please login to merge, or discard this patch.
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
             'fragment'
78 78
         );
79 79
         
80
-        foreach($parts as $part) 
80
+        foreach ($parts as $part) 
81 81
         {
82 82
             $method = 'render_'.$part;
83 83
             $result[] = (string)$this->$method();
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
     
89 89
     protected function render_scheme() : string
90 90
     {
91
-        if(!$this->info->hasScheme()) {
91
+        if (!$this->info->hasScheme()) {
92 92
             return '';
93 93
         }
94 94
         
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
     
104 104
     protected function render_username() : string
105 105
     {
106
-        if(!$this->info->hasUsername()) {
106
+        if (!$this->info->hasUsername()) {
107 107
             return '';
108 108
         }
109 109
         
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
     
120 120
     protected function render_host() : string
121 121
     {
122
-        if(!$this->info->hasHost()) {
122
+        if (!$this->info->hasHost()) {
123 123
             return '';
124 124
         }
125 125
         
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
     
132 132
     protected function render_port() : string
133 133
     {
134
-        if(!$this->info->hasPort()) {
134
+        if (!$this->info->hasPort()) {
135 135
             return '';
136 136
         }
137 137
         
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
        
145 145
     protected function render_path() : string
146 146
     {
147
-        if(!$this->info->hasPath()) {
147
+        if (!$this->info->hasPath()) {
148 148
             return '';
149 149
         }
150 150
         
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
     {
170 170
         $previous = $this->info->isParamExclusionEnabled();
171 171
         
172
-        if($previous)
172
+        if ($previous)
173 173
         {
174 174
             $this->info->setParamExclusion(false);
175 175
         }
@@ -185,19 +185,19 @@  discard block
 block discarded – undo
185 185
     {
186 186
         $params = $this->resolveParams();
187 187
         
188
-        if(empty($params)) {
188
+        if (empty($params)) {
189 189
             return '';
190 190
         }
191 191
         
192 192
         $tokens = array();
193 193
         $excluded = array();
194 194
         
195
-        if($this->info->isParamExclusionEnabled())
195
+        if ($this->info->isParamExclusionEnabled())
196 196
         {
197 197
             $excluded = $this->info->getExcludedParams();
198 198
         }
199 199
         
200
-        foreach($params as $param => $value)
200
+        foreach ($params as $param => $value)
201 201
         {
202 202
             // If the parameter is numeric, it will automatically
203 203
             // be an integer, so we need the conversion here.
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
             
219 219
             $tag = $this->resolveTag($excluded, $param);
220 220
             
221
-            if(!empty($tag))
221
+            if (!empty($tag))
222 222
             {
223 223
                 $tokens[] = sprintf($tag, $parts);
224 224
             }
@@ -232,13 +232,13 @@  discard block
 block discarded – undo
232 232
     protected function resolveTag(array $excluded, string $paramName) : string
233 233
     {
234 234
         // regular, non-excluded parameter
235
-        if(!isset($excluded[$paramName]))
235
+        if (!isset($excluded[$paramName]))
236 236
         {
237 237
             return '<span class="link-param">%s</span>';
238 238
         }
239 239
 
240 240
         // highlight excluded parameters is disabled, ignore this parameter
241
-        if(!$this->info->isHighlightExcludeEnabled())
241
+        if (!$this->info->isHighlightExcludeEnabled())
242 242
         {
243 243
             return '';
244 244
         }
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
      
255 255
     protected function render_fragment() : string
256 256
     {
257
-        if(!$this->info->hasFragment()) {
257
+        if (!$this->info->hasFragment()) {
258 258
             return '';
259 259
         }
260 260
         
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
     {
270 270
         $cssFolder = realpath(__DIR__.'/../../css');
271 271
         
272
-        if($cssFolder === false) {
272
+        if ($cssFolder === false) {
273 273
             throw new BaseException(
274 274
                 'Cannot find package CSS folder.',
275 275
                 null,
Please login to merge, or discard this patch.
src/ConvertHelper/QueryParser.php 2 patches
Indentation   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -27,16 +27,16 @@
 block discarded – undo
27 27
         
28 28
     }
29 29
     
30
-   /**
31
-    * We parse the query string ourselves, because the PHP implementation
32
-    * of parse_str has limitations that do not apply to query strings. This
33
-    * is due to the fact that parse_str has to create PHP-compatible variable
34
-    * names from the parameters. URL parameters simply allow way more things
35
-    * than PHP variable names.
36
-    * 
37
-    * @param string $queryString
38
-    * @return array
39
-    */
30
+    /**
31
+     * We parse the query string ourselves, because the PHP implementation
32
+     * of parse_str has limitations that do not apply to query strings. This
33
+     * is due to the fact that parse_str has to create PHP-compatible variable
34
+     * names from the parameters. URL parameters simply allow way more things
35
+     * than PHP variable names.
36
+     * 
37
+     * @param string $queryString
38
+     * @return array
39
+     */
40 40
     public function parse(string $queryString) : array
41 41
     {
42 42
         // allow HTML entities notation
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
         
47 47
         $result = array();
48 48
         
49
-        foreach($parts as $part)
49
+        foreach ($parts as $part)
50 50
         {
51 51
             $tokens = explode('=', $part);
52 52
             
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 
56 56
             $trimmed = trim($name);
57 57
             
58
-            if(empty($trimmed))
58
+            if (empty($trimmed))
59 59
             {
60 60
                 continue;
61 61
             }
Please login to merge, or discard this patch.
src/URLInfo/Parser.php 3 patches
Indentation   +73 added lines, -73 removed lines patch added patch discarded remove patch
@@ -23,24 +23,24 @@  discard block
 block discarded – undo
23 23
  */
24 24
 class URLInfo_Parser
25 25
 {
26
-   /**
27
-    * @var string
28
-    */
26
+    /**
27
+     * @var string
28
+     */
29 29
     protected $url;
30 30
     
31
-   /**
32
-    * @var bool
33
-    */
31
+    /**
32
+     * @var bool
33
+     */
34 34
     protected $isValid = false;
35 35
     
36
-   /**
37
-    * @var array
38
-    */
36
+    /**
37
+     * @var array
38
+     */
39 39
     protected $info;
40 40
     
41
-   /**
42
-    * @var array|NULL
43
-    */
41
+    /**
42
+     * @var array|NULL
43
+     */
44 44
     protected $error;
45 45
     
46 46
     /**
@@ -56,25 +56,25 @@  discard block
 block discarded – undo
56 56
         'file'
57 57
     );
58 58
     
59
-   /**
60
-    * Stores a list of all unicode characters in the URL
61
-    * that have been filtered out before parsing it with
62
-    * parse_url.
63
-    * 
64
-    * @var string[]string
65
-    */
59
+    /**
60
+     * Stores a list of all unicode characters in the URL
61
+     * that have been filtered out before parsing it with
62
+     * parse_url.
63
+     * 
64
+     * @var string[]string
65
+     */
66 66
     protected $unicodeChars = array();
67 67
     
68
-   /**
69
-    * @var bool
70
-    */
68
+    /**
69
+     * @var bool
70
+     */
71 71
     protected $encodeUTF = false;
72 72
     
73
-   /**
74
-    * 
75
-    * @param string $url The target URL.
76
-    * @param bool $encodeUTF Whether to URL encode any plain text unicode characters.
77
-    */
73
+    /**
74
+     * 
75
+     * @param string $url The target URL.
76
+     * @param bool $encodeUTF Whether to URL encode any plain text unicode characters.
77
+     */
78 78
     public function __construct(string $url, bool $encodeUTF)
79 79
     {
80 80
         $this->url = $url;
@@ -87,12 +87,12 @@  discard block
 block discarded – undo
87 87
         }
88 88
     }
89 89
 
90
-   /**
91
-    * Retrieves the array as parsed by PHP's parse_url,
92
-    * filtered and adjusted as necessary.
93
-    * 
94
-    * @return array
95
-    */
90
+    /**
91
+     * Retrieves the array as parsed by PHP's parse_url,
92
+     * filtered and adjusted as necessary.
93
+     * 
94
+     * @return array
95
+     */
96 96
     public function getInfo() : array
97 97
     {
98 98
         return $this->info;
@@ -114,11 +114,11 @@  discard block
 block discarded – undo
114 114
         }
115 115
     }
116 116
     
117
-   /**
118
-    * Finds any non-url encoded unicode characters in 
119
-    * the URL, and encodes them before the URL is 
120
-    * passed to parse_url.
121
-    */
117
+    /**
118
+     * Finds any non-url encoded unicode characters in 
119
+     * the URL, and encodes them before the URL is 
120
+     * passed to parse_url.
121
+     */
122 122
     protected function filterUnicodeChars() : void
123 123
     {
124 124
         $chars = \AppUtils\ConvertHelper::string2array($this->url);
@@ -236,11 +236,11 @@  discard block
 block discarded – undo
236 236
         return false;
237 237
     }
238 238
 
239
-   /**
240
-    * Goes through all information in the parse_url result
241
-    * array, and attempts to fix any user errors in formatting
242
-    * that can be recovered from, mostly regarding stray spaces.
243
-    */
239
+    /**
240
+     * Goes through all information in the parse_url result
241
+     * array, and attempts to fix any user errors in formatting
242
+     * that can be recovered from, mostly regarding stray spaces.
243
+     */
244 244
     protected function filterParsed()
245 245
     {
246 246
         $this->info['params'] = array();
@@ -269,13 +269,13 @@  discard block
 block discarded – undo
269 269
         }
270 270
     }
271 271
     
272
-   /**
273
-    * Recursively goes through the array, and converts all previously
274
-    * URL encoded characters with their unicode character counterparts.
275
-    * 
276
-    * @param array $subject
277
-    * @return array
278
-    */
272
+    /**
273
+     * Recursively goes through the array, and converts all previously
274
+     * URL encoded characters with their unicode character counterparts.
275
+     * 
276
+     * @param array $subject
277
+     * @return array
278
+     */
279 279
     protected function restoreUnicodeChars(array $subject) : array
280 280
     {
281 281
         $result = array();
@@ -299,13 +299,13 @@  discard block
 block discarded – undo
299 299
         return $result;
300 300
     }
301 301
     
302
-   /**
303
-    * Replaces all URL encoded unicode characters
304
-    * in the string with the unicode character.
305
-    * 
306
-    * @param string $string
307
-    * @return string
308
-    */
302
+    /**
303
+     * Replaces all URL encoded unicode characters
304
+     * in the string with the unicode character.
305
+     * 
306
+     * @param string $string
307
+     * @return string
308
+     */
309 309
     protected function restoreUnicodeChar(string $string) : string
310 310
     {
311 311
         if(strstr($string, '%'))
@@ -363,21 +363,21 @@  discard block
 block discarded – undo
363 363
         );
364 364
     }
365 365
    
366
-   /**
367
-    * Checks whether the URL that was parsed is valid.
368
-    * @return bool
369
-    */
366
+    /**
367
+     * Checks whether the URL that was parsed is valid.
368
+     * @return bool
369
+     */
370 370
     public function isValid() : bool
371 371
     {
372 372
         return $this->isValid;
373 373
     }
374 374
 
375
-   /**
376
-    * If the validation failed, retrieves the validation
377
-    * error message.
378
-    * 
379
-    * @return string
380
-    */
375
+    /**
376
+     * If the validation failed, retrieves the validation
377
+     * error message.
378
+     * 
379
+     * @return string
380
+     */
381 381
     public function getErrorMessage() : string
382 382
     {
383 383
         if(isset($this->error)) {
@@ -387,12 +387,12 @@  discard block
 block discarded – undo
387 387
         return '';
388 388
     }
389 389
     
390
-   /**
391
-    * If the validation failed, retrieves the validation
392
-    * error code.
393
-    * 
394
-    * @return int
395
-    */
390
+    /**
391
+     * If the validation failed, retrieves the validation
392
+     * error code.
393
+     * 
394
+     * @return int
395
+     */
396 396
     public function getErrorCode() : int
397 397
     {
398 398
         if(isset($this->error)) {
Please login to merge, or discard this patch.
Spacing   +28 added lines, -28 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
         
83 83
         $this->parse();
84 84
         
85
-        if(!$this->detectType()) {
85
+        if (!$this->detectType()) {
86 86
             $this->validate();
87 87
         }
88 88
     }
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
         
109 109
         // if the URL contains any URL characters, and we
110 110
         // do not want them URL encoded, restore them.
111
-        if(!$this->encodeUTF && !empty($this->unicodeChars))
111
+        if (!$this->encodeUTF && !empty($this->unicodeChars))
112 112
         {
113 113
             $this->info = $this->restoreUnicodeChars($this->info);
114 114
         }
@@ -125,13 +125,13 @@  discard block
 block discarded – undo
125 125
         
126 126
         $keep = array();
127 127
         
128
-        foreach($chars as $char)
128
+        foreach ($chars as $char)
129 129
         {
130
-            if(preg_match('/\p{L}/usix', $char))
130
+            if (preg_match('/\p{L}/usix', $char))
131 131
             {
132 132
                 $encoded = rawurlencode($char);
133 133
                 
134
-                if($encoded != $char)
134
+                if ($encoded != $char)
135 135
                 {
136 136
                     $this->unicodeChars[$encoded] = $char;
137 137
                     $char = $encoded;
@@ -152,11 +152,11 @@  discard block
 block discarded – undo
152 152
             'phoneLink'
153 153
         );
154 154
         
155
-        foreach($types as $type)
155
+        foreach ($types as $type)
156 156
         {
157 157
             $method = 'detectType_'.$type;
158 158
             
159
-            if($this->$method() === true) 
159
+            if ($this->$method() === true) 
160 160
             {
161 161
                 $this->isValid = true;
162 162
                 return true;
@@ -174,11 +174,11 @@  discard block
 block discarded – undo
174 174
             'hostIsPresent'
175 175
         );
176 176
         
177
-        foreach($validations as $validation) 
177
+        foreach ($validations as $validation) 
178 178
         {
179 179
             $method = 'validate_'.$validation;
180 180
             
181
-            if($this->$method() !== true) {
181
+            if ($this->$method() !== true) {
182 182
                 return;
183 183
             }
184 184
         }
@@ -191,13 +191,13 @@  discard block
 block discarded – undo
191 191
         // every link needs a host. This case can happen for ex, if
192 192
         // the link starts with a typo with only one slash, like:
193 193
         // "http:/hostname"
194
-        if(isset($this->info['host'])) {
194
+        if (isset($this->info['host'])) {
195 195
             return true;
196 196
         }
197 197
         
198 198
         $this->setError(
199 199
             URLInfo::ERROR_MISSING_HOST,
200
-            t('Cannot determine the link\'s host name.') . ' ' .
200
+            t('Cannot determine the link\'s host name.').' '.
201 201
             t('This usually happens when there\'s a typo somewhere.')
202 202
         );
203 203
 
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
     
207 207
     protected function validate_schemeIsSet() : bool
208 208
     {
209
-        if(isset($this->info['scheme'])) {
209
+        if (isset($this->info['scheme'])) {
210 210
             return true;
211 211
         }
212 212
         
@@ -223,13 +223,13 @@  discard block
 block discarded – undo
223 223
     
224 224
     protected function validate_schemeIsKnown() : bool
225 225
     {
226
-        if(in_array($this->info['scheme'], $this->knownSchemes)) {
226
+        if (in_array($this->info['scheme'], $this->knownSchemes)) {
227 227
             return true;
228 228
         }
229 229
         
230 230
         $this->setError(
231 231
             URLInfo::ERROR_INVALID_SCHEME,
232
-            t('The scheme %1$s is not supported for links.', $this->info['scheme']) . ' ' .
232
+            t('The scheme %1$s is not supported for links.', $this->info['scheme']).' '.
233 233
             t('Valid schemes are: %1$s.', implode(', ', $this->knownSchemes))
234 234
         );
235 235
 
@@ -246,23 +246,23 @@  discard block
 block discarded – undo
246 246
         $this->info['params'] = array();
247 247
         $this->info['type'] = URLInfo::TYPE_URL;
248 248
         
249
-        if(isset($this->info['user'])) {
249
+        if (isset($this->info['user'])) {
250 250
             $this->info['user'] = urldecode($this->info['user']);
251 251
         }
252 252
 
253
-        if(isset($this->info['pass'])) {
253
+        if (isset($this->info['pass'])) {
254 254
             $this->info['pass'] = urldecode($this->info['pass']);
255 255
         }
256 256
         
257
-        if(isset($this->info['host'])) {
257
+        if (isset($this->info['host'])) {
258 258
             $this->info['host'] = str_replace(' ', '', $this->info['host']);
259 259
         }
260 260
         
261
-        if(isset($this->info['path'])) {
261
+        if (isset($this->info['path'])) {
262 262
             $this->info['path'] = str_replace(' ', '', $this->info['path']);
263 263
         }
264 264
         
265
-        if(isset($this->info['query']) && !empty($this->info['query']))
265
+        if (isset($this->info['query']) && !empty($this->info['query']))
266 266
         {
267 267
             $this->info['params'] = \AppUtils\ConvertHelper::parseQueryString($this->info['query']);
268 268
             ksort($this->info['params']);
@@ -280,9 +280,9 @@  discard block
 block discarded – undo
280 280
     {
281 281
         $result = array();
282 282
         
283
-        foreach($subject as $key => $val)
283
+        foreach ($subject as $key => $val)
284 284
         {
285
-            if(is_array($val))
285
+            if (is_array($val))
286 286
             {
287 287
                 $val = $this->restoreUnicodeChars($val);
288 288
             }
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
     */
309 309
     protected function restoreUnicodeChar(string $string) : string
310 310
     {
311
-        if(strstr($string, '%'))
311
+        if (strstr($string, '%'))
312 312
         {
313 313
             return str_replace(array_keys($this->unicodeChars), array_values($this->unicodeChars), $string);
314 314
         }
@@ -318,12 +318,12 @@  discard block
 block discarded – undo
318 318
     
319 319
     protected function detectType_email() : bool
320 320
     {
321
-        if(isset($this->info['scheme']) && $this->info['scheme'] == 'mailto') {
321
+        if (isset($this->info['scheme']) && $this->info['scheme'] == 'mailto') {
322 322
             $this->info['type'] = URLInfo::TYPE_EMAIL;
323 323
             return true;
324 324
         }
325 325
         
326
-        if(isset($this->info['path']) && preg_match(\AppUtils\RegexHelper::REGEX_EMAIL, $this->info['path']))
326
+        if (isset($this->info['path']) && preg_match(\AppUtils\RegexHelper::REGEX_EMAIL, $this->info['path']))
327 327
         {
328 328
             $this->info['scheme'] = 'mailto';
329 329
             $this->info['type'] = URLInfo::TYPE_EMAIL;
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
     
336 336
     protected function detectType_fragmentLink() : bool
337 337
     {
338
-        if(isset($this->info['fragment']) && !isset($this->info['scheme'])) {
338
+        if (isset($this->info['fragment']) && !isset($this->info['scheme'])) {
339 339
             $this->info['type'] = URLInfo::TYPE_FRAGMENT;
340 340
             return true;
341 341
         }
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
     
346 346
     protected function detectType_phoneLink() : bool
347 347
     {
348
-        if(isset($this->info['scheme']) && $this->info['scheme'] == 'tel') {
348
+        if (isset($this->info['scheme']) && $this->info['scheme'] == 'tel') {
349 349
             $this->info['type'] = URLInfo::TYPE_PHONE;
350 350
             return true;
351 351
         }
@@ -380,7 +380,7 @@  discard block
 block discarded – undo
380 380
     */
381 381
     public function getErrorMessage() : string
382 382
     {
383
-        if(isset($this->error)) {
383
+        if (isset($this->error)) {
384 384
             return $this->error['message'];
385 385
         }
386 386
         
@@ -395,7 +395,7 @@  discard block
 block discarded – undo
395 395
     */
396 396
     public function getErrorCode() : int
397 397
     {
398
-        if(isset($this->error)) {
398
+        if (isset($this->error)) {
399 399
             return $this->error['code'];
400 400
         }
401 401
         
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -285,8 +285,7 @@
 block discarded – undo
285 285
             if(is_array($val))
286 286
             {
287 287
                 $val = $this->restoreUnicodeChars($val);
288
-            }
289
-            else
288
+            } else
290 289
             {
291 290
                 $val = $this->restoreUnicodeChar($val);
292 291
             }
Please login to merge, or discard this patch.
src/ConvertHelper/ControlCharacters.php 2 patches
Indentation   +43 added lines, -43 removed lines patch added patch discarded remove patch
@@ -22,9 +22,9 @@  discard block
 block discarded – undo
22 22
 {
23 23
     const ERROR_MALFORMATTED_STRING = 53801;
24 24
     
25
-   /**
26
-    * @var string[]
27
-    */
25
+    /**
26
+     * @var string[]
27
+     */
28 28
     protected static $controlChars =  array(
29 29
         '0000-0008', // control chars
30 30
         '000E-000F', // control chars
@@ -32,19 +32,19 @@  discard block
 block discarded – undo
32 32
         '2000-200F', // non-breaking space and co
33 33
     );
34 34
     
35
-   /**
36
-    * @var string|NULL
37
-    */
35
+    /**
36
+     * @var string|NULL
37
+     */
38 38
     protected static $controlCharsRegex;
39 39
 
40
-   /**
41
-    * @var string[]
42
-    */
40
+    /**
41
+     * @var string[]
42
+     */
43 43
     protected static $hexAlphabet = array('0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C', 'D', 'E', 'F');
44 44
     
45
-   /**
46
-    * @var string[]|NULL
47
-    */
45
+    /**
46
+     * @var string[]|NULL
47
+     */
48 48
     protected static $charsAsHex;
49 49
     
50 50
     public function __construct()
@@ -67,13 +67,13 @@  discard block
 block discarded – undo
67 67
         }
68 68
     }
69 69
     
70
-   /**
71
-    * Retrieves the HEX character codes for all control
72
-    * characters that the {@link stripControlCharacters()}
73
-    * method will remove.
74
-    *
75
-    * @return string[]
76
-    */
70
+    /**
71
+     * Retrieves the HEX character codes for all control
72
+     * characters that the {@link stripControlCharacters()}
73
+     * method will remove.
74
+     *
75
+     * @return string[]
76
+     */
77 77
     public function getCharsAsHex() : array
78 78
     {
79 79
         if (isset(self::$charsAsHex))
@@ -120,13 +120,13 @@  discard block
 block discarded – undo
120 120
         return $stack;
121 121
     }
122 122
     
123
-   /**
124
-    * Retrieves an array of all control characters that
125
-    * the {@link stripControlCharacters()} method will
126
-    * remove, as the actual UTF-8 characters.
127
-    *
128
-    * @return string[]
129
-    */
123
+    /**
124
+     * Retrieves an array of all control characters that
125
+     * the {@link stripControlCharacters()} method will
126
+     * remove, as the actual UTF-8 characters.
127
+     *
128
+     * @return string[]
129
+     */
130 130
     public function getCharsAsUTF8() : array
131 131
     {
132 132
         $chars = $this->getCharsAsHex();
@@ -139,12 +139,12 @@  discard block
 block discarded – undo
139 139
         return $result;
140 140
     }
141 141
     
142
-   /**
143
-    * Retrieves all control characters as JSON encoded
144
-    * characters, e.g. "\u200b".
145
-    *
146
-    * @return string[]
147
-    */
142
+    /**
143
+     * Retrieves all control characters as JSON encoded
144
+     * characters, e.g. "\u200b".
145
+     *
146
+     * @return string[]
147
+     */
148 148
     public function getCharsAsJSON() : array
149 149
     {
150 150
         $chars = $this->getCharsAsHex();
@@ -157,17 +157,17 @@  discard block
 block discarded – undo
157 157
         return $result;
158 158
     }
159 159
     
160
-   /**
161
-    * Removes all control characters from the specified string
162
-    * that can cause problems in some cases, like creating
163
-    * valid XML documents. This includes invisible non-breaking
164
-    * spaces.
165
-    *
166
-    * @param string $string
167
-    * @return string
168
-    * @see https://stackoverflow.com/a/8171868/2298192
169
-    * @see https://unicode-table.com/en
170
-    */
160
+    /**
161
+     * Removes all control characters from the specified string
162
+     * that can cause problems in some cases, like creating
163
+     * valid XML documents. This includes invisible non-breaking
164
+     * spaces.
165
+     *
166
+     * @param string $string
167
+     * @return string
168
+     * @see https://stackoverflow.com/a/8171868/2298192
169
+     * @see https://unicode-table.com/en
170
+     */
171 171
     public function stripControlCharacters(string $string) : string
172 172
     {
173 173
         if(empty($string)) 
Please login to merge, or discard this patch.
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
    /**
26 26
     * @var string[]
27 27
     */
28
-    protected static $controlChars =  array(
28
+    protected static $controlChars = array(
29 29
         '0000-0008', // control chars
30 30
         '000E-000F', // control chars
31 31
         '0010-001F', // control chars
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
     public function __construct()
51 51
     {
52 52
         // create the regex from the unicode characters list
53
-        if(!isset(self::$controlCharsRegex))
53
+        if (!isset(self::$controlCharsRegex))
54 54
         {
55 55
             $chars = $this->getCharsAsHex();
56 56
             
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
             // in the regular expression.
59 59
             $stack = array();
60 60
             
61
-            foreach($chars as $char) 
61
+            foreach ($chars as $char) 
62 62
             {
63 63
                 $stack[] = '\x{'.$char.'}';
64 64
             }
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
         
84 84
         $stack = array();
85 85
         
86
-        foreach(self::$controlChars as $char)
86
+        foreach (self::$controlChars as $char)
87 87
         {
88 88
             $tokens = explode('-', $char);
89 89
             $start = $tokens[0];
@@ -92,24 +92,24 @@  discard block
 block discarded – undo
92 92
             
93 93
             $range = array();
94 94
             
95
-            foreach(self::$hexAlphabet as $number) 
95
+            foreach (self::$hexAlphabet as $number) 
96 96
             {
97 97
                 $range[] = $prefix.$number;
98 98
             }
99 99
             
100 100
             $use = false;
101 101
             
102
-            foreach($range as $number) 
102
+            foreach ($range as $number) 
103 103
             {
104
-                if($number == $start) {
104
+                if ($number == $start) {
105 105
                     $use = true;
106 106
                 }
107 107
                 
108
-                if($use) {
108
+                if ($use) {
109 109
                     $stack[] = $number;
110 110
                 }
111 111
                 
112
-                if($number == $end) {
112
+                if ($number == $end) {
113 113
                     break;
114 114
                 }
115 115
             }
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
         $chars = $this->getCharsAsHex();
133 133
         
134 134
         $result = array();
135
-        foreach($chars as $char) {
135
+        foreach ($chars as $char) {
136 136
             $result[] = hex2bin($char);
137 137
         }
138 138
         
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
         $chars = $this->getCharsAsHex();
151 151
         
152 152
         $result = array();
153
-        foreach($chars as $char) {
153
+        foreach ($chars as $char) {
154 154
             $result[] = '\u'.strtolower($char);
155 155
         }
156 156
         
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
     */
171 171
     public function stripControlCharacters(string $string) : string
172 172
     {
173
-        if(empty($string)) 
173
+        if (empty($string)) 
174 174
         {
175 175
             return $string;
176 176
         }
@@ -178,13 +178,13 @@  discard block
 block discarded – undo
178 178
         $result = preg_replace(self::$controlCharsRegex, '', $string);
179 179
         
180 180
         // can happen if the text contains invalid UTF8
181
-        if($result === null)
181
+        if ($result === null)
182 182
         {
183 183
             $string = ConvertHelper::string2utf8($string);
184 184
             
185 185
             $result = preg_replace(self::$controlCharsRegex, '', $string);
186 186
             
187
-            if($result === null)
187
+            if ($result === null)
188 188
             {
189 189
                 throw new ConvertHelper_Exception(
190 190
                     'Cannot strip control characters: malformatted string encountered.',
Please login to merge, or discard this patch.
src/Value/Bool.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
 {
22 22
     protected $value = false;
23 23
     
24
-    public function __construct(bool $value=false)
24
+    public function __construct(bool $value = false)
25 25
     {
26 26
         $this->value = $value;
27 27
     }
Please login to merge, or discard this patch.