Mistralys / application-localization

src/Localization/Countries/BaseCountry.php

<?php
/**
 * @package Localization
 * @subpackage Countries
 */

declare(strict_types=1);

namespace AppLocalize\Localization\Countries;

use AppLocalize\Localization;

/**
 * Individual country representation for handling country-related
 * data like currencies and locales.
 *
 * @package Localization
 * @subpackage Countries
 * @author Sebastian Mordziol <s.mordziol@mistralys.eu>
 */
abstract class BaseCountry implements CountryInterface
{
    protected ?CountryCurrency $currency;

    public function getCurrency() : CountryCurrency
    {
        if(!isset($this->currency)) {
            $this->currency = new CountryCurrency(
                Localization::createCurrencies()->getByID($this->getCurrencyISO()),
                $this
            );
        }

        return $this->currency;

The expression return $this->currency could return the type null which is incompatible with the type-hinted return AppLocalize\Localization\Countries\CountryCurrency. Consider adding an additional type-check to rule them out.

    }

    public function getID() : string
    {
        return $this->getCode();
    }

    public function getCurrencyID() : string
    {
        return $this->getCurrencyISO();
    }

    /**
     * Returns the human-readable locale label.
     * @return string
     * @see getLabel()
     */
    public function __toString()
    {
        return $this->getLabel();
    }
}