Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like ClassLoader often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ClassLoader, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
43 | class ClassLoader |
||
44 | { |
||
45 | // PSR-4 |
||
46 | private $prefixLengthsPsr4 = array(); |
||
47 | private $prefixDirsPsr4 = array(); |
||
48 | private $fallbackDirsPsr4 = array(); |
||
49 | |||
50 | // PSR-0 |
||
51 | private $prefixesPsr0 = array(); |
||
52 | private $fallbackDirsPsr0 = array(); |
||
53 | |||
54 | private $useIncludePath = false; |
||
55 | private $classMap = array(); |
||
56 | private $classMapAuthoritative = false; |
||
57 | private $missingClasses = array(); |
||
58 | private $apcuPrefix; |
||
59 | |||
60 | public function getPrefixes() |
||
68 | |||
69 | public function getPrefixesPsr4() |
||
73 | |||
74 | public function getFallbackDirs() |
||
78 | |||
79 | public function getFallbackDirsPsr4() |
||
83 | |||
84 | public function getClassMap() |
||
88 | |||
89 | /** |
||
90 | * @param array $classMap Class to filename map |
||
91 | */ |
||
92 | public function addClassMap(array $classMap) |
||
100 | |||
101 | /** |
||
102 | * Registers a set of PSR-0 directories for a given prefix, either |
||
103 | * appending or prepending to the ones previously set for this prefix. |
||
104 | * |
||
105 | * @param string $prefix The prefix |
||
106 | * @param array|string $paths The PSR-0 root directories |
||
107 | * @param bool $prepend Whether to prepend the directories |
||
108 | */ |
||
109 | public function add($prefix, $paths, $prepend = false) |
||
145 | |||
146 | /** |
||
147 | * Registers a set of PSR-4 directories for a given namespace, either |
||
148 | * appending or prepending to the ones previously set for this namespace. |
||
149 | * |
||
150 | * @param string $prefix The prefix/namespace, with trailing '\\' |
||
151 | * @param array|string $paths The PSR-4 base directories |
||
152 | * @param bool $prepend Whether to prepend the directories |
||
153 | * |
||
154 | * @throws \InvalidArgumentException |
||
155 | */ |
||
156 | public function addPsr4($prefix, $paths, $prepend = false) |
||
193 | |||
194 | /** |
||
195 | * Registers a set of PSR-0 directories for a given prefix, |
||
196 | * replacing any others previously set for this prefix. |
||
197 | * |
||
198 | * @param string $prefix The prefix |
||
199 | * @param array|string $paths The PSR-0 base directories |
||
200 | */ |
||
201 | public function set($prefix, $paths) |
||
209 | |||
210 | /** |
||
211 | * Registers a set of PSR-4 directories for a given namespace, |
||
212 | * replacing any others previously set for this namespace. |
||
213 | * |
||
214 | * @param string $prefix The prefix/namespace, with trailing '\\' |
||
215 | * @param array|string $paths The PSR-4 base directories |
||
216 | * |
||
217 | * @throws \InvalidArgumentException |
||
218 | */ |
||
219 | public function setPsr4($prefix, $paths) |
||
232 | |||
233 | /** |
||
234 | * Turns on searching the include path for class files. |
||
235 | * |
||
236 | * @param bool $useIncludePath |
||
237 | */ |
||
238 | public function setUseIncludePath($useIncludePath) |
||
242 | |||
243 | /** |
||
244 | * Can be used to check if the autoloader uses the include path to check |
||
245 | * for classes. |
||
246 | * |
||
247 | * @return bool |
||
248 | */ |
||
249 | public function getUseIncludePath() |
||
253 | |||
254 | /** |
||
255 | * Turns off searching the prefix and fallback directories for classes |
||
256 | * that have not been registered with the class map. |
||
257 | * |
||
258 | * @param bool $classMapAuthoritative |
||
259 | */ |
||
260 | public function setClassMapAuthoritative($classMapAuthoritative) |
||
264 | |||
265 | /** |
||
266 | * Should class lookup fail if not found in the current class map? |
||
267 | * |
||
268 | * @return bool |
||
269 | */ |
||
270 | public function isClassMapAuthoritative() |
||
274 | |||
275 | /** |
||
276 | * APCu prefix to use to cache found/not-found classes, if the extension is enabled. |
||
277 | * |
||
278 | * @param string|null $apcuPrefix |
||
279 | */ |
||
280 | public function setApcuPrefix($apcuPrefix) |
||
284 | |||
285 | /** |
||
286 | * The APCu prefix in use, or null if APCu caching is not enabled. |
||
287 | * |
||
288 | * @return string|null |
||
289 | */ |
||
290 | public function getApcuPrefix() |
||
294 | |||
295 | /** |
||
296 | * Registers this instance as an autoloader. |
||
297 | * |
||
298 | * @param bool $prepend Whether to prepend the autoloader or not |
||
299 | */ |
||
300 | public function register($prepend = false) |
||
304 | |||
305 | /** |
||
306 | * Unregisters this instance as an autoloader. |
||
307 | */ |
||
308 | public function unregister() |
||
312 | |||
313 | /** |
||
314 | * Loads the given class or interface. |
||
315 | * |
||
316 | * @param string $class The name of the class |
||
317 | * @return bool|null True if loaded, null otherwise |
||
318 | */ |
||
319 | public function loadClass($class) |
||
327 | |||
328 | /** |
||
329 | * Finds the path to the file where the class is defined. |
||
330 | * |
||
331 | * @param string $class The name of the class |
||
332 | * |
||
333 | * @return string|false The path if found, false otherwise |
||
334 | */ |
||
335 | public function findFile($class) |
||
369 | |||
370 | private function findFileWithExtension($class, $ext) |
||
435 | } |
||
436 | |||
446 |