Issues in ThreadMeta.php (master) - Issues in master - Miliooo/MilioooMessageBundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (118)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Messaging/Model/ThreadMeta.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the MilioooMessageBundle package.
 *
 * (c) Michiel boeckaert <[email protected]>
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Miliooo\Messaging\Model;

use Miliooo\Messaging\User\ParticipantInterface;

/**
 * The thread meta model
 *
 * @author Michiel Boeckaert <[email protected]>
 */
abstract class ThreadMeta implements ThreadMetaInterface

{
    /**
     * The unique id of the thread
     *
     * @var integer
     */
    protected $id;

    /**
     * The thread this meta belongs to
     *
     * @var ThreadInterface
     */
    protected $thread;

    /**
     * The participant of the thread meta
     *
     * @var ParticipantInterface
     */
    protected $participant;

    /**
     * The status of the given thread for the participant
     *
     * @var string
     */
    protected $status;

    /**
     * Datetime of the last message written by the participant
     *
     * @var \DateTime
     */
    protected $lastParticipantMessageDate;

    /**
     * Datetime of the last message written by another participant
     *
     * @var \DateTime
     */
    protected $lastMessageDate;

    /**
     * The number of unread messages for the participant for the given thread.
     *
     * @var integer
     */
    protected $unreadMessageCount = 0;

    /**
     * Constructor.
     */
    public function __construct()
    {
        $this->status = ThreadMetaInterface::STATUS_ACTIVE;
    }

    /**
     * Gets the unique id
     *
     * @return integer|null
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * {@inheritdoc}
     */
    public function setThread(ThreadInterface $thread)
    {
        $this->thread = $thread;
    }

    /**
     * {@inheritdoc}
     */
    public function getThread()
    {
        return $this->thread;
    }

    /**
     * {@inheritdoc}
     */
    public function setParticipant(ParticipantInterface $participant)
    {
        $this->participant = $participant;
    }

    /**
     * {@inheritdoc}
     */
    public function getParticipant()
    {
        return $this->participant;
    }

    /**
     * {@inheritdoc}
     */
    public function getStatus()
    {
        return $this->status;
    }

    /**
     * {@inheritdoc}
     * @param $status
     */
    public function setStatus($status)
    {
        if (!in_array($status, [ThreadMetaInterface::STATUS_ACTIVE, ThreadMetaInterface::STATUS_ARCHIVED], true)) {
            throw new \InvalidArgumentException('Not a valid status');
        }

        $this->status = $status;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
    }

    /**
     * {@inheritdoc}
     */
    public function setLastParticipantMessageDate(\DateTime $dateTime)
    {
        $this->lastParticipantMessageDate = $dateTime;
    }

    /**
     * {@inheritdoc}
     */
    public function getLastParticipantMessageDate()
    {
        return $this->lastParticipantMessageDate;
    }

    /**
     * {@inheritdoc}
     */
    public function getLastMessageDate()
    {
        return $this->lastMessageDate;
    }

    /**
     * {@inheritdoc}
     */
    public function setLastMessageDate(\DateTime $lastMessageDate)
    {
        $this->lastMessageDate = $lastMessageDate;
    }

    /**
     * {@inheritdoc}
     */
    public function getUnreadMessageCount()
    {
        return $this->unreadMessageCount;
    }

    /**
     * {@inheritdoc}
     */
    public function setUnreadMessageCount($unreadCount)
    {
        $this->unreadMessageCount = intval($unreadCount);
    }
}


1			<?php
2
3			/*
4			* This file is part of the MilioooMessageBundle package.
5			*
6			* (c) Michiel boeckaert <[email protected]>
7			* This source file is subject to the MIT license that is bundled
8			* with this source code in the file LICENSE.
9			*/
10
11			namespace Miliooo\Messaging\Model;
12
13			use Miliooo\Messaging\User\ParticipantInterface;
14
15			/**
16			* The thread meta model
17			*
18			* @author Michiel Boeckaert <[email protected]>
19			*/
20			abstract class ThreadMeta implements ThreadMetaInterface
			0 ignored issues – show Coding Style introduced 2016-03-28 11:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this `ThreadMeta` does not seem to conform to the naming convention (`^Abstract\|Factory$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
21			{
22			/**
23			* The unique id of the thread
24			*
25			* @var integer
26			*/
27			protected $id;
28
29			/**
30			* The thread this meta belongs to
31			*
32			* @var ThreadInterface
33			*/
34			protected $thread;
35
36			/**
37			* The participant of the thread meta
38			*
39			* @var ParticipantInterface
40			*/
41			protected $participant;
42
43			/**
44			* The status of the given thread for the participant
45			*
46			* @var string
47			*/
48			protected $status;
49
50			/**
51			* Datetime of the last message written by the participant
52			*
53			* @var \DateTime
54			*/
55			protected $lastParticipantMessageDate;
56
57			/**
58			* Datetime of the last message written by another participant
59			*
60			* @var \DateTime
61			*/
62			protected $lastMessageDate;
63
64			/**
65			* The number of unread messages for the participant for the given thread.
66			*
67			* @var integer
68			*/
69			protected $unreadMessageCount = 0;
70
71			/**
72			* Constructor.
73			*/
74			public function __construct()
75			{
76			$this->status = ThreadMetaInterface::STATUS_ACTIVE;
77			}
78
79			/**
80			* Gets the unique id
81			*
82			* @return integer\|null
83			*/
84			public function getId()
85			{
86			return $this->id;
87			}
88
89			/**
90			* {@inheritdoc}
91			*/
92			public function setThread(ThreadInterface $thread)
93			{
94			$this->thread = $thread;
95			}
96
97			/**
98			* {@inheritdoc}
99			*/
100			public function getThread()
101			{
102			return $this->thread;
103			}
104
105			/**
106			* {@inheritdoc}
107			*/
108			public function setParticipant(ParticipantInterface $participant)
109			{
110			$this->participant = $participant;
111			}
112
113			/**
114			* {@inheritdoc}
115			*/
116			public function getParticipant()
117			{
118			return $this->participant;
119			}
120
121			/**
122			* {@inheritdoc}
123			*/
124			public function getStatus()
125			{
126			return $this->status;
127			}
128
129			/**
130			* {@inheritdoc}
131			* @param $status
132			*/
133			public function setStatus($status)
134			{
135			if (!in_array($status, [ThreadMetaInterface::STATUS_ACTIVE, ThreadMetaInterface::STATUS_ARCHIVED], true)) {
136			throw new \InvalidArgumentException('Not a valid status');
137			}
138
139			$this->status = $status;
			0 ignored issues – show Documentation Bug introduced 2016-03-28 11:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$status` was declared of type `string`, but `$status` is of type `integer`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
140			}
141
142			/**
143			* {@inheritdoc}
144			*/
145			public function setLastParticipantMessageDate(\DateTime $dateTime)
146			{
147			$this->lastParticipantMessageDate = $dateTime;
148			}
149
150			/**
151			* {@inheritdoc}
152			*/
153			public function getLastParticipantMessageDate()
154			{
155			return $this->lastParticipantMessageDate;
156			}
157
158			/**
159			* {@inheritdoc}
160			*/
161			public function getLastMessageDate()
162			{
163			return $this->lastMessageDate;
164			}
165
166			/**
167			* {@inheritdoc}
168			*/
169			public function setLastMessageDate(\DateTime $lastMessageDate)
170			{
171			$this->lastMessageDate = $lastMessageDate;
172			}
173
174			/**
175			* {@inheritdoc}
176			*/
177			public function getUnreadMessageCount()
178			{
179			return $this->unreadMessageCount;
180			}
181
182			/**
183			* {@inheritdoc}
184			*/
185			public function setUnreadMessageCount($unreadCount)
186			{
187			$this->unreadMessageCount = intval($unreadCount);
188			}
189			}
190

Miliooo / MilioooMessageBundle

Issues (118)

Security Analysis not enabled

Messaging/Model/ThreadMeta.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like