| Conditions | 6 |
| Paths | 51 |
| Total Lines | 58 |
| Lines | 58 |
| Ratio | 100 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | View Code Duplication | 'use strict'; |
|
| 3 | function decryptAES () { |
||
| 4 | |||
| 5 | const pass = String(document.getElementById('pass').value); |
||
| 6 | try { |
||
| 7 | |||
| 8 | var decryptionError = String(document.getElementById('decryptionError').innerHTML); |
||
| 9 | var noContentError = String(document.getElementById('noContentError').innerHTML); |
||
| 10 | |||
| 11 | } catch (e) { |
||
| 12 | |||
| 13 | decryptionError = 'Incorrect Password!'; |
||
| 14 | noContentError = 'No content to display!'; |
||
| 15 | |||
| 16 | } |
||
| 17 | |||
| 18 | try { |
||
| 19 | |||
| 20 | let content = CryptoJS.AES.decrypt(document.getElementById('encrypt-blog').innerHTML.trim(), pass); |
||
| 21 | content = content.toString(CryptoJS.enc.Utf8); |
||
| 22 | content = decodeBase64(content); |
||
| 23 | content = unescape(content); |
||
| 24 | if (content === '') { |
||
| 25 | |||
| 26 | throw new Error(noContentError); // ??? |
||
| 27 | |||
| 28 | } else { |
||
| 29 | |||
| 30 | document.getElementById('encrypt-blog').style.display = 'inline'; |
||
| 31 | document.getElementById('encrypt-blog').innerHTML = ''; |
||
| 32 | // Use jquery to load some js code |
||
| 33 | $('#encrypt-blog').html(content); |
||
| 34 | document.getElementById('security').style.display = 'none'; |
||
| 35 | if (document.getElementById('toc-div')) { |
||
| 36 | |||
| 37 | document.getElementById('toc-div').style.display = 'inline'; |
||
| 38 | |||
| 39 | } |
||
| 40 | |||
| 41 | } |
||
| 42 | // Call MathJax to render |
||
| 43 | if(typeof MathJax !== 'undefined') { |
||
| 44 | |||
| 45 | MathJax.Hub.Queue( |
||
| 46 | ['resetEquationNumbers', MathJax.InputJax.TeX, ], |
||
| 47 | ['PreProcess', MathJax.Hub, ], |
||
| 48 | ['Reprocess', MathJax.Hub, ] |
||
| 49 | ); |
||
| 50 | |||
| 51 | } |
||
| 52 | |||
| 53 | } catch (e) { |
||
| 54 | |||
| 55 | alert(decryptionError); |
||
| 56 | console.log(e); |
||
| 57 | |||
| 58 | } |
||
| 59 | |||
| 60 | } |
||
| 61 | |||
| 107 |