Micro\Plugin\Http\Business\Logger\Formatter\Format\AbstractHeaderFormatter

Complexity

Total Complexity

5

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	format()	0	26	5

<?php

declare(strict_types=1);

/*
 *  This file is part of the Micro framework package.
 *
 *  (c) Stanislau Komar <kost@micro-php.net>
 *
 *  For the full copyright and license information, please view the LICENSE
 *  file that was distributed with this source code.
 */

namespace Micro\Plugin\Http\Business\Logger\Formatter\Format;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

/**
 * @author Stanislau Komar <head.trackingsoft@gmail.com>
 *
 * @codeCoverageIgnore
 */
abstract class AbstractHeaderFormatter implements LogFormatterConcreteInterface
{
    public function format(Request $request, ?Response $response, ?\Throwable $exception, ?string $message = null): string
    {
        if (!$message) {
            return '';
        }

        $matchPattern = sprintf('/{{%s_header\.(.*?)}}/', $this->getPrefix());
        $matched = preg_match_all($matchPattern, $message, $matches);
        if (!$matched || 2 !== \count($matches)) {

The expression $matched of type integer|null is loosely compared to false; this is ambiguous if the integer can be 0. You might want to explicitly use === null instead.

            return $message;
        }

        $matchesPattern = $matches[0];
        $matchesVars = $matches[1];

        $countMatches = \count($matchesVars);

        for ($i = 0; $i < $countMatches; ++$i) {
            $message = str_ireplace(
                $matchesPattern[$i],
                $this->getValue($request, $response, $matchesVars[$i]),
                $message
            );
        }

        return $message;

The expression return $message could return the type array which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }

    abstract protected function getValue(Request $request, ?Response $response, string $matchedVar): string;

    abstract protected function getPrefix(): string;
}