CardSchemeStrategy::extractSchemes() - Code Metrics - Inspection of "v1.6.0 Release" - Micro-PHP/dto - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#10)

by Stanislau

created 2023-02-16 12:03 UTC

CardSchemeStrategy::extractSchemes() A

↳ Parent: CardSchemeStrategy

Complexity

Conditions	4
Paths	3

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4.0218

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	8
c	1
b	0
f	0
nc	3
nop	1
dl	0
loc	14
ccs	8
cts	9
cp	0.8889
crap	4.0218
rs	10

<?php

declare(strict_types=1);

/*
 *  This file is part of the Micro framework package.
 *
 *  (c) Stanislau Komar <[email protected]>
 *
 *  For the full copyright and license information, please view the LICENSE
 *  file that was distributed with this source code.
 */

namespace Micro\Library\DTO\Preparation\Processor\Property\Assert;

use Symfony\Component\Validator\Constraints\CardScheme;

class CardSchemeStrategy extends AbstractConstraintStrategy
{
    protected function generateArguments(array $config): array
    {
        $parent = parent::generateArguments($config);
        $parent['schemes'] = $this->extractSchemes($config);

        return array_filter($parent);
    }

    /**
     * @param array<string, mixed> $config
     *
     * @return array<string>|null
     */
    protected function extractSchemes(array $config): array|null
    {
        $schemes = $this->explodeString($config['schemes'] ?? '');
        if (!$schemes) {

            return null;
        }

        $result = [];
        foreach ($schemes as $schemaName) {
            $s = \constant(sprintf('%s::%s', CardScheme::class, $schemaName));
            $result[] = $s ?: $schemaName;
        }

        return $result;
    }

    protected function getValidatorProperty(): string
    {
        return 'card_scheme';
    }

    protected function getAttributeClassName(): string
    {
        return CardScheme::class;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		/*
6		* This file is part of the Micro framework package.
7		*
8		* (c) Stanislau Komar <[email protected]>
9		*
10		* For the full copyright and license information, please view the LICENSE
11		* file that was distributed with this source code.
12		*/
13
14		namespace Micro\Library\DTO\Preparation\Processor\Property\Assert;
15
16		use Symfony\Component\Validator\Constraints\CardScheme;
17
18		class CardSchemeStrategy extends AbstractConstraintStrategy
19		{
20	1	protected function generateArguments(array $config): array
21		{
22	1	$parent = parent::generateArguments($config);
23	1	$parent['schemes'] = $this->extractSchemes($config);
24
25	1	return array_filter($parent);
26		}
27
28		/**
29		* @param array<string, mixed> $config
30		*
31		* @return array<string>\|null
32		*/
33	1	protected function extractSchemes(array $config): array\|null
34		{
35	1	$schemes = $this->explodeString($config['schemes'] ?? '');
36	1	if (!$schemes) {
		0 ignored issues – show Bug Best Practice introduced 2023-02-15 21:06 UTC by Report Bug Copy Issue Report The expression `$schemes` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
37		return null;
38		}
39
40	1	$result = [];
41	1	foreach ($schemes as $schemaName) {
42	1	$s = \constant(sprintf('%s::%s', CardScheme::class, $schemaName));
43	1	$result[] = $s ?: $schemaName;
44		}
45
46	1	return $result;
47		}
48
49	1	protected function getValidatorProperty(): string
50		{
51	1	return 'card_scheme';
52		}
53
54	1	protected function getAttributeClassName(): string
55		{
56	1	return CardScheme::class;
57		}
58		}
59

Micro-PHP / dto

Pull Request — master (#10)

CardSchemeStrategy::extractSchemes() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like