SugarAPI\SDK\Request\GETFile

Complexity

Total Complexity

10

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	send()	0	4	1
A	setFile()	0	6	2
A	initFile()	0	8	3
A	closeFile()	0	5	2
A	getFile()	0	3	1
A	close()	0	4	1

<?php

namespace SugarAPI\SDK\Request;


class GETFile extends GET {

    /**
     * File to dump response
     * @var resource
     */
    protected $filePath;

    /**
     * File Handle used by Curl
     * @var
     */
    protected $fileHandle;

    /**
     * @inheritdoc
     */
    protected static $_DEFAULT_HEADERS = array();

    /**
     * Set Temp File for File Response
     * @inheritdoc
     */
    public function send(){
        //$this->initFile();

84% of this comment could be valid code. Did you maybe forget this after debugging?

        return parent::send();
    }

    public function setFile($filePath){
        if ($this->status == self::STATUS_INIT) {
            $this->filePath = fopen($filePath, 'w+');
        }
        return $this;
    }

    protected function initFile(){
        if ($this->status == self::STATUS_INIT) {
            if ($this->filePath == NULL) {
                $this->filePath = tempnam(sys_get_temp_dir(), 'SugarAP_SDK_Response_');

It seems like tempnam(sys_get_temp_dir(), 'SugarAP_SDK_Response_') of type string is incompatible with the declared type resource of property $filePath.

            }
        }
        $this->fileHandle = fopen($this->filePath,'w+');
    }

    protected function closeFile(){
        if ($this->status !== self::STATUS_INIT) {
            fclose($this->fileHandle);
        }
    }

    public function getFile(){

Please use __construct() instead of a PHP4-style constructor that is named after the class.

        return $this->filePath;
    }

    public function close(){
        $this->closeFile();
        return parent::close();
    }

}