Passed
Push — master ( f9a48a...945dc8 )
by Mike
03:01
created
src/Exception/SDKException.php 1 patch
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@
 block discarded – undo
4 4
 
5 5
 class EntryPointException extends SDKException {
6 6
 
7
-    public function __construct($message) {
7
+    public function __construct($message){
8 8
         parent::__construct($message);
9 9
     }
10 10
 
Please login to merge, or discard this patch.
src/Helpers/Helpers.php 1 patch
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
     public static function getSDKEntryPointRegistry(){
40 40
         $entryPoints = array();
41 41
         require __DIR__.DIRECTORY_SEPARATOR.'registry.php';
42
-        foreach ($entryPoints as $funcName => $className) {
42
+        foreach ($entryPoints as $funcName => $className){
43 43
             $className = "SugarAPI\\SDK\\EntryPoint\\" . $className;
44 44
             $entryPoints[$funcName] = $className;
45 45
         }
Please login to merge, or discard this patch.
src/Request/Abstracts/AbstractRequest.php 1 patch
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@
 block discarded – undo
90 90
     /**
91 91
      * Always make sure to destroy Curl Resource
92 92
      */
93
-    public function __destruct() {
93
+    public function __destruct(){
94 94
         if ($this->status!==self::STATUS_CLOSED){
95 95
             curl_close($this->CurlRequest);
96 96
         }
Please login to merge, or discard this patch.
src/EntryPoint/Abstracts/AbstractEntryPoint.php 1 patch
Braces   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
     public function __construct($baseUrl,array $options = array()){
120 120
         $this->baseUrl = $baseUrl;
121 121
 
122
-        if (!empty($options)) {
122
+        if (!empty($options)){
123 123
             $this->setOptions($options);
124 124
         }
125 125
         $this->configureURL();
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
     /**
147 147
      * @inheritdoc
148 148
      */
149
-    public function setAuth($accessToken) {
149
+    public function setAuth($accessToken){
150 150
         $this->accessToken = $accessToken;
151 151
         return $this;
152 152
     }
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
     /**
155 155
      * @inheritdoc
156 156
      */
157
-    public function setUrl($url) {
157
+    public function setUrl($url){
158 158
         $this->Url = $url;
159 159
         return $this;
160 160
     }
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
     /**
163 163
      * @inheritdoc
164 164
      */
165
-    public function setRequest(RequestInterface $Request) {
165
+    public function setRequest(RequestInterface $Request){
166 166
         $this->Request = $Request;
167 167
         return $this;
168 168
     }
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
     /**
171 171
      * @inheritdoc
172 172
      */
173
-    public function setResponse(ResponseInterface $Response) {
173
+    public function setResponse(ResponseInterface $Response){
174 174
         $this->Response = $Response;
175 175
         return $this;
176 176
     }
@@ -220,10 +220,10 @@  discard block
 block discarded – undo
220 220
     public function execute($data = NULL){
221 221
         $data =  ($data === NULL?$this->Data:$data);
222 222
         $this->configureData($data);
223
-        if (is_object($this->Request)) {
223
+        if (is_object($this->Request)){
224 224
             $this->configureRequest();
225 225
             $this->Request->send();
226
-        }else{
226
+        } else{
227 227
             throw new InvalidRequestException(get_called_class(),"Request property not configured");
228 228
         }
229 229
         return $this;
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
     /**
233 233
      * @inheritdoc
234 234
      */
235
-    public function authRequired() {
235
+    public function authRequired(){
236 236
         return $this->_AUTH_REQUIRED;
237 237
     }
238 238
 
@@ -242,10 +242,10 @@  discard block
 block discarded – undo
242 242
      * @throws RequiredDataException
243 243
      */
244 244
     protected function configureRequest(){
245
-        if ($this->verifyUrl()) {
245
+        if ($this->verifyUrl()){
246 246
             $this->Request->setURL($this->Url);
247 247
         }
248
-        if ($this->verifyData() && !empty($this->Data)) {
248
+        if ($this->verifyData() && !empty($this->Data)){
249 249
             $this->Request->setBody($this->Data);
250 250
         }
251 251
         $this->configureAuth();
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
      * Configures the authentication header on the Request object
256 256
      */
257 257
     protected function configureAuth(){
258
-        if ($this->authRequired()) {
258
+        if ($this->authRequired()){
259 259
             $this->Request->addHeader('OAuth-Token', $this->accessToken);
260 260
         }
261 261
     }
@@ -292,12 +292,12 @@  discard block
 block discarded – undo
292 292
      */
293 293
     protected function configureURL(){
294 294
         $url = $this->_URL;
295
-        if ($this->requiresOptions()) {
295
+        if ($this->requiresOptions()){
296 296
             $urlParts = explode("/", $this->_URL);
297 297
             $o = 0;
298
-            foreach ($urlParts as $key => $part) {
299
-                if (strpos($part, "$") !== FALSE) {
300
-                    if (isset($this->Options[$o])) {
298
+            foreach ($urlParts as $key => $part){
299
+                if (strpos($part, "$") !== FALSE){
300
+                    if (isset($this->Options[$o])){
301 301
                         $urlParts[$key] = $this->Options[$o];
302 302
                         $o++;
303 303
                     }
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
      * @throws RequiredDataException
329 329
      */
330 330
     protected function verifyData(){
331
-        if (isset($this->_DATA_TYPE)||!empty($this->_DATA_TYPE)) {
331
+        if (isset($this->_DATA_TYPE)||!empty($this->_DATA_TYPE)){
332 332
             $this->verifyDataType();
333 333
         }
334 334
         if (!empty($this->_REQUIRED_DATA)){
@@ -343,7 +343,7 @@  discard block
 block discarded – undo
343 343
      * @throws RequiredDataException
344 344
      */
345 345
     protected function verifyDataType(){
346
-        if (gettype($this->Data) !== $this->_DATA_TYPE) {
346
+        if (gettype($this->Data) !== $this->_DATA_TYPE){
347 347
             throw new RequiredDataException(get_called_class(),"Valid DataType is {$this->_DATA_TYPE}");
348 348
         }
349 349
         return true;
Please login to merge, or discard this patch.
src/EntryPoint/POST/ModuleRecordFileField.php 1 patch
Braces   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,13 +32,13 @@
 block discarded – undo
32 32
      * @throws RequiredOptionsException
33 33
      */
34 34
     protected function configureData($data){
35
-        if (is_string($data)) {
36
-            if (!empty($this->Options)) {
35
+        if (is_string($data)){
36
+            if (!empty($this->Options)){
37 37
                 $fileField = end($this->Options);
38 38
                 $data = array(
39 39
                     $fileField => $data
40 40
                 );
41
-            } else {
41
+            } else{
42 42
                 throw new RequiredOptionsException(get_called_class(), "Options are required, when passing String for data.");
43 43
             }
44 44
         }
Please login to merge, or discard this patch.
src/EntryPoint/POST/Bulk.php 1 patch
Braces   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -30,19 +30,19 @@
 block discarded – undo
30 30
         'method' => ''
31 31
     );
32 32
 
33
-    protected function configureData($data) {
34
-        if (!isset($data['requests'])) {
33
+    protected function configureData($data){
34
+        if (!isset($data['requests'])){
35 35
             $requestData = array(
36 36
                 'requests' => array()
37 37
             );
38 38
             $counter = 0;
39
-            foreach ($data as $key => $EntryPoint) {
40
-                if (is_object($EntryPoint)) {
39
+            foreach ($data as $key => $EntryPoint){
40
+                if (is_object($EntryPoint)){
41 41
                     $requestData['requests'][$counter] = $this->bulkRequest;
42 42
                     $requestData['requests'][$counter]['method'] = $EntryPoint->getRequest()->getType();
43
-                    if ($requestData['requests'][$counter]['method'] == "POST" || $requestData['requests'][$counter]['method'] == "PUT") {
43
+                    if ($requestData['requests'][$counter]['method'] == "POST" || $requestData['requests'][$counter]['method'] == "PUT"){
44 44
                         $requestData['requests'][$counter]['data'] = json_encode($EntryPoint->getData());
45
-                    } else {
45
+                    } else{
46 46
                         unset($requestData['requests'][$counter]['data']);
47 47
                     }
48 48
                     $requestData['requests'][$counter]['headers'] = $EntryPoint->getRequest()->getHeaders();
Please login to merge, or discard this patch.
src/Response/File.php 1 patch
Braces   +5 added lines, -6 removed lines patch added patch discarded remove patch
@@ -31,10 +31,10 @@  discard block
 block discarded – undo
31 31
      * Extract Filename from Headers
32 32
      * @param mixed $curlResponse
33 33
      */
34
-    public function setCurlResponse($curlResponse) {
34
+    public function setCurlResponse($curlResponse){
35 35
         parent::setCurlResponse($curlResponse);
36
-        if (!$this->error) {
37
-            if (empty($this->fileName)) {
36
+        if (!$this->error){
37
+            if (empty($this->fileName)){
38 38
                 $this->extractFileName();
39 39
             }
40 40
             $this->writeFile();
@@ -59,8 +59,7 @@  discard block
 block discarded – undo
59 59
      * Extract the filename from the Headers, and store it in filename property
60 60
      */
61 61
     protected function extractFileName(){
62
-        foreach (explode("\r\n", $this->headers) as $header)
63
-        {
62
+        foreach (explode("\r\n", $this->headers) as $header){
64 63
             if (strpos($header, 'filename')!==FALSE){
65 64
                 $this->setFileName(substr($header, (strpos($header, "\"")+1), -1));
66 65
             }
@@ -99,7 +98,7 @@  discard block
 block discarded – undo
99 98
             fwrite($fileHandle,$this->body);
100 99
             fclose($fileHandle);
101 100
             return $file;
102
-        }else{
101
+        } else{
103 102
             return FALSE;
104 103
         }
105 104
     }
Please login to merge, or discard this patch.
src/Response/Abstracts/AbstractResponse.php 1 patch
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
         }
53 53
     }
54 54
 
55
-    public function setCurlResponse($curlResponse) {
55
+    public function setCurlResponse($curlResponse){
56 56
         $this->extractInfo();
57 57
         if (!$this->getError()){
58 58
             $this->extractResponse($curlResponse);
Please login to merge, or discard this patch.
src/Client/Abstracts/AbstractClient.php 1 patch
Braces   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
      * @inheritdoc
76 76
      * @param string $server
77 77
      */
78
-    public function setServer($server) {
78
+    public function setServer($server){
79 79
         $this->server = $server;
80 80
         $this->apiURL = Helpers::configureAPIURL($this->server);
81 81
         return $this;
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
     /**
85 85
      * @inheritdoc
86 86
      */
87
-    public function getAPIUrl() {
87
+    public function getAPIUrl(){
88 88
         return $this->apiURL;
89 89
     }
90 90
 
@@ -94,9 +94,9 @@  discard block
 block discarded – undo
94 94
      */
95 95
     public function setCredentials(array $credentials){
96 96
         $this->credentials = $credentials;
97
-        if (isset($this->credentials['client_id'])) {
97
+        if (isset($this->credentials['client_id'])){
98 98
             $token = static::getStoredToken($this->credentials['client_id']);
99
-            if (!empty($token)) {
99
+            if (!empty($token)){
100 100
                 $this->setToken($token);
101 101
             }
102 102
         }
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
     /**
130 130
      * @inheritdoc
131 131
      */
132
-    public function getServer() {
132
+    public function getServer(){
133 133
         return $this->server;
134 134
     }
135 135
 
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
         $implements = class_implements($className);
162 162
         if (is_array($implements) && in_array('SugarAPI\SDK\EntryPoint\Interfaces\EPInterface',$implements)){
163 163
             $this->entryPoints[$funcName] = $className;
164
-        }else{
164
+        } else{
165 165
             throw new EntryPointException($className,'Class must extend SugarAPI\SDK\EntryPoint\Interfaces\EPInterface');
166 166
         }
167 167
         return $this;
@@ -180,12 +180,12 @@  discard block
 block discarded – undo
180 180
             $EntryPoint = new $Class($this->apiURL, $params);
181 181
 
182 182
             if ($EntryPoint->authRequired()){
183
-                if (isset($this->token) && $this->authenticated()) {
183
+                if (isset($this->token) && $this->authenticated()){
184 184
                     $EntryPoint->setAuth($this->getToken()->access_token);
185 185
                 }
186 186
             }
187 187
             return $EntryPoint;
188
-        }else{
188
+        } else{
189 189
             throw new EntryPointException($name,'Unregistered EntryPoint');
190 190
         }
191 191
     }
@@ -194,13 +194,13 @@  discard block
 block discarded – undo
194 194
      * @inheritdoc
195 195
      * @throws AuthenticationException - When Login request fails
196 196
      */
197
-    public function login() {
197
+    public function login(){
198 198
         $EP = new OAuth2Token($this->apiURL);
199 199
         $response = $EP->execute($this->credentials)->getResponse();
200 200
         if ($response->getStatus()=='200'){
201 201
             $this->setToken($response->getBody(FALSE));
202 202
             static::storeToken($this->token,$this->credentials['client_id']);
203
-        } else {
203
+        } else{
204 204
             $error = $response->getBody();
205 205
             throw new AuthenticationException("Login Response [".$error['error']."] ".$error['error_message']);
206 206
         }
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
214 214
     public function refreshToken(){
215 215
         if (isset($this->credentials['client_id'])&&
216 216
             isset($this->credentials['client_secret'])&&
217
-            isset($this->token)) {
217
+            isset($this->token)){
218 218
             $refreshOptions = array(
219 219
                 'client_id' => $this->credentials['client_id'],
220 220
                 'client_secret' => $this->credentials['client_secret'],
@@ -222,11 +222,11 @@  discard block
 block discarded – undo
222 222
             );
223 223
             $EP = new RefreshToken($this->apiURL);
224 224
             $response = $EP->execute($refreshOptions)->getResponse();
225
-            if ($response->getStatus() == '200') {
225
+            if ($response->getStatus() == '200'){
226 226
                 $this->setToken($response->getBody(FALSE));
227 227
                 static::storeToken($this->token, $this->credentials['client_id']);
228 228
                 return TRUE;
229
-            } else {
229
+            } else{
230 230
                 $error = $response->getBody();
231 231
                 throw new AuthenticationException("Refresh Response [" . $error['error'] . "] " . $error['error_message']);
232 232
             }
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
                 unset($this->token);
247 247
                 static::removeStoredToken($this->credentials['client_id']);
248 248
                 return TRUE;
249
-            }else{
249
+            } else{
250 250
                 $error = $response->getBody();
251 251
                 throw new AuthenticationException("Logout Response [".$error['error']."] ".$error['message']);
252 252
             }
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
      * @inheritdoc
259 259
      * @param \stdClass $token
260 260
      */
261
-    public static function storeToken($token, $client_id) {
261
+    public static function storeToken($token, $client_id){
262 262
         static::$_STORED_TOKENS[$client_id] = $token;
263 263
         return TRUE;
264 264
     }
@@ -266,14 +266,14 @@  discard block
 block discarded – undo
266 266
     /**
267 267
      * @inheritdoc
268 268
      */
269
-    public static function getStoredToken($client_id) {
269
+    public static function getStoredToken($client_id){
270 270
         return (isset(static::$_STORED_TOKENS[$client_id])?static::$_STORED_TOKENS[$client_id]:NULL);
271 271
     }
272 272
 
273 273
     /**
274 274
      * @inheritdoc
275 275
      */
276
-    public static function removeStoredToken($client_id) {
276
+    public static function removeStoredToken($client_id){
277 277
         unset(static::$_STORED_TOKENS[$client_id]);
278 278
         return TRUE;
279 279
     }
Please login to merge, or discard this patch.