BaseTokenParser::parseParameters() - Code Metrics - Inspection of "Major refactoring to improve architecture" - MewesK/TwigSpreadsheetBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dea5e9...4057a0 )

by Mewes

created 2017-06-05 05:19 UTC

BaseTokenParser::parseParameters() C

↳ Parent: BaseTokenParser

Complexity

Conditions	9
Paths	32

Size

Total Lines	51
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	51
rs	6.2727
c	0
b	0
f	0
cc	9
eloc	28
nc	32
nop	1

How to fix Long Method

<?php

namespace MewesK\TwigSpreadsheetBundle\Twig\TokenParser;

/**
 * Class BaseTokenParser.
 */
abstract class BaseTokenParser extends \Twig_TokenParser
{
    /**
     * @var int
     */
    const PARAMETER_TYPE_ARRAY = 0;

    /**
     * @var int
     */
    const PARAMETER_TYPE_VALUE = 1;

    /**
     * @param \Twig_Token $token
     *
     * @return array
     */
    public function configureParameters(\Twig_Token $token): array
    {
        return [];
    }

    /**
     * @return array
     */
    public function getAttributes(): array
    {
        return [];
    }

    /**
     * @return string
     */
    abstract public function getNode(): string;

    /**
     * @return bool
     */
    public function hasBody(): bool
    {
        return true;
    }

    /**
     * @param \Twig_Token $token
     *
     * @throws \Twig_Error_Syntax
     * @throws \InvalidArgumentException
     *
     * @return \Twig_node
     */
    public function parse(\Twig_Token $token)
    {
        // parse attributes
        $nodes = $this->parseParameters($this->configureParameters($token));

        // parse body
        if ($this->hasBody()) {
            $nodes['body'] = $this->parseBody();
        }

        // return node
        $nodeClass = $this->getNode();

        return new $nodeClass($nodes, $this->getAttributes(), $token->getLine(), $this->getTag());
    }

    /**
     * @param array $parameterConfiguration
     *
     * @throws \InvalidArgumentException
     * @throws \Twig_Error_Syntax
     *
     * @return \Twig_Node_Expression[]
     */
    private function parseParameters(array $parameterConfiguration = []): array
    {
        // parse expressions
        $expressions = [];
        while (!$this->parser->getStream()->test(\Twig_Token::BLOCK_END_TYPE)) {
            $expressions[] = $this->parser->getExpressionParser()->parseExpression();
        }

        // end of expressions
        $this->parser->getStream()->expect(\Twig_Token::BLOCK_END_TYPE);

        // map expressions to parameters
        $parameters = [];
        foreach ($parameterConfiguration as $parameterName => $parameterOptions) {
            // try mapping expression
            $expression = reset($expressions);
            if ($expression !== false) {
                switch ($parameterOptions['type']) {
                    case self::PARAMETER_TYPE_ARRAY:
                        // check if expression is valid array
                        $valid = $expression instanceof \Twig_Node_Expression_Array;
                        break;
                    case self::PARAMETER_TYPE_VALUE:
                        // check if expression is valid value
                        $valid = !($expression instanceof \Twig_Node_Expression_Array);
                        break;
                    default:
                        throw new \InvalidArgumentException('Invalid parameter type');
                        break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
                }

                if ($valid) {
                    // set expression as parameter and remove it from expressions list
                    $parameters[$parameterName] = array_shift($expressions);
                    continue;
                }
            }

            // set default as parameter otherwise or throw exception if default is false
            if ($parameterOptions['default'] === false) {
                throw new \Twig_Error_Syntax('A required parameter is missing');
            }
            $parameters[$parameterName] = $parameterOptions['default'];
        }

        if (count($expressions) > 0) {
            throw new \Twig_Error_Syntax('Too many parameters');
        }

        return $parameters;
    }

    /**
     * @return \Twig_Node
     */
    private function parseBody(): \Twig_Node
    {
        // parse body
        $body = $this->parser->subparse(function (\Twig_Token $token) {
            return $token->test('end'.$this->getTag());
        },
            true
        );

        // end of body
        $this->parser->getStream()->expect(\Twig_Token::BLOCK_END_TYPE);

        return $body;
    }
}


1			<?php
2
3			namespace MewesK\TwigSpreadsheetBundle\Twig\TokenParser;
4
5			/**
6			* Class BaseTokenParser.
7			*/
8			abstract class BaseTokenParser extends \Twig_TokenParser
9			{
10			/**
11			* @var int
12			*/
13			const PARAMETER_TYPE_ARRAY = 0;
14
15			/**
16			* @var int
17			*/
18			const PARAMETER_TYPE_VALUE = 1;
19
20			/**
21			* @param \Twig_Token $token
22			*
23			* @return array
24			*/
25			public function configureParameters(\Twig_Token $token): array
26			{
27			return [];
28			}
29
30			/**
31			* @return array
32			*/
33			public function getAttributes(): array
34			{
35			return [];
36			}
37
38			/**
39			* @return string
40			*/
41			abstract public function getNode(): string;
42
43			/**
44			* @return bool
45			*/
46			public function hasBody(): bool
47			{
48			return true;
49			}
50
51			/**
52			* @param \Twig_Token $token
53			*
54			* @throws \Twig_Error_Syntax
55			* @throws \InvalidArgumentException
56			*
57			* @return \Twig_node
58			*/
59			public function parse(\Twig_Token $token)
60			{
61			// parse attributes
62			$nodes = $this->parseParameters($this->configureParameters($token));
63
64			// parse body
65			if ($this->hasBody()) {
66			$nodes['body'] = $this->parseBody();
67			}
68
69			// return node
70			$nodeClass = $this->getNode();
71
72			return new $nodeClass($nodes, $this->getAttributes(), $token->getLine(), $this->getTag());
73			}
74
75			/**
76			* @param array $parameterConfiguration
77			*
78			* @throws \InvalidArgumentException
79			* @throws \Twig_Error_Syntax
80			*
81			* @return \Twig_Node_Expression[]
82			*/
83			private function parseParameters(array $parameterConfiguration = []): array
84			{
85			// parse expressions
86			$expressions = [];
87			while (!$this->parser->getStream()->test(\Twig_Token::BLOCK_END_TYPE)) {
88			$expressions[] = $this->parser->getExpressionParser()->parseExpression();
89			}
90
91			// end of expressions
92			$this->parser->getStream()->expect(\Twig_Token::BLOCK_END_TYPE);
93
94			// map expressions to parameters
95			$parameters = [];
96			foreach ($parameterConfiguration as $parameterName => $parameterOptions) {
97			// try mapping expression
98			$expression = reset($expressions);
99			if ($expression !== false) {
100			switch ($parameterOptions['type']) {
101			case self::PARAMETER_TYPE_ARRAY:
102			// check if expression is valid array
103			$valid = $expression instanceof \Twig_Node_Expression_Array;
104			break;
105			case self::PARAMETER_TYPE_VALUE:
106			// check if expression is valid value
107			$valid = !($expression instanceof \Twig_Node_Expression_Array);
108			break;
109			default:
110			throw new \InvalidArgumentException('Invalid parameter type');
111			break;
			0 ignored issues – show Unused Code introduced 2017-06-05 05:22 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
112			}
113
114			if ($valid) {
115			// set expression as parameter and remove it from expressions list
116			$parameters[$parameterName] = array_shift($expressions);
117			continue;
118			}
119			}
120
121			// set default as parameter otherwise or throw exception if default is false
122			if ($parameterOptions['default'] === false) {
123			throw new \Twig_Error_Syntax('A required parameter is missing');
124			}
125			$parameters[$parameterName] = $parameterOptions['default'];
126			}
127
128			if (count($expressions) > 0) {
129			throw new \Twig_Error_Syntax('Too many parameters');
130			}
131
132			return $parameters;
133			}
134
135			/**
136			* @return \Twig_Node
137			*/
138			private function parseBody(): \Twig_Node
139			{
140			// parse body
141			$body = $this->parser->subparse(function (\Twig_Token $token) {
142			return $token->test('end'.$this->getTag());
143			},
144			true
145			);
146
147			// end of body
148			$this->parser->getStream()->expect(\Twig_Token::BLOCK_END_TYPE);
149
150			return $body;
151			}
152			}
153

MewesK / TwigSpreadsheetBundle

GitHub Access Token became invalid

Push — master ( dea5e9...4057a0 )

BaseTokenParser::parseParameters() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like