CouchbaseTest::setUp() - Code Metrics - Inspection of "Added phpmd config" - MehrAlsNix/zf-couchbase2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( aae60d...6ebfe1 )

by Siad

created 2015-12-29 16:13 UTC

CouchbaseTest::setUp() D

↳ Parent: CouchbaseTest

Complexity

Conditions	10
Paths	192

Size

Total Lines	39
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	39
rs	4.6061
cc	10
eloc	27
nc	192
nop	0

How to fix Complexity

<?php
/**
 * zf-couchbase2
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 *
 * @copyright 2015 MehrAlsNix (http://www.mehralsnix.de)
 * @license   http://www.opensource.org/licenses/mit-license.php MIT
 * @link      http://github.com/MehrAlsNix/zf-couchbase2
 */

namespace MehrAlsNix\Test\ZF\Cache\Storage\Adapter;

use MehrAlsNix\ZF\Cache\Storage\Adapter\Couchbase;
use MehrAlsNix\ZF\Cache\Storage\Adapter\CouchbaseOptions;
use Zend\Cache\Exception\ExtensionNotLoadedException;

/**
 * Class CouchbaseTest
 * @package MehrAlsNix\Test\ZF\Cache\Storage\Adapter
 */
class CouchbaseTest extends CommonAdapterTest
{
    public function setUp()
    {
        if (!getenv('TESTS_ZEND_CACHE_COUCHBASE_ENABLED')) {
            $this->markTestSkipped('Enable TESTS_ZEND_CACHE_COUCHBASE_ENABLED to run this test');
        }
        if (version_compare('2.0.0', phpversion('couchbase')) > 0) {
            try {
                new Couchbase();
                $this->fail("Expected exception Zend\Cache\Exception\ExtensionNotLoadedException");
            } catch (ExtensionNotLoadedException $e) {
                $this->markTestSkipped("Missing ext/couchbase version >= 2.0.0");
            }
        }
        $this->_options = new CouchbaseOptions([
            'resource_id' => __CLASS__
        ]);
        if (getenv('TESTS_ZEND_CACHE_COUCHBASE_HOST') && getenv('TESTS_ZEND_CACHE_COUCHBASE_PORT')) {
            $this->_options->getResourceManager()->setServer(__CLASS__, [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                [getenv('TESTS_ZEND_CACHE_COUCHBASE_HOST'), getenv('TESTS_ZEND_CACHE_COUCHBASE_PORT')]
            ]);
        } elseif (getenv('TESTS_ZEND_CACHE_COUCHBASE_HOST')) {
            $this->_options->getResourceManager()->setServer(__CLASS__, [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                [getenv('TESTS_ZEND_CACHE_COUCHBASE_HOST')]
            ]);
        }
        if (getenv('TESTS_ZEND_CACHE_COUCHBASE_USERNAME')) {
            $this->_options->getResourceManager()->setUsername(__CLASS__, getenv('TESTS_ZEND_CACHE_COUCHBASE_USERNAME'));
        }
        if (getenv('TESTS_ZEND_CACHE_COUCHBASE_PASSWORD')) {
            $this->_options->getResourceManager()->setPassword(__CLASS__, getenv('TESTS_ZEND_CACHE_COUCHBASE_PASSWORD'));
        }
        if (getenv('TESTS_ZEND_CACHE_COUCHBASE_BUCKET')) {
            $this->_options->getResourceManager()->setBucket(__CLASS__, getenv('TESTS_ZEND_CACHE_COUCHBASE_BUCKET'));
        }
        $this->_storage = new Couchbase();
        $this->_storage->setOptions($this->_options);
        $this->_storage->flush();
        parent::setUp();
    }

    public function tearDown()
    {
        if ($this->_storage) {
            $this->_storage->flush();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }
        parent::tearDown();
    }
}


Push — develop ( aae60d...6ebfe1 )

CouchbaseTest::setUp() D

Complexity

Size

Duplication

How to fix Complexity

Long Method

Available Fixes

1			<?php
2			/**
3			* zf-couchbase2
4			*
5			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
6			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
7			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
8			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
9			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
10			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
11			* SOFTWARE.
12			*
13			* @copyright 2015 MehrAlsNix (http://www.mehralsnix.de)
14			* @license http://www.opensource.org/licenses/mit-license.php MIT
15			* @link http://github.com/MehrAlsNix/zf-couchbase2
16			*/
17
18			namespace MehrAlsNix\Test\ZF\Cache\Storage\Adapter;
19
20			use MehrAlsNix\ZF\Cache\Storage\Adapter\Couchbase;
21			use MehrAlsNix\ZF\Cache\Storage\Adapter\CouchbaseOptions;
22			use Zend\Cache\Exception\ExtensionNotLoadedException;
23
24			/**
25			* Class CouchbaseTest
26			* @package MehrAlsNix\Test\ZF\Cache\Storage\Adapter
27			*/
28			class CouchbaseTest extends CommonAdapterTest
29			{
30			public function setUp()
31			{
32			if (!getenv('TESTS_ZEND_CACHE_COUCHBASE_ENABLED')) {
33			$this->markTestSkipped('Enable TESTS_ZEND_CACHE_COUCHBASE_ENABLED to run this test');
34			}
35			if (version_compare('2.0.0', phpversion('couchbase')) > 0) {
36			try {
37			new Couchbase();
38			$this->fail("Expected exception Zend\Cache\Exception\ExtensionNotLoadedException");
39			} catch (ExtensionNotLoadedException $e) {
40			$this->markTestSkipped("Missing ext/couchbase version >= 2.0.0");
41			}
42			}
43			$this->_options = new CouchbaseOptions([
44			'resource_id' => __CLASS__
45			]);
46			if (getenv('TESTS_ZEND_CACHE_COUCHBASE_HOST') && getenv('TESTS_ZEND_CACHE_COUCHBASE_PORT')) {
47			$this->_options->getResourceManager()->setServer(__CLASS__, [
			0 ignored issues – show Documentation introduced 2015-12-29 16:17 UTC by Report Bug Copy Issue Report `array(array(getenv('TEST...ACHE_COUCHBASE_PORT')))` is of type `array<integer,array<inte...",\"1\":\"string\"}>"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
48			[getenv('TESTS_ZEND_CACHE_COUCHBASE_HOST'), getenv('TESTS_ZEND_CACHE_COUCHBASE_PORT')]
49			]);
50			} elseif (getenv('TESTS_ZEND_CACHE_COUCHBASE_HOST')) {
51			$this->_options->getResourceManager()->setServer(__CLASS__, [
			0 ignored issues – show Documentation introduced 2015-12-29 16:17 UTC by Report Bug Copy Issue Report `array(array(getenv('TEST...ACHE_COUCHBASE_HOST')))` is of type `array<integer,array<inte...,{\"0\":\"string\"}>"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
52			[getenv('TESTS_ZEND_CACHE_COUCHBASE_HOST')]
53			]);
54			}
55			if (getenv('TESTS_ZEND_CACHE_COUCHBASE_USERNAME')) {
56			$this->_options->getResourceManager()->setUsername(__CLASS__, getenv('TESTS_ZEND_CACHE_COUCHBASE_USERNAME'));
57			}
58			if (getenv('TESTS_ZEND_CACHE_COUCHBASE_PASSWORD')) {
59			$this->_options->getResourceManager()->setPassword(__CLASS__, getenv('TESTS_ZEND_CACHE_COUCHBASE_PASSWORD'));
60			}
61			if (getenv('TESTS_ZEND_CACHE_COUCHBASE_BUCKET')) {
62			$this->_options->getResourceManager()->setBucket(__CLASS__, getenv('TESTS_ZEND_CACHE_COUCHBASE_BUCKET'));
63			}
64			$this->_storage = new Couchbase();
65			$this->_storage->setOptions($this->_options);
66			$this->_storage->flush();
67			parent::setUp();
68			}
69
70			public function tearDown()
71			{
72			if ($this->_storage) {
73			$this->_storage->flush();
			0 ignored issues – show Bug introduced 2015-12-29 16:17 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Zend\Cache\Storage\StorageInterface` as the method `flush()` does only exist in the following implementations of said interface: `MehrAlsNix\ZF\Cache\Storage\Adapter\Couchbase`, `Zend\Cache\Storage\Adapter\Apc`, `Zend\Cache\Storage\Adapter\BlackHole`, `Zend\Cache\Storage\Adapter\Dba`, `Zend\Cache\Storage\Adapter\Filesystem`, `Zend\Cache\Storage\Adapter\Memcache`, `Zend\Cache\Storage\Adapter\Memcached`, `Zend\Cache\Storage\Adapter\Memory`, `Zend\Cache\Storage\Adapter\MongoDb`, `Zend\Cache\Storage\Adapter\Redis`, `Zend\Cache\Storage\Adapter\Session`, `Zend\Cache\Storage\Adapter\WinCache`, `Zend\Cache\Storage\Adapter\XCache`, `Zend\Cache\Storage\Adapter\ZendServerDisk`, `Zend\Cache\Storage\Adapter\ZendServerShm`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
74			}
75			parent::tearDown();
76			}
77			}
78

MehrAlsNix / zf-couchbase2

Push — develop ( aae60d...6ebfe1 )

CouchbaseTest::setUp() D

Complexity

Size

Duplication

How to fix Complexity

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like