Bot::sendResponse() - Code Metrics - Inspection of "Merge branch 'master' of github.com:MehrAlsNix/Tel..." - MehrAlsNix/TelegramBot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e5a473...e29741 )

by Mattias

created 2017-06-21 22:32 UTC

Bot::sendResponse() A

↳ Parent: Bot

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	15
ccs	11
cts	11
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	10
nc	1
nop	2
crap	1

<?php

namespace TelegramBot;

use React\HttpClient\Client;
use React\HttpClient\Request;
use React\HttpClient\Response;

class Bot implements BotInterface {

  use \League\Event\EmitterTrait;

  /** @var string */
  private $botToken;
  /** @var int */
  private $offset;
  /** @var \React\HttpClient\Client */
  private $client;

  /**
   * @param string $botToken
   */
  public function __construct(string $botToken)
  {
      $this->botToken = $botToken;
  }

  /**
   * @param \React\HttpClient\Client
   */
  public function setClient(Client $client) {
    $this->client = $client;
  }

  public function poll() {
    $request = $this->getMassagesRequest();
    $request->on('response', [$this, '_handlePollResponse']);
    $request->end();
  }

  /**
   * @param \React\HttpClient\Response $response
   */
  public function _handlePollResponse(Response $response) {
    $response->on('data', [$this, '_handlePollData']);
    $response->on('error', [$this, '_handlePollError']);
  }

  /**
   * @param array $data
   * @param \React\HttpClient\Response $response
   */
  public function _handlePollData($data, $response) {

    $data = json_decode($data, 1);
    $messageData = $data['result'];

    foreach ($messageData as $message) {

      if (!isset($message['message']['text'])) {
        continue;
      }

      $this->getEmitter()->emit(
        $message['message']['text'],
        ['message' => $message, 'responder' => $this->getResponder($message)]

      );

      $this->setUpdateId($message['update_id']);
    }
  }

  /**
   * @param \React\HttpClient\Response $response
   */
  public function _handlePollError(Response $response) {
    print('Error: ');
    print_r($response);
  }

  /**
   * @param string $message
   */
  public function getResponder($message) {
    return function ($text) use($message){
        $this->sendResponse($text, $message);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    };
  }

  public function getMassagesRequest(): Request {
    return $this->client->request(
      'GET',
      $this->botCommand('getUpdates', ['offset' => $this->offset])
    );
  }

  public function sendResponse(string $responseText, array $incomingMessage) {
    $responseData = $this->postDataEncoder([
      'chat_id' => $incomingMessage['message']['chat']['id'],
      'reply_to_message_id' => $incomingMessage['message']['message_id'],
      'text' => $responseText
    ]);

    $responseCall = $this->client->request(
      'POST',
      $this->botCommand('sendMessage'),
      $this->getResponseHeaders($responseData)
    );

    $responseCall->end($responseData);
  }

  public function setUpdateId($id) {
    $this->offset = $id+1;
  }


  private function botCommand(string $command, array $params = []) :string {
    $params = (count($params)) ? '?' . $this->postDataEncoder($params) : '';

    return $this->assembleUri($command, $params);
  }


  private function assembleUri($command, $params) :string {
    return sprintf(
      'https://api.telegram.org/bot%s/%s%s',
      $this->botToken,
      $command,
      $params
    );
  }

  public function getResponseHeaders(string $responseString) :array {
    return [
      'Content-Type' =>  'application/x-www-form-urlencoded',
      'Content-Length' => strlen($responseString)
    ];
  }

  private function postDataEncoder(array $data) :string {
    $string = '';

    foreach ($data as $k => $v) {
      $string .= $k . '=' . urlencode($v) . '&';
    }

    return $string;
  }
}


1		<?php
2
3		namespace TelegramBot;
4
5		use React\HttpClient\Client;
6		use React\HttpClient\Request;
7		use React\HttpClient\Response;
8
9		class Bot implements BotInterface {
10
11		use \League\Event\EmitterTrait;
12
13		/** @var string */
14		private $botToken;
15		/** @var int */
16		private $offset;
17		/** @var \React\HttpClient\Client */
18		private $client;
19
20		/**
21		* @param string $botToken
22		*/
23	5	public function __construct(string $botToken)
24		{
25	5	$this->botToken = $botToken;
26	5	}
27
28		/**
29		* @param \React\HttpClient\Client
30		*/
31	5	public function setClient(Client $client) {
32	5	$this->client = $client;
33	5	}
34
35		public function poll() {
36		$request = $this->getMassagesRequest();
37		$request->on('response', [$this, '_handlePollResponse']);
38		$request->end();
39		}
40
41		/**
42		* @param \React\HttpClient\Response $response
43		*/
44		public function _handlePollResponse(Response $response) {
45		$response->on('data', [$this, '_handlePollData']);
46		$response->on('error', [$this, '_handlePollError']);
47		}
48
49		/**
50		* @param array $data
51		* @param \React\HttpClient\Response $response
52		*/
53		public function _handlePollData($data, $response) {
		0 ignored issues – show Unused Code introduced 2017-06-21 21:02 UTC by Report Bug Copy Issue Report The parameter `$response` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
54		$data = json_decode($data, 1);
55		$messageData = $data['result'];
56
57		foreach ($messageData as $message) {
58
59		if (!isset($message['message']['text'])) {
60		continue;
61		}
62
63		$this->getEmitter()->emit(
64		$message['message']['text'],
65		['message' => $message, 'responder' => $this->getResponder($message)]
		0 ignored issues – show Unused Code introduced 2017-06-21 21:02 UTC by Report Bug Copy Issue Report The call to `EmitterInterface::emit()` has too many arguments starting with `array('message' => $mess...getResponder($message))`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
66		);
67
68		$this->setUpdateId($message['update_id']);
69		}
70		}
71
72		/**
73		* @param \React\HttpClient\Response $response
74		*/
75		public function _handlePollError(Response $response) {
76		print('Error: ');
77		print_r($response);
78		}
79
80		/**
81		* @param string $message
82		*/
83		public function getResponder($message) {
84	1	return function ($text) use($message){
85		$this->sendResponse($text, $message);
		0 ignored issues – show Documentation introduced 2017-06-21 21:33 UTC by Report Bug Copy Issue Report `$message` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
86	1	};
87		}
88
89	1	public function getMassagesRequest(): Request {
90	1	return $this->client->request(
91	1	'GET',
92	1	$this->botCommand('getUpdates', ['offset' => $this->offset])
93		);
94		}
95
96	1	public function sendResponse(string $responseText, array $incomingMessage) {
97	1	$responseData = $this->postDataEncoder([
98	1	'chat_id' => $incomingMessage['message']['chat']['id'],
99	1	'reply_to_message_id' => $incomingMessage['message']['message_id'],
100	1	'text' => $responseText
101		]);
102
103	1	$responseCall = $this->client->request(
104	1	'POST',
105	1	$this->botCommand('sendMessage'),
106	1	$this->getResponseHeaders($responseData)
107		);
108
109	1	$responseCall->end($responseData);
110	1	}
111
112		public function setUpdateId($id) {
113		$this->offset = $id+1;
114		}
115
116
117	2	private function botCommand(string $command, array $params = []) :string {
118	2	$params = (count($params)) ? '?' . $this->postDataEncoder($params) : '';
119
120	2	return $this->assembleUri($command, $params);
121		}
122
123
124	2	private function assembleUri($command, $params) :string {
125	2	return sprintf(
126	2	'https://api.telegram.org/bot%s/%s%s',
127	2	$this->botToken,
128		$command,
129		$params
130		);
131		}
132
133	2	public function getResponseHeaders(string $responseString) :array {
134		return [
135	2	'Content-Type' => 'application/x-www-form-urlencoded',
136	2	'Content-Length' => strlen($responseString)
137		];
138		}
139
140	2	private function postDataEncoder(array $data) :string {
141	2	$string = '';
142
143	2	foreach ($data as $k => $v) {
144	2	$string .= $k . '=' . urlencode($v) . '&';
145		}
146
147	2	return $string;
148		}
149		}
150

MehrAlsNix / TelegramBot

Push — master ( e5a473...e29741 )

Bot::sendResponse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like