AdminControllerTest - Code Metrics - Inspection of "Update AdminControllerTest.php" - MeestorHok/Blue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 04acc1...595f19 )

by Jake

created 2016-06-09 18:18 UTC

AdminControllerTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
c	4
b	0
f	0
dl	0
loc	48
rs	10
wmc	3
lcom	0
cbo	1

3 Methods

Rating	Name	Size	Complexity
A	createApplication()	9	1
A	test_returns_dashboard_if_user_is_authenticated()	11	1
A	test_redirects_to_login_if_user_is_not_authenticated()	5	1

<?php

use MeestorHok\Blue\Http\Controllers\AdminController;
//use Illuminate\Contracts\View\Factory;

//use Illuminate\Http\Request;
use Illuminate\Routing\RouteCollection;
//use Illuminate\Routing\UrlGenerator as URL;



class AdminControllerTest extends Illuminate\Foundation\Testing\TestCase
namespace YourVendor;

class YourClass { }
{
    
    /**
     * The base URL to use while testing the application.
     *
     * @var string
     */
    protected $baseUrl = 'https://blue-meestorhok.c9users.io';

    /**
     * Creates the application.
     *
     * @return \Illuminate\Foundation\Application
     */
    public function createApplication()
    {
        // $app = require __DIR__.'/../bootstrap/app.php';


        // $app->make(Illuminate\Contracts\Console\Kernel::class)->bootstrap();


        // return $app;
        return 'hello!';
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
    
    // public function setUp() 

    // { 
    //     $this->urlGenerator = new UrlGenerator(new RouteCollection(), Request::create('/', 'GET'));

    // }
    
    public function test_returns_dashboard_if_user_is_authenticated ()
    {
        // $user = factory(App\User::class)->create();

        
        // $this->actingAs($user, 'admin')

        //      ->call('GET', 'admin')

        //      ->see('Waddup, y\'all');
        // $this->assertTrue(true);

        $this->call('GET', 'admin')->see('Waddup, y\'all');

       // $this->assertFalse($request);

    }
    
    public function test_redirects_to_login_if_user_is_not_authenticated ()
    {
        //$request = $this->urlGenerator->to('admin')->assertRedirectedTo('login');

        $this->assertTrue(true);
    }
}


1			<?php
2
3			use MeestorHok\Blue\Http\Controllers\AdminController;
4			//use Illuminate\Contracts\View\Factory;
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-09 18:20 UTC by Report Bug Copy Issue Report `45%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
5			//use Illuminate\Http\Request;
6			use Illuminate\Routing\RouteCollection;
7			//use Illuminate\Routing\UrlGenerator as URL;
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-09 18:20 UTC by Report Bug Copy Issue Report `38%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
8
9
10			class AdminControllerTest extends Illuminate\Foundation\Testing\TestCase
			0 ignored issues – show Coding Style Compatibility introduced 2016-06-08 14:33 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
11			{
12
13			/**
14			* The base URL to use while testing the application.
15			*
16			* @var string
17			*/
18			protected $baseUrl = 'https://blue-meestorhok.c9users.io';
19
20			/**
21			* Creates the application.
22			*
23			* @return \Illuminate\Foundation\Application
24			*/
25			public function createApplication()
26			{
27			// $app = require __DIR__.'/../bootstrap/app.php';
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-09 18:20 UTC by Report Bug Copy Issue Report `46%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
28
29			// $app->make(Illuminate\Contracts\Console\Kernel::class)->bootstrap();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-09 18:20 UTC by Report Bug Copy Issue Report `65%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
30
31			// return $app;
32			return 'hello!';
			0 ignored issues – show Bug Best Practice introduced 2016-06-09 18:20 UTC by Report Bug Copy Issue Report The return type of `return 'hello!';` (`string`) is incompatible with the return type declared by the abstract method `Illuminate\Foundation\Te...Case::createApplication` of type `Symfony\Component\HttpKernel\HttpKernelInterface`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
33			}
34
35			// public function setUp()
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-09 18:20 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
36			// {
37			// $this->urlGenerator = new UrlGenerator(new RouteCollection(), Request::create('/', 'GET'));
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-09 18:20 UTC by Report Bug Copy Issue Report `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
38			// }
39
40			public function test_returns_dashboard_if_user_is_authenticated ()
41			{
42			// $user = factory(App\User::class)->create();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-08 22:22 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
43
44			// $this->actingAs($user, 'admin')
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-08 22:22 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
45			// ->call('GET', 'admin')
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-08 22:22 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
46			// ->see('Waddup, y\'all');
47			// $this->assertTrue(true);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-09 16:24 UTC by Report Bug Copy Issue Report `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
48			$this->call('GET', 'admin')->see('Waddup, y\'all');
			0 ignored issues – show Bug introduced 2016-06-09 18:20 UTC by Report Bug Copy Issue Report The method `see()` does not seem to exist on `object<Illuminate\Http\Response>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
49			// $this->assertFalse($request);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-09 18:20 UTC by Report Bug Copy Issue Report `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
50			}
51
52			public function test_redirects_to_login_if_user_is_not_authenticated ()
53			{
54			//$request = $this->urlGenerator->to('admin')->assertRedirectedTo('login');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-09 18:20 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
55			$this->assertTrue(true);
56			}
57			}
58

MeestorHok / Blue

Push — master ( 04acc1...595f19 )

AdminControllerTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like