AdminControllerTest - Code Metrics - Inspection of "Update AdminControllerTest.php" - MeestorHok/Blue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 860ce2...7162da )

by Jake

created 2016-06-09 16:34 UTC

AdminControllerTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
dl	0
loc	29
rs	10
c	3
b	0
f	0
wmc	3
lcom	1
cbo	4

3 Methods

Rating	Name	Size	Complexity
A	setUp()	4	1
A	test_returns_dashboard_if_user_is_authenticated()	11	1
A	test_redirects_to_login_if_user_is_not_authenticated()	5	1

<?php

use MeestorHok\Blue\Http\Controllers\AdminController;
//use Illuminate\Contracts\View\Factory;
use Illuminate\Http\Request;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Illuminate\Routing\RouteCollection;
use Illuminate\Routing\UrlGenerator;


class AdminControllerTest extends PHPUnit_Framework_TestCase
namespace YourVendor;

class YourClass { }
{
    
    /** 
     * Setup the test environment. 
     */ 
    public function setUp() 
    { 
        $this->urlGenerator = new UrlGenerator(new RouteCollection(), Request::create('/', 'GET'));
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
    
    public function test_returns_dashboard_if_user_is_authenticated ()
    {
        // $user = factory(App\User::class)->create();

        
        // $this->actingAs($user, 'admin')

        //      ->call('GET', 'admin')

        //      ->see('Waddup, y\'all');
        // $this->assertTrue(true);

        $request = $this->urlGenerator->to('admin')->see('Waddup, y\'all');
        $this->assertFalse($request);
    }
    
    public function test_redirects_to_login_if_user_is_not_authenticated ()
    {
        $request = $this->urlGenerator->to('admin')->assertRedirectedTo('login');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        //$this->assertTrue(true);

    }
}


1			<?php
2
3			use MeestorHok\Blue\Http\Controllers\AdminController;
4			//use Illuminate\Contracts\View\Factory;
5			use Illuminate\Http\Request;
			0 ignored issues – show Bug introduced 2016-06-09 16:36 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Request`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
6			use Illuminate\Routing\RouteCollection;
7			use Illuminate\Routing\UrlGenerator;
8
9
10			class AdminControllerTest extends PHPUnit_Framework_TestCase
			0 ignored issues – show Coding Style Compatibility introduced 2016-06-08 22:18 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
11			{
12
13			/**
14			* Setup the test environment.
15			*/
16			public function setUp()
17			{
18			$this->urlGenerator = new UrlGenerator(new RouteCollection(), Request::create('/', 'GET'));
			0 ignored issues – show Bug introduced 2016-06-09 16:36 UTC by Report Bug Copy Issue Report The property `urlGenerator` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Compatibility introduced 2016-06-09 16:36 UTC by Report Bug Copy Issue Report `\Illuminate\Http\Request::create('/', 'GET')` of type `object<Symfony\Component\HttpFoundation\Request>` is not a sub-type of `object<Illuminate\Http\Request>`. It seems like you assume a child class of the class `Symfony\Component\HttpFoundation\Request` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
19			}
20
21			public function test_returns_dashboard_if_user_is_authenticated ()
22			{
23			// $user = factory(App\User::class)->create();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-08 22:22 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
24
25			// $this->actingAs($user, 'admin')
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-08 22:22 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
26			// ->call('GET', 'admin')
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-08 22:22 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
27			// ->see('Waddup, y\'all');
28			// $this->assertTrue(true);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-09 16:24 UTC by Report Bug Copy Issue Report `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
29			$request = $this->urlGenerator->to('admin')->see('Waddup, y\'all');
30			$this->assertFalse($request);
31			}
32
33			public function test_redirects_to_login_if_user_is_not_authenticated ()
34			{
35			$request = $this->urlGenerator->to('admin')->assertRedirectedTo('login');
			0 ignored issues – show Unused Code introduced 2016-06-09 16:36 UTC by Report Bug Copy Issue Report `$request` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
36			//$this->assertTrue(true);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-09 16:36 UTC by Report Bug Copy Issue Report `86%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
37			}
38			}
39

MeestorHok / Blue

Push — master ( 860ce2...7162da )

AdminControllerTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like