LinkedSocialAccountController::findOrCreate() - Code Metrics - Inspection of "Merge pull request #10 from Medianet-Tunisia/featu..." - Medianet-Tunisia/laravel-auth-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f02ea2...3c3bda )

by Soufiene

created 2020-06-24 14:02 UTC

LinkedSocialAccountController::findOrCreate() A

↳ Parent: LinkedSocialAccountController

Complexity

Conditions	4
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	21
CRAP Score	4.1137

Importance

Changes

Metric	Value
dl	0
loc	44
ccs	21
cts	26
cp	0.8077
rs	9.216
c	0
b	0
f	0
cc	4
nc	5
nop	1
crap	4.1137

<?php

namespace MedianetDev\LaravelAuthApi\Http\Controllers;

use MedianetDev\LaravelAuthApi\Http\Helpers\ApiResponse;
use MedianetDev\LaravelAuthApi\Http\Requests\SocialAccountRequest;
use MedianetDev\LaravelAuthApi\Models\ApiUser;
use MedianetDev\LaravelAuthApi\Models\LinkedSocialAccount;

class LinkedSocialAccountController extends Controller
{
    public function findOrCreate(SocialAccountRequest $request)
    {
        // see if any social account with the given data exists
        $socialAccount = $this->getSocialAccount($request);

        // if there is a social account return the associated user and the access token
        if ($socialAccount) {
            return ApiResponse::send([
                'flag' => 0,
                'user' => $socialAccount->user,
                'access_token' => $socialAccount->user->createToken('AppName')->accessToken,
            ], 1, 200, "find an associated user account with this $request->provider_name account");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }

        // try to get a user with the given email address
        $user = ApiUser::where('email', $request->email)->first();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        // if there is no user with that email address create one
        $newUser = false;
        if (! $user) {
            $user = ApiUser::create($request->only(

                array_merge(['name', 'email'], array_keys(config('laravel-auth-api.extra_columns')))
            ));
            $newUser = true;
        }

        // create and link a social account
        $user->linkedSocialAccounts()->create($request->only(['provider_name', 'provider_id', 'email']));

        // return the new created user and the access token
        if ($newUser) {
            return ApiResponse::send([
                'flag' => 1,
                'user' => $user,
                'access_token' => $user->createToken('AppName')->accessToken,
            ], 1, 201, 'new user account and social account has been created.');
        }

        return ApiResponse::send([
            'flag' => 0,
            'user' => $user,
            'access_token' => $user->createToken('AppName')->accessToken,
        ], 1, 201, "new social account has been created for $request->name.");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    private function getSocialAccount(SocialAccountRequest $request)
    {
        return LinkedSocialAccount::where('provider_name', $request->provider_name)
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->where('provider_id', $request->provider_id)
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->first();
    }
}


1		<?php
2
3		namespace MedianetDev\LaravelAuthApi\Http\Controllers;
4
5		use MedianetDev\LaravelAuthApi\Http\Helpers\ApiResponse;
6		use MedianetDev\LaravelAuthApi\Http\Requests\SocialAccountRequest;
7		use MedianetDev\LaravelAuthApi\Models\ApiUser;
8		use MedianetDev\LaravelAuthApi\Models\LinkedSocialAccount;
9
10		class LinkedSocialAccountController extends Controller
11		{
12	2	public function findOrCreate(SocialAccountRequest $request)
13		{
14		// see if any social account with the given data exists
15	2	$socialAccount = $this->getSocialAccount($request);
16
17		// if there is a social account return the associated user and the access token
18	2	if ($socialAccount) {
19		return ApiResponse::send([
20		'flag' => 0,
21		'user' => $socialAccount->user,
22		'access_token' => $socialAccount->user->createToken('AppName')->accessToken,
23		], 1, 200, "find an associated user account with this $request->provider_name account");
		0 ignored issues – show Documentation introduced 2020-06-23 13:27 UTC by Report Bug Copy Issue Report The property `provider_name` does not exist on `object<MedianetDev\Larav...s\SocialAccountRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
24		}
25
26		// try to get a user with the given email address
27	2	$user = ApiUser::where('email', $request->email)->first();
		0 ignored issues – show Documentation introduced 2020-06-23 13:27 UTC by Report Bug Copy Issue Report The property `email` does not exist on `object<MedianetDev\Larav...s\SocialAccountRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
28
29		// if there is no user with that email address create one
30	2	$newUser = false;
31	2	if (! $user) {
32	1	$user = ApiUser::create($request->only(
		0 ignored issues – show Bug introduced 2020-06-24 14:01 UTC by Report Bug Copy Issue Report The method `create()` does not exist on `MedianetDev\LaravelAuthApi\Models\ApiUser`. Did you maybe mean `created()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
33	1	array_merge(['name', 'email'], array_keys(config('laravel-auth-api.extra_columns')))
34		));
35	1	$newUser = true;
36		}
37
38		// create and link a social account
39	2	$user->linkedSocialAccounts()->create($request->only(['provider_name', 'provider_id', 'email']));
40
41		// return the new created user and the access token
42	2	if ($newUser) {
43	1	return ApiResponse::send([
44	1	'flag' => 1,
45	1	'user' => $user,
46	1	'access_token' => $user->createToken('AppName')->accessToken,
47	1	], 1, 201, 'new user account and social account has been created.');
48		}
49
50	1	return ApiResponse::send([
51	1	'flag' => 0,
52	1	'user' => $user,
53	1	'access_token' => $user->createToken('AppName')->accessToken,
54	1	], 1, 201, "new social account has been created for $request->name.");
		0 ignored issues – show Documentation introduced 2020-06-23 13:27 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<MedianetDev\Larav...s\SocialAccountRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
55		}
56
57	2	private function getSocialAccount(SocialAccountRequest $request)
58		{
59	2	return LinkedSocialAccount::where('provider_name', $request->provider_name)
		0 ignored issues – show Documentation introduced 2020-06-23 13:27 UTC by Report Bug Copy Issue Report The property `provider_name` does not exist on `object<MedianetDev\Larav...s\SocialAccountRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
60	2	->where('provider_id', $request->provider_id)
		0 ignored issues – show Documentation introduced 2020-06-23 13:27 UTC by Report Bug Copy Issue Report The property `provider_id` does not exist on `object<MedianetDev\Larav...s\SocialAccountRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
61	2	->first();
62		}
63		}
64

Medianet-Tunisia / laravel-auth-api

Push — master ( f02ea2...3c3bda )

LinkedSocialAccountController::findOrCreate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like