MedianetDev\LaravelAuthApi\Http\Controllers\ChangeUserProfileInfoController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	5
Bugs	1	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	update()	0	18	2

<?php

namespace MedianetDev\LaravelAuthApi\Http\Controllers;

use Illuminate\Support\Facades\Auth;
use MedianetDev\LaravelAuthApi\Http\Helpers\ApiResponse;
use MedianetDev\LaravelAuthApi\Http\Requests\ChangeUserProfileInfoRequest;

class ChangeUserProfileInfoController extends Controller
{
    /**
     * Create a new controller instance.
     *
     * @return void
     */
    public function __construct()
    {
        $this->middleware('auth:api');
    }

    public function update(ChangeUserProfileInfoRequest $request)
    {
        //TODO: encapsulate all the responses with ApiRequest
        $user = Auth::guard('apiauth')->user();

        $user->name = $request->name;

Accessing name on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $user->email = $request->email;

Accessing email on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        if ($user->isDirty('email')) {
            // mark the email as not verified yet
            $user->email_verified_at = null;

Accessing email_verified_at on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            // send a verification email
            $user->sendEmailVerificationNotification();
        }

        $user->save();

        return ApiResponse::send(['status' => 'Account updated successfully'], 1, 200, 'Account updated successfully');
    }
}