MedianetDev\LaravelAuthApi\Http\Controllers\ApiLoginRegisterController

Complexity

Total Complexity

6

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Test Coverage

Coverage

92.31%

Importance

Changes	2
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getUser()	0	5	1
A	__construct()	0	3	1
A	login()	0	11	2
A	register()	0	16	2

<?php

namespace MedianetDev\LaravelAuthApi\Http\Controllers;

use Illuminate\Support\Facades\Auth;
use MedianetDev\LaravelAuthApi\Http\Helpers\ApiResponse;
use MedianetDev\LaravelAuthApi\Http\Requests\ApiUserLoginRequest as LoginRequest;
use MedianetDev\LaravelAuthApi\Http\Requests\ApiUserRegisterRequest as RegisterRequest;

class ApiLoginRegisterController extends Controller
{
    /**
     * Instantiate a new controller instance.
     *
     * @return void
     */
    public function __construct()
    {
        $this->middleware('auth:apiauth')->only('getUser');
    }

    public $successStatus = 200;

    public function register(RegisterRequest $request)
    {
        $user = config('laravel-auth-api.user_model_fqn');
        $input = $request->only(
            array_merge(['name', 'email', 'password'], array_keys(config('laravel-auth-api.extra_columns')))
        );
        $input['password'] = bcrypt($input['password']);
        $user = (new $user)->create($input);
        if (config('laravel-auth-api.auto_send_verify_email')) {
            $user->sendEmailVerificationNotification();
        }
        $success = [];
        $success['access_token'] = $user->createToken('AppName')->accessToken;
        $success['user'] = $user->toArray();

        return  ApiResponse::send($success, 1, 201, 'Account created successfully');
    }

    public function login(LoginRequest $request)
    {
        if (Auth::guard('apiauthweb')->attempt(['email' => $request->email, 'password' => $request->password])) {
            $user = Auth::guard('apiauthweb')->user();
            $success = [];
            $success['access_token'] = $user->createToken('AppName')->accessToken;

The method createToken() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of said class. However, the method does not exist in Illuminate\Auth\GenericUser. Are you sure you never get one of those?

            $success['user'] = $user->toArray();

            return ApiResponse::send($success, 1, 200);
        } else {
            return ApiResponse::send(['error' => 'Unauthorised'], 0, 401, 'Password or incorrect identity');
        }
    }

    public function getUser()
    {
        $user = Auth::guard('apiauth')->user();

        return ApiResponse::send($user, 1, 200);

It seems like $user can also be of type Illuminate\Contracts\Auth\Authenticatable; however, parameter $data of MedianetDev\LaravelAuthApi\Http\Helpers\ApiResponse::send() does only seem to accept array, maybe add an additional type check?

    }
}