Issues in Configuration.php - New Issues - Inspection of "Refactor tests" - MediaMonks/symfony-rest-api-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d57410...764919 )

unknown

created 2019-11-29 13:48 UTC

DependencyInjection/Configuration.php (5 issues)

Labels

Compatibility 5

Severity

Minor 5

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace MediaMonks\RestApiBundle\DependencyInjection;

use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;
use Symfony\Component\Config\Definition\ConfigurationInterface;

final class Configuration implements ConfigurationInterface
{
    /**
     * Generates the configuration tree.
     *
     * @return TreeBuilder
     */
    public function getConfigTreeBuilder()
    {
        $treeBuilder = new TreeBuilder('mediamonks_rest_api');
        $rootNode = $treeBuilder->getRootNode();

        $this->addDebugNode($rootNode);

        $this->addRequestMatcherNode($rootNode);

        $this->addSerializer($rootNode);

        $this->addPostMessageOriginNode($rootNode);

        $this->addResponseModel($rootNode);


        return $treeBuilder;
    }

    /**
     * @param ArrayNodeDefinition $node
     */
    private function addDebugNode(ArrayNodeDefinition $node)
    {
        $node->children()
            ->scalarNode('debug')
            ->defaultNull()
            ->end();
    }

    /**
     * @param ArrayNodeDefinition $node
     */
    private function addRequestMatcherNode(ArrayNodeDefinition $node)
    {
        $node->children()
            ->arrayNode('request_matcher')
                ->addDefaultsIfNotSet()
                    ->children()
                        ->scalarNode('path')
                        ->end()
                        ->arrayNode('whitelist')
                            ->defaultValue(['~^/api$~', '~^/api/~'])
                            ->prototype('scalar')
                            ->end()
                        ->end()
                        ->arrayNode('blacklist')
                            ->defaultValue(['~^/api/doc~'])
                            ->prototype('scalar')
                        ->end()
                    ->end()
                ->end()
            ->end();
    }

    /**
     * @param ArrayNodeDefinition $node
     */
    private function addSerializer(ArrayNodeDefinition $node)
    {
        $node->children()
            ->scalarNode('serializer')
            ->defaultValue('json')
            ->end();
    }

    /**
     * @param ArrayNodeDefinition $node
     */
    private function addPostMessageOriginNode(ArrayNodeDefinition $node)
    {
        $node->children()
            ->scalarNode('post_message_origin')
            ->defaultNull()
            ->end();
    }

    /**
     * @param ArrayNodeDefinition $node
     */
    private function addResponseModel(ArrayNodeDefinition $node)
    {
        $node->children()
            ->scalarNode('response_model')
            ->defaultNull()
            ->end();
    }
}


1		<?php
2
3		namespace MediaMonks\RestApiBundle\DependencyInjection;
4
5		use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
6		use Symfony\Component\Config\Definition\Builder\TreeBuilder;
7		use Symfony\Component\Config\Definition\ConfigurationInterface;
8
9		final class Configuration implements ConfigurationInterface
10		{
11		/**
12		* Generates the configuration tree.
13		*
14		* @return TreeBuilder
15		*/
16	5	public function getConfigTreeBuilder()
17		{
18	5	$treeBuilder = new TreeBuilder('mediamonks_rest_api');
19	5	$rootNode = $treeBuilder->getRootNode();
20
21	5	$this->addDebugNode($rootNode);
		0 ignored issues – show Compatibility introduced 2019-11-29 13:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$rootNode` of type `object<Symfony\Component...Builder\NodeDefinition>` is not a sub-type of `object<Symfony\Component...er\ArrayNodeDefinition>`. It seems like you assume a child class of the class `Symfony\Component\Config...\Builder\NodeDefinition` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
22	5	$this->addRequestMatcherNode($rootNode);
		0 ignored issues – show Compatibility introduced 2019-11-29 13:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$rootNode` of type `object<Symfony\Component...Builder\NodeDefinition>` is not a sub-type of `object<Symfony\Component...er\ArrayNodeDefinition>`. It seems like you assume a child class of the class `Symfony\Component\Config...\Builder\NodeDefinition` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
23	5	$this->addSerializer($rootNode);
		0 ignored issues – show Compatibility introduced 2019-11-29 13:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$rootNode` of type `object<Symfony\Component...Builder\NodeDefinition>` is not a sub-type of `object<Symfony\Component...er\ArrayNodeDefinition>`. It seems like you assume a child class of the class `Symfony\Component\Config...\Builder\NodeDefinition` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
24	5	$this->addPostMessageOriginNode($rootNode);
		0 ignored issues – show Compatibility introduced 2019-11-29 13:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$rootNode` of type `object<Symfony\Component...Builder\NodeDefinition>` is not a sub-type of `object<Symfony\Component...er\ArrayNodeDefinition>`. It seems like you assume a child class of the class `Symfony\Component\Config...\Builder\NodeDefinition` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
25	5	$this->addResponseModel($rootNode);
		0 ignored issues – show Compatibility introduced 2019-11-29 13:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$rootNode` of type `object<Symfony\Component...Builder\NodeDefinition>` is not a sub-type of `object<Symfony\Component...er\ArrayNodeDefinition>`. It seems like you assume a child class of the class `Symfony\Component\Config...\Builder\NodeDefinition` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
26
27	5	return $treeBuilder;
28		}
29
30		/**
31		* @param ArrayNodeDefinition $node
32		*/
33	5	private function addDebugNode(ArrayNodeDefinition $node)
34		{
35	5	$node->children()
36	5	->scalarNode('debug')
37	5	->defaultNull()
38	5	->end();
39	5	}
40
41		/**
42		* @param ArrayNodeDefinition $node
43		*/
44	5	private function addRequestMatcherNode(ArrayNodeDefinition $node)
45		{
46	5	$node->children()
47	5	->arrayNode('request_matcher')
48	5	->addDefaultsIfNotSet()
49	5	->children()
50	5	->scalarNode('path')
51	5	->end()
52	5	->arrayNode('whitelist')
53	5	->defaultValue(['~^/api$~', '~^/api/~'])
54	5	->prototype('scalar')
55	5	->end()
56	5	->end()
57	5	->arrayNode('blacklist')
58	5	->defaultValue(['~^/api/doc~'])
59	5	->prototype('scalar')
60	5	->end()
61	5	->end()
62	5	->end()
63	5	->end();
64	5	}
65
66		/**
67		* @param ArrayNodeDefinition $node
68		*/
69	5	private function addSerializer(ArrayNodeDefinition $node)
70		{
71	5	$node->children()
72	5	->scalarNode('serializer')
73	5	->defaultValue('json')
74	5	->end();
75	5	}
76
77		/**
78		* @param ArrayNodeDefinition $node
79		*/
80	5	private function addPostMessageOriginNode(ArrayNodeDefinition $node)
81		{
82	5	$node->children()
83	5	->scalarNode('post_message_origin')
84	5	->defaultNull()
85	5	->end();
86	5	}
87
88		/**
89		* @param ArrayNodeDefinition $node
90		*/
91	5	private function addResponseModel(ArrayNodeDefinition $node)
92		{
93	5	$node->children()
94	5	->scalarNode('response_model')
95	5	->defaultNull()
96	5	->end();
97	5	}
98		}
99

MediaMonks / symfony-rest-api-bundle

Push — master ( d57410...764919 )

DependencyInjection/Configuration.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like