MP\ExtendedApi\EUpdateAllAction::prepareDataProvider()

Complexity

Conditions	13
Paths	32

Size

Total Lines	72
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
    protected function prepareDataProvider()
    {
        $filter            = Yii::$app->request->get($this->filterAttribute);
        $extraFilter       = Yii::$app->request->get($this->extraFilter);
        $queryParams       = Yii::$app->request->getQueryParams();
        $updatedAttributes = [];

        if (!empty($filter)) {
            $queryParams[$this->filterAttribute] = json_decode($filter, true);

It seems like $filter can also be of type array; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

        }

        if (!empty($extraFilter) && is_string($extraFilter)) {
            $extraFilter = json_decode($extraFilter, true);
        }

        if (!empty($queryParams[$this->updatedAttribute])) {
            $updatedAttributes = json_decode($queryParams[$this->updatedAttribute], true);
        }

        if (empty($updatedAttributes)) {
            throw new BadRequestHttpException("Param '{$this->updatedAttribute}' cannot be empty");
        }

        Yii::$app->request->setQueryParams($queryParams);

        $this->prepareDataProvider = function (EIndexAction $action, $filter) use ($extraFilter) {
            /** @var ActiveDataProvider $dataProvider */
            $dataProvider = call_user_func([$action->dataFilter->searchModel, 'getDataProvider']);
            $dataProvider->query->andWhere($filter);

            if ($this->addQuery) {
                call_user_func($this->addQuery, $dataProvider->query, $extraFilter, $action->dataFilter);

                if ($action->dataFilter->hasErrors()) {

The method hasErrors() does not exist on null.

                    return $action->dataFilter;
                }
            }

            if ($this->filterUser) {
                $filterUserColumn = is_callable($this->filterUser) ? call_user_func($this->filterUser) : $this->filterUser;

                if ($filterUserColumn !== null) {
                    $dataProvider->query->andWhere([$filterUserColumn => Yii::$app->user->getId()]);

The method getId() does not exist on null.

                }
            }

            return $dataProvider;
        };

        $dataProvider = parent::prepareDataProvider();
        /** @var ActiveQuery $query */
        $query = $dataProvider->query;
        $query
            ->limit(-1)
            ->offset(-1)
            ->orderBy([]);

        $countUpdated = 0;

        foreach ($query->each() as $model) {
            /** @var $model ActiveRecord */
            $model->setAttributes($updatedAttributes);

            if ($model->save()) {
                $this->_updatedModels[] = $model;
                $countUpdated++;
            }
        }

        Yii::$app->response->headers->set('X-Total-Updated', $countUpdated);

        return;
    }