Syncer\Command\SyncTimings

Complexity

Total Complexity

15

Size/Duplication

Total Lines	157
Duplicated Lines	9.55 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	15	1
A	configure()	0	7	1
D	execute()	15	36	9
A	logTask()	0	10	1
A	buildTaskDescription()	0	12	2
A	buildTimeLog()	0	9	1

<?php

namespace Syncer\Command;

use Syncer\Dto\InvoiceNinja\Task;
use Syncer\Dto\Toggl\TimeEntry;
use Syncer\InvoiceNinja\Client as InvoiceNinjaClient;
use Syncer\Toggl\ReportsClient;
use Syncer\Toggl\TogglClient;

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Style\SymfonyStyle;

/**
 * Class SyncTimings
 * @package Syncer\Command
 *
 * @author Matthieu Calie <matthieu@calie.be>
 */
class SyncTimings extends Command
{
    /**
     * @var SymfonyStyle
     */
    private $io;

    /**
     * @var TogglClient
     */
    private $togglClient;

    /**
     * @var ReportsClient
     */
    private $reportsClient;

    /**
     * @var InvoiceNinjaClient
     */
    private $invoiceNinjaClient;

    /**
     * @var array
     */
    private $clients;

    /**
     * @var array
     */
    private $projects;

    /**
     * SyncTimings constructor.
     *
     * @param TogglClient $togglClient
     * @param ReportsClient $reportsClient
     * @param InvoiceNinjaClient $invoiceNinjaClient
     * @param array $clients
     * @param array $projects
     */
    public function __construct(
        TogglClient $togglClient,
        ReportsClient $reportsClient,
        InvoiceNinjaClient $invoiceNinjaClient,
        $clients,
        $projects
    ) {
        $this->togglClient = $togglClient;
        $this->reportsClient = $reportsClient;
        $this->invoiceNinjaClient = $invoiceNinjaClient;
        $this->clients = $clients;
        $this->projects = $projects;

        parent::__construct();
    }

    /**
     * Configure the command
     */
    protected function configure()
    {
        $this
            ->setName('sync:timings')
            ->setDescription('Syncs timings from toggl to invoiceninja')
        ;
    }

    /**
     * {@inheritdoc}
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $this->io = new SymfonyStyle($input, $output);
        $workspaces = $this->togglClient->getWorkspaces();

        foreach ($workspaces as $workspace) {

The expression $workspaces of type object|array|integer|double|string|boolean is not guaranteed to be traversable. How about adding an additional type check?

            $detailedReport = $this->reportsClient->getDetailedReport($workspace->getId());

            foreach($detailedReport->getData() as $timeEntry) {
                $timeEntrySent = false;

                // Log the entry if the client key exists
                if (is_array($this->clients)

This code seems to be duplicated across your project.

                    && array_key_exists($timeEntry->getClient(), $this->clients)
                ) {
                    $this->logTask($timeEntry, $this->clients, $timeEntry->getClient());

                    $timeEntrySent = true;
                }

                // Log the entry if the project key exists
                if (is_array($this->projects)

This code seems to be duplicated across your project.

                    && array_key_exists($timeEntry->getProject(), $this->projects)
                    && !$timeEntrySent
                ) {
                    $this->logTask($timeEntry, $this->projects, $timeEntry->getProject());

                    $timeEntrySent = true;
                }

                if ($timeEntrySent) {
                    $this->io->success('TimeEntry ('. $timeEntry->getDescription() . ') sent to toggl');
                }
            }
        }
    }

    /**
     * @param TimeEntry $entry
     * @param array $config
     * @param $key
     */
    private function logTask(TimeEntry $entry, array $config, $key)
    {
        $task = new Task();

        $task->setDescription($this->buildTaskDescription($entry));
        $task->setTimeLog($this->buildTimeLog($entry));
        $task->setClientId($config[$key]);

        $this->invoiceNinjaClient->saveNewTask($task);
    }

    /**
     * @param TimeEntry $entry
     *
     * @return string
     */
    private function buildTaskDescription(TimeEntry $entry)
    {
        $description = '';

        if ($entry->getProject()) {
            $description .= $entry->getProject() . ': ';
        }

        $description .= $entry->getDescription();

        return $description;
    }

    /**
     * @param TimeEntry $entry
     *
     * @return string
     */
    private function buildTimeLog(TimeEntry $entry)
    {
        $timeLog = [
            $entry->getStart()->getTimestamp(),
            $entry->getEnd()->getTimestamp(),
        ];

        return \GuzzleHttp\json_encode($timeLog);
    }
}