Complex classes like OutputRules often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use OutputRules, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
17 | class OutputRules implements \Masterminds\HTML5\Serializer\RulesInterface |
||
18 | { |
||
19 | /** |
||
20 | * Defined in http://www.w3.org/TR/html51/infrastructure.html#html-namespace-0. |
||
21 | */ |
||
22 | const NAMESPACE_HTML = 'http://www.w3.org/1999/xhtml'; |
||
23 | |||
24 | const NAMESPACE_MATHML = 'http://www.w3.org/1998/Math/MathML'; |
||
25 | |||
26 | const NAMESPACE_SVG = 'http://www.w3.org/2000/svg'; |
||
27 | |||
28 | const NAMESPACE_XLINK = 'http://www.w3.org/1999/xlink'; |
||
29 | |||
30 | const NAMESPACE_XML = 'http://www.w3.org/XML/1998/namespace'; |
||
31 | |||
32 | const NAMESPACE_XMLNS = 'http://www.w3.org/2000/xmlns/'; |
||
33 | |||
34 | /** |
||
35 | * Holds the HTML5 element names that causes a namespace switch. |
||
36 | * |
||
37 | * @var array |
||
38 | */ |
||
39 | protected $implicitNamespaces = array( |
||
40 | self::NAMESPACE_HTML, |
||
41 | self::NAMESPACE_SVG, |
||
42 | self::NAMESPACE_MATHML, |
||
43 | self::NAMESPACE_XML, |
||
44 | self::NAMESPACE_XMLNS, |
||
45 | ); |
||
46 | |||
47 | const IM_IN_HTML = 1; |
||
48 | |||
49 | const IM_IN_SVG = 2; |
||
50 | |||
51 | const IM_IN_MATHML = 3; |
||
52 | |||
53 | /** |
||
54 | * Used as cache to detect if is available ENT_HTML5. |
||
55 | * |
||
56 | * @var bool |
||
57 | */ |
||
58 | private $hasHTML5 = false; |
||
59 | |||
60 | protected $traverser; |
||
61 | |||
62 | protected $encode = false; |
||
63 | |||
64 | protected $out; |
||
65 | |||
66 | protected $outputMode; |
||
67 | |||
68 | private $xpath; |
||
69 | |||
70 | protected $nonBooleanAttributes = array( |
||
71 | /* |
||
72 | array( |
||
73 | 'nodeNamespace'=>'http://www.w3.org/1999/xhtml', |
||
74 | 'attrNamespace'=>'http://www.w3.org/1999/xhtml', |
||
75 | |||
76 | 'nodeName'=>'img', 'nodeName'=>array('img', 'a'), |
||
77 | 'attrName'=>'alt', 'attrName'=>array('title', 'alt'), |
||
78 | ), |
||
79 | */ |
||
80 | array( |
||
81 | 'nodeNamespace' => 'http://www.w3.org/1999/xhtml', |
||
82 | 'attrName' => array('href', |
||
83 | 'hreflang', |
||
84 | 'http-equiv', |
||
85 | 'icon', |
||
86 | 'id', |
||
87 | 'keytype', |
||
88 | 'kind', |
||
89 | 'label', |
||
90 | 'lang', |
||
91 | 'language', |
||
92 | 'list', |
||
93 | 'maxlength', |
||
94 | 'media', |
||
95 | 'method', |
||
96 | 'name', |
||
97 | 'placeholder', |
||
98 | 'rel', |
||
99 | 'rows', |
||
100 | 'rowspan', |
||
101 | 'sandbox', |
||
102 | 'spellcheck', |
||
103 | 'scope', |
||
104 | 'seamless', |
||
105 | 'shape', |
||
106 | 'size', |
||
107 | 'sizes', |
||
108 | 'span', |
||
109 | 'src', |
||
110 | 'srcdoc', |
||
111 | 'srclang', |
||
112 | 'srcset', |
||
113 | 'start', |
||
114 | 'step', |
||
115 | 'style', |
||
116 | 'summary', |
||
117 | 'tabindex', |
||
118 | 'target', |
||
119 | 'title', |
||
120 | 'type', |
||
121 | 'value', |
||
122 | 'width', |
||
123 | 'border', |
||
124 | 'charset', |
||
125 | 'cite', |
||
126 | 'class', |
||
127 | 'code', |
||
128 | 'codebase', |
||
129 | 'color', |
||
130 | 'cols', |
||
131 | 'colspan', |
||
132 | 'content', |
||
133 | 'coords', |
||
134 | 'data', |
||
135 | 'datetime', |
||
136 | 'default', |
||
137 | 'dir', |
||
138 | 'dirname', |
||
139 | 'enctype', |
||
140 | 'for', |
||
141 | 'form', |
||
142 | 'formaction', |
||
143 | 'headers', |
||
144 | 'height', |
||
145 | 'accept', |
||
146 | 'accept-charset', |
||
147 | 'accesskey', |
||
148 | 'action', |
||
149 | 'align', |
||
150 | 'alt', |
||
151 | 'bgcolor', |
||
152 | ), |
||
153 | ), |
||
154 | array( |
||
155 | 'nodeNamespace' => 'http://www.w3.org/1999/xhtml', |
||
156 | 'xpath' => 'starts-with(local-name(), \'data-\')', |
||
157 | ), |
||
158 | ); |
||
159 | |||
160 | const DOCTYPE = '<!DOCTYPE html>'; |
||
161 | |||
162 | 64 | public function __construct($output, $options = array()) |
|
163 | { |
||
164 | 64 | if (isset($options['encode_entities'])) { |
|
165 | 64 | $this->encode = $options['encode_entities']; |
|
166 | 64 | } |
|
167 | |||
168 | 64 | $this->outputMode = static::IM_IN_HTML; |
|
169 | 64 | $this->out = $output; |
|
170 | |||
171 | // If HHVM, see https://github.com/facebook/hhvm/issues/2727 |
||
172 | 64 | $this->hasHTML5 = defined('ENT_HTML5') && !defined('HHVM_VERSION'); |
|
173 | 64 | } |
|
174 | |||
175 | public function addRule(array $rule) |
||
176 | { |
||
177 | $this->nonBooleanAttributes[] = $rule; |
||
178 | } |
||
179 | |||
180 | 64 | public function setTraverser(\Masterminds\HTML5\Serializer\Traverser $traverser) |
|
181 | { |
||
182 | 64 | $this->traverser = $traverser; |
|
183 | |||
184 | 64 | return $this; |
|
185 | } |
||
186 | |||
187 | 18 | public function document($dom) |
|
188 | { |
||
189 | 18 | $this->doctype(); |
|
190 | 18 | if ($dom->documentElement) { |
|
191 | 17 | foreach ($dom->childNodes as $node) { |
|
192 | 17 | $this->traverser->node($node); |
|
193 | 17 | } |
|
194 | 17 | $this->nl(); |
|
195 | 17 | } |
|
196 | 18 | } |
|
197 | |||
198 | 19 | protected function doctype() |
|
199 | { |
||
200 | 19 | $this->wr(static::DOCTYPE); |
|
201 | 19 | $this->nl(); |
|
202 | 19 | } |
|
203 | |||
204 | 27 | public function element($ele) |
|
205 | { |
||
206 | 27 | $name = $ele->tagName; |
|
207 | |||
208 | // Per spec: |
||
209 | // If the element has a declared namespace in the HTML, MathML or |
||
210 | // SVG namespaces, we use the lname instead of the tagName. |
||
211 | 27 | if ($this->traverser->isLocalElement($ele)) { |
|
212 | 27 | $name = $ele->localName; |
|
213 | 27 | } |
|
214 | |||
215 | // If we are in SVG or MathML there is special handling. |
||
216 | // Using if/elseif instead of switch because it's faster in PHP. |
||
217 | 27 | if ('svg' == $name) { |
|
218 | 3 | $this->outputMode = static::IM_IN_SVG; |
|
219 | 3 | $name = Elements::normalizeSvgElement($name); |
|
220 | 27 | } elseif ('math' == $name) { |
|
221 | 2 | $this->outputMode = static::IM_IN_MATHML; |
|
222 | 2 | } |
|
223 | |||
224 | 27 | $this->openTag($ele); |
|
225 | 27 | if (Elements::isA($name, Elements::TEXT_RAW)) { |
|
226 | 4 | foreach ($ele->childNodes as $child) { |
|
227 | 4 | if ($child instanceof \DOMCharacterData) { |
|
228 | 4 | $this->wr($child->data); |
|
229 | 4 | } elseif ($child instanceof \DOMElement) { |
|
230 | 1 | $this->element($child); |
|
231 | 1 | } |
|
232 | 4 | } |
|
233 | 4 | } else { |
|
234 | // Handle children. |
||
235 | 25 | if ($ele->hasChildNodes()) { |
|
236 | 25 | $this->traverser->children($ele->childNodes); |
|
237 | 25 | } |
|
238 | |||
239 | // Close out the SVG or MathML special handling. |
||
240 | 25 | if ('svg' == $name || 'math' == $name) { |
|
241 | 5 | $this->outputMode = static::IM_IN_HTML; |
|
242 | 5 | } |
|
243 | } |
||
244 | |||
245 | // If not unary, add a closing tag. |
||
246 | 27 | if (!Elements::isA($name, Elements::VOID_TAG)) { |
|
247 | 27 | $this->closeTag($ele); |
|
248 | 27 | } |
|
249 | 27 | } |
|
250 | |||
251 | /** |
||
252 | * Write a text node. |
||
253 | * |
||
254 | * @param \DOMText $ele The text node to write |
||
255 | */ |
||
256 | 24 | public function text($ele) |
|
257 | { |
||
258 | 24 | if (isset($ele->parentNode) && isset($ele->parentNode->tagName) && Elements::isA($ele->parentNode->localName, Elements::TEXT_RAW)) { |
|
259 | 1 | $this->wr($ele->data); |
|
260 | |||
261 | 1 | return; |
|
262 | } |
||
263 | |||
264 | // FIXME: This probably needs some flags set. |
||
265 | 24 | $this->wr($this->enc($ele->data)); |
|
266 | 24 | } |
|
267 | |||
268 | 2 | public function cdata($ele) |
|
269 | { |
||
270 | // This encodes CDATA. |
||
271 | 2 | $this->wr($ele->ownerDocument->saveXML($ele)); |
|
272 | 2 | } |
|
273 | |||
274 | 3 | public function comment($ele) |
|
275 | { |
||
276 | // These produce identical output. |
||
277 | // $this->wr('<!--')->wr($ele->data)->wr('-->'); |
||
278 | 3 | $this->wr($ele->ownerDocument->saveXML($ele)); |
|
279 | 3 | } |
|
280 | |||
281 | 3 | public function processorInstruction($ele) |
|
282 | { |
||
283 | 3 | $this->wr('<?') |
|
284 | 3 | ->wr($ele->target) |
|
285 | 3 | ->wr(' ') |
|
286 | 3 | ->wr($ele->data) |
|
287 | 3 | ->wr('?>'); |
|
288 | 3 | } |
|
289 | |||
290 | /** |
||
291 | * Write the namespace attributes. |
||
292 | * |
||
293 | * |
||
294 | * @param \DOMNode $ele The element being written |
||
295 | */ |
||
296 | 28 | protected function namespaceAttrs($ele) |
|
297 | { |
||
298 | 28 | if (!$this->xpath || $this->xpath->document !== $ele->ownerDocument) { |
|
299 | 28 | $this->xpath = new \DOMXPath($ele->ownerDocument); |
|
300 | 28 | } |
|
301 | |||
302 | 28 | foreach ($this->xpath->query('namespace::*[not(.=../../namespace::*)]', $ele) as $nsNode) { |
|
303 | 23 | if (!in_array($nsNode->nodeValue, $this->implicitNamespaces)) { |
|
304 | 3 | $this->wr(' ')->wr($nsNode->nodeName)->wr('="')->wr($nsNode->nodeValue)->wr('"'); |
|
305 | 3 | } |
|
306 | 28 | } |
|
307 | 28 | } |
|
308 | |||
309 | /** |
||
310 | * Write the opening tag. |
||
311 | * |
||
312 | * Tags for HTML, MathML, and SVG are in the local name. Otherwise, use the |
||
313 | * qualified name (8.3). |
||
314 | * |
||
315 | * @param \DOMNode $ele The element being written |
||
316 | */ |
||
317 | 28 | protected function openTag($ele) |
|
318 | { |
||
319 | 28 | $this->wr('<')->wr($this->traverser->isLocalElement($ele) ? $ele->localName : $ele->tagName); |
|
320 | |||
321 | 28 | $this->attrs($ele); |
|
322 | 28 | $this->namespaceAttrs($ele); |
|
323 | |||
324 | 28 | if ($this->outputMode == static::IM_IN_HTML) { |
|
325 | 26 | $this->wr('>'); |
|
326 | 26 | } // If we are not in html mode we are in SVG, MathML, or XML embedded content. |
|
327 | else { |
||
328 | 5 | if ($ele->hasChildNodes()) { |
|
329 | 5 | $this->wr('>'); |
|
330 | 5 | } // If there are no children this is self closing. |
|
331 | else { |
||
332 | 2 | $this->wr(' />'); |
|
333 | } |
||
334 | } |
||
335 | 28 | } |
|
336 | |||
337 | 39 | protected function attrs($ele) |
|
373 | |||
374 | 10 | protected function nonBooleanAttribute(\DOMAttr $attr) |
|
375 | { |
||
376 | 10 | $ele = $attr->ownerElement; |
|
377 | 10 | foreach ($this->nonBooleanAttributes as $rule) { |
|
378 | 10 | if (isset($rule['nodeNamespace']) && $rule['nodeNamespace'] !== $ele->namespaceURI) { |
|
379 | continue; |
||
380 | } |
||
381 | 10 | if (isset($rule['attNamespace']) && $rule['attNamespace'] !== $attr->namespaceURI) { |
|
382 | continue; |
||
383 | } |
||
384 | 10 | if (isset($rule['nodeName']) && !is_array($rule['nodeName']) && $rule['nodeName'] !== $ele->localName) { |
|
385 | continue; |
||
413 | |||
414 | 9 | private function getXPath(\DOMNode $node) |
|
422 | |||
423 | /** |
||
424 | * Write the closing tag. |
||
425 | * |
||
426 | * Tags for HTML, MathML, and SVG are in the local name. Otherwise, use the |
||
427 | * qualified name (8.3). |
||
428 | * |
||
429 | * @param \DOMNode $ele The element being written |
||
430 | */ |
||
431 | 27 | protected function closeTag($ele) |
|
437 | |||
438 | /** |
||
439 | * Write to the output. |
||
440 | * |
||
441 | * @param string $text The string to put into the output |
||
442 | * |
||
443 | * @return Traverser $this so it can be used in chaining |
||
444 | */ |
||
445 | 48 | protected function wr($text) |
|
451 | |||
452 | /** |
||
453 | * Write a new line character. |
||
454 | * |
||
455 | * @return Traverser $this so it can be used in chaining |
||
456 | */ |
||
457 | 20 | protected function nl() |
|
463 | |||
464 | /** |
||
465 | * Encode text. |
||
466 | * |
||
467 | * When encode is set to false, the default value, the text passed in is |
||
468 | * escaped per section 8.3 of the html5 spec. For details on how text is |
||
469 | * escaped see the escape() method. |
||
470 | * |
||
471 | * When encoding is set to true the text is converted to named character |
||
472 | * references where appropriate. Section 8.1.4 Character references of the |
||
473 | * html5 spec refers to using named character references. This is useful for |
||
474 | * characters that can't otherwise legally be used in the text. |
||
475 | * |
||
476 | * The named character references are listed in section 8.5. |
||
477 | * |
||
478 | * @see http://www.w3.org/TR/2013/CR-html5-20130806/syntax.html#named-character-references True encoding will turn all named character references into their entities. |
||
479 | * This includes such characters as +.# and many other common ones. By default |
||
480 | * encoding here will just escape &'<>". |
||
481 | * |
||
482 | * Note, PHP 5.4+ has better html5 encoding. |
||
483 | * |
||
484 | * @todo Use the Entities class in php 5.3 to have html5 entities. |
||
485 | * |
||
486 | * @param string $text text to encode |
||
487 | * @param bool $attribute True if we are encoding an attrubute, false otherwise |
||
488 | * |
||
489 | * @return string the encoded text |
||
490 | */ |
||
491 | 44 | protected function enc($text, $attribute = false) |
|
509 | |||
510 | /** |
||
511 | * Escape test. |
||
512 | * |
||
513 | * According to the html5 spec section 8.3 Serializing HTML fragments, text |
||
514 | * within tags that are not style, script, xmp, iframe, noembed, and noframes |
||
515 | * need to be properly escaped. |
||
516 | * |
||
517 | * The & should be converted to &, no breaking space unicode characters |
||
518 | * converted to , when in attribute mode the " should be converted to |
||
519 | * ", and when not in attribute mode the < and > should be converted to |
||
520 | * < and >. |
||
521 | * |
||
522 | * @see http://www.w3.org/TR/2013/CR-html5-20130806/syntax.html#escapingString |
||
523 | * |
||
524 | * @param string $text text to escape |
||
525 | * @param bool $attribute True if we are escaping an attrubute, false otherwise |
||
526 | */ |
||
527 | 51 | protected function escape($text, $attribute = false) |
|
549 | } |
||
550 |