Complex classes like Signal often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Signal, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 43 | class Signal implements LoggerAwareInterface |
||
| 44 | { |
||
| 45 | |||
| 46 | const Slots = 'slots'; |
||
| 47 | const Signals = 'signals'; |
||
| 48 | |||
| 49 | /** |
||
| 50 | * Generated signals name. |
||
| 51 | * Name of this constant is confusing. |
||
| 52 | * @internal description |
||
| 53 | */ |
||
| 54 | const ConfigFilename = 'signals-definition.php'; |
||
| 55 | |||
| 56 | /** |
||
| 57 | * Config file name |
||
| 58 | */ |
||
| 59 | const ConfigName = "signals"; |
||
| 60 | |||
| 61 | /** |
||
| 62 | * Runtime path. |
||
| 63 | * This is path where config from yml will be stored. |
||
| 64 | * Path is relative to project root. |
||
| 65 | * @var string |
||
| 66 | */ |
||
| 67 | public $runtimePath = 'runtime'; |
||
| 68 | |||
| 69 | /** |
||
| 70 | * This aliases will be searched for SlotFor and SignalFor annotations |
||
| 71 | * TODO Autodetect based on composer autoload |
||
| 72 | * @var string[] |
||
| 73 | */ |
||
| 74 | public $paths = [ |
||
| 75 | 'vendor', |
||
| 76 | ]; |
||
| 77 | |||
| 78 | /** |
||
| 79 | * Directories to ignore while scanning |
||
| 80 | * @var string[] |
||
| 81 | */ |
||
| 82 | public $ignoreDirs = [ |
||
| 83 | 'vendor', // Vendors in vendors |
||
| 84 | 'generated', // Generated data, including signals |
||
| 85 | 'runtime', // Runtime data |
||
| 86 | ]; |
||
| 87 | |||
| 88 | /** |
||
| 89 | * Filters configuration. |
||
| 90 | * This filters will be applied to every emit. |
||
| 91 | * @var string[]|object[] |
||
| 92 | */ |
||
| 93 | public $filters = []; |
||
| 94 | |||
| 95 | /** |
||
| 96 | * Sorters configuration. |
||
| 97 | * @var string[]|object[] |
||
| 98 | */ |
||
| 99 | public $sorters = []; |
||
| 100 | |||
| 101 | /** |
||
| 102 | * Extractor configuration |
||
| 103 | * @var string|[]|object |
||
| 104 | */ |
||
| 105 | public $extractor = Addendum::class; |
||
| 106 | |||
| 107 | /** |
||
| 108 | * Input/Output configuration |
||
| 109 | * @var string|[]|object |
||
| 110 | */ |
||
| 111 | public $io = PhpFile::class; |
||
| 112 | |||
| 113 | /** |
||
| 114 | * Whenever component is initialized |
||
| 115 | * @var bool |
||
| 116 | */ |
||
| 117 | public $isInitialized = false; |
||
| 118 | |||
| 119 | /** |
||
| 120 | * Configuration of signals and slots |
||
| 121 | * @var string[][] |
||
| 122 | */ |
||
| 123 | private static $config = []; |
||
| 124 | |||
| 125 | /** |
||
| 126 | * Logger instance holder |
||
| 127 | * NOTE: There is property annotation with `logger` name, |
||
| 128 | * thus this name is a bit longer |
||
| 129 | * @var LoggerInterface |
||
| 130 | */ |
||
| 131 | private $loggerInstance = null; |
||
| 132 | |||
| 133 | /** |
||
| 134 | * Embedded dependency injection |
||
| 135 | * @var EmbeDi |
||
| 136 | */ |
||
| 137 | private $di = null; |
||
| 138 | |||
| 139 | /** |
||
| 140 | * Version |
||
| 141 | * @var string |
||
| 142 | */ |
||
| 143 | private $version = null; |
||
| 144 | |||
| 145 | /** |
||
| 146 | * Current filters |
||
| 147 | * @var PreFilterInterface[]|PostFilterInterface[] |
||
| 148 | */ |
||
| 149 | private $currentFilters = []; |
||
| 150 | |||
| 151 | 25 | public function __construct($configName = self::ConfigName) |
|
| 163 | |||
| 164 | /** |
||
| 165 | * Getter |
||
| 166 | * @param string $name |
||
| 167 | * @return mixed |
||
| 168 | */ |
||
| 169 | public function __get($name) |
||
| 173 | |||
| 174 | /** |
||
| 175 | * Setter |
||
| 176 | * @param string $name |
||
| 177 | * @param mixed $value |
||
| 178 | * @return mixed |
||
| 179 | */ |
||
| 180 | public function __set($name, $value) |
||
| 184 | |||
| 185 | /** |
||
| 186 | * Get current signals version |
||
| 187 | * |
||
| 188 | * @codeCoverageIgnore |
||
| 189 | * @return string |
||
| 190 | */ |
||
| 191 | public function getVersion() |
||
| 199 | |||
| 200 | public function init() |
||
| 211 | |||
| 212 | /** |
||
| 213 | * Apply filter to current emit. |
||
| 214 | * |
||
| 215 | * Pass false as param to disable all filters. |
||
| 216 | * |
||
| 217 | * @param FilterInterface|string|mixed $filter |
||
| 218 | * @return Signal |
||
| 219 | * @throws UnexpectedValueException |
||
| 220 | */ |
||
| 221 | 4 | public function filter($filter) |
|
| 241 | |||
| 242 | /** |
||
| 243 | * Emit signal to inform slots |
||
| 244 | * @param object|string $signal |
||
| 245 | * @return object[] |
||
| 246 | */ |
||
| 247 | 24 | public function emit($signal) |
|
| 295 | |||
| 296 | /** |
||
| 297 | * Call for signals from slot |
||
| 298 | * @param object $slot |
||
| 299 | * @param string $interface Interface or class name which must be implemented, instanceof or sub class of to get into slot |
||
| 300 | */ |
||
| 301 | 7 | public function gather($slot, $interface = null) |
|
| 387 | |||
| 388 | /** |
||
| 389 | * Get filters |
||
| 390 | * @param string $interface |
||
| 391 | * @return PreFilterInterface[]|PostFilterInterface[] |
||
| 392 | */ |
||
| 393 | 24 | public function getFilters($interface) |
|
| 406 | |||
| 407 | /** |
||
| 408 | * Get logger |
||
| 409 | * @codeCoverageIgnore |
||
| 410 | * @return LoggerInterface |
||
| 411 | */ |
||
| 412 | public function getLogger() |
||
| 416 | |||
| 417 | /** |
||
| 418 | * Set logger |
||
| 419 | * @codeCoverageIgnore |
||
| 420 | * @param LoggerInterface $logger |
||
| 421 | * @return Signal |
||
| 422 | */ |
||
| 423 | public function setLogger(LoggerInterface $logger) |
||
| 428 | |||
| 429 | /** |
||
| 430 | * Get dependency injection container |
||
| 431 | * @return EmbeDi |
||
| 432 | */ |
||
| 433 | 24 | public function getDi() |
|
| 437 | |||
| 438 | public function setDi(EmbeDi $di) |
||
| 443 | |||
| 444 | /** |
||
| 445 | * Get Input/Output adapter |
||
| 446 | * @codeCoverageIgnore |
||
| 447 | * @return BuilderIOInterface I/O Adapter |
||
| 448 | */ |
||
| 449 | public function getIO() |
||
| 453 | |||
| 454 | /** |
||
| 455 | * Set Input/Output interface |
||
| 456 | * @codeCoverageIgnore |
||
| 457 | * @param BuilderIOInterface $io |
||
| 458 | * @return Signal |
||
| 459 | */ |
||
| 460 | public function setIO(BuilderIOInterface $io) |
||
| 464 | |||
| 465 | /** |
||
| 466 | * @codeCoverageIgnore |
||
| 467 | * @return ExtractorInterface |
||
| 468 | */ |
||
| 469 | public function getExtractor() |
||
| 473 | |||
| 474 | /** |
||
| 475 | * @codeCoverageIgnore |
||
| 476 | * @param ExtractorInterface $extractor |
||
| 477 | * @return Signal |
||
| 478 | */ |
||
| 479 | public function setExtractor(ExtractorInterface $extractor) |
||
| 483 | |||
| 484 | /** |
||
| 485 | * Reloads signals cache and reinitializes component. |
||
| 486 | */ |
||
| 487 | public function resetCache() |
||
| 491 | |||
| 492 | private function reload() |
||
| 496 | |||
| 497 | /** |
||
| 498 | * Get configured property |
||
| 499 | * @param string $property |
||
| 500 | * @return SignalAwareInterface |
||
| 501 | */ |
||
| 502 | 1 | private function getConfigured($property) |
|
| 518 | |||
| 519 | /** |
||
| 520 | * Set signal aware property |
||
| 521 | * @param SignalAwareInterface $object |
||
| 522 | * @param string $property |
||
| 523 | * @return Signal |
||
| 524 | */ |
||
| 525 | private function setConfigured(SignalAwareInterface $object, $property) |
||
| 531 | |||
| 532 | } |
||
| 533 |