Complex classes like Signal often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Signal, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 42 | class Signal implements LoggerAwareInterface |
||
| 43 | { |
||
| 44 | |||
| 45 | const Slots = 'slots'; |
||
| 46 | const Signals = 'signals'; |
||
| 47 | |||
| 48 | /** |
||
| 49 | * Generated signals name. |
||
| 50 | * Name of this constant is confusing. |
||
| 51 | * @internal description |
||
| 52 | */ |
||
| 53 | const ConfigFilename = 'signals-definition.php'; |
||
| 54 | |||
| 55 | /** |
||
| 56 | * Config file name |
||
| 57 | */ |
||
| 58 | const ConfigName = "signals"; |
||
| 59 | |||
| 60 | /** |
||
| 61 | * Runtime path. |
||
| 62 | * This is path where config from yml will be stored. |
||
| 63 | * Path is relative to project root. |
||
| 64 | * @var string |
||
| 65 | */ |
||
| 66 | public $runtimePath = 'runtime'; |
||
| 67 | |||
| 68 | /** |
||
| 69 | * This aliases will be searched for SlotFor and SignalFor annotations |
||
| 70 | * TODO Autodetect based on composer autoload |
||
| 71 | * @var string[] |
||
| 72 | */ |
||
| 73 | public $paths = [ |
||
| 74 | 'vendor', |
||
| 75 | ]; |
||
| 76 | |||
| 77 | /** |
||
| 78 | * Filters configuration. |
||
| 79 | * This filters will be applied to every emit. |
||
| 80 | * @var string[]|object[] |
||
| 81 | */ |
||
| 82 | public $filters = []; |
||
| 83 | |||
| 84 | /** |
||
| 85 | * Sorters configuration. |
||
| 86 | * @var string[]|object[] |
||
| 87 | */ |
||
| 88 | public $sorters = []; |
||
| 89 | |||
| 90 | /** |
||
| 91 | * Extractor configuration |
||
| 92 | * @var string|[]|object |
||
| 93 | */ |
||
| 94 | public $extractor = Addendum::class; |
||
| 95 | |||
| 96 | /** |
||
| 97 | * Input/Output configuration |
||
| 98 | * @var string|[]|object |
||
| 99 | */ |
||
| 100 | public $io = PhpFile::class; |
||
| 101 | |||
| 102 | /** |
||
| 103 | * Whenever component is initialized |
||
| 104 | * @var bool |
||
| 105 | */ |
||
| 106 | public $isInitialized = false; |
||
| 107 | |||
| 108 | /** |
||
| 109 | * Configuration of signals and slots |
||
| 110 | * @var string[][] |
||
| 111 | */ |
||
| 112 | private static $config = []; |
||
| 113 | |||
| 114 | /** |
||
| 115 | * Logger |
||
| 116 | * @var LoggerInterface |
||
| 117 | */ |
||
| 118 | private $logger = null; |
||
| 119 | |||
| 120 | /** |
||
| 121 | * |
||
| 122 | * @var EmbeDi |
||
| 123 | */ |
||
| 124 | private $di = null; |
||
| 125 | |||
| 126 | /** |
||
| 127 | * Version |
||
| 128 | * @var string |
||
| 129 | */ |
||
| 130 | private $version = null; |
||
| 131 | |||
| 132 | /** |
||
| 133 | * Current filters |
||
| 134 | * @var PreFilterInterface[]|PostFilterInterface[] |
||
| 135 | */ |
||
| 136 | private $currentFilters = []; |
||
| 137 | |||
| 138 | 17 | public function __construct($configName = self::ConfigName) |
|
| 139 | { |
||
| 140 | 17 | $this->logger = new NullLogger; |
|
| 141 | |||
| 142 | /** |
||
| 143 | * TODO This should be made as embedi adapter, currently unsupported |
||
| 144 | */ |
||
| 145 | 17 | $config = new ConfigReader($configName); |
|
| 146 | 17 | $this->di = EmbeDi::fly($configName); |
|
| 147 | 17 | $this->di->apply($config->toArray(), $this); |
|
| 148 | 17 | $this->di->configure($this); |
|
| 149 | 17 | } |
|
| 150 | |||
| 151 | /** |
||
| 152 | * Getter |
||
| 153 | * @param string $name |
||
| 154 | * @return mixed |
||
| 155 | */ |
||
| 156 | public function __get($name) |
||
| 157 | { |
||
| 158 | return $this->{'get' . ucfirst($name)}(); |
||
| 159 | } |
||
| 160 | |||
| 161 | /** |
||
| 162 | * Setter |
||
| 163 | * @param string $name |
||
| 164 | * @param mixed $value |
||
| 165 | * @return mixed |
||
| 166 | */ |
||
| 167 | public function __set($name, $value) |
||
| 168 | { |
||
| 169 | return $this->{'set' . ucfirst($name)}($value); |
||
| 170 | } |
||
| 171 | |||
| 172 | /** |
||
| 173 | * Get current signals version |
||
| 174 | * |
||
| 175 | * @codeCoverageIgnore |
||
| 176 | * @return string |
||
| 177 | */ |
||
| 178 | public function getVersion() |
||
| 179 | { |
||
| 180 | if (null === $this->version) |
||
| 181 | { |
||
| 182 | $this->version = require __DIR__ . '/version.php'; |
||
| 183 | } |
||
| 184 | return $this->version; |
||
| 185 | } |
||
| 186 | |||
| 187 | public function init() |
||
| 188 | { |
||
| 189 | if (!$this->isInitialized) |
||
| 190 | { |
||
| 191 | $this->reload(); |
||
| 192 | } |
||
| 193 | if (!$this->di->isStored($this)) |
||
| 194 | { |
||
| 195 | $this->di->store($this); |
||
| 196 | } |
||
| 197 | } |
||
| 198 | |||
| 199 | /** |
||
| 200 | * Apply filter to current emit. |
||
| 201 | * @param FilterInterface|string|mixed $filter |
||
| 202 | * @return Signal |
||
| 203 | * @throws UnexpectedValueException |
||
| 204 | */ |
||
| 205 | 3 | public function filter($filter) |
|
| 206 | { |
||
| 207 | // Instantiate from string or array |
||
| 208 | 3 | if (!is_object($filter)) |
|
| 209 | 3 | { |
|
| 210 | 1 | $filter = $this->di->apply($filter); |
|
| 211 | 1 | } |
|
| 212 | 3 | if (!$filter instanceof PreFilterInterface && !$filter instanceof PostFilterInterface) |
|
| 213 | 3 | { |
|
| 214 | throw new UnexpectedValueException(sprintf('$filter must implement either `%s` or `%s` interface', PreFilterInterface::class, PostFilterInterface::class)); |
||
| 215 | } |
||
| 216 | 3 | $this->currentFilters[] = $filter; |
|
| 217 | 3 | return $this; |
|
| 218 | } |
||
| 219 | |||
| 220 | /** |
||
| 221 | * Emit signal to inform slots |
||
| 222 | * @param object|string $signal |
||
| 223 | * @return object[] |
||
| 224 | */ |
||
| 225 | 16 | public function emit($signal) |
|
| 226 | { |
||
| 227 | 16 | $result = []; |
|
| 228 | 16 | if (is_string($signal)) |
|
| 229 | 16 | { |
|
| 230 | $signal = new $signal; |
||
| 231 | } |
||
| 232 | 16 | $name = get_class($signal); |
|
| 233 | 16 | NameNormalizer::normalize($name); |
|
| 234 | 16 | if (!isset(self::$config[self::Signals][$name])) |
|
| 235 | 16 | { |
|
| 236 | self::$config[self::Signals][$name] = []; |
||
| 237 | $this->logger->debug('No slots found for signal `{name}`, skipping', ['name' => $name]); |
||
| 238 | return $result; |
||
| 239 | } |
||
| 240 | |||
| 241 | 16 | foreach (self::$config[self::Signals][$name] as $fqn => $injections) |
|
|
|
|||
| 242 | { |
||
| 243 | // Skip |
||
| 244 | 16 | if (false === $injections || count($injections) == 0) |
|
| 245 | 16 | { |
|
| 246 | continue; |
||
| 247 | } |
||
| 248 | 16 | if (!PreFilter::filter($this, $fqn, $signal)) |
|
| 249 | 16 | { |
|
| 250 | 3 | continue; |
|
| 251 | } |
||
| 252 | 13 | foreach ($injections as $injection) |
|
| 253 | { |
||
| 254 | 13 | $injected = SlotFactory::create($this, $signal, $fqn, $injection); |
|
| 255 | 13 | if (false === $injected) |
|
| 256 | 13 | { |
|
| 257 | continue; |
||
| 258 | } |
||
| 259 | 13 | if (!PostFilter::filter($this, $injected, $signal)) |
|
| 260 | 16 | { |
|
| 261 | 2 | continue; |
|
| 262 | 15 | } |
|
| 263 | 11 | $result[] = $injected; |
|
| 264 | 13 | } |
|
| 265 | 16 | } |
|
| 266 | 16 | $this->currentFilters = []; |
|
| 267 | 16 | return $result; |
|
| 268 | } |
||
| 269 | |||
| 270 | /** |
||
| 271 | * Call for signals from slot |
||
| 272 | * @param object $slot |
||
| 273 | * @param string $interface Interface, which must be implemented to get into slot |
||
| 274 | */ |
||
| 275 | 2 | public function gather($slot, $interface = null) |
|
| 276 | { |
||
| 277 | 2 | $name = get_class($slot); |
|
| 278 | NameNormalizer::normalize($name); |
||
| 279 | if (!isset(self::$config[self::Slots][$name])) |
||
| 280 | { |
||
| 281 | self::$config[self::Slots][$name] = []; |
||
| 282 | $this->logger->debug('No signals found for slot `{name}`, skipping', ['name' => $name]); |
||
| 283 | } |
||
| 284 | $result = []; |
||
| 285 | foreach ((array) self::$config[self::Slots][$name] as $fqn => $emit) |
||
| 286 | { |
||
| 287 | if (false === $emit) |
||
| 288 | { |
||
| 289 | continue; |
||
| 290 | } |
||
| 291 | // Check if class exists and log if doesn't |
||
| 292 | if (!ClassChecker::exists($fqn)) |
||
| 293 | { |
||
| 294 | $this->logger->debug(sprintf("Class `%s` not found while gathering slot `%s`", $fqn, get_class($slot))); |
||
| 295 | continue; |
||
| 296 | } |
||
| 297 | if (null === $interface) |
||
| 298 | { |
||
| 299 | $result[] = new $fqn; |
||
| 300 | continue; |
||
| 301 | } |
||
| 302 | |||
| 303 | // Check if class implements interface |
||
| 304 | if (isset(class_implements($fqn)[$interface])) |
||
| 305 | { |
||
| 306 | $result[] = new $fqn; |
||
| 307 | } |
||
| 308 | } |
||
| 309 | return $result; |
||
| 310 | } |
||
| 311 | |||
| 312 | /** |
||
| 313 | * Get filters |
||
| 314 | * @param string $interface |
||
| 315 | * @return PreFilterInterface[]|PostFilterInterface[] |
||
| 316 | */ |
||
| 317 | 16 | public function getFilters($interface) |
|
| 318 | { |
||
| 319 | 16 | $filters = FilterFactory::create($this, $interface); |
|
| 320 | 16 | foreach ($this->currentFilters as $filter) |
|
| 321 | { |
||
| 322 | 3 | if (!$filter instanceof $interface) |
|
| 323 | 3 | { |
|
| 324 | 1 | continue; |
|
| 325 | } |
||
| 326 | 3 | $filters[] = $filter; |
|
| 327 | 16 | } |
|
| 328 | 16 | return $filters; |
|
| 329 | } |
||
| 330 | |||
| 331 | /** |
||
| 332 | * Get logger |
||
| 333 | * @codeCoverageIgnore |
||
| 334 | * @return LoggerInterface |
||
| 335 | */ |
||
| 336 | public function getLogger() |
||
| 340 | |||
| 341 | /** |
||
| 342 | * Set logger |
||
| 343 | * @codeCoverageIgnore |
||
| 344 | * @param LoggerInterface $logger |
||
| 345 | * @return Signal |
||
| 346 | */ |
||
| 347 | public function setLogger(LoggerInterface $logger) |
||
| 352 | |||
| 353 | /** |
||
| 354 | * Get dependency injection container |
||
| 355 | * @return EmbeDi |
||
| 356 | */ |
||
| 357 | 16 | public function getDi() |
|
| 358 | { |
||
| 359 | 16 | return $this->di; |
|
| 360 | } |
||
| 361 | |||
| 362 | public function setDi(EmbeDi $di) |
||
| 367 | |||
| 368 | /** |
||
| 369 | * Get Input/Output adapter |
||
| 370 | * @codeCoverageIgnore |
||
| 371 | * @return BuilderIOInterface I/O Adapter |
||
| 372 | */ |
||
| 373 | public function getIO() |
||
| 374 | { |
||
| 375 | return $this->getConfigured('io'); |
||
| 376 | } |
||
| 377 | |||
| 378 | /** |
||
| 379 | * Set Input/Output interface |
||
| 380 | * @codeCoverageIgnore |
||
| 381 | * @param BuilderIOInterface $io |
||
| 382 | * @return Signal |
||
| 383 | */ |
||
| 384 | public function setIO(BuilderIOInterface $io) |
||
| 385 | { |
||
| 386 | return $this->setConfigured($io, 'io'); |
||
| 387 | } |
||
| 388 | |||
| 389 | /** |
||
| 390 | * @codeCoverageIgnore |
||
| 391 | * @return ExtractorInterface |
||
| 392 | */ |
||
| 393 | public function getExtractor() |
||
| 397 | |||
| 398 | /** |
||
| 399 | * @codeCoverageIgnore |
||
| 400 | * @param ExtractorInterface $extractor |
||
| 401 | * @return Signal |
||
| 402 | */ |
||
| 403 | public function setExtractor(ExtractorInterface $extractor) |
||
| 404 | { |
||
| 405 | return $this->setConfigured($extractor, 'extractor'); |
||
| 406 | } |
||
| 407 | |||
| 408 | /** |
||
| 409 | * Reloads signals cache and reinitializes component. |
||
| 410 | */ |
||
| 411 | public function resetCache() |
||
| 415 | |||
| 416 | private function reload() |
||
| 420 | |||
| 421 | /** |
||
| 422 | * Get configured property |
||
| 423 | * @param string $property |
||
| 424 | * @return SignalAwareInterface |
||
| 425 | */ |
||
| 426 | 1 | private function getConfigured($property) |
|
| 442 | |||
| 443 | /** |
||
| 444 | * Set signal aware property |
||
| 445 | * @param SignalAwareInterface $object |
||
| 446 | * @param string $property |
||
| 447 | * @return Signal |
||
| 448 | */ |
||
| 449 | private function setConfigured(SignalAwareInterface $object, $property) |
||
| 455 | |||
| 456 | } |
||
| 457 |