Maslosoft\Manganel\MultiScopeManager

Complexity

Total Complexity

8

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

59.09%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getNewCriteria()	0	6	1
A	getModelCriteria()	0	15	3
A	getOneModelCriteria()	0	15	3

<?php

namespace Maslosoft\Manganel;

use Maslosoft\Mangan\Abstracts\AbstractScopeManager;
use Maslosoft\Mangan\Interfaces\ScopeManagerInterface;
use Maslosoft\Manganel\Interfaces\ModelsAwareInterface;
use Maslosoft\Manganel\Traits\UniqueModelsAwareTrait;

/**
 * Scope Manager with support for many models
 *
 * TODO, maybe it's not even necessary? Will be known when SearchFinder will be
 * implemented...
 *
 * @author Piotr Maselkowski <pmaselkowski at gmail.com>
 */
class MultiScopeManager extends AbstractScopeManager implements ScopeManagerInterface,
		ModelsAwareInterface
{

	use UniqueModelsAwareTrait;

	/**
	 *
	 * @param object $model Base model used for criteria
	 * @param object[] $models Additional models used for criteria
	 */
	public function __construct($model, $models = [])
	{
		$this->setModel($model);
		$this->setModels($models);
	}

	public function getNewCriteria($criteria = null)
	{
		$newCriteria = new SearchCriteria($criteria);
		$newCriteria->decorateWith($this->getModel());
		return $newCriteria;
	}

	protected function getModelCriteria()
	{
		$criteria = new SearchCriteria;

		foreach ($this->getModels() as $model)
		{
			$criteria->mergeWith($this->getOneModelCriteria($model));

It seems like $this->getOneModelCriteria($model) can be null; however, mergeWith() does not accept null, maybe add an additional type check?

		}

		if (empty($criteria))
		{
			return $this->getNewCriteria();
		}
		return $criteria;
	}

	private function getOneModelCriteria($model)
	{
		if ($model instanceof WithCriteriaInterface)

The class Maslosoft\Manganel\WithCriteriaInterface does not exist. Did you forget a USE statement, or did you not list all dependencies?

		{
			$criteria = $model->getDbCriteria();

$criteria is not used, you could remove the assignment.

		}
		elseif ($model instanceof CriteriaAwareInterface)

The class Maslosoft\Manganel\CriteriaAwareInterface does not exist. Did you forget a USE statement, or did you not list all dependencies?

		{
			$criteria = $model->getCriteria();

$criteria is not used, you could remove the assignment.

		}
		else
		{
			return new SearchCriteria;
		}
	}

}