ScoreAwareTrait::getScore() - Code Metrics - Inspection of "* Allow handling missing 404 exception when removi..." - Maslosoft/Manganel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3fab57...455a7d )

by Peter

created 2019-04-04 15:33 UTC

ScoreAwareTrait::getScore() A

↳ Parent: ScoreAwareTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	3
cts	3
cp	1
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	0
crap	2

<?php

/**
 * This software package is licensed under `AGPL-3.0-only, proprietary` license[s].
 *
 * @package maslosoft/manganel
 * @license AGPL-3.0-only, proprietary
 *
 * @copyright Copyright (c) Peter Maselkowski <[email protected]>
 * @link https://maslosoft.com/manganel/
 */

namespace Maslosoft\Manganel\Traits;

use Maslosoft\Manganel\Interfaces\ScoreAwareInterface;
use UnexpectedValueException;

/**
 * ScoreAwareTrait
 *
 * @see ScoreAwareInterface
 * @author Piotr Maselkowski <pmaselkowski at gmail.com>
 */
trait ScoreAwareTrait
{

	private $score = 0.0;

	public function getScore()
	{
		if (!$this instanceof ScoreAwareInterface)
		{
			throw new UnexpectedValueException(sprintf('Class `%s` using `%s` must implement `%s`', get_class($this), __CLASS__, ScoreAwareInterface::class)); // @codeCoverageIgnore
		}
		return $this->score;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
	}

	public function setScore($score)
	{
		if (!$this instanceof ScoreAwareInterface)
		{
			throw new UnexpectedValueException(sprintf('Class `%s` using `%s` must implement `%s`', get_class($this), __CLASS__, ScoreAwareInterface::class)); // @codeCoverageIgnore
		}
		$this->score = floatval($score);
		return $this;
	}

}


1		<?php
2
3		/**
4		* This software package is licensed under `AGPL-3.0-only, proprietary` license[s].
5		*
6		* @package maslosoft/manganel
7		* @license AGPL-3.0-only, proprietary
8		*
9		* @copyright Copyright (c) Peter Maselkowski <[email protected]>
10		* @link https://maslosoft.com/manganel/
11		*/
12
13		namespace Maslosoft\Manganel\Traits;
14
15		use Maslosoft\Manganel\Interfaces\ScoreAwareInterface;
16		use UnexpectedValueException;
17
18		/**
19		* ScoreAwareTrait
20		*
21		* @see ScoreAwareInterface
22		* @author Piotr Maselkowski <pmaselkowski at gmail.com>
23		*/
24		trait ScoreAwareTrait
25		{
26
27		private $score = 0.0;
28
29	17	public function getScore()
30		{
31	17	if (!$this instanceof ScoreAwareInterface)
32		{
33		throw new UnexpectedValueException(sprintf('Class `%s` using `%s` must implement `%s`', get_class($this), __CLASS__, ScoreAwareInterface::class)); // @codeCoverageIgnore
34		}
35	17	return $this->score;
		0 ignored issues – show Bug introduced 2016-08-04 13:25 UTC by Report Bug Copy Issue Report Accessing `score` on the interface `Maslosoft\Manganel\Interfaces\ScoreAwareInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
36		}
37
38	17	public function setScore($score)
39		{
40	17	if (!$this instanceof ScoreAwareInterface)
41		{
42		throw new UnexpectedValueException(sprintf('Class `%s` using `%s` must implement `%s`', get_class($this), __CLASS__, ScoreAwareInterface::class)); // @codeCoverageIgnore
43		}
44	17	$this->score = floatval($score);
45	17	return $this;
46		}
47
48		}
49

Maslosoft / Manganel

Push — master ( 3fab57...455a7d )

ScoreAwareTrait::getScore() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like