Issues in JsonString.php (master) - Issues in master - Maslosoft/Mangan - Measure and Improve Code Quality continuously with Scrutinizer

Issues (28)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Transformers/JsonString.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * This software package is licensed under AGPL or Commercial license.
 *
 * @package maslosoft/mangan
 * @licence AGPL or Commercial
 * @copyright Copyright (c) Piotr Masełkowski <[email protected]>
 * @copyright Copyright (c) Maslosoft
 * @copyright Copyright (c) Others as mentioned in code
 * @link https://maslosoft.com/mangan/
 */

namespace Maslosoft\Mangan\Transformers;

use Maslosoft\Addendum\Interfaces\AnnotatedInterface;
use Maslosoft\Mangan\AspectManager;
use Maslosoft\Mangan\Exceptions\TransformatorException;
use Maslosoft\Mangan\Interfaces\Transformators\TransformatorInterface;

/**
 * JsonString
 *
 * @author Piotr Maselkowski <pmaselkowski at gmail.com>
 */
class JsonString implements TransformatorInterface
{
	const AspectJsonStringFromModel = 'AspectJsonStringFromModel';
	const AspectJsonStringToModel = 'AspectJsonStringToModel';

	/**
	 * Returns the given object as an associative array
	 * @param AnnotatedInterface|object $model
	 * @param string[] $fields Fields to transform
	 * @param int $options json_encode options
	 * @return array an associative array of the contents of this object
	 */
	public static function fromModel(AnnotatedInterface $model, $fields = [], $options = null)
	{
		AspectManager::addAspect($model, self::AspectJsonStringFromModel);
		$data = json_encode(JsonArray::fromModel($model, $fields), $options);
		AspectManager::removeAspect($model, self::AspectJsonStringFromModel);
		return $data;
	}

	/**
	 * Create document from array
	 *
	 * @param mixed[] $data
	 * @param string|object $className
	 * @param AnnotatedInterface $instance
	 * @return AnnotatedInterface
	 * @throws TransformatorException
	 */
	public static function toModel($data, $className = null, AnnotatedInterface $instance = null)
	{
		AspectManager::addAspect($instance, self::AspectJsonStringFromModel);
		$model = JsonArray::toModel(json_decode($data, true), $className, $instance);

		AspectManager::removeAspect($instance, self::AspectJsonStringToModel);
		AspectManager::removeAspect($model, self::AspectJsonStringToModel);
		return $model;
	}

}


1		<?php
2
3		/**
4		* This software package is licensed under AGPL or Commercial license.
5		*
6		* @package maslosoft/mangan
7		* @licence AGPL or Commercial
8		* @copyright Copyright (c) Piotr Masełkowski <[email protected]>
9		* @copyright Copyright (c) Maslosoft
10		* @copyright Copyright (c) Others as mentioned in code
11		* @link https://maslosoft.com/mangan/
12		*/
13
14		namespace Maslosoft\Mangan\Transformers;
15
16		use Maslosoft\Addendum\Interfaces\AnnotatedInterface;
17		use Maslosoft\Mangan\AspectManager;
18		use Maslosoft\Mangan\Exceptions\TransformatorException;
19		use Maslosoft\Mangan\Interfaces\Transformators\TransformatorInterface;
20
21		/**
22		* JsonString
23		*
24		* @author Piotr Maselkowski <pmaselkowski at gmail.com>
25		*/
26		class JsonString implements TransformatorInterface
27		{
28		const AspectJsonStringFromModel = 'AspectJsonStringFromModel';
29		const AspectJsonStringToModel = 'AspectJsonStringToModel';
30
31		/**
32		* Returns the given object as an associative array
33		* @param AnnotatedInterface\|object $model
34		* @param string[] $fields Fields to transform
35		* @param int $options json_encode options
36		* @return array an associative array of the contents of this object
37		*/
38	2	public static function fromModel(AnnotatedInterface $model, $fields = [], $options = null)
39		{
40	2	AspectManager::addAspect($model, self::AspectJsonStringFromModel);
41	2	$data = json_encode(JsonArray::fromModel($model, $fields), $options);
42	2	AspectManager::removeAspect($model, self::AspectJsonStringFromModel);
43	2	return $data;
44		}
45
46		/**
47		* Create document from array
48		*
49		* @param mixed[] $data
50		* @param string\|object $className
51		* @param AnnotatedInterface $instance
52		* @return AnnotatedInterface
53		* @throws TransformatorException
54		*/
55	2	public static function toModel($data, $className = null, AnnotatedInterface $instance = null)
56		{
57	2	AspectManager::addAspect($instance, self::AspectJsonStringFromModel);
58	2	$model = JsonArray::toModel(json_decode($data, true), $className, $instance);
		0 ignored issues – show Bug introduced 2019-08-27 12:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$className` defined by parameter `$className` on line 55 can also be of type `object`; however, `Maslosoft\Mangan\Transformers\JsonArray::toModel()` does only seem to accept `string\|null`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
59	2	AspectManager::removeAspect($instance, self::AspectJsonStringToModel);
60	2	AspectManager::removeAspect($model, self::AspectJsonStringToModel);
61	2	return $model;
62		}
63
64		}
65

Maslosoft / Mangan

Issues (28)

Security Analysis no request data

src/Transformers/JsonString.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like