Maslosoft\Mangan\Traits\Finder\CreateModel

Complexity

Total Complexity

3

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Test Coverage

Coverage

85.71%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	createModel()	0	20	3

<?php


namespace Maslosoft\Mangan\Traits\Finder;


use Maslosoft\Addendum\Interfaces\AnnotatedInterface;
use Maslosoft\Mangan\Exceptions\ManganException;
use Maslosoft\Mangan\Meta\ManganMeta;
use Maslosoft\Mangan\Transformers\RawArray;

trait CreateModel
{
	/**
	 * Create model from `$data`.
	 *
	 * NOTE: It requires `getModel` method accessible
	 * within this method.
	 *
	 * NOTE: Do not declare abstract `getModel` here
	 * as *possibly* it might be protected or public in classes
	 * using this trait.
	 *
	 * @param                    $data
	 * @return AnnotatedInterface
	 * @throws ManganException
	 */
	protected function createModel($data)

Using PHP4-style constructors that are named like the class is not recommend; better use the more explicit __construct method.

	{
		if (!empty($data['$err']))
		{
			throw new ManganException(sprintf("There is an error in query: %s", $data['$err']));
		}

		// By default create instances of same
		// type as provided model
		$model = $this->getModel();

It seems like getModel() must be provided by classes using this trait. How about adding it as abstract method to this trait?

		// For non homogeneous collections class
		// need to be taken from data, not defined
		// by model
		if(ManganMeta::create($model)->type()->homogenous === false)
		{
			$model = null;
		}
		return RawArray::toModel($data, $model);
	}
}